Skip to content

support latest version - #2

Merged
gauron99 merged 1 commit into
mainfrom
push-qpzomypwwykl
Jan 30, 2026
Merged

support latest version#2
gauron99 merged 1 commit into
mainfrom
push-qpzomypwwykl

Conversation

@gauron99

@gauron99gauron99 commented Jan 29, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator
  • add support for 'latest' keyword in versioning
  • uses that 'latest' as default now
  • updated README.md & action.yml
  • default (first) workflow now tests 'latest'

@gauron99gauron99 mentioned this pull request Jan 29, 2026
Merged
twoGiants
twoGiants reviewed Jan 29, 2026
View reviewed changes
Comment threadindex.js
@gauron99
gauron99force-pushed the push-qpzomypwwykl branch 2 times, most recently from bf0aeeb to 0b03d6eCompareJanuary 29, 2026 15:14
twoGiants
twoGiants requested changes Jan 29, 2026
View reviewed changes

@twoGiantstwoGiants left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😸 👍

I did not expect it to bring much more complexity but surprisingly it did. Well, you really never know!

I'm proposing some structural changes which streamline the run function IMHO.
Wdyt? It's not a must.

In any case I would the DEFAULT_FUNC_VERSION constant instead of the "latest" string, put it together with the other constants at the top and simplify resolveUrl if you decide to keep it.

Comment threadindex.js Outdated
Comment threadindex.js Outdated
Comment threadindex.js Outdated
Comment threadindex.js Outdated
Comment threadindex.js
Comment threadindex.js Outdated
twoGiants
twoGiants approved these changes Jan 30, 2026
View reviewed changes

@twoGiantstwoGiants left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🥇

Looks very clean and straight forward.

@gauron99
gauron99 merged commit 7660a62 into mainJan 30, 2026
8 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twoGiantstwoGiantstwoGiants approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gauron99@twoGiants