Uh oh!
There was an error while loading. Please reload this page.
Warn on older versions of func - #3
Conversation
bafd5a7 to
54b8989Compare
twoGiants
left a comment
There was a problem hiding this comment.
Good job! 👍
I think we can make it a bit simpler. Wdyt?
See my comments below.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
54b8989 to
bd74eefCompare
twoGiants
left a comment
There was a problem hiding this comment.
Looks good, looks good! Your JavaScript muscles are getting bigger 💪 😄 , love it!
I left a few comments and would do another round. Hope it's ok! We're close to the finish line 🎸 🎶 🎶
Let me know if anything is unclear.
By the way => next PR should be unit test coverage. Logic is getting more and more complex.
There was a problem hiding this comment.
Ok, looks good, but lets clean it up a bit and then we're done. I hope it's ok for you to go another round 🙈 .
I would avoid working with null values if I can. Especially in JavaScript. Being explicit makes the code easier to reason about, at least for me 😸. JavaScript is a permissive language 😆 it has undefined, null, NaN as empty/null values and they behave differently 😆. Unlike in go where nil checks are common place => in JavaScript I would use them only when there is no other way. So in the JS code you write, where you can set non-null values => do it and check against that.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bd74eef to
7573b59Compare
twoGiants
left a comment
There was a problem hiding this comment.
Looks great! 😸 👍
Thanks for keeping it clean and readable. 🥇
Uh oh!
There was an error while loading. Please reload this page.
This is a subsequent PR to #2
please note
will add in subsequent PR
nccmodule )