Uh oh!
There was an error while loading. Please reload this page.
fix(telemetry): upgrade Sentry SDK to 10.39.0 and remove custom patches - #249
Merged
Conversation
Upstream 10.39.0 fixes all issues we had manually patched: - Timer .unref() calls that prevented CLI from exiting (#19062, #19174) - Bun runtime context override in NodeClient (#19269) Remove the @sentry/core@10.38.0 patch file and the runtime context workaround in telemetry.ts since they are no longer needed.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Build
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 4126 uncovered lines. Files with missing lines (71)
Coverage diff@@ Coverage Diff @@## main #PR +/-##
==========================================
- Coverage 68.18% 68.17% -0.01%
==========================================
Files 108 108 —
Lines 12968 12961 -7
Branches 0 0 —
==========================================
+ Hits 8842 8835 -7- Misses 4126 4126 —- Partials 0 0 —Generated by Codecov Action |
BYK
marked this pull request as ready for review
February 16, 2026 20:52
Uh oh!
There was an error while loading. Please reload this page.
3 tasks
betegon added a commit
that referenced
this pull request
Aug 21, 2026
## Summary Make `sentry init` accept a terminal workflow result as successful only when it explicitly reports `status: "success"` and `result.exitCode: 0`. Previously, a successful response with no `result` or no `exitCode` passed the truthiness check and could print the success handoff with process exit 0. The CLI now treats that as malformed, surfaces a specific `WizardError`, and exits nonzero. Existing nonzero workflow-to-CLI exit mappings are unchanged. This makes the process exit status a reliable black-box signal for the init smoke harness. ## Compatibility This intentionally stops accepting terminal success payloads that omit `exitCode`. The current wizard success output already returns `exitCode: 0`. The draft [#1406](#1406) also touches `handleFinalResult`; merge order will require rebasing whichever PR lands second. ## Test plan - focused wizard runner tests: 74 passed - CLI typecheck - Biome on the three changed files - `git diff --check` - native `darwin-arm64` binary build - real Express init against the local candidate API: exit 0 - invalid OpenRouter credential: CLI exit 61 and smoke harness exit 1 ## Rollout The paired API-owned smoke is [getsentry/cli-init-api#249](getsentry/cli-init-api#249). Once this lands, bump its pinned CLI SHA so malformed successful workflow responses cannot produce a false-green smoke result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
@sentry/bunand@sentry/nodefrom 10.38.0 → 10.39.0 and remove all custom patches/workarounds that are now fixed upstream.Changes
patches/@sentry%2Fcore@10.38.0.patch(92 lines) — Added.unref()to timers insetupWeightBasedFlushing,_isClientDoneProcessing, andmakePromiseBufferto prevent the CLI from hanging on exit. Fixed upstream by #19062 and #19174.src/lib/telemetry.ts(14 lines) — Manually overrodeoptions.runtimeafterSentry.init()to report Bun instead of Node.js. Fixed upstream —NodeClientnow usesoptions.runtime || { name: 'node', ... }and@sentry/bunpasses{ name: 'bun', version: Bun.version }. Tracked as #19269.package.json— Bumped both SDK packages to10.39.0and removed@sentry/corefrompatchedDependencies.Verification
bun install, typecheck, lint, and tests all pass cleanlymainare unrelated)