fix(core): Avoid blocking the process when calling flush on empty buffer - #19062

Merged
Lms24 merged 12 commits into
developfrom
copilot/fix-issue-18996-bug
Jan 29, 2026
Merged

fix(core): Avoid blocking the process when calling flush on empty buffer#19062
Lms24 merged 12 commits into
developfrom
copilot/fix-issue-18996-bug

Conversation

CopilotAI commented Jan 28, 2026•
edited by Lms24
Loading

Copy link
Copy Markdown
Contributor

PR and description checked and updated by @Lms24

This PR fixes a bug when calling Sentry.flush() (or client.flush()) and there's no telemetry being processed by the SDK. While previously we'd wait for the passed-in timeout, we now exit early.

In addition, this also calls unref() on started timeouts for server SDKs so that pending timeouts started by the SDK don't block the process from exiting.

CopilotAI changed the title [WIP] Fix bug for issue 18996 in sentry-javascriptFix client.flush() blocking process exit due to non-unref'd timersJan 28, 2026
CopilotAI requested a review from Lms24January 28, 2026 16:05
@Lms24Lms24 changed the title Fix client.flush() blocking process exit due to non-unref'd timersfix(core): Avoid blocking the process when calling flush on empty bufferJan 28, 2026
@github-actions

github-actionsBot commented Jan 28, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.35 kB+0.1%+24 B 🔺
@sentry/browser - with treeshaking flags23.86 kB+0.12%+28 B 🔺
@sentry/browser (incl. Tracing)42.17 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.81 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Replay)80.79 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.44 kB+0.04%+27 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.49 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.69 kB+0.03%+24 B 🔺
@sentry/browser (incl. Feedback)42.07 kB+0.06%+24 B 🔺
@sentry/browser (incl. sendFeedback)30.04 kB+0.08%+23 B 🔺
@sentry/browser (incl. FeedbackAsync)35.04 kB+0.07%+24 B 🔺
@sentry/browser (incl. Metrics)26.46 kB+0.11%+29 B 🔺
@sentry/browser (incl. Logs)26.61 kB+0.12%+30 B 🔺
@sentry/browser (incl. Metrics & Logs)27.27 kB+0.1%+26 B 🔺
@sentry/react27.08 kB+0.1%+27 B 🔺
@sentry/react (incl. Tracing)44.4 kB+0.07%+28 B 🔺
@sentry/vue29.79 kB+0.09%+24 B 🔺
@sentry/vue (incl. Tracing)43.96 kB+0.06%+23 B 🔺
@sentry/svelte25.37 kB+0.1%+24 B 🔺
CDN Bundle27.92 kB+0.08%+22 B 🔺
CDN Bundle (incl. Tracing)42.96 kB+0.07%+27 B 🔺
CDN Bundle (incl. Logs, Metrics)28.77 kB+0.09%+25 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.78 kB+0.07%+27 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.7 kB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay)79.69 kB+0.04%+25 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.56 kB+0.04%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.14 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.07 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed81.69 kB+0.1%+75 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.23 kB+0.06%+75 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.52 kB+0.09%+75 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.06 kB+0.06%+75 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.91 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.83 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.65 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.63 kB+0.03%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.44 kB+0.03%+75 B 🔺
@sentry/nextjs (client)46.76 kB+0.07%+30 B 🔺
@sentry/sveltekit (client)42.54 kB+0.06%+24 B 🔺
@sentry/node-core52.1 kB+0.06%+27 B 🔺
@sentry/node166.1 kB+0.02%+22 B 🔺
@sentry/node - without tracing93.86 kB+0.03%+24 B 🔺
@sentry/aws-serverless109.38 kB+0.03%+25 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Jan 28, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline10,418-8,412+24%
GET With Sentry1,74117%1,612+8%
GET With Sentry (error only)6,98067%5,928+18%
POST Baseline1,044-1,171-11%
POST With Sentry54152%565-4%
POST With Sentry (error only)93890%1,048-10%
MYSQL Baseline3,732-3,243+15%
MYSQL With Sentry46412%469-1%
MYSQL With Sentry (error only)2,94979%2,646+11%

View base workflow run

chargome
chargome approved these changes Jan 29, 2026
View reviewed changes

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment threadpackages/core/src/utils/timer.ts Outdated
This was referenced Jan 29, 2026
Merged
Closed
@Lms24
Lms24 marked this pull request as ready for review January 29, 2026 16:51
CopilotAIand others added 9 commits January 29, 2026 18:03
@Lms24
Initial plan
f40eb35
@Lms24
Fix client.flush() blocking process exit with unref'd timers and earl…
1438d5b
…y exit
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
Fix lint error in client.test.ts
f9f3f6b
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
deslop
dfa682b
@Lms24
extract safeUnref
92aa121
@Lms24
size check
8746622
@Lms24
stop flushing too early
4d8a973
@Lms24@chargome
Update packages/core/src/utils/timer.ts
39baa2f
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@Lms24
make test more strict
917fc69
@Lms24
Lms24force-pushed the copilot/fix-issue-18996-bug branch from 0ad6633 to 917fc69CompareJanuary 29, 2026 17:22
cursor[bot]
cursorBot reviewed Jan 29, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment threadpackages/core/src/utils/timer.ts
@Lms24
Lms24 merged commit c61baee into developJan 29, 2026
217 checks passed
@Lms24
Lms24 deleted the copilot/fix-issue-18996-bug branch January 29, 2026 18:26
Lms24 added a commit that referenced this pull request Feb 4, 2026
@Lms24
chore(bugbot): Add rule to flag not-unref'd timers (#19082)
29853f1
Quick follow-up from
#19062.
Closes#19083 (added automatically)
This was referenced Feb 5, 2026
Closed
Merged
JPeer264 added a commit that referenced this pull request Feb 5, 2026
@JPeer264
fix(core): Avoid blocking the process for weightBasedFlushing (#19174)
b7f8cfe
closes#19171
closes
[JS-1641](https://linear.app/getsentry/issue/JS-1641/metrics-flush-timer-should-use-unref-to-not-block-process-exit)
This was is something that got missed by Copilot on #19062
@BYKBYK mentioned this pull request Feb 16, 2026
Merged
BYK added a commit to getsentry/cli that referenced this pull request Feb 16, 2026
@BYK
fix(telemetry): upgrade Sentry SDK to 10.39.0 and remove custom patch…
604b4e6
…es (#249)
## Summary
Upgrade `@sentry/bun` and `@sentry/node` from 10.38.0 → 10.39.0 and
remove all custom patches/workarounds that are now fixed upstream.
## Changes
- **Removed `patches/@sentry%2Fcore@10.38.0.patch`** (92 lines) — Added
`.unref()` to timers in `setupWeightBasedFlushing`,
`_isClientDoneProcessing`, and `makePromiseBuffer` to prevent the CLI
from hanging on exit. Fixed upstream by
[#19062](getsentry/sentry-javascript#19062) and
[#19174](getsentry/sentry-javascript#19174).
- **Removed runtime context workaround in `src/lib/telemetry.ts`** (14
lines) — Manually overrode `options.runtime` after `Sentry.init()` to
report Bun instead of Node.js. Fixed upstream — `NodeClient` now uses
`options.runtime || { name: 'node', ... }` and `@sentry/bun` passes `{
name: 'bun', version: Bun.version }`. Tracked as
[#19269](getsentry/sentry-javascript#19269).
- **Updated `package.json`** — Bumped both SDK packages to `10.39.0` and
removed `@sentry/core` from `patchedDependencies`.
## Verification
- Verified all three upstream fixes by reading the 10.39.0 source code
and linked PRs
- `bun install`, typecheck, lint, and tests all pass cleanly
- No new test failures introduced (pre-existing ~95 failures on `main`
are unrelated)
@coderabbitaicoderabbitaiBot mentioned this pull request May 13, 2026
Merged
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@Lms24Lms24

Copilot code reviewCopilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(core): Avoid blocking the process when calling flush on empty buffer - #19062
Merged
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Jan 29, 2026
Merged
fix(core): Avoid blocking the process when calling flush on empty buffer#19062
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Conversation
CopilotAI
commented
Jan 28, 2026•

edited by Lms24

Loading

Copy link


Copy Markdown

Contributor
PR and description checked and updated by @Lms24
This PR fixes a bug when calling Sentry.flush() (or client.flush()) and there's no telemetry being processed by the SDK. While previously we'd wait for the passed-in timeout, we now exit early.
In addition, this also calls unref() on started timeouts for server SDKs so that pending timeouts started by the SDK don't block the process from exiting.
CopilotAI
changed the title
[WIP] Fix bug for issue 18996 in sentry-javascriptFix client.flush() blocking process exit due to non-unref'd timersJan 28, 2026
CopilotAI
requested a review
from Lms24January 28, 2026 16:05
@Lms24Lms24
changed the title
Fix client.flush() blocking process exit due to non-unref'd timersfix(core): Avoid blocking the process when calling flush on empty bufferJan 28, 2026
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser25.35 kB+0.1%+24 B 🔺
@sentry/browser - with treeshaking flags23.86 kB+0.12%+28 B 🔺
@sentry/browser (incl. Tracing)42.17 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.81 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Replay)80.79 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.44 kB+0.04%+27 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.49 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.69 kB+0.03%+24 B 🔺
@sentry/browser (incl. Feedback)42.07 kB+0.06%+24 B 🔺
@sentry/browser (incl. sendFeedback)30.04 kB+0.08%+23 B 🔺
@sentry/browser (incl. FeedbackAsync)35.04 kB+0.07%+24 B 🔺
@sentry/browser (incl. Metrics)26.46 kB+0.11%+29 B 🔺
@sentry/browser (incl. Logs)26.61 kB+0.12%+30 B 🔺
@sentry/browser (incl. Metrics & Logs)27.27 kB+0.1%+26 B 🔺
@sentry/react27.08 kB+0.1%+27 B 🔺
@sentry/react (incl. Tracing)44.4 kB+0.07%+28 B 🔺
@sentry/vue29.79 kB+0.09%+24 B 🔺
@sentry/vue (incl. Tracing)43.96 kB+0.06%+23 B 🔺
@sentry/svelte25.37 kB+0.1%+24 B 🔺
CDN Bundle27.92 kB+0.08%+22 B 🔺
CDN Bundle (incl. Tracing)42.96 kB+0.07%+27 B 🔺
CDN Bundle (incl. Logs, Metrics)28.77 kB+0.09%+25 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.78 kB+0.07%+27 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.7 kB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay)79.69 kB+0.04%+25 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.56 kB+0.04%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.14 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.07 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed81.69 kB+0.1%+75 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.23 kB+0.06%+75 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.52 kB+0.09%+75 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.06 kB+0.06%+75 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.91 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.83 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.65 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.63 kB+0.03%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.44 kB+0.03%+75 B 🔺
@sentry/nextjs (client)46.76 kB+0.07%+30 B 🔺
@sentry/sveltekit (client)42.54 kB+0.06%+24 B 🔺
@sentry/node-core52.1 kB+0.06%+27 B 🔺
@sentry/node166.1 kB+0.02%+22 B 🔺
@sentry/node - without tracing93.86 kB+0.03%+24 B 🔺
@sentry/aws-serverless109.38 kB+0.03%+25 B 🔺
View base workflow run
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline10,418-8,412+24%
GET With Sentry1,74117%1,612+8%
GET With Sentry (error only)6,98067%5,928+18%
POST Baseline1,044-1,171-11%
POST With Sentry54152%565-4%
POST With Sentry (error only)93890%1,048-10%
MYSQL Baseline3,732-3,243+15%
MYSQL With Sentry46412%469-1%
MYSQL With Sentry (error only)2,94979%2,646+11%
View base workflow run
chargome
chargome
approved these changes
Jan 29, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Comment threadpackages/core/src/utils/timer.ts
Outdated


This was referenced Jan 29, 2026
 Merged


Closed

@Lms24
Lms24
marked this pull request as ready for review
January 29, 2026 16:51
CopilotAIand others
added 9 commits
January 29, 2026 18:03
@Lms24
Initial plan
f40eb35
@Lms24
Fix client.flush() blocking process exit with unref'd timers and earl…
1438d5b
…y exit
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
Fix lint error in client.test.ts
f9f3f6b
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
deslop
dfa682b
@Lms24
extract safeUnref
92aa121
@Lms24
size check
8746622
@Lms24
stop flushing too early
4d8a973
@Lms24@chargome
Update packages/core/src/utils/timer.ts
39baa2f
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@Lms24
make test more strict
917fc69
@Lms24
Lms24force-pushed
the
copilot/fix-issue-18996-bug
branch
from
0ad6633 to
917fc69CompareJanuary 29, 2026 17:22
cursor[bot]
cursorBot
reviewed
Jan 29, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment threadpackages/core/src/utils/timer.ts
@Lms24
Lms24
merged commit c61baee
into
developJan 29, 2026

217 checks passed

@Lms24
Lms24
deleted the

copilot/fix-issue-18996-bug

branch
January 29, 2026 18:26
Lms24 added a commit
that referenced
this pull request
Feb 4, 2026
@Lms24
chore(bugbot): Add rule to flag not-unref'd timers (#19082)
29853f1
Quick follow-up from
#19062.
Closes#19083 (added automatically)

This was referenced Feb 5, 2026

Closed

 Merged

JPeer264 added a commit
that referenced
this pull request
Feb 5, 2026
@JPeer264
fix(core): Avoid blocking the process for weightBasedFlushing (#19174)
b7f8cfe
closes#19171
closes
[JS-1641](https://linear.app/getsentry/issue/JS-1641/metrics-flush-timer-should-use-unref-to-not-block-process-exit)
This was is something that got missed by Copilot on #19062
@BYKBYK
mentioned this pull request
Feb 16, 2026
 Merged

BYK added a commit
to getsentry/cli
that referenced
this pull request
Feb 16, 2026
@BYK
fix(telemetry): upgrade Sentry SDK to 10.39.0 and remove custom patch…
604b4e6
…es (#249)
## Summary
Upgrade `@sentry/bun` and `@sentry/node` from 10.38.0 → 10.39.0 and
remove all custom patches/workarounds that are now fixed upstream.
## Changes
- **Removed `patches/@sentry%2Fcore@10.38.0.patch`** (92 lines) — Added
`.unref()` to timers in `setupWeightBasedFlushing`,
`_isClientDoneProcessing`, and `makePromiseBuffer` to prevent the CLI
from hanging on exit. Fixed upstream by
[#19062](getsentry/sentry-javascript#19062) and
[#19174](getsentry/sentry-javascript#19174).
- **Removed runtime context workaround in `src/lib/telemetry.ts`** (14
lines) — Manually overrode `options.runtime` after `Sentry.init()` to
report Bun instead of Node.js. Fixed upstream — `NodeClient` now uses
`options.runtime || { name: 'node', ... }` and `@sentry/bun` passes `{
name: 'bun', version: Bun.version }`. Tracked as
[#19269](getsentry/sentry-javascript#19269).
- **Updated `package.json`** — Bumped both SDK packages to `10.39.0` and
removed `@sentry/core` from `patchedDependencies`.
## Verification
- Verified all three upstream fixes by reading the 10.39.0 source code
and linked PRs
- `bun install`, typecheck, lint, and tests all pass cleanly
- No new test failures introduced (pre-existing ~95 failures on `main`
are unrelated)
@coderabbitaicoderabbitaiBot
mentioned this pull request
May 13, 2026
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@Lms24Lms24
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Avoid blocking the process when calling flush on empty buffer - #19062
Merged
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Jan 29, 2026
Merged
fix(core): Avoid blocking the process when calling flush on empty buffer#19062
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Conversation
CopilotAI
commented
Jan 28, 2026•

edited by Lms24

Loading

Copy link


Copy Markdown

Contributor
PR and description checked and updated by @Lms24
This PR fixes a bug when calling Sentry.flush() (or client.flush()) and there's no telemetry being processed by the SDK. While previously we'd wait for the passed-in timeout, we now exit early.
In addition, this also calls unref() on started timeouts for server SDKs so that pending timeouts started by the SDK don't block the process from exiting.
CopilotAI
changed the title
[WIP] Fix bug for issue 18996 in sentry-javascriptFix client.flush() blocking process exit due to non-unref'd timersJan 28, 2026
CopilotAI
requested a review
from Lms24January 28, 2026 16:05
@Lms24Lms24
changed the title
Fix client.flush() blocking process exit due to non-unref'd timersfix(core): Avoid blocking the process when calling flush on empty bufferJan 28, 2026
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser25.35 kB+0.1%+24 B 🔺
@sentry/browser - with treeshaking flags23.86 kB+0.12%+28 B 🔺
@sentry/browser (incl. Tracing)42.17 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.81 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Replay)80.79 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.44 kB+0.04%+27 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.49 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.69 kB+0.03%+24 B 🔺
@sentry/browser (incl. Feedback)42.07 kB+0.06%+24 B 🔺
@sentry/browser (incl. sendFeedback)30.04 kB+0.08%+23 B 🔺
@sentry/browser (incl. FeedbackAsync)35.04 kB+0.07%+24 B 🔺
@sentry/browser (incl. Metrics)26.46 kB+0.11%+29 B 🔺
@sentry/browser (incl. Logs)26.61 kB+0.12%+30 B 🔺
@sentry/browser (incl. Metrics & Logs)27.27 kB+0.1%+26 B 🔺
@sentry/react27.08 kB+0.1%+27 B 🔺
@sentry/react (incl. Tracing)44.4 kB+0.07%+28 B 🔺
@sentry/vue29.79 kB+0.09%+24 B 🔺
@sentry/vue (incl. Tracing)43.96 kB+0.06%+23 B 🔺
@sentry/svelte25.37 kB+0.1%+24 B 🔺
CDN Bundle27.92 kB+0.08%+22 B 🔺
CDN Bundle (incl. Tracing)42.96 kB+0.07%+27 B 🔺
CDN Bundle (incl. Logs, Metrics)28.77 kB+0.09%+25 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.78 kB+0.07%+27 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.7 kB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay)79.69 kB+0.04%+25 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.56 kB+0.04%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.14 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.07 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed81.69 kB+0.1%+75 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.23 kB+0.06%+75 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.52 kB+0.09%+75 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.06 kB+0.06%+75 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.91 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.83 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.65 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.63 kB+0.03%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.44 kB+0.03%+75 B 🔺
@sentry/nextjs (client)46.76 kB+0.07%+30 B 🔺
@sentry/sveltekit (client)42.54 kB+0.06%+24 B 🔺
@sentry/node-core52.1 kB+0.06%+27 B 🔺
@sentry/node166.1 kB+0.02%+22 B 🔺
@sentry/node - without tracing93.86 kB+0.03%+24 B 🔺
@sentry/aws-serverless109.38 kB+0.03%+25 B 🔺
View base workflow run
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline10,418-8,412+24%
GET With Sentry1,74117%1,612+8%
GET With Sentry (error only)6,98067%5,928+18%
POST Baseline1,044-1,171-11%
POST With Sentry54152%565-4%
POST With Sentry (error only)93890%1,048-10%
MYSQL Baseline3,732-3,243+15%
MYSQL With Sentry46412%469-1%
MYSQL With Sentry (error only)2,94979%2,646+11%
View base workflow run
chargome
chargome
approved these changes
Jan 29, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Comment threadpackages/core/src/utils/timer.ts
Outdated


This was referenced Jan 29, 2026
 Merged


Closed

@Lms24
Lms24
marked this pull request as ready for review
January 29, 2026 16:51
CopilotAIand others
added 9 commits
January 29, 2026 18:03
@Lms24
Initial plan
f40eb35
@Lms24
Fix client.flush() blocking process exit with unref'd timers and earl…
1438d5b
…y exit
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
Fix lint error in client.test.ts
f9f3f6b
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
deslop
dfa682b
@Lms24
extract safeUnref
92aa121
@Lms24
size check
8746622
@Lms24
stop flushing too early
4d8a973
@Lms24@chargome
Update packages/core/src/utils/timer.ts
39baa2f
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@Lms24
make test more strict
917fc69
@Lms24
Lms24force-pushed
the
copilot/fix-issue-18996-bug
branch
from
0ad6633 to
917fc69CompareJanuary 29, 2026 17:22
cursor[bot]
cursorBot
reviewed
Jan 29, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment threadpackages/core/src/utils/timer.ts
@Lms24
Lms24
merged commit c61baee
into
developJan 29, 2026

217 checks passed

@Lms24
Lms24
deleted the

copilot/fix-issue-18996-bug

branch
January 29, 2026 18:26
Lms24 added a commit
that referenced
this pull request
Feb 4, 2026
@Lms24
chore(bugbot): Add rule to flag not-unref'd timers (#19082)
29853f1
Quick follow-up from
#19062.
Closes#19083 (added automatically)

This was referenced Feb 5, 2026

Closed

 Merged

JPeer264 added a commit
that referenced
this pull request
Feb 5, 2026
@JPeer264
fix(core): Avoid blocking the process for weightBasedFlushing (#19174)
b7f8cfe
closes#19171
closes
[JS-1641](https://linear.app/getsentry/issue/JS-1641/metrics-flush-timer-should-use-unref-to-not-block-process-exit)
This was is something that got missed by Copilot on #19062
@BYKBYK
mentioned this pull request
Feb 16, 2026
 Merged

BYK added a commit
to getsentry/cli
that referenced
this pull request
Feb 16, 2026
@BYK
fix(telemetry): upgrade Sentry SDK to 10.39.0 and remove custom patch…
604b4e6
…es (#249)
## Summary
Upgrade `@sentry/bun` and `@sentry/node` from 10.38.0 → 10.39.0 and
remove all custom patches/workarounds that are now fixed upstream.
## Changes
- **Removed `patches/@sentry%2Fcore@10.38.0.patch`** (92 lines) — Added
`.unref()` to timers in `setupWeightBasedFlushing`,
`_isClientDoneProcessing`, and `makePromiseBuffer` to prevent the CLI
from hanging on exit. Fixed upstream by
[#19062](getsentry/sentry-javascript#19062) and
[#19174](getsentry/sentry-javascript#19174).
- **Removed runtime context workaround in `src/lib/telemetry.ts`** (14
lines) — Manually overrode `options.runtime` after `Sentry.init()` to
report Bun instead of Node.js. Fixed upstream — `NodeClient` now uses
`options.runtime || { name: 'node', ... }` and `@sentry/bun` passes `{
name: 'bun', version: Bun.version }`. Tracked as
[#19269](getsentry/sentry-javascript#19269).
- **Updated `package.json`** — Bumped both SDK packages to `10.39.0` and
removed `@sentry/core` from `patchedDependencies`.
## Verification
- Verified all three upstream fixes by reading the 10.39.0 source code
and linked PRs
- `bun install`, typecheck, lint, and tests all pass cleanly
- No new test failures introduced (pre-existing ~95 failures on `main`
are unrelated)
@coderabbitaicoderabbitaiBot
mentioned this pull request
May 13, 2026
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@Lms24Lms24
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Avoid blocking the process when calling flush on empty buffer - #19062
Merged
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Jan 29, 2026
Merged
fix(core): Avoid blocking the process when calling flush on empty buffer#19062
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Conversation
CopilotAI
commented
Jan 28, 2026•

edited by Lms24

Loading

Copy link


Copy Markdown

Contributor
PR and description checked and updated by @Lms24
This PR fixes a bug when calling Sentry.flush() (or client.flush()) and there's no telemetry being processed by the SDK. While previously we'd wait for the passed-in timeout, we now exit early.
In addition, this also calls unref() on started timeouts for server SDKs so that pending timeouts started by the SDK don't block the process from exiting.
CopilotAI
changed the title
[WIP] Fix bug for issue 18996 in sentry-javascriptFix client.flush() blocking process exit due to non-unref'd timersJan 28, 2026
CopilotAI
requested a review
from Lms24January 28, 2026 16:05
@Lms24Lms24
changed the title
Fix client.flush() blocking process exit due to non-unref'd timersfix(core): Avoid blocking the process when calling flush on empty bufferJan 28, 2026
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser25.35 kB+0.1%+24 B 🔺
@sentry/browser - with treeshaking flags23.86 kB+0.12%+28 B 🔺
@sentry/browser (incl. Tracing)42.17 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.81 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Replay)80.79 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.44 kB+0.04%+27 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.49 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.69 kB+0.03%+24 B 🔺
@sentry/browser (incl. Feedback)42.07 kB+0.06%+24 B 🔺
@sentry/browser (incl. sendFeedback)30.04 kB+0.08%+23 B 🔺
@sentry/browser (incl. FeedbackAsync)35.04 kB+0.07%+24 B 🔺
@sentry/browser (incl. Metrics)26.46 kB+0.11%+29 B 🔺
@sentry/browser (incl. Logs)26.61 kB+0.12%+30 B 🔺
@sentry/browser (incl. Metrics & Logs)27.27 kB+0.1%+26 B 🔺
@sentry/react27.08 kB+0.1%+27 B 🔺
@sentry/react (incl. Tracing)44.4 kB+0.07%+28 B 🔺
@sentry/vue29.79 kB+0.09%+24 B 🔺
@sentry/vue (incl. Tracing)43.96 kB+0.06%+23 B 🔺
@sentry/svelte25.37 kB+0.1%+24 B 🔺
CDN Bundle27.92 kB+0.08%+22 B 🔺
CDN Bundle (incl. Tracing)42.96 kB+0.07%+27 B 🔺
CDN Bundle (incl. Logs, Metrics)28.77 kB+0.09%+25 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.78 kB+0.07%+27 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.7 kB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay)79.69 kB+0.04%+25 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.56 kB+0.04%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.14 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.07 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed81.69 kB+0.1%+75 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.23 kB+0.06%+75 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.52 kB+0.09%+75 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.06 kB+0.06%+75 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.91 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.83 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.65 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.63 kB+0.03%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.44 kB+0.03%+75 B 🔺
@sentry/nextjs (client)46.76 kB+0.07%+30 B 🔺
@sentry/sveltekit (client)42.54 kB+0.06%+24 B 🔺
@sentry/node-core52.1 kB+0.06%+27 B 🔺
@sentry/node166.1 kB+0.02%+22 B 🔺
@sentry/node - without tracing93.86 kB+0.03%+24 B 🔺
@sentry/aws-serverless109.38 kB+0.03%+25 B 🔺
View base workflow run
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline10,418-8,412+24%
GET With Sentry1,74117%1,612+8%
GET With Sentry (error only)6,98067%5,928+18%
POST Baseline1,044-1,171-11%
POST With Sentry54152%565-4%
POST With Sentry (error only)93890%1,048-10%
MYSQL Baseline3,732-3,243+15%
MYSQL With Sentry46412%469-1%
MYSQL With Sentry (error only)2,94979%2,646+11%
View base workflow run
chargome
chargome
approved these changes
Jan 29, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Comment threadpackages/core/src/utils/timer.ts
Outdated


This was referenced Jan 29, 2026
 Merged


Closed

@Lms24
Lms24
marked this pull request as ready for review
January 29, 2026 16:51
CopilotAIand others
added 9 commits
January 29, 2026 18:03
@Lms24
Initial plan
f40eb35
@Lms24
Fix client.flush() blocking process exit with unref'd timers and earl…
1438d5b
…y exit
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
Fix lint error in client.test.ts
f9f3f6b
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
deslop
dfa682b
@Lms24
extract safeUnref
92aa121
@Lms24
size check
8746622
@Lms24
stop flushing too early
4d8a973
@Lms24@chargome
Update packages/core/src/utils/timer.ts
39baa2f
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@Lms24
make test more strict
917fc69
@Lms24
Lms24force-pushed
the
copilot/fix-issue-18996-bug
branch
from
0ad6633 to
917fc69CompareJanuary 29, 2026 17:22
cursor[bot]
cursorBot
reviewed
Jan 29, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment threadpackages/core/src/utils/timer.ts
@Lms24
Lms24
merged commit c61baee
into
developJan 29, 2026

217 checks passed

@Lms24
Lms24
deleted the

copilot/fix-issue-18996-bug

branch
January 29, 2026 18:26
Lms24 added a commit
that referenced
this pull request
Feb 4, 2026
@Lms24
chore(bugbot): Add rule to flag not-unref'd timers (#19082)
29853f1
Quick follow-up from
#19062.
Closes#19083 (added automatically)

This was referenced Feb 5, 2026

Closed

 Merged

JPeer264 added a commit
that referenced
this pull request
Feb 5, 2026
@JPeer264
fix(core): Avoid blocking the process for weightBasedFlushing (#19174)
b7f8cfe
closes#19171
closes
[JS-1641](https://linear.app/getsentry/issue/JS-1641/metrics-flush-timer-should-use-unref-to-not-block-process-exit)
This was is something that got missed by Copilot on #19062
@BYKBYK
mentioned this pull request
Feb 16, 2026
 Merged

BYK added a commit
to getsentry/cli
that referenced
this pull request
Feb 16, 2026
@BYK
fix(telemetry): upgrade Sentry SDK to 10.39.0 and remove custom patch…
604b4e6
…es (#249)
## Summary
Upgrade `@sentry/bun` and `@sentry/node` from 10.38.0 → 10.39.0 and
remove all custom patches/workarounds that are now fixed upstream.
## Changes
- **Removed `patches/@sentry%2Fcore@10.38.0.patch`** (92 lines) — Added
`.unref()` to timers in `setupWeightBasedFlushing`,
`_isClientDoneProcessing`, and `makePromiseBuffer` to prevent the CLI
from hanging on exit. Fixed upstream by
[#19062](getsentry/sentry-javascript#19062) and
[#19174](getsentry/sentry-javascript#19174).
- **Removed runtime context workaround in `src/lib/telemetry.ts`** (14
lines) — Manually overrode `options.runtime` after `Sentry.init()` to
report Bun instead of Node.js. Fixed upstream — `NodeClient` now uses
`options.runtime || { name: 'node', ... }` and `@sentry/bun` passes `{
name: 'bun', version: Bun.version }`. Tracked as
[#19269](getsentry/sentry-javascript#19269).
- **Updated `package.json`** — Bumped both SDK packages to `10.39.0` and
removed `@sentry/core` from `patchedDependencies`.
## Verification
- Verified all three upstream fixes by reading the 10.39.0 source code
and linked PRs
- `bun install`, typecheck, lint, and tests all pass cleanly
- No new test failures introduced (pre-existing ~95 failures on `main`
are unrelated)
@coderabbitaicoderabbitaiBot
mentioned this pull request
May 13, 2026
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@Lms24Lms24
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(core): Avoid blocking the process when calling flush on empty buffer - #19062
Merged
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Jan 29, 2026
Merged
fix(core): Avoid blocking the process when calling flush on empty buffer#19062
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Conversation
CopilotAI
commented
Jan 28, 2026•

edited by Lms24

Loading

Copy link


Copy Markdown

Contributor
PR and description checked and updated by @Lms24
This PR fixes a bug when calling Sentry.flush() (or client.flush()) and there's no telemetry being processed by the SDK. While previously we'd wait for the passed-in timeout, we now exit early.
In addition, this also calls unref() on started timeouts for server SDKs so that pending timeouts started by the SDK don't block the process from exiting.
CopilotAI
changed the title
[WIP] Fix bug for issue 18996 in sentry-javascriptFix client.flush() blocking process exit due to non-unref'd timersJan 28, 2026
CopilotAI
requested a review
from Lms24January 28, 2026 16:05
@Lms24Lms24
changed the title
Fix client.flush() blocking process exit due to non-unref'd timersfix(core): Avoid blocking the process when calling flush on empty bufferJan 28, 2026
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser25.35 kB+0.1%+24 B 🔺
@sentry/browser - with treeshaking flags23.86 kB+0.12%+28 B 🔺
@sentry/browser (incl. Tracing)42.17 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.81 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Replay)80.79 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.44 kB+0.04%+27 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.49 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.69 kB+0.03%+24 B 🔺
@sentry/browser (incl. Feedback)42.07 kB+0.06%+24 B 🔺
@sentry/browser (incl. sendFeedback)30.04 kB+0.08%+23 B 🔺
@sentry/browser (incl. FeedbackAsync)35.04 kB+0.07%+24 B 🔺
@sentry/browser (incl. Metrics)26.46 kB+0.11%+29 B 🔺
@sentry/browser (incl. Logs)26.61 kB+0.12%+30 B 🔺
@sentry/browser (incl. Metrics & Logs)27.27 kB+0.1%+26 B 🔺
@sentry/react27.08 kB+0.1%+27 B 🔺
@sentry/react (incl. Tracing)44.4 kB+0.07%+28 B 🔺
@sentry/vue29.79 kB+0.09%+24 B 🔺
@sentry/vue (incl. Tracing)43.96 kB+0.06%+23 B 🔺
@sentry/svelte25.37 kB+0.1%+24 B 🔺
CDN Bundle27.92 kB+0.08%+22 B 🔺
CDN Bundle (incl. Tracing)42.96 kB+0.07%+27 B 🔺
CDN Bundle (incl. Logs, Metrics)28.77 kB+0.09%+25 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.78 kB+0.07%+27 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.7 kB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay)79.69 kB+0.04%+25 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.56 kB+0.04%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.14 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.07 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed81.69 kB+0.1%+75 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.23 kB+0.06%+75 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.52 kB+0.09%+75 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.06 kB+0.06%+75 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.91 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.83 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.65 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.63 kB+0.03%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.44 kB+0.03%+75 B 🔺
@sentry/nextjs (client)46.76 kB+0.07%+30 B 🔺
@sentry/sveltekit (client)42.54 kB+0.06%+24 B 🔺
@sentry/node-core52.1 kB+0.06%+27 B 🔺
@sentry/node166.1 kB+0.02%+22 B 🔺
@sentry/node - without tracing93.86 kB+0.03%+24 B 🔺
@sentry/aws-serverless109.38 kB+0.03%+25 B 🔺
View base workflow run
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline10,418-8,412+24%
GET With Sentry1,74117%1,612+8%
GET With Sentry (error only)6,98067%5,928+18%
POST Baseline1,044-1,171-11%
POST With Sentry54152%565-4%
POST With Sentry (error only)93890%1,048-10%
MYSQL Baseline3,732-3,243+15%
MYSQL With Sentry46412%469-1%
MYSQL With Sentry (error only)2,94979%2,646+11%
View base workflow run
chargome
chargome
approved these changes
Jan 29, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Comment threadpackages/core/src/utils/timer.ts
Outdated


This was referenced Jan 29, 2026
 Merged


Closed

@Lms24
Lms24
marked this pull request as ready for review
January 29, 2026 16:51
CopilotAIand others
added 9 commits
January 29, 2026 18:03
@Lms24
Initial plan
f40eb35
@Lms24
Fix client.flush() blocking process exit with unref'd timers and earl…
1438d5b
…y exit
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
Fix lint error in client.test.ts
f9f3f6b
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
deslop
dfa682b
@Lms24
extract safeUnref
92aa121
@Lms24
size check
8746622
@Lms24
stop flushing too early
4d8a973
@Lms24@chargome
Update packages/core/src/utils/timer.ts
39baa2f
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@Lms24
make test more strict
917fc69
@Lms24
Lms24force-pushed
the
copilot/fix-issue-18996-bug
branch
from
0ad6633 to
917fc69CompareJanuary 29, 2026 17:22
cursor[bot]
cursorBot
reviewed
Jan 29, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment threadpackages/core/src/utils/timer.ts
@Lms24
Lms24
merged commit c61baee
into
developJan 29, 2026

217 checks passed

@Lms24
Lms24
deleted the

copilot/fix-issue-18996-bug

branch
January 29, 2026 18:26
Lms24 added a commit
that referenced
this pull request
Feb 4, 2026
@Lms24
chore(bugbot): Add rule to flag not-unref'd timers (#19082)
29853f1
Quick follow-up from
#19062.
Closes#19083 (added automatically)

This was referenced Feb 5, 2026

Closed

 Merged

JPeer264 added a commit
that referenced
this pull request
Feb 5, 2026
@JPeer264
fix(core): Avoid blocking the process for weightBasedFlushing (#19174)
b7f8cfe
closes#19171
closes
[JS-1641](https://linear.app/getsentry/issue/JS-1641/metrics-flush-timer-should-use-unref-to-not-block-process-exit)
This was is something that got missed by Copilot on #19062
@BYKBYK
mentioned this pull request
Feb 16, 2026
 Merged

BYK added a commit
to getsentry/cli
that referenced
this pull request
Feb 16, 2026
@BYK
fix(telemetry): upgrade Sentry SDK to 10.39.0 and remove custom patch…
604b4e6
…es (#249)
## Summary
Upgrade `@sentry/bun` and `@sentry/node` from 10.38.0 → 10.39.0 and
remove all custom patches/workarounds that are now fixed upstream.
## Changes
- **Removed `patches/@sentry%2Fcore@10.38.0.patch`** (92 lines) — Added
`.unref()` to timers in `setupWeightBasedFlushing`,
`_isClientDoneProcessing`, and `makePromiseBuffer` to prevent the CLI
from hanging on exit. Fixed upstream by
[#19062](getsentry/sentry-javascript#19062) and
[#19174](getsentry/sentry-javascript#19174).
- **Removed runtime context workaround in `src/lib/telemetry.ts`** (14
lines) — Manually overrode `options.runtime` after `Sentry.init()` to
report Bun instead of Node.js. Fixed upstream — `NodeClient` now uses
`options.runtime || { name: 'node', ... }` and `@sentry/bun` passes `{
name: 'bun', version: Bun.version }`. Tracked as
[#19269](getsentry/sentry-javascript#19269).
- **Updated `package.json`** — Bumped both SDK packages to `10.39.0` and
removed `@sentry/core` from `patchedDependencies`.
## Verification
- Verified all three upstream fixes by reading the 10.39.0 source code
and linked PRs
- `bun install`, typecheck, lint, and tests all pass cleanly
- No new test failures introduced (pre-existing ~95 failures on `main`
are unrelated)
@coderabbitaicoderabbitaiBot
mentioned this pull request
May 13, 2026
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@Lms24Lms24
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Avoid blocking the process when calling flush on empty buffer - #19062
Merged
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Jan 29, 2026
Merged
fix(core): Avoid blocking the process when calling flush on empty buffer#19062
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Conversation
CopilotAI
commented
Jan 28, 2026•

edited by Lms24

Loading

Copy link


Copy Markdown

Contributor
PR and description checked and updated by @Lms24
This PR fixes a bug when calling Sentry.flush() (or client.flush()) and there's no telemetry being processed by the SDK. While previously we'd wait for the passed-in timeout, we now exit early.
In addition, this also calls unref() on started timeouts for server SDKs so that pending timeouts started by the SDK don't block the process from exiting.
CopilotAI
changed the title
[WIP] Fix bug for issue 18996 in sentry-javascriptFix client.flush() blocking process exit due to non-unref'd timersJan 28, 2026
CopilotAI
requested a review
from Lms24January 28, 2026 16:05
@Lms24Lms24
changed the title
Fix client.flush() blocking process exit due to non-unref'd timersfix(core): Avoid blocking the process when calling flush on empty bufferJan 28, 2026
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser25.35 kB+0.1%+24 B 🔺
@sentry/browser - with treeshaking flags23.86 kB+0.12%+28 B 🔺
@sentry/browser (incl. Tracing)42.17 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.81 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Replay)80.79 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.44 kB+0.04%+27 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.49 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.69 kB+0.03%+24 B 🔺
@sentry/browser (incl. Feedback)42.07 kB+0.06%+24 B 🔺
@sentry/browser (incl. sendFeedback)30.04 kB+0.08%+23 B 🔺
@sentry/browser (incl. FeedbackAsync)35.04 kB+0.07%+24 B 🔺
@sentry/browser (incl. Metrics)26.46 kB+0.11%+29 B 🔺
@sentry/browser (incl. Logs)26.61 kB+0.12%+30 B 🔺
@sentry/browser (incl. Metrics & Logs)27.27 kB+0.1%+26 B 🔺
@sentry/react27.08 kB+0.1%+27 B 🔺
@sentry/react (incl. Tracing)44.4 kB+0.07%+28 B 🔺
@sentry/vue29.79 kB+0.09%+24 B 🔺
@sentry/vue (incl. Tracing)43.96 kB+0.06%+23 B 🔺
@sentry/svelte25.37 kB+0.1%+24 B 🔺
CDN Bundle27.92 kB+0.08%+22 B 🔺
CDN Bundle (incl. Tracing)42.96 kB+0.07%+27 B 🔺
CDN Bundle (incl. Logs, Metrics)28.77 kB+0.09%+25 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.78 kB+0.07%+27 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.7 kB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay)79.69 kB+0.04%+25 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.56 kB+0.04%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.14 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.07 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed81.69 kB+0.1%+75 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.23 kB+0.06%+75 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.52 kB+0.09%+75 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.06 kB+0.06%+75 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.91 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.83 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.65 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.63 kB+0.03%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.44 kB+0.03%+75 B 🔺
@sentry/nextjs (client)46.76 kB+0.07%+30 B 🔺
@sentry/sveltekit (client)42.54 kB+0.06%+24 B 🔺
@sentry/node-core52.1 kB+0.06%+27 B 🔺
@sentry/node166.1 kB+0.02%+22 B 🔺
@sentry/node - without tracing93.86 kB+0.03%+24 B 🔺
@sentry/aws-serverless109.38 kB+0.03%+25 B 🔺
View base workflow run
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline10,418-8,412+24%
GET With Sentry1,74117%1,612+8%
GET With Sentry (error only)6,98067%5,928+18%
POST Baseline1,044-1,171-11%
POST With Sentry54152%565-4%
POST With Sentry (error only)93890%1,048-10%
MYSQL Baseline3,732-3,243+15%
MYSQL With Sentry46412%469-1%
MYSQL With Sentry (error only)2,94979%2,646+11%
View base workflow run
chargome
chargome
approved these changes
Jan 29, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Comment threadpackages/core/src/utils/timer.ts
Outdated


This was referenced Jan 29, 2026
 Merged


Closed

@Lms24
Lms24
marked this pull request as ready for review
January 29, 2026 16:51
CopilotAIand others
added 9 commits
January 29, 2026 18:03
@Lms24
Initial plan
f40eb35
@Lms24
Fix client.flush() blocking process exit with unref'd timers and earl…
1438d5b
…y exit
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
Fix lint error in client.test.ts
f9f3f6b
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
deslop
dfa682b
@Lms24
extract safeUnref
92aa121
@Lms24
size check
8746622
@Lms24
stop flushing too early
4d8a973
@Lms24@chargome
Update packages/core/src/utils/timer.ts
39baa2f
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@Lms24
make test more strict
917fc69
@Lms24
Lms24force-pushed
the
copilot/fix-issue-18996-bug
branch
from
0ad6633 to
917fc69CompareJanuary 29, 2026 17:22
cursor[bot]
cursorBot
reviewed
Jan 29, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment threadpackages/core/src/utils/timer.ts
@Lms24
Lms24
merged commit c61baee
into
developJan 29, 2026

217 checks passed

@Lms24
Lms24
deleted the

copilot/fix-issue-18996-bug

branch
January 29, 2026 18:26
Lms24 added a commit
that referenced
this pull request
Feb 4, 2026
@Lms24
chore(bugbot): Add rule to flag not-unref'd timers (#19082)
29853f1
Quick follow-up from
#19062.
Closes#19083 (added automatically)

This was referenced Feb 5, 2026

Closed

 Merged

JPeer264 added a commit
that referenced
this pull request
Feb 5, 2026
@JPeer264
fix(core): Avoid blocking the process for weightBasedFlushing (#19174)
b7f8cfe
closes#19171
closes
[JS-1641](https://linear.app/getsentry/issue/JS-1641/metrics-flush-timer-should-use-unref-to-not-block-process-exit)
This was is something that got missed by Copilot on #19062
@BYKBYK
mentioned this pull request
Feb 16, 2026
 Merged

BYK added a commit
to getsentry/cli
that referenced
this pull request
Feb 16, 2026
@BYK
fix(telemetry): upgrade Sentry SDK to 10.39.0 and remove custom patch…
604b4e6
…es (#249)
## Summary
Upgrade `@sentry/bun` and `@sentry/node` from 10.38.0 → 10.39.0 and
remove all custom patches/workarounds that are now fixed upstream.
## Changes
- **Removed `patches/@sentry%2Fcore@10.38.0.patch`** (92 lines) — Added
`.unref()` to timers in `setupWeightBasedFlushing`,
`_isClientDoneProcessing`, and `makePromiseBuffer` to prevent the CLI
from hanging on exit. Fixed upstream by
[#19062](getsentry/sentry-javascript#19062) and
[#19174](getsentry/sentry-javascript#19174).
- **Removed runtime context workaround in `src/lib/telemetry.ts`** (14
lines) — Manually overrode `options.runtime` after `Sentry.init()` to
report Bun instead of Node.js. Fixed upstream — `NodeClient` now uses
`options.runtime || { name: 'node', ... }` and `@sentry/bun` passes `{
name: 'bun', version: Bun.version }`. Tracked as
[#19269](getsentry/sentry-javascript#19269).
- **Updated `package.json`** — Bumped both SDK packages to `10.39.0` and
removed `@sentry/core` from `patchedDependencies`.
## Verification
- Verified all three upstream fixes by reading the 10.39.0 source code
and linked PRs
- `bun install`, typecheck, lint, and tests all pass cleanly
- No new test failures introduced (pre-existing ~95 failures on `main`
are unrelated)
@coderabbitaicoderabbitaiBot
mentioned this pull request
May 13, 2026
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@Lms24Lms24
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(core): Avoid blocking the process when calling flush on empty buffer - #19062
Merged
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Jan 29, 2026
Merged
fix(core): Avoid blocking the process when calling flush on empty buffer#19062
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Conversation
CopilotAI
commented
Jan 28, 2026•

edited by Lms24

Loading

Copy link


Copy Markdown

Contributor
PR and description checked and updated by @Lms24
This PR fixes a bug when calling Sentry.flush() (or client.flush()) and there's no telemetry being processed by the SDK. While previously we'd wait for the passed-in timeout, we now exit early.
In addition, this also calls unref() on started timeouts for server SDKs so that pending timeouts started by the SDK don't block the process from exiting.
CopilotAI
changed the title
[WIP] Fix bug for issue 18996 in sentry-javascriptFix client.flush() blocking process exit due to non-unref'd timersJan 28, 2026
CopilotAI
requested a review
from Lms24January 28, 2026 16:05
@Lms24Lms24
changed the title
Fix client.flush() blocking process exit due to non-unref'd timersfix(core): Avoid blocking the process when calling flush on empty bufferJan 28, 2026
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser25.35 kB+0.1%+24 B 🔺
@sentry/browser - with treeshaking flags23.86 kB+0.12%+28 B 🔺
@sentry/browser (incl. Tracing)42.17 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.81 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Replay)80.79 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.44 kB+0.04%+27 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.49 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.69 kB+0.03%+24 B 🔺
@sentry/browser (incl. Feedback)42.07 kB+0.06%+24 B 🔺
@sentry/browser (incl. sendFeedback)30.04 kB+0.08%+23 B 🔺
@sentry/browser (incl. FeedbackAsync)35.04 kB+0.07%+24 B 🔺
@sentry/browser (incl. Metrics)26.46 kB+0.11%+29 B 🔺
@sentry/browser (incl. Logs)26.61 kB+0.12%+30 B 🔺
@sentry/browser (incl. Metrics & Logs)27.27 kB+0.1%+26 B 🔺
@sentry/react27.08 kB+0.1%+27 B 🔺
@sentry/react (incl. Tracing)44.4 kB+0.07%+28 B 🔺
@sentry/vue29.79 kB+0.09%+24 B 🔺
@sentry/vue (incl. Tracing)43.96 kB+0.06%+23 B 🔺
@sentry/svelte25.37 kB+0.1%+24 B 🔺
CDN Bundle27.92 kB+0.08%+22 B 🔺
CDN Bundle (incl. Tracing)42.96 kB+0.07%+27 B 🔺
CDN Bundle (incl. Logs, Metrics)28.77 kB+0.09%+25 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.78 kB+0.07%+27 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.7 kB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay)79.69 kB+0.04%+25 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.56 kB+0.04%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.14 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.07 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed81.69 kB+0.1%+75 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.23 kB+0.06%+75 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.52 kB+0.09%+75 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.06 kB+0.06%+75 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.91 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.83 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.65 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.63 kB+0.03%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.44 kB+0.03%+75 B 🔺
@sentry/nextjs (client)46.76 kB+0.07%+30 B 🔺
@sentry/sveltekit (client)42.54 kB+0.06%+24 B 🔺
@sentry/node-core52.1 kB+0.06%+27 B 🔺
@sentry/node166.1 kB+0.02%+22 B 🔺
@sentry/node - without tracing93.86 kB+0.03%+24 B 🔺
@sentry/aws-serverless109.38 kB+0.03%+25 B 🔺
View base workflow run
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline10,418-8,412+24%
GET With Sentry1,74117%1,612+8%
GET With Sentry (error only)6,98067%5,928+18%
POST Baseline1,044-1,171-11%
POST With Sentry54152%565-4%
POST With Sentry (error only)93890%1,048-10%
MYSQL Baseline3,732-3,243+15%
MYSQL With Sentry46412%469-1%
MYSQL With Sentry (error only)2,94979%2,646+11%
View base workflow run
chargome
chargome
approved these changes
Jan 29, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Comment threadpackages/core/src/utils/timer.ts
Outdated


This was referenced Jan 29, 2026
 Merged


Closed

@Lms24
Lms24
marked this pull request as ready for review
January 29, 2026 16:51
CopilotAIand others
added 9 commits
January 29, 2026 18:03
@Lms24
Initial plan
f40eb35
@Lms24
Fix client.flush() blocking process exit with unref'd timers and earl…
1438d5b
…y exit
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
Fix lint error in client.test.ts
f9f3f6b
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
deslop
dfa682b
@Lms24
extract safeUnref
92aa121
@Lms24
size check
8746622
@Lms24
stop flushing too early
4d8a973
@Lms24@chargome
Update packages/core/src/utils/timer.ts
39baa2f
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@Lms24
make test more strict
917fc69
@Lms24
Lms24force-pushed
the
copilot/fix-issue-18996-bug
branch
from
0ad6633 to
917fc69CompareJanuary 29, 2026 17:22
cursor[bot]
cursorBot
reviewed
Jan 29, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment threadpackages/core/src/utils/timer.ts
@Lms24
Lms24
merged commit c61baee
into
developJan 29, 2026

217 checks passed

@Lms24
Lms24
deleted the

copilot/fix-issue-18996-bug

branch
January 29, 2026 18:26
Lms24 added a commit
that referenced
this pull request
Feb 4, 2026
@Lms24
chore(bugbot): Add rule to flag not-unref'd timers (#19082)
29853f1
Quick follow-up from
#19062.
Closes#19083 (added automatically)

This was referenced Feb 5, 2026

Closed

 Merged

JPeer264 added a commit
that referenced
this pull request
Feb 5, 2026
@JPeer264
fix(core): Avoid blocking the process for weightBasedFlushing (#19174)
b7f8cfe
closes#19171
closes
[JS-1641](https://linear.app/getsentry/issue/JS-1641/metrics-flush-timer-should-use-unref-to-not-block-process-exit)
This was is something that got missed by Copilot on #19062
@BYKBYK
mentioned this pull request
Feb 16, 2026
 Merged

BYK added a commit
to getsentry/cli
that referenced
this pull request
Feb 16, 2026
@BYK
fix(telemetry): upgrade Sentry SDK to 10.39.0 and remove custom patch…
604b4e6
…es (#249)
## Summary
Upgrade `@sentry/bun` and `@sentry/node` from 10.38.0 → 10.39.0 and
remove all custom patches/workarounds that are now fixed upstream.
## Changes
- **Removed `patches/@sentry%2Fcore@10.38.0.patch`** (92 lines) — Added
`.unref()` to timers in `setupWeightBasedFlushing`,
`_isClientDoneProcessing`, and `makePromiseBuffer` to prevent the CLI
from hanging on exit. Fixed upstream by
[#19062](getsentry/sentry-javascript#19062) and
[#19174](getsentry/sentry-javascript#19174).
- **Removed runtime context workaround in `src/lib/telemetry.ts`** (14
lines) — Manually overrode `options.runtime` after `Sentry.init()` to
report Bun instead of Node.js. Fixed upstream — `NodeClient` now uses
`options.runtime || { name: 'node', ... }` and `@sentry/bun` passes `{
name: 'bun', version: Bun.version }`. Tracked as
[#19269](getsentry/sentry-javascript#19269).
- **Updated `package.json`** — Bumped both SDK packages to `10.39.0` and
removed `@sentry/core` from `patchedDependencies`.
## Verification
- Verified all three upstream fixes by reading the 10.39.0 source code
and linked PRs
- `bun install`, typecheck, lint, and tests all pass cleanly
- No new test failures introduced (pre-existing ~95 failures on `main`
are unrelated)
@coderabbitaicoderabbitaiBot
mentioned this pull request
May 13, 2026
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@Lms24Lms24
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(core): Avoid blocking the process when calling flush on empty buffer - #19062
Merged
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Jan 29, 2026
Merged
fix(core): Avoid blocking the process when calling flush on empty buffer#19062
Lms24 merged 12 commits into
developfrom 
copilot/fix-issue-18996-bug
Conversation
CopilotAI
commented
Jan 28, 2026•

edited by Lms24

Loading

Copy link


Copy Markdown

Contributor
PR and description checked and updated by @Lms24
This PR fixes a bug when calling Sentry.flush() (or client.flush()) and there's no telemetry being processed by the SDK. While previously we'd wait for the passed-in timeout, we now exit early.
In addition, this also calls unref() on started timeouts for server SDKs so that pending timeouts started by the SDK don't block the process from exiting.
CopilotAI
changed the title
[WIP] Fix bug for issue 18996 in sentry-javascriptFix client.flush() blocking process exit due to non-unref'd timersJan 28, 2026
CopilotAI
requested a review
from Lms24January 28, 2026 16:05
@Lms24Lms24
changed the title
Fix client.flush() blocking process exit due to non-unref'd timersfix(core): Avoid blocking the process when calling flush on empty bufferJan 28, 2026
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser25.35 kB+0.1%+24 B 🔺
@sentry/browser - with treeshaking flags23.86 kB+0.12%+28 B 🔺
@sentry/browser (incl. Tracing)42.17 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Profiling)46.81 kB+0.06%+24 B 🔺
@sentry/browser (incl. Tracing, Replay)80.79 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.44 kB+0.04%+27 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)85.49 kB+0.03%+24 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)97.69 kB+0.03%+24 B 🔺
@sentry/browser (incl. Feedback)42.07 kB+0.06%+24 B 🔺
@sentry/browser (incl. sendFeedback)30.04 kB+0.08%+23 B 🔺
@sentry/browser (incl. FeedbackAsync)35.04 kB+0.07%+24 B 🔺
@sentry/browser (incl. Metrics)26.46 kB+0.11%+29 B 🔺
@sentry/browser (incl. Logs)26.61 kB+0.12%+30 B 🔺
@sentry/browser (incl. Metrics & Logs)27.27 kB+0.1%+26 B 🔺
@sentry/react27.08 kB+0.1%+27 B 🔺
@sentry/react (incl. Tracing)44.4 kB+0.07%+28 B 🔺
@sentry/vue29.79 kB+0.09%+24 B 🔺
@sentry/vue (incl. Tracing)43.96 kB+0.06%+23 B 🔺
@sentry/svelte25.37 kB+0.1%+24 B 🔺
CDN Bundle27.92 kB+0.08%+22 B 🔺
CDN Bundle (incl. Tracing)42.96 kB+0.07%+27 B 🔺
CDN Bundle (incl. Logs, Metrics)28.77 kB+0.09%+25 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)43.78 kB+0.07%+27 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)67.7 kB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay)79.69 kB+0.04%+25 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.56 kB+0.04%+26 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)85.14 kB+0.03%+23 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.07 kB+0.03%+25 B 🔺
CDN Bundle - uncompressed81.69 kB+0.1%+75 B 🔺
CDN Bundle (incl. Tracing) - uncompressed127.23 kB+0.06%+75 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed84.52 kB+0.09%+75 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.06 kB+0.06%+75 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed207.91 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed243.83 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed246.65 kB+0.04%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.63 kB+0.03%+75 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed259.44 kB+0.03%+75 B 🔺
@sentry/nextjs (client)46.76 kB+0.07%+30 B 🔺
@sentry/sveltekit (client)42.54 kB+0.06%+24 B 🔺
@sentry/node-core52.1 kB+0.06%+27 B 🔺
@sentry/node166.1 kB+0.02%+22 B 🔺
@sentry/node - without tracing93.86 kB+0.03%+24 B 🔺
@sentry/aws-serverless109.38 kB+0.03%+25 B 🔺
View base workflow run
@github-actions
github-actionsBot
commented
Jan 28, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
node-overhead report 🧳
Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline10,418-8,412+24%
GET With Sentry1,74117%1,612+8%
GET With Sentry (error only)6,98067%5,928+18%
POST Baseline1,044-1,171-11%
POST With Sentry54152%565-4%
POST With Sentry (error only)93890%1,048-10%
MYSQL Baseline3,732-3,243+15%
MYSQL With Sentry46412%469-1%
MYSQL With Sentry (error only)2,94979%2,646+11%
View base workflow run
chargome
chargome
approved these changes
Jan 29, 2026
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Comment threadpackages/core/src/utils/timer.ts
Outdated


This was referenced Jan 29, 2026
 Merged


Closed

@Lms24
Lms24
marked this pull request as ready for review
January 29, 2026 16:51
CopilotAIand others
added 9 commits
January 29, 2026 18:03
@Lms24
Initial plan
f40eb35
@Lms24
Fix client.flush() blocking process exit with unref'd timers and earl…
1438d5b
…y exit
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
Fix lint error in client.test.ts
f9f3f6b
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@Lms24
deslop
dfa682b
@Lms24
extract safeUnref
92aa121
@Lms24
size check
8746622
@Lms24
stop flushing too early
4d8a973
@Lms24@chargome
Update packages/core/src/utils/timer.ts
39baa2f
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
@Lms24
make test more strict
917fc69
@Lms24
Lms24force-pushed
the
copilot/fix-issue-18996-bug
branch
from
0ad6633 to
917fc69CompareJanuary 29, 2026 17:22
cursor[bot]
cursorBot
reviewed
Jan 29, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment threadpackages/core/src/utils/timer.ts
@Lms24
Lms24
merged commit c61baee
into
developJan 29, 2026

217 checks passed

@Lms24
Lms24
deleted the

copilot/fix-issue-18996-bug

branch
January 29, 2026 18:26
Lms24 added a commit
that referenced
this pull request
Feb 4, 2026
@Lms24
chore(bugbot): Add rule to flag not-unref'd timers (#19082)
29853f1
Quick follow-up from
#19062.
Closes#19083 (added automatically)

This was referenced Feb 5, 2026

Closed

 Merged

JPeer264 added a commit
that referenced
this pull request
Feb 5, 2026
@JPeer264
fix(core): Avoid blocking the process for weightBasedFlushing (#19174)
b7f8cfe
closes#19171
closes
[JS-1641](https://linear.app/getsentry/issue/JS-1641/metrics-flush-timer-should-use-unref-to-not-block-process-exit)
This was is something that got missed by Copilot on #19062
@BYKBYK
mentioned this pull request
Feb 16, 2026
 Merged

BYK added a commit
to getsentry/cli
that referenced
this pull request
Feb 16, 2026
@BYK
fix(telemetry): upgrade Sentry SDK to 10.39.0 and remove custom patch…
604b4e6
…es (#249)
## Summary
Upgrade `@sentry/bun` and `@sentry/node` from 10.38.0 → 10.39.0 and
remove all custom patches/workarounds that are now fixed upstream.
## Changes
- **Removed `patches/@sentry%2Fcore@10.38.0.patch`** (92 lines) — Added
`.unref()` to timers in `setupWeightBasedFlushing`,
`_isClientDoneProcessing`, and `makePromiseBuffer` to prevent the CLI
from hanging on exit. Fixed upstream by
[#19062](getsentry/sentry-javascript#19062) and
[#19174](getsentry/sentry-javascript#19174).
- **Removed runtime context workaround in `src/lib/telemetry.ts`** (14
lines) — Manually overrode `options.runtime` after `Sentry.init()` to
report Bun instead of Node.js. Fixed upstream — `NodeClient` now uses
`options.runtime || { name: 'node', ... }` and `@sentry/bun` passes `{
name: 'bun', version: Bun.version }`. Tracked as
[#19269](getsentry/sentry-javascript#19269).
- **Updated `package.json`** — Bumped both SDK packages to `10.39.0` and
removed `@sentry/core` from `patchedDependencies`.
## Verification
- Verified all three upstream fixes by reading the 10.39.0 source code
and linked PRs
- `bun install`, typecheck, lint, and tests all pass cleanly
- No new test failures introduced (pre-existing ~95 failures on `main`
are unrelated)
@coderabbitaicoderabbitaiBot
mentioned this pull request
May 13, 2026
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@Lms24Lms24
Copilot code reviewCopilot

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@chargome