Uh oh!
There was an error while loading. Please reload this page.
ref(dynamic-config): Remove transaction metrics allowlist from Sentry - #2092
Merged
Conversation
jjbayer
approved these changes
May 4, 2023
iker-barriocanal
approved these changes
May 5, 2023
| **Internal**: | ||
| - Remove transaction metrics allowlist. ([#2092](https://github.com/getsentry/relay/pull/2092)) |
Contributor
There was a problem hiding this comment.
Should we add this to a breaking changes section in the changelog?
jan-auer added a commit
that referenced
this pull request
May 9, 2023
* master: (178 commits) ref(crons): Allow `_` in monitor slugs (#2100) fix(span-metrics): Scrub subdomains in metric tags (#2103) feat(normalization): Scrub span description URLs (#2095) feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091) ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092) feat(protocol): Support old effective-directory format (#2048) ref(spans): Add more tags to span metrics (#2090) fix(server): Support HTTP half-close connections (#2089) ref(spans): Use transactions namespace with `span` prefix (#2087) ref(spans): Update span metrics feature flag name (#2086) feat(metrics): Extract more metrics from spans (#2080) build: Bump tempfile to remove flagged dependency (#2085) feat(filter): Add document_uri csp filter (#2059) build: Use jemalloc on Linux (#2084) ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081) feat(crons): Pass-through minimal `sdk` field (#2073) fix(quota): Parse large limits (#2079) instr(server): More details on unexpected envelope drop (#2077) fix(ci): Skip flaky integration test (#2076) feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070) ...
jjbayer pushed a commit
to getsentry/sentry
that referenced
this pull request
May 10, 2023
…on (#48428) Now that we have removed the transaction metrics allowlist from relay (getsentry/relay#2092) we want to also remove it from sentry. This also requires bumping the relay library version to 0.8.22 to pass project config validation tests. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
volokluev pushed a commit
to getsentry/sentry
that referenced
this pull request
May 30, 2023
…on (#48428) Now that we have removed the transaction metrics allowlist from relay (getsentry/relay#2092) we want to also remove it from sentry. This also requires bumping the relay library version to 0.8.22 to pass project config validation tests. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1632
With this change, old external relays will have to be upgraded in order to extract metrics.