fix(span-metrics): Scrub subdomains in metric tags by iker-barriocanal · Pull Request #2103 · getsentry/relay

iker-barriocanal · 2023-05-08T09:26:15Z

A dummy and straight-forward approach to scrub subdomains and reduce metric cardinality. It's a best effort.

#skip-changelog

jjbayer

Requesting changes because of the no port case

jjbayer · 2023-05-08T09:56:53Z

+ } else {
+ Some(format!("{}:{}", domain, port))
+ }


nit: Should be possible to do this without allocating a vector (and without the else branch), but I don't have the code for it ready so feel free to ignore.

iker-barriocanal · 2023-05-08T13:12:51Z

+ extracted_domain[0], extracted_domain[1], p
+ ));
+ }
+ return Some(format!("*.{}.{}", extracted_domain[0], extracted_domain[1]));


It'd be more readable to generate more than one string, but I think the code isn't that complicated to make it worth the performance overhead of creating more strings.

* master: (178 commits) ref(crons): Allow `_` in monitor slugs (#2100) fix(span-metrics): Scrub subdomains in metric tags (#2103) feat(normalization): Scrub span description URLs (#2095) feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091) ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092) feat(protocol): Support old effective-directory format (#2048) ref(spans): Add more tags to span metrics (#2090) fix(server): Support HTTP half-close connections (#2089) ref(spans): Use transactions namespace with `span` prefix (#2087) ref(spans): Update span metrics feature flag name (#2086) feat(metrics): Extract more metrics from spans (#2080) build: Bump tempfile to remove flagged dependency (#2085) feat(filter): Add document_uri csp filter (#2059) build: Use jemalloc on Linux (#2084) ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081) feat(crons): Pass-through minimal `sdk` field (#2073) fix(quota): Parse large limits (#2079) instr(server): More details on unexpected envelope drop (#2077) fix(ci): Skip flaky integration test (#2076) feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070) ...

iker-barriocanal · 2023-05-08T09:26:15Z

A dummy and straight-forward approach to scrub subdomains and reduce metric cardinality. It's a best effort.

#skip-changelog

jjbayer

Requesting changes because of the no port case

jjbayer · 2023-05-08T09:56:53Z

+ } else {
+ Some(format!("{}:{}", domain, port))
+ }


nit: Should be possible to do this without allocating a vector (and without the else branch), but I don't have the code for it ready so feel free to ignore.

iker-barriocanal · 2023-05-08T13:12:51Z

+ extracted_domain[0], extracted_domain[1], p
+ ));
+ }
+ return Some(format!("*.{}.{}", extracted_domain[0], extracted_domain[1]));


It'd be more readable to generate more than one string, but I think the code isn't that complicated to make it worth the performance overhead of creating more strings.

* master: (178 commits) ref(crons): Allow `_` in monitor slugs (#2100) fix(span-metrics): Scrub subdomains in metric tags (#2103) feat(normalization): Scrub span description URLs (#2095) feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091) ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092) feat(protocol): Support old effective-directory format (#2048) ref(spans): Add more tags to span metrics (#2090) fix(server): Support HTTP half-close connections (#2089) ref(spans): Use transactions namespace with `span` prefix (#2087) ref(spans): Update span metrics feature flag name (#2086) feat(metrics): Extract more metrics from spans (#2080) build: Bump tempfile to remove flagged dependency (#2085) feat(filter): Add document_uri csp filter (#2059) build: Use jemalloc on Linux (#2084) ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081) feat(crons): Pass-through minimal `sdk` field (#2073) fix(quota): Parse large limits (#2079) instr(server): More details on unexpected envelope drop (#2077) fix(ci): Skip flaky integration test (#2076) feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070) ...

iker-barriocanal · 2023-05-08T09:26:15Z

A dummy and straight-forward approach to scrub subdomains and reduce metric cardinality. It's a best effort.

#skip-changelog

jjbayer

Requesting changes because of the no port case

jjbayer · 2023-05-08T09:56:53Z

+ } else {
+ Some(format!("{}:{}", domain, port))
+ }


nit: Should be possible to do this without allocating a vector (and without the else branch), but I don't have the code for it ready so feel free to ignore.

iker-barriocanal · 2023-05-08T13:12:51Z

+ extracted_domain[0], extracted_domain[1], p
+ ));
+ }
+ return Some(format!("*.{}.{}", extracted_domain[0], extracted_domain[1]));


It'd be more readable to generate more than one string, but I think the code isn't that complicated to make it worth the performance overhead of creating more strings.

* master: (178 commits) ref(crons): Allow `_` in monitor slugs (#2100) fix(span-metrics): Scrub subdomains in metric tags (#2103) feat(normalization): Scrub span description URLs (#2095) feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091) ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092) feat(protocol): Support old effective-directory format (#2048) ref(spans): Add more tags to span metrics (#2090) fix(server): Support HTTP half-close connections (#2089) ref(spans): Use transactions namespace with `span` prefix (#2087) ref(spans): Update span metrics feature flag name (#2086) feat(metrics): Extract more metrics from spans (#2080) build: Bump tempfile to remove flagged dependency (#2085) feat(filter): Add document_uri csp filter (#2059) build: Use jemalloc on Linux (#2084) ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081) feat(crons): Pass-through minimal `sdk` field (#2073) fix(quota): Parse large limits (#2079) instr(server): More details on unexpected envelope drop (#2077) fix(ci): Skip flaky integration test (#2076) feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070) ...

iker-barriocanal · 2023-05-08T09:26:15Z

A dummy and straight-forward approach to scrub subdomains and reduce metric cardinality. It's a best effort.

#skip-changelog

jjbayer

Requesting changes because of the no port case

jjbayer · 2023-05-08T09:56:53Z

+ } else {
+ Some(format!("{}:{}", domain, port))
+ }


nit: Should be possible to do this without allocating a vector (and without the else branch), but I don't have the code for it ready so feel free to ignore.

iker-barriocanal · 2023-05-08T13:12:51Z

+ extracted_domain[0], extracted_domain[1], p
+ ));
+ }
+ return Some(format!("*.{}.{}", extracted_domain[0], extracted_domain[1]));


It'd be more readable to generate more than one string, but I think the code isn't that complicated to make it worth the performance overhead of creating more strings.

* master: (178 commits) ref(crons): Allow `_` in monitor slugs (#2100) fix(span-metrics): Scrub subdomains in metric tags (#2103) feat(normalization): Scrub span description URLs (#2095) feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091) ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092) feat(protocol): Support old effective-directory format (#2048) ref(spans): Add more tags to span metrics (#2090) fix(server): Support HTTP half-close connections (#2089) ref(spans): Use transactions namespace with `span` prefix (#2087) ref(spans): Update span metrics feature flag name (#2086) feat(metrics): Extract more metrics from spans (#2080) build: Bump tempfile to remove flagged dependency (#2085) feat(filter): Add document_uri csp filter (#2059) build: Use jemalloc on Linux (#2084) ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081) feat(crons): Pass-through minimal `sdk` field (#2073) fix(quota): Parse large limits (#2079) instr(server): More details on unexpected envelope drop (#2077) fix(ci): Skip flaky integration test (#2076) feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070) ...

iker-barriocanal · 2023-05-08T09:26:15Z

A dummy and straight-forward approach to scrub subdomains and reduce metric cardinality. It's a best effort.

#skip-changelog

jjbayer

Requesting changes because of the no port case

jjbayer · 2023-05-08T09:56:53Z

+ } else {
+ Some(format!("{}:{}", domain, port))
+ }


nit: Should be possible to do this without allocating a vector (and without the else branch), but I don't have the code for it ready so feel free to ignore.

iker-barriocanal · 2023-05-08T13:12:51Z

+ extracted_domain[0], extracted_domain[1], p
+ ));
+ }
+ return Some(format!("*.{}.{}", extracted_domain[0], extracted_domain[1]));


It'd be more readable to generate more than one string, but I think the code isn't that complicated to make it worth the performance overhead of creating more strings.

* master: (178 commits) ref(crons): Allow `_` in monitor slugs (#2100) fix(span-metrics): Scrub subdomains in metric tags (#2103) feat(normalization): Scrub span description URLs (#2095) feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091) ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092) feat(protocol): Support old effective-directory format (#2048) ref(spans): Add more tags to span metrics (#2090) fix(server): Support HTTP half-close connections (#2089) ref(spans): Use transactions namespace with `span` prefix (#2087) ref(spans): Update span metrics feature flag name (#2086) feat(metrics): Extract more metrics from spans (#2080) build: Bump tempfile to remove flagged dependency (#2085) feat(filter): Add document_uri csp filter (#2059) build: Use jemalloc on Linux (#2084) ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081) feat(crons): Pass-through minimal `sdk` field (#2073) fix(quota): Parse large limits (#2079) instr(server): More details on unexpected envelope drop (#2077) fix(ci): Skip flaky integration test (#2076) feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070) ...

iker-barriocanal · 2023-05-08T09:26:15Z

A dummy and straight-forward approach to scrub subdomains and reduce metric cardinality. It's a best effort.

#skip-changelog

jjbayer

Requesting changes because of the no port case

jjbayer · 2023-05-08T09:56:53Z

+ } else {
+ Some(format!("{}:{}", domain, port))
+ }


nit: Should be possible to do this without allocating a vector (and without the else branch), but I don't have the code for it ready so feel free to ignore.

iker-barriocanal · 2023-05-08T13:12:51Z

+ extracted_domain[0], extracted_domain[1], p
+ ));
+ }
+ return Some(format!("*.{}.{}", extracted_domain[0], extracted_domain[1]));


It'd be more readable to generate more than one string, but I think the code isn't that complicated to make it worth the performance overhead of creating more strings.

* master: (178 commits) ref(crons): Allow `_` in monitor slugs (#2100) fix(span-metrics): Scrub subdomains in metric tags (#2103) feat(normalization): Scrub span description URLs (#2095) feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091) ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092) feat(protocol): Support old effective-directory format (#2048) ref(spans): Add more tags to span metrics (#2090) fix(server): Support HTTP half-close connections (#2089) ref(spans): Use transactions namespace with `span` prefix (#2087) ref(spans): Update span metrics feature flag name (#2086) feat(metrics): Extract more metrics from spans (#2080) build: Bump tempfile to remove flagged dependency (#2085) feat(filter): Add document_uri csp filter (#2059) build: Use jemalloc on Linux (#2084) ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081) feat(crons): Pass-through minimal `sdk` field (#2073) fix(quota): Parse large limits (#2079) instr(server): More details on unexpected envelope drop (#2077) fix(ci): Skip flaky integration test (#2076) feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070) ...

iker-barriocanal · 2023-05-08T09:26:15Z

A dummy and straight-forward approach to scrub subdomains and reduce metric cardinality. It's a best effort.

#skip-changelog

jjbayer

Requesting changes because of the no port case

jjbayer · 2023-05-08T09:56:53Z

+ } else {
+ Some(format!("{}:{}", domain, port))
+ }


nit: Should be possible to do this without allocating a vector (and without the else branch), but I don't have the code for it ready so feel free to ignore.

iker-barriocanal · 2023-05-08T13:12:51Z

+ extracted_domain[0], extracted_domain[1], p
+ ));
+ }
+ return Some(format!("*.{}.{}", extracted_domain[0], extracted_domain[1]));


It'd be more readable to generate more than one string, but I think the code isn't that complicated to make it worth the performance overhead of creating more strings.

* master: (178 commits) ref(crons): Allow `_` in monitor slugs (#2100) fix(span-metrics): Scrub subdomains in metric tags (#2103) feat(normalization): Scrub span description URLs (#2095) feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091) ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092) feat(protocol): Support old effective-directory format (#2048) ref(spans): Add more tags to span metrics (#2090) fix(server): Support HTTP half-close connections (#2089) ref(spans): Use transactions namespace with `span` prefix (#2087) ref(spans): Update span metrics feature flag name (#2086) feat(metrics): Extract more metrics from spans (#2080) build: Bump tempfile to remove flagged dependency (#2085) feat(filter): Add document_uri csp filter (#2059) build: Use jemalloc on Linux (#2084) ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081) feat(crons): Pass-through minimal `sdk` field (#2073) fix(quota): Parse large limits (#2079) instr(server): More details on unexpected envelope drop (#2077) fix(ci): Skip flaky integration test (#2076) feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070) ...

iker-barriocanal · 2023-05-08T09:26:15Z

A dummy and straight-forward approach to scrub subdomains and reduce metric cardinality. It's a best effort.

#skip-changelog

jjbayer

Requesting changes because of the no port case

jjbayer · 2023-05-08T09:56:53Z

+ } else {
+ Some(format!("{}:{}", domain, port))
+ }


nit: Should be possible to do this without allocating a vector (and without the else branch), but I don't have the code for it ready so feel free to ignore.

iker-barriocanal · 2023-05-08T13:12:51Z

+ extracted_domain[0], extracted_domain[1], p
+ ));
+ }
+ return Some(format!("*.{}.{}", extracted_domain[0], extracted_domain[1]));


It'd be more readable to generate more than one string, but I think the code isn't that complicated to make it worth the performance overhead of creating more strings.

* master: (178 commits) ref(crons): Allow `_` in monitor slugs (#2100) fix(span-metrics): Scrub subdomains in metric tags (#2103) feat(normalization): Scrub span description URLs (#2095) feat(dynamic-sampling): Add possibility to run dynamic sampling from `sentry-relay` (#2091) ref(dynamic-config): Remove transaction metrics allowlist from Sentry (#2092) feat(protocol): Support old effective-directory format (#2048) ref(spans): Add more tags to span metrics (#2090) fix(server): Support HTTP half-close connections (#2089) ref(spans): Use transactions namespace with `span` prefix (#2087) ref(spans): Update span metrics feature flag name (#2086) feat(metrics): Extract more metrics from spans (#2080) build: Bump tempfile to remove flagged dependency (#2085) feat(filter): Add document_uri csp filter (#2059) build: Use jemalloc on Linux (#2084) ci(gha): add debugging for "Couldn'\''t write tracker file" issue (#2081) feat(crons): Pass-through minimal `sdk` field (#2073) fix(quota): Parse large limits (#2079) instr(server): More details on unexpected envelope drop (#2077) fix(ci): Skip flaky integration test (#2076) feat(dynamic-sampling): Add support for `trace.replay_id` in matching rules (#2070) ...

fix(span-metrics): Scrub subdomains in metric tags
7688516

iker-barriocanal self-assigned this May 8, 2023

iker-barriocanal requested a review from a teamMay 8, 2023 09:26

jjbayer requested changes May 8, 2023
View reviewed changes

Also normalize domain on no port
d38d9e3

iker-barriocanal commented May 8, 2023
View reviewed changes

iker-barriocanal requested a review from jjbayer May 8, 2023 13:13

delete unneeded return
fa3166a

jjbayer requested changes May 8, 2023
View reviewed changes

Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated
Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated

fix case domain.tld
c21de58

iker-barriocanal requested a review from jjbayer May 8, 2023 14:29

jjbayer approved these changes May 8, 2023
View reviewed changes

iker-barriocanal enabled auto-merge (squash) May 8, 2023 14:33

iker-barriocanal merged commit e03d54d into masterMay 8, 2023

iker-barriocanal deleted the iker/fix/spans-metrics-domains branch May 8, 2023 14:46

fix(span-metrics): Scrub subdomains in metric tags
7688516

iker-barriocanal self-assigned this May 8, 2023

iker-barriocanal requested a review from a teamMay 8, 2023 09:26

jjbayer requested changes May 8, 2023
View reviewed changes

Also normalize domain on no port
d38d9e3

iker-barriocanal commented May 8, 2023
View reviewed changes

iker-barriocanal requested a review from jjbayer May 8, 2023 13:13

delete unneeded return
fa3166a

jjbayer requested changes May 8, 2023
View reviewed changes

Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated
Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated

fix case domain.tld
c21de58

iker-barriocanal requested a review from jjbayer May 8, 2023 14:29

jjbayer approved these changes May 8, 2023
View reviewed changes

iker-barriocanal enabled auto-merge (squash) May 8, 2023 14:33

iker-barriocanal merged commit e03d54d into masterMay 8, 2023

iker-barriocanal deleted the iker/fix/spans-metrics-domains branch May 8, 2023 14:46

fix(span-metrics): Scrub subdomains in metric tags
7688516

iker-barriocanal self-assigned this May 8, 2023

iker-barriocanal requested a review from a teamMay 8, 2023 09:26

jjbayer requested changes May 8, 2023
View reviewed changes

Also normalize domain on no port
d38d9e3

iker-barriocanal commented May 8, 2023
View reviewed changes

iker-barriocanal requested a review from jjbayer May 8, 2023 13:13

delete unneeded return
fa3166a

jjbayer requested changes May 8, 2023
View reviewed changes

Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated
Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated

fix case domain.tld
c21de58

iker-barriocanal requested a review from jjbayer May 8, 2023 14:29

jjbayer approved these changes May 8, 2023
View reviewed changes

iker-barriocanal enabled auto-merge (squash) May 8, 2023 14:33

iker-barriocanal merged commit e03d54d into masterMay 8, 2023

iker-barriocanal deleted the iker/fix/spans-metrics-domains branch May 8, 2023 14:46

fix(span-metrics): Scrub subdomains in metric tags
7688516

iker-barriocanal self-assigned this May 8, 2023

iker-barriocanal requested a review from a teamMay 8, 2023 09:26

jjbayer requested changes May 8, 2023
View reviewed changes

Also normalize domain on no port
d38d9e3

iker-barriocanal commented May 8, 2023
View reviewed changes

iker-barriocanal requested a review from jjbayer May 8, 2023 13:13

delete unneeded return
fa3166a

jjbayer requested changes May 8, 2023
View reviewed changes

Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated
Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated

fix case domain.tld
c21de58

iker-barriocanal requested a review from jjbayer May 8, 2023 14:29

jjbayer approved these changes May 8, 2023
View reviewed changes

iker-barriocanal enabled auto-merge (squash) May 8, 2023 14:33

iker-barriocanal merged commit e03d54d into masterMay 8, 2023

iker-barriocanal deleted the iker/fix/spans-metrics-domains branch May 8, 2023 14:46

fix(span-metrics): Scrub subdomains in metric tags
7688516

iker-barriocanal self-assigned this May 8, 2023

iker-barriocanal requested a review from a teamMay 8, 2023 09:26

jjbayer requested changes May 8, 2023
View reviewed changes

Also normalize domain on no port
d38d9e3

iker-barriocanal commented May 8, 2023
View reviewed changes

iker-barriocanal requested a review from jjbayer May 8, 2023 13:13

delete unneeded return
fa3166a

jjbayer requested changes May 8, 2023
View reviewed changes

Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated
Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated

fix case domain.tld
c21de58

iker-barriocanal requested a review from jjbayer May 8, 2023 14:29

jjbayer approved these changes May 8, 2023
View reviewed changes

iker-barriocanal enabled auto-merge (squash) May 8, 2023 14:33

iker-barriocanal merged commit e03d54d into masterMay 8, 2023

iker-barriocanal deleted the iker/fix/spans-metrics-domains branch May 8, 2023 14:46

fix(span-metrics): Scrub subdomains in metric tags
7688516

iker-barriocanal self-assigned this May 8, 2023

iker-barriocanal requested a review from a teamMay 8, 2023 09:26

jjbayer requested changes May 8, 2023
View reviewed changes

Also normalize domain on no port
d38d9e3

iker-barriocanal commented May 8, 2023
View reviewed changes

iker-barriocanal requested a review from jjbayer May 8, 2023 13:13

delete unneeded return
fa3166a

jjbayer requested changes May 8, 2023
View reviewed changes

Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated
Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated

fix case domain.tld
c21de58

iker-barriocanal requested a review from jjbayer May 8, 2023 14:29

jjbayer approved these changes May 8, 2023
View reviewed changes

iker-barriocanal enabled auto-merge (squash) May 8, 2023 14:33

iker-barriocanal merged commit e03d54d into masterMay 8, 2023

iker-barriocanal deleted the iker/fix/spans-metrics-domains branch May 8, 2023 14:46

fix(span-metrics): Scrub subdomains in metric tags
7688516

iker-barriocanal self-assigned this May 8, 2023

iker-barriocanal requested a review from a teamMay 8, 2023 09:26

jjbayer requested changes May 8, 2023
View reviewed changes

Also normalize domain on no port
d38d9e3

iker-barriocanal commented May 8, 2023
View reviewed changes

iker-barriocanal requested a review from jjbayer May 8, 2023 13:13

delete unneeded return
fa3166a

jjbayer requested changes May 8, 2023
View reviewed changes

Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated
Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated

fix case domain.tld
c21de58

iker-barriocanal requested a review from jjbayer May 8, 2023 14:29

jjbayer approved these changes May 8, 2023
View reviewed changes

iker-barriocanal enabled auto-merge (squash) May 8, 2023 14:33

iker-barriocanal merged commit e03d54d into masterMay 8, 2023

iker-barriocanal deleted the iker/fix/spans-metrics-domains branch May 8, 2023 14:46

fix(span-metrics): Scrub subdomains in metric tags
7688516

iker-barriocanal self-assigned this May 8, 2023

iker-barriocanal requested a review from a teamMay 8, 2023 09:26

jjbayer requested changes May 8, 2023
View reviewed changes

Also normalize domain on no port
d38d9e3

iker-barriocanal commented May 8, 2023
View reviewed changes

iker-barriocanal requested a review from jjbayer May 8, 2023 13:13

delete unneeded return
fa3166a

jjbayer requested changes May 8, 2023
View reviewed changes

Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated
Comment threadrelay-server/src/metrics_extraction/transactions/mod.rs Outdated

fix case domain.tld
c21de58

iker-barriocanal requested a review from jjbayer May 8, 2023 14:29

jjbayer approved these changes May 8, 2023
View reviewed changes

iker-barriocanal enabled auto-merge (squash) May 8, 2023 14:33

iker-barriocanal merged commit e03d54d into masterMay 8, 2023

iker-barriocanal deleted the iker/fix/spans-metrics-domains branch May 8, 2023 14:46

Uh oh!

Conversation

iker-barriocanal commented May 8, 2023

Uh oh!

jjbayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

iker-barriocanal commented May 8, 2023

Uh oh!

jjbayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

iker-barriocanal commented May 8, 2023

Uh oh!

jjbayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

iker-barriocanal commented May 8, 2023

Uh oh!

jjbayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!