Uh oh!
There was an error while loading. Please reload this page.
feat: Bundle canvas worker manually - #144
Merged
Merged
Conversation
size-limit report 📦
|
1 task
mydea
commented
Dec 19, 2023
MemberAuthor
Tracking this upstream as well: rrweb-io#1376 |
billyvg
approved these changes
Dec 19, 2023
| }, | ||
| ); | ||
| } catch { | ||
| // Error when initializing canvas... |
Member
There was a problem hiding this comment.
Should this bubble up to error handler?
MemberAuthor
There was a problem hiding this comment.
good point, I'll wrap this in callbackWrapper instead!
Comment on lines
+7
to
+8
| const workerBlob = new Blob([workerString]); | ||
| return URL.createObjectURL(workerBlob); |
Member
There was a problem hiding this comment.
Does this mean we'll have potential CSP errors now?
MemberAuthor
There was a problem hiding this comment.
we already had before! Previously this was just being rewritten to a string-based worker by rollup under the hood 😬
mydea added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 10, 2024
This bump contains the following changes: - fix(rrweb): Use unpatched requestAnimationFrame when possible [#150](getsentry/rrweb#150) - ref: Avoid async in canvas [#143](getsentry/rrweb#143) - feat: Bundle canvas worker manually [#144](getsentry/rrweb#144) - build: Build for ES2020 [#142](getsentry/rrweb#142) Extracted out from #9826Closes#6946
billyvg pushed a commit
that referenced
this pull request
Apr 26, 2024
While trying to get the ReplayCanvas integration to properly tree shake, I noticed that the current way this worker is built is not ideal, and maybe is not treeshakeable properly. We use a rollup plugin to convert the worker to a base64 string, which a) is more verbose than just having the worker be a plain string, and b) possibly is not tree shakeable. This refactors the worker to work the same way as the compression worker in Sentry - we build it to a string and use that in rrweb. This is a bit more complicated, from a setup perspective, but gives us full control over the worker build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to get the ReplayCanvas integration to properly tree shake, I noticed that the current way this worker is built is not ideal, and maybe is not treeshakeable properly. We use a rollup plugin to convert the worker to a base64 string, which a) is more verbose than just having the worker be a plain string, and b) possibly is not tree shakeable.
This refactors the worker to work the same way as the compression worker in Sentry - we build it to a string and use that in rrweb. This is a bit more complicated, from a setup perspective, but gives us full control over the worker build.