fix: Protect against `matches()` being undefined by billyvg · Pull Request #154 · getsentry/rrweb

billyvg · 2024-01-10T15:48:27Z

try/catch to protect against cases where el.matches is not a function (not sure exact cause, but possibly el is undefined, or not an Element type)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

github-actions · 2024-01-10T15:51:31Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.68 KB (+0.04% 🔺)
rrweb - record & CanvasManager only (gzipped)	19.22 KB (+0.04% 🔺)
rrweb - record only (min)	56.93 KB (+0.04% 🔺)
rrweb - record with treeshaking flags (gzipped)	15.46 KB (+0.04% 🔺)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

billyvg · 2024-01-10T15:48:27Z

try/catch to protect against cases where el.matches is not a function (not sure exact cause, but possibly el is undefined, or not an Element type)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

github-actions · 2024-01-10T15:51:31Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.68 KB (+0.04% 🔺)
rrweb - record & CanvasManager only (gzipped)	19.22 KB (+0.04% 🔺)
rrweb - record only (min)	56.93 KB (+0.04% 🔺)
rrweb - record with treeshaking flags (gzipped)	15.46 KB (+0.04% 🔺)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

billyvg · 2024-01-10T15:48:27Z

try/catch to protect against cases where el.matches is not a function (not sure exact cause, but possibly el is undefined, or not an Element type)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

github-actions · 2024-01-10T15:51:31Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.68 KB (+0.04% 🔺)
rrweb - record & CanvasManager only (gzipped)	19.22 KB (+0.04% 🔺)
rrweb - record only (min)	56.93 KB (+0.04% 🔺)
rrweb - record with treeshaking flags (gzipped)	15.46 KB (+0.04% 🔺)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

billyvg · 2024-01-10T15:48:27Z

try/catch to protect against cases where el.matches is not a function (not sure exact cause, but possibly el is undefined, or not an Element type)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

github-actions · 2024-01-10T15:51:31Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.68 KB (+0.04% 🔺)
rrweb - record & CanvasManager only (gzipped)	19.22 KB (+0.04% 🔺)
rrweb - record only (min)	56.93 KB (+0.04% 🔺)
rrweb - record with treeshaking flags (gzipped)	15.46 KB (+0.04% 🔺)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

billyvg · 2024-01-10T15:48:27Z

try/catch to protect against cases where el.matches is not a function (not sure exact cause, but possibly el is undefined, or not an Element type)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

github-actions · 2024-01-10T15:51:31Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.68 KB (+0.04% 🔺)
rrweb - record & CanvasManager only (gzipped)	19.22 KB (+0.04% 🔺)
rrweb - record only (min)	56.93 KB (+0.04% 🔺)
rrweb - record with treeshaking flags (gzipped)	15.46 KB (+0.04% 🔺)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

billyvg · 2024-01-10T15:48:27Z

try/catch to protect against cases where el.matches is not a function (not sure exact cause, but possibly el is undefined, or not an Element type)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

github-actions · 2024-01-10T15:51:31Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.68 KB (+0.04% 🔺)
rrweb - record & CanvasManager only (gzipped)	19.22 KB (+0.04% 🔺)
rrweb - record only (min)	56.93 KB (+0.04% 🔺)
rrweb - record with treeshaking flags (gzipped)	15.46 KB (+0.04% 🔺)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

billyvg · 2024-01-10T15:48:27Z

try/catch to protect against cases where el.matches is not a function (not sure exact cause, but possibly el is undefined, or not an Element type)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

github-actions · 2024-01-10T15:51:31Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.68 KB (+0.04% 🔺)
rrweb - record & CanvasManager only (gzipped)	19.22 KB (+0.04% 🔺)
rrweb - record only (min)	56.93 KB (+0.04% 🔺)
rrweb - record with treeshaking flags (gzipped)	15.46 KB (+0.04% 🔺)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

billyvg · 2024-01-10T15:48:27Z

try/catch to protect against cases where el.matches is not a function (not sure exact cause, but possibly el is undefined, or not an Element type)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

github-actions · 2024-01-10T15:51:31Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	16.68 KB (+0.04% 🔺)
rrweb - record & CanvasManager only (gzipped)	19.22 KB (+0.04% 🔺)
rrweb - record only (min)	56.93 KB (+0.04% 🔺)
rrweb - record with treeshaking flags (gzipped)	15.46 KB (+0.04% 🔺)

try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

fix: Protect against matches() being undefined
6c189bd
try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

billyvg force-pushed the fix-el-matches-undefined branch from 1ff656f to 6c189bdCompare January 10, 2024 15:50

billyvg marked this pull request as ready for review January 10, 2024 16:00

billyvg requested a review from a teamJanuary 10, 2024 16:01

c298lee approved these changes Jan 10, 2024
View reviewed changes

billyvg merged commit 70b74a7 into sentry-v2Jan 10, 2024

billyvg deleted the fix-el-matches-undefined branch January 10, 2024 16:46

billyvg added a commit that referenced this pull request Apr 26, 2024
fix: Protect againstmatches()being undefined (#154)
e546f59
try/catch to protect against cases where `el.matches` is not a function (not sure exact cause, but possibly `el` is undefined, or not an Element type)

chargome mentioned this pull request Mar 26, 2026
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4 #273
Merged