feat: Refactor module scope vars & export `mirror` & `takeFullSnapshot` directly by mydea · Pull Request #113 · getsentry/rrweb

mydea · 2023-10-17T07:58:57Z

Currently, we use these from record.xx, which is not ideal thinking about treeshaking and lazy loading.

This moves these to be proper exports so we can use the in Replay without having to import record and everything that comes with it (=everything).

billyvg · 2023-10-17T15:16:04Z

 let recording = false;

-const mirror = createMirror();
+export const mirror = createMirror();


🤔
so rrweb1 did have mirror exported directly, but they deprecated that -- I'm not sure the reasoning (it's possible they wanted to keep compatibility and decided to have a different interface to mirror, but maybe worthwhile to dig in and see why they changed public interface to mirror.

yeah so that mirror was different - it was a shared mirror for recording/replaying, I believe (also that mirror was a noop by now).
This is different in that we just always export the recording mirror from @sentry/rrweb.

mydea · 2023-10-25T09:48:15Z

I've updated this to actually remove as much module scope vars as possible, removing things we put on record.xxx that we don't actually need (this cannot be tree shaken), and streamlining this as much as possible. This should safe us a few bytes...!

github-actions · 2023-10-27T07:47:52Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	23 KB (-0.22% 🔽)
rrweb - record only (min)	80.57 KB (-0.26% 🔽)
rrweb - record with treeshaking flags (gzipped)	15.8 KB (-0.29% 🔽)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124) Note: With this update, canvas is _always_ excluded, unless we opt in by passing a `getCanvasManager` function to `record()`. We'll provide a way to do this once we have a fully formed canvas story. For now, this will reduce bundle size considerably for all SDK users.

…t` directly (#113) Currently, we use these from `record.xx`, which is not ideal thinking about treeshaking and lazy loading. This moves these to be proper exports so we can use the in Replay without having to import `record` and everything that comes with it (=everything).

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

mydea · 2023-10-17T07:58:57Z

Currently, we use these from record.xx, which is not ideal thinking about treeshaking and lazy loading.

This moves these to be proper exports so we can use the in Replay without having to import record and everything that comes with it (=everything).

billyvg · 2023-10-17T15:16:04Z

 let recording = false;

-const mirror = createMirror();
+export const mirror = createMirror();


🤔
so rrweb1 did have mirror exported directly, but they deprecated that -- I'm not sure the reasoning (it's possible they wanted to keep compatibility and decided to have a different interface to mirror, but maybe worthwhile to dig in and see why they changed public interface to mirror.

yeah so that mirror was different - it was a shared mirror for recording/replaying, I believe (also that mirror was a noop by now).
This is different in that we just always export the recording mirror from @sentry/rrweb.

mydea · 2023-10-25T09:48:15Z

I've updated this to actually remove as much module scope vars as possible, removing things we put on record.xxx that we don't actually need (this cannot be tree shaken), and streamlining this as much as possible. This should safe us a few bytes...!

github-actions · 2023-10-27T07:47:52Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	23 KB (-0.22% 🔽)
rrweb - record only (min)	80.57 KB (-0.26% 🔽)
rrweb - record with treeshaking flags (gzipped)	15.8 KB (-0.29% 🔽)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124) Note: With this update, canvas is _always_ excluded, unless we opt in by passing a `getCanvasManager` function to `record()`. We'll provide a way to do this once we have a fully formed canvas story. For now, this will reduce bundle size considerably for all SDK users.

…t` directly (#113) Currently, we use these from `record.xx`, which is not ideal thinking about treeshaking and lazy loading. This moves these to be proper exports so we can use the in Replay without having to import `record` and everything that comes with it (=everything).

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

mydea · 2023-10-17T07:58:57Z

Currently, we use these from record.xx, which is not ideal thinking about treeshaking and lazy loading.

This moves these to be proper exports so we can use the in Replay without having to import record and everything that comes with it (=everything).

billyvg · 2023-10-17T15:16:04Z

 let recording = false;

-const mirror = createMirror();
+export const mirror = createMirror();


🤔
so rrweb1 did have mirror exported directly, but they deprecated that -- I'm not sure the reasoning (it's possible they wanted to keep compatibility and decided to have a different interface to mirror, but maybe worthwhile to dig in and see why they changed public interface to mirror.

yeah so that mirror was different - it was a shared mirror for recording/replaying, I believe (also that mirror was a noop by now).
This is different in that we just always export the recording mirror from @sentry/rrweb.

mydea · 2023-10-25T09:48:15Z

I've updated this to actually remove as much module scope vars as possible, removing things we put on record.xxx that we don't actually need (this cannot be tree shaken), and streamlining this as much as possible. This should safe us a few bytes...!

github-actions · 2023-10-27T07:47:52Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	23 KB (-0.22% 🔽)
rrweb - record only (min)	80.57 KB (-0.26% 🔽)
rrweb - record with treeshaking flags (gzipped)	15.8 KB (-0.29% 🔽)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124) Note: With this update, canvas is _always_ excluded, unless we opt in by passing a `getCanvasManager` function to `record()`. We'll provide a way to do this once we have a fully formed canvas story. For now, this will reduce bundle size considerably for all SDK users.

…t` directly (#113) Currently, we use these from `record.xx`, which is not ideal thinking about treeshaking and lazy loading. This moves these to be proper exports so we can use the in Replay without having to import `record` and everything that comes with it (=everything).

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

mydea · 2023-10-17T07:58:57Z

Currently, we use these from record.xx, which is not ideal thinking about treeshaking and lazy loading.

This moves these to be proper exports so we can use the in Replay without having to import record and everything that comes with it (=everything).

billyvg · 2023-10-17T15:16:04Z

 let recording = false;

-const mirror = createMirror();
+export const mirror = createMirror();


🤔
so rrweb1 did have mirror exported directly, but they deprecated that -- I'm not sure the reasoning (it's possible they wanted to keep compatibility and decided to have a different interface to mirror, but maybe worthwhile to dig in and see why they changed public interface to mirror.

yeah so that mirror was different - it was a shared mirror for recording/replaying, I believe (also that mirror was a noop by now).
This is different in that we just always export the recording mirror from @sentry/rrweb.

mydea · 2023-10-25T09:48:15Z

I've updated this to actually remove as much module scope vars as possible, removing things we put on record.xxx that we don't actually need (this cannot be tree shaken), and streamlining this as much as possible. This should safe us a few bytes...!

github-actions · 2023-10-27T07:47:52Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	23 KB (-0.22% 🔽)
rrweb - record only (min)	80.57 KB (-0.26% 🔽)
rrweb - record with treeshaking flags (gzipped)	15.8 KB (-0.29% 🔽)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124) Note: With this update, canvas is _always_ excluded, unless we opt in by passing a `getCanvasManager` function to `record()`. We'll provide a way to do this once we have a fully formed canvas story. For now, this will reduce bundle size considerably for all SDK users.

…t` directly (#113) Currently, we use these from `record.xx`, which is not ideal thinking about treeshaking and lazy loading. This moves these to be proper exports so we can use the in Replay without having to import `record` and everything that comes with it (=everything).

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

mydea · 2023-10-17T07:58:57Z

Currently, we use these from record.xx, which is not ideal thinking about treeshaking and lazy loading.

This moves these to be proper exports so we can use the in Replay without having to import record and everything that comes with it (=everything).

billyvg · 2023-10-17T15:16:04Z

 let recording = false;

-const mirror = createMirror();
+export const mirror = createMirror();


🤔
so rrweb1 did have mirror exported directly, but they deprecated that -- I'm not sure the reasoning (it's possible they wanted to keep compatibility and decided to have a different interface to mirror, but maybe worthwhile to dig in and see why they changed public interface to mirror.

yeah so that mirror was different - it was a shared mirror for recording/replaying, I believe (also that mirror was a noop by now).
This is different in that we just always export the recording mirror from @sentry/rrweb.

mydea · 2023-10-25T09:48:15Z

I've updated this to actually remove as much module scope vars as possible, removing things we put on record.xxx that we don't actually need (this cannot be tree shaken), and streamlining this as much as possible. This should safe us a few bytes...!

github-actions · 2023-10-27T07:47:52Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	23 KB (-0.22% 🔽)
rrweb - record only (min)	80.57 KB (-0.26% 🔽)
rrweb - record with treeshaking flags (gzipped)	15.8 KB (-0.29% 🔽)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124) Note: With this update, canvas is _always_ excluded, unless we opt in by passing a `getCanvasManager` function to `record()`. We'll provide a way to do this once we have a fully formed canvas story. For now, this will reduce bundle size considerably for all SDK users.

…t` directly (#113) Currently, we use these from `record.xx`, which is not ideal thinking about treeshaking and lazy loading. This moves these to be proper exports so we can use the in Replay without having to import `record` and everything that comes with it (=everything).

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

mydea · 2023-10-17T07:58:57Z

Currently, we use these from record.xx, which is not ideal thinking about treeshaking and lazy loading.

This moves these to be proper exports so we can use the in Replay without having to import record and everything that comes with it (=everything).

billyvg · 2023-10-17T15:16:04Z

 let recording = false;

-const mirror = createMirror();
+export const mirror = createMirror();


🤔
so rrweb1 did have mirror exported directly, but they deprecated that -- I'm not sure the reasoning (it's possible they wanted to keep compatibility and decided to have a different interface to mirror, but maybe worthwhile to dig in and see why they changed public interface to mirror.

yeah so that mirror was different - it was a shared mirror for recording/replaying, I believe (also that mirror was a noop by now).
This is different in that we just always export the recording mirror from @sentry/rrweb.

mydea · 2023-10-25T09:48:15Z

I've updated this to actually remove as much module scope vars as possible, removing things we put on record.xxx that we don't actually need (this cannot be tree shaken), and streamlining this as much as possible. This should safe us a few bytes...!

github-actions · 2023-10-27T07:47:52Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	23 KB (-0.22% 🔽)
rrweb - record only (min)	80.57 KB (-0.26% 🔽)
rrweb - record with treeshaking flags (gzipped)	15.8 KB (-0.29% 🔽)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124) Note: With this update, canvas is _always_ excluded, unless we opt in by passing a `getCanvasManager` function to `record()`. We'll provide a way to do this once we have a fully formed canvas story. For now, this will reduce bundle size considerably for all SDK users.

…t` directly (#113) Currently, we use these from `record.xx`, which is not ideal thinking about treeshaking and lazy loading. This moves these to be proper exports so we can use the in Replay without having to import `record` and everything that comes with it (=everything).

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

mydea · 2023-10-17T07:58:57Z

Currently, we use these from record.xx, which is not ideal thinking about treeshaking and lazy loading.

This moves these to be proper exports so we can use the in Replay without having to import record and everything that comes with it (=everything).

billyvg · 2023-10-17T15:16:04Z

 let recording = false;

-const mirror = createMirror();
+export const mirror = createMirror();


🤔
so rrweb1 did have mirror exported directly, but they deprecated that -- I'm not sure the reasoning (it's possible they wanted to keep compatibility and decided to have a different interface to mirror, but maybe worthwhile to dig in and see why they changed public interface to mirror.

yeah so that mirror was different - it was a shared mirror for recording/replaying, I believe (also that mirror was a noop by now).
This is different in that we just always export the recording mirror from @sentry/rrweb.

mydea · 2023-10-25T09:48:15Z

I've updated this to actually remove as much module scope vars as possible, removing things we put on record.xxx that we don't actually need (this cannot be tree shaken), and streamlining this as much as possible. This should safe us a few bytes...!

github-actions · 2023-10-27T07:47:52Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	23 KB (-0.22% 🔽)
rrweb - record only (min)	80.57 KB (-0.26% 🔽)
rrweb - record with treeshaking flags (gzipped)	15.8 KB (-0.29% 🔽)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124) Note: With this update, canvas is _always_ excluded, unless we opt in by passing a `getCanvasManager` function to `record()`. We'll provide a way to do this once we have a fully formed canvas story. For now, this will reduce bundle size considerably for all SDK users.

…t` directly (#113) Currently, we use these from `record.xx`, which is not ideal thinking about treeshaking and lazy loading. This moves these to be proper exports so we can use the in Replay without having to import `record` and everything that comes with it (=everything).

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

mydea · 2023-10-17T07:58:57Z

Currently, we use these from record.xx, which is not ideal thinking about treeshaking and lazy loading.

This moves these to be proper exports so we can use the in Replay without having to import record and everything that comes with it (=everything).

billyvg · 2023-10-17T15:16:04Z

 let recording = false;

-const mirror = createMirror();
+export const mirror = createMirror();


🤔
so rrweb1 did have mirror exported directly, but they deprecated that -- I'm not sure the reasoning (it's possible they wanted to keep compatibility and decided to have a different interface to mirror, but maybe worthwhile to dig in and see why they changed public interface to mirror.

yeah so that mirror was different - it was a shared mirror for recording/replaying, I believe (also that mirror was a noop by now).
This is different in that we just always export the recording mirror from @sentry/rrweb.

mydea · 2023-10-25T09:48:15Z

I've updated this to actually remove as much module scope vars as possible, removing things we put on record.xxx that we don't actually need (this cannot be tree shaken), and streamlining this as much as possible. This should safe us a few bytes...!

github-actions · 2023-10-27T07:47:52Z

size-limit report 📦

Path	Size
rrweb - record only (gzipped)	23 KB (-0.22% 🔽)
rrweb - record only (min)	80.57 KB (-0.26% 🔽)
rrweb - record with treeshaking flags (gzipped)	15.8 KB (-0.29% 🔽)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124)

- feat: Export getCanvasManager & allow passing it to record() [#122](getsentry/rrweb#122) - feat: Remove hooks related code, which is not used [#126](getsentry/rrweb#126) - feat: Remove plugins related code, which is not used [#123](getsentry/rrweb#123) - feat: Refactor module scope vars & export mirror & `takeFullSnapshot` directly [#113](getsentry/rrweb#113) - fix(rrweb): Fix rule.style being undefined [#121](getsentry/rrweb#121) - ref: Avoid unnecessary cloning of objects or arrays [#125](getsentry/rrweb#125) - ref: Avoid cloning events to add timestamp [#124](getsentry/rrweb#124) Note: With this update, canvas is _always_ excluded, unless we opt in by passing a `getCanvasManager` function to `record()`. We'll provide a way to do this once we have a fully formed canvas story. For now, this will reduce bundle size considerably for all SDK users.

…t` directly (#113) Currently, we use these from `record.xx`, which is not ideal thinking about treeshaking and lazy loading. This moves these to be proper exports so we can use the in Replay without having to import `record` and everything that comes with it (=everything).

Bump the core build/test tooling across all workspace packages: - **vite** ^5.2.8 → ^6.4.1 - **vitest** ^1.4.0 → ^2.1.9 - **vite-plugin-dts** ^3.8.1 → ^4.5.4 - **rollup-plugin-terser** (deprecated) → **@rollup/plugin-terser** in rrweb-worker Added `cssFileName: 'style'` to the shared vite config to preserve the `style.css` output filename (Vite 6 changed the default to package-name-based). ### Dependabot alerts resolved **Fully resolved** (vulnerable version completely removed from lockfile): | Alert | Severity | Package | Summary | |-------|----------|---------|---------| | #113 | CRITICAL | `vitest` | Remote Code Execution when accessing a malicious website while Vitest API server is listening | | #203 | HIGH | `rollup` | Rollup 4 has Arbitrary File Write via Path Traversal | | #110 | MEDIUM | `vue-template-compiler` | Client-side XSS (no fix available — removed by vite-plugin-dts v4 dropping the dependency) | **Partially resolved** (some vulnerable entries removed, but package still exists via other dependency chains): | Alert | Severity | Package | Remaining source | |-------|----------|---------|-----------------| | #154, #146, #145, #141, #140, #139, #138, #126, #111 | MEDIUM/LOW | `vite` | `@sveltejs/vite-plugin-svelte@3` still pulls in vite@5 (needs Svelte 5 upgrade) | | #114 | MEDIUM | `esbuild` | `esbuild-plugin-umd-wrapper` still uses esbuild@0.18 | | #214 | HIGH | `serialize-javascript` | webpack (via `@size-limit`) still pulls in v6 | | #105, #104 | MEDIUM | `nanoid` | postcss (via vite internally) still uses nanoid@3 | | #165, #155 | HIGH/MEDIUM | `validator` | `@microsoft/api-extractor` (via vite-plugin-dts) — needs further investigation | The partially resolved alerts will be addressed in later phases (Svelte 5 upgrade, @size-limit bump, mop-up). closes https://linear.app/getsentry/issue/SDK-1095/bump-vitest-vite-56-1-critical-7-alerts --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: chargome <chargome@users.noreply.github.com>

mydea requested a review from billyvg October 17, 2023 07:58

mydea self-assigned this Oct 17, 2023

billyvg reviewed Oct 17, 2023
View reviewed changes

billyvg approved these changes Oct 18, 2023
View reviewed changes

mydea force-pushed the fn/custom-exports branch from a5bcc01 to 677e95dCompare October 25, 2023 09:15

mydea changed the title ~~feat: Export takeFullSnapshot and mirror from record~~feat: Refactor module scope vars & export mirror & takeFullSnapshot directlyOct 25, 2023

mydea force-pushed the fn/custom-exports branch from 33f7886 to 20d18b7Compare October 25, 2023 10:15

mydea mentioned this pull request Oct 25, 2023
feat: Export getCanvasManager & allow passing it to record()#122
Merged

mydea force-pushed the fn/custom-exports branch from 20d18b7 to 39ceb88Compare October 27, 2023 07:42

mydeaand others added 3 commits October 27, 2023 10:01

export takeFullSnapshot and mirror from record
918a399

Apply formatting changes
86b0045

feat: Remove unusuedrecord.xxx methods & module scope vars
c22a3e8

mydea force-pushed the fn/custom-exports branch from 39ceb88 to c22a3e8Compare October 27, 2023 08:01

mydea merged commit ab97f8f into sentry-v2Oct 27, 2023

mydea deleted the fn/custom-exports branch October 27, 2023 08:10

mydea mentioned this pull request Oct 31, 2023
feat(replay): Update rrweb to 2.2.0 getsentry/sentry-javascript#9414
Merged

chargome mentioned this pull request Mar 26, 2026
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4 #273
Merged

mydea requested a review from billyvg October 17, 2023 07:58

mydea self-assigned this Oct 17, 2023

billyvg reviewed Oct 17, 2023
View reviewed changes

billyvg approved these changes Oct 18, 2023
View reviewed changes

mydea force-pushed the fn/custom-exports branch from a5bcc01 to 677e95dCompare October 25, 2023 09:15

mydea changed the title ~~feat: Export takeFullSnapshot and mirror from record~~feat: Refactor module scope vars & export mirror & takeFullSnapshot directlyOct 25, 2023

mydea force-pushed the fn/custom-exports branch from 33f7886 to 20d18b7Compare October 25, 2023 10:15

mydea mentioned this pull request Oct 25, 2023
feat: Export getCanvasManager & allow passing it to record()#122
Merged

mydea force-pushed the fn/custom-exports branch from 20d18b7 to 39ceb88Compare October 27, 2023 07:42

mydeaand others added 3 commits October 27, 2023 10:01

export takeFullSnapshot and mirror from record
918a399

Apply formatting changes
86b0045

feat: Remove unusuedrecord.xxx methods & module scope vars
c22a3e8

mydea force-pushed the fn/custom-exports branch from 39ceb88 to c22a3e8Compare October 27, 2023 08:01

mydea merged commit ab97f8f into sentry-v2Oct 27, 2023

mydea deleted the fn/custom-exports branch October 27, 2023 08:10

mydea mentioned this pull request Oct 31, 2023
feat(replay): Update rrweb to 2.2.0 getsentry/sentry-javascript#9414
Merged

chargome mentioned this pull request Mar 26, 2026
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4 #273
Merged

mydea requested a review from billyvg October 17, 2023 07:58

mydea self-assigned this Oct 17, 2023

billyvg reviewed Oct 17, 2023
View reviewed changes

billyvg approved these changes Oct 18, 2023
View reviewed changes

mydea force-pushed the fn/custom-exports branch from a5bcc01 to 677e95dCompare October 25, 2023 09:15

mydea changed the title ~~feat: Export takeFullSnapshot and mirror from record~~feat: Refactor module scope vars & export mirror & takeFullSnapshot directlyOct 25, 2023

mydea force-pushed the fn/custom-exports branch from 33f7886 to 20d18b7Compare October 25, 2023 10:15

mydea mentioned this pull request Oct 25, 2023
feat: Export getCanvasManager & allow passing it to record()#122
Merged

mydea force-pushed the fn/custom-exports branch from 20d18b7 to 39ceb88Compare October 27, 2023 07:42

mydeaand others added 3 commits October 27, 2023 10:01

export takeFullSnapshot and mirror from record
918a399

Apply formatting changes
86b0045

feat: Remove unusuedrecord.xxx methods & module scope vars
c22a3e8

mydea force-pushed the fn/custom-exports branch from 39ceb88 to c22a3e8Compare October 27, 2023 08:01

mydea merged commit ab97f8f into sentry-v2Oct 27, 2023

mydea deleted the fn/custom-exports branch October 27, 2023 08:10

mydea mentioned this pull request Oct 31, 2023
feat(replay): Update rrweb to 2.2.0 getsentry/sentry-javascript#9414
Merged

chargome mentioned this pull request Mar 26, 2026
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4 #273
Merged

mydea requested a review from billyvg October 17, 2023 07:58

mydea self-assigned this Oct 17, 2023

billyvg reviewed Oct 17, 2023
View reviewed changes

billyvg approved these changes Oct 18, 2023
View reviewed changes

mydea force-pushed the fn/custom-exports branch from a5bcc01 to 677e95dCompare October 25, 2023 09:15

mydea changed the title ~~feat: Export takeFullSnapshot and mirror from record~~feat: Refactor module scope vars & export mirror & takeFullSnapshot directlyOct 25, 2023

mydea force-pushed the fn/custom-exports branch from 33f7886 to 20d18b7Compare October 25, 2023 10:15

mydea mentioned this pull request Oct 25, 2023
feat: Export getCanvasManager & allow passing it to record()#122
Merged

mydea force-pushed the fn/custom-exports branch from 20d18b7 to 39ceb88Compare October 27, 2023 07:42

mydeaand others added 3 commits October 27, 2023 10:01

export takeFullSnapshot and mirror from record
918a399

Apply formatting changes
86b0045

feat: Remove unusuedrecord.xxx methods & module scope vars
c22a3e8

mydea force-pushed the fn/custom-exports branch from 39ceb88 to c22a3e8Compare October 27, 2023 08:01

mydea merged commit ab97f8f into sentry-v2Oct 27, 2023

mydea deleted the fn/custom-exports branch October 27, 2023 08:10

mydea mentioned this pull request Oct 31, 2023
feat(replay): Update rrweb to 2.2.0 getsentry/sentry-javascript#9414
Merged

chargome mentioned this pull request Mar 26, 2026
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4 #273
Merged

mydea requested a review from billyvg October 17, 2023 07:58

mydea self-assigned this Oct 17, 2023

billyvg reviewed Oct 17, 2023
View reviewed changes

billyvg approved these changes Oct 18, 2023
View reviewed changes

mydea force-pushed the fn/custom-exports branch from a5bcc01 to 677e95dCompare October 25, 2023 09:15

mydea changed the title ~~feat: Export takeFullSnapshot and mirror from record~~feat: Refactor module scope vars & export mirror & takeFullSnapshot directlyOct 25, 2023

mydea force-pushed the fn/custom-exports branch from 33f7886 to 20d18b7Compare October 25, 2023 10:15

mydea mentioned this pull request Oct 25, 2023
feat: Export getCanvasManager & allow passing it to record()#122
Merged

mydea force-pushed the fn/custom-exports branch from 20d18b7 to 39ceb88Compare October 27, 2023 07:42

mydeaand others added 3 commits October 27, 2023 10:01

export takeFullSnapshot and mirror from record
918a399

Apply formatting changes
86b0045

feat: Remove unusuedrecord.xxx methods & module scope vars
c22a3e8

mydea force-pushed the fn/custom-exports branch from 39ceb88 to c22a3e8Compare October 27, 2023 08:01

mydea merged commit ab97f8f into sentry-v2Oct 27, 2023

mydea deleted the fn/custom-exports branch October 27, 2023 08:10

mydea mentioned this pull request Oct 31, 2023
feat(replay): Update rrweb to 2.2.0 getsentry/sentry-javascript#9414
Merged

chargome mentioned this pull request Mar 26, 2026
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4 #273
Merged

mydea requested a review from billyvg October 17, 2023 07:58

mydea self-assigned this Oct 17, 2023

billyvg reviewed Oct 17, 2023
View reviewed changes

billyvg approved these changes Oct 18, 2023
View reviewed changes

mydea force-pushed the fn/custom-exports branch from a5bcc01 to 677e95dCompare October 25, 2023 09:15

mydea changed the title ~~feat: Export takeFullSnapshot and mirror from record~~feat: Refactor module scope vars & export mirror & takeFullSnapshot directlyOct 25, 2023

mydea force-pushed the fn/custom-exports branch from 33f7886 to 20d18b7Compare October 25, 2023 10:15

mydea mentioned this pull request Oct 25, 2023
feat: Export getCanvasManager & allow passing it to record()#122
Merged

mydea force-pushed the fn/custom-exports branch from 20d18b7 to 39ceb88Compare October 27, 2023 07:42

mydeaand others added 3 commits October 27, 2023 10:01

export takeFullSnapshot and mirror from record
918a399

Apply formatting changes
86b0045

feat: Remove unusuedrecord.xxx methods & module scope vars
c22a3e8

mydea force-pushed the fn/custom-exports branch from 39ceb88 to c22a3e8Compare October 27, 2023 08:01

mydea merged commit ab97f8f into sentry-v2Oct 27, 2023

mydea deleted the fn/custom-exports branch October 27, 2023 08:10

mydea mentioned this pull request Oct 31, 2023
feat(replay): Update rrweb to 2.2.0 getsentry/sentry-javascript#9414
Merged

chargome mentioned this pull request Mar 26, 2026
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4 #273
Merged

mydea requested a review from billyvg October 17, 2023 07:58

mydea self-assigned this Oct 17, 2023

billyvg reviewed Oct 17, 2023
View reviewed changes

billyvg approved these changes Oct 18, 2023
View reviewed changes

mydea force-pushed the fn/custom-exports branch from a5bcc01 to 677e95dCompare October 25, 2023 09:15

mydea changed the title ~~feat: Export takeFullSnapshot and mirror from record~~feat: Refactor module scope vars & export mirror & takeFullSnapshot directlyOct 25, 2023

mydea force-pushed the fn/custom-exports branch from 33f7886 to 20d18b7Compare October 25, 2023 10:15

mydea mentioned this pull request Oct 25, 2023
feat: Export getCanvasManager & allow passing it to record()#122
Merged

mydea force-pushed the fn/custom-exports branch from 20d18b7 to 39ceb88Compare October 27, 2023 07:42

mydeaand others added 3 commits October 27, 2023 10:01

export takeFullSnapshot and mirror from record
918a399

Apply formatting changes
86b0045

feat: Remove unusuedrecord.xxx methods & module scope vars
c22a3e8

mydea force-pushed the fn/custom-exports branch from 39ceb88 to c22a3e8Compare October 27, 2023 08:01

mydea merged commit ab97f8f into sentry-v2Oct 27, 2023

mydea deleted the fn/custom-exports branch October 27, 2023 08:10

mydea mentioned this pull request Oct 31, 2023
feat(replay): Update rrweb to 2.2.0 getsentry/sentry-javascript#9414
Merged

chargome mentioned this pull request Mar 26, 2026
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4 #273
Merged

mydea requested a review from billyvg October 17, 2023 07:58

mydea self-assigned this Oct 17, 2023

billyvg reviewed Oct 17, 2023
View reviewed changes

billyvg approved these changes Oct 18, 2023
View reviewed changes

mydea force-pushed the fn/custom-exports branch from a5bcc01 to 677e95dCompare October 25, 2023 09:15

mydea changed the title ~~feat: Export takeFullSnapshot and mirror from record~~feat: Refactor module scope vars & export mirror & takeFullSnapshot directlyOct 25, 2023

mydea force-pushed the fn/custom-exports branch from 33f7886 to 20d18b7Compare October 25, 2023 10:15

mydea mentioned this pull request Oct 25, 2023
feat: Export getCanvasManager & allow passing it to record()#122
Merged

mydea force-pushed the fn/custom-exports branch from 20d18b7 to 39ceb88Compare October 27, 2023 07:42

mydeaand others added 3 commits October 27, 2023 10:01

export takeFullSnapshot and mirror from record
918a399

Apply formatting changes
86b0045

feat: Remove unusuedrecord.xxx methods & module scope vars
c22a3e8

mydea force-pushed the fn/custom-exports branch from 39ceb88 to c22a3e8Compare October 27, 2023 08:01

mydea merged commit ab97f8f into sentry-v2Oct 27, 2023

mydea deleted the fn/custom-exports branch October 27, 2023 08:10

mydea mentioned this pull request Oct 31, 2023
feat(replay): Update rrweb to 2.2.0 getsentry/sentry-javascript#9414
Merged

chargome mentioned this pull request Mar 26, 2026
chore(build): Bump vite 5→6, vitest 1→2, vite-plugin-dts 3→4 #273
Merged

Uh oh!

Conversation

mydea commented Oct 17, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mydea commented Oct 25, 2023

Uh oh!

github-actionsBot commented Oct 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mydea commented Oct 17, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mydea commented Oct 25, 2023

Uh oh!

github-actionsBot commented Oct 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mydea commented Oct 17, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mydea commented Oct 25, 2023

Uh oh!

github-actionsBot commented Oct 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mydea commented Oct 17, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mydea commented Oct 25, 2023

Uh oh!

github-actionsBot commented Oct 27, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

github-actionsBot commented Oct 27, 2023•
edited
Loading

github-actionsBot commented Oct 27, 2023•
edited
Loading

github-actionsBot commented Oct 27, 2023•
edited
Loading

github-actionsBot commented Oct 27, 2023•
edited
Loading

github-actionsBot commented Oct 27, 2023•
edited
Loading