Uh oh!
There was an error while loading. Please reload this page.
feat: Add maskAllText option - #35
Conversation
859a016 to
a76ff92Compare18bd320 to
60d7d40CompareSimilar to `maskAllInputs`, this option will mask all text nodes (except those defined by `unmaskSelector`)
60d7d40 to
326ab31CompareThere was a problem hiding this comment.
On first glance this looks good to me, but I have a question:
I probably missed an important part of the conversation here, but why do we need this instead of or over the maskTextSelector option being set to MASK_ALL_TEXT_SELECTOR in the SDK? Is it because otherwise we can't mask attributes (i.e. #40)?
billyvg
commented
Feb 7, 2023
Yeah masking attributes is one of the reasons. Other is that the selector was kind of a hack to do the masking we wanted and I'd rather have it done natively in rrweb without using a separate selector. We saw it previously using '*' that it could lead to unintended side effects. |
billyvg
commented
Feb 8, 2023
@Lms24 Yeah that's what i'm thinking, it could have been a merge artifact... looking at the other exported |
Similar to
maskAllInputs, this option will mask all text nodes (except those defined byunmaskTextSelector)