Uh oh!
There was an error while loading. Please reload this page.
feat: With maskAllText, mask the attributes: placeholder, title, aria-label - #40
Merged
Merged
Conversation
billyvg
changed the base branch from
sentry-v1
to
feat-native-mask-all-text-optionFebruary 2, 2023 22:24
billyvgforce-pushed
the
feat-native-mask-all-text-option
branch
2 times, most recently
from
February 3, 2023 19:12
60d7d40 to
326ab31Comparebillyvgforce-pushed
the
feat-mask-placeholder-title-attributes
branch
from
February 3, 2023 19:36
e69e2aa to
eec6a2fComparemaskAllText, mask the attributes: placeholder, title, aria-label
This was referenced Feb 6, 2023
Lms24
approved these changes
Feb 7, 2023
| Comment = 5 | ||
| } | ||
| export declare type documentNode = { | ||
| export type documentNode = { |
Member
There was a problem hiding this comment.
No action required, just curious: Why remove the declare here?
MemberAuthor
There was a problem hiding this comment.
I think this was auto generated? I'll undo and see what happens
MemberAuthor
There was a problem hiding this comment.
Yeah not sure what happened before, but export type is the correct statement (it also watches others in the file for type).
Similar to `maskAllInputs`, this option will mask all text nodes (except those defined by `unmaskSelector`)
Mask the title and placeholder attributes when `maskAllText` is enabled.
If textarea has a child string content, it will get duplicated as a `value` attribute. Masking by text vs input can cause these two values to diverge (i.e. only one is masked). On playback, we remove duplicate textContent for textareas, which means we could show double textarea values: one masked, one unmasked.
billyvgforce-pushed
the
feat-mask-placeholder-title-attributes
branch
from
February 8, 2023 18:37
f7c1e66 to
736070aCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
maskAllTextis enabled, let's mask some specific attributes:placeholder,title, andaria-label. I've opted to just hardcode these instead of adding them as options for now since they are only tied tomaskAllText.Depends on #35