Adding unsupported hot reload - #12683

Merged
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported
Feb 26, 2025
Merged

Adding unsupported hot reload#12683
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported

Conversation

@rodolfoBee

Copy link
Copy Markdown
Member

As concluded in getsentry/sentry-dotnet#3889 Hot Reload isn't supported with static libraries. Adding a note to the troubleshooting page.

Closesgetsentry/sentry-dotnet#3959

@vercel

vercelBot commented Feb 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
sentry-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 13, 2025 4:23am
2 Skipped Deployments
NameStatusPreviewCommentsUpdated (UTC)
changelog⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am
develop-docs⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am

@phunkeler

Copy link
Copy Markdown

I believe the correct terminology here is Hot Restart. Hot Reload, while somewhat related, refers to a different Visual Studio feature.

@rodolfoBee

Copy link
Copy Markdown
MemberAuthor

@phunkeler thank you for the correction :D

@codecov

codecovBot commented Feb 12, 2025

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle nameSizeChange
sentry-docs-server-cjs10.7MB-9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push9.37MB-6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
static/chunks/pages/_app-*.js-3 bytes865.83kB-0.0%
static/chunks/7801-*.js-3 bytes390.91kB-0.0%
server/middleware-*.js5.55kB6.55kB555.3% ⚠️
server/middleware-*.js-5.55kB1.0kB-84.74%
static/J4XrYODc4hCwGEo30X-*.js(New)578 bytes578 bytes100.0% 🚀
static/J4XrYODc4hCwGEo30X-*.js(New)77 bytes77 bytes100.0% 🚀
static/xsi8XB3m-*.js(Deleted)-578 bytes0 bytes-100.0% 🗑️
static/xsi8XB3m-*.js(Deleted)-77 bytes0 bytes-100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
1729.js-3 bytes1.64MB-0.0%
../instrumentation.js-3 bytes968.36kB-0.0%
9523.js-3 bytes944.56kB-0.0%


Then `SentrySession` can be used instead of `Sentry.Session`.

### VS Hot Restart isn't compatible with static assemblies

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Limitation
- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Incompatibility

A bit more concise.

Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated
Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated

> The xcframework sentry.bindings.cocoa\5.0.1\lib\net8.0-ios17.0\Sentry.Bindings.Cocoa.resources.zip has an incorrect or unknown format and cannot be processed.

This happens because Hot Restart does not support static iOS libraries or frameworks containing static libraries, as detailed in the [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/maui/ios/hot-restart?view=net-maui-9.0#limitations).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aritchie curious, nothing we can do about this?

People need to uninstall Sentry to use Hot Restart?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia We may be able to detect hotrestart in a prebuild step, but I'm not sure. I'll look into it. I wish the tooling gave better error messages in these cases

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seems like we at least need to say then: "To use Hot Restart you'll need to remove the Sentry SDK" if that's the solution. But that's quite sub optimal obviously

@aritchiearitchieFeb 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely some form of condition that can be applied to the package reference and if/def constant you can use in code to remove UseSentry. I'll ask around.

Thoughts

<PackageReferenceInclude="Sentry.Maui"Condition="$(HOT_RESTART) == 'false'" />
#if !HOTRESTART.UseSentry(...)
#endif

Comment threadplatform-includes/troubleshooting/dotnet.mdx
@rodolfoBee
rodolfoBee merged commit 49365e6 into masterFeb 26, 2025
@rodolfoBee
rodolfoBee deleted the add-hot-reload-unsupported branch February 26, 2025 08:53
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
feat: Mention that the cookie-sync extension works for previews (#12858)
ref(flags): update unleashIntegration param (#12795)
ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
docs(python): Clarify how to init SDK in `async` app (#12854)
move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
docs(span-links): Add develop docs for span links (#12829)
feat(java): add Reactor integration docs (#12686)
Add Quarkus to community maintained SDKs (#12834)
Adding unsupported hot reload (#12683)
Fix broken links (#12844)
feat(python): Clarification regarding start_transaction (#12835)
docs(flutter): Fix event serverName reset in samples (#12832)
ref(insights): move performance docs under insights (#12720)
Bump API schema to 2e61347a (#12836)
fix(apple): Usages of sendDefaultPii (#12833)
Add `sendDefaultPii: true` to React Native init code snippets (#12812)
Only show Browser vs React Native source maps alert for browser sdks (#12816)
Add Data Collected page for React Native (#12811)
Fix React Native Onboarding Option Buttons (#12813)
Add Hono guide (#12710)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document xcframework errors when using Hot Reload with a remote Mac

5 participants

@rodolfoBee@phunkeler@aritchie@bruno-garcia@coolguyzone
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Adding unsupported hot reload - #12683

Merged
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported
Feb 26, 2025
Merged

Adding unsupported hot reload#12683
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported

Conversation

@rodolfoBee

Copy link
Copy Markdown
Member

As concluded in getsentry/sentry-dotnet#3889 Hot Reload isn't supported with static libraries. Adding a note to the troubleshooting page.

Closesgetsentry/sentry-dotnet#3959

@vercel

vercelBot commented Feb 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
sentry-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 13, 2025 4:23am
2 Skipped Deployments
NameStatusPreviewCommentsUpdated (UTC)
changelog⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am
develop-docs⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am

@phunkeler

Copy link
Copy Markdown

I believe the correct terminology here is Hot Restart. Hot Reload, while somewhat related, refers to a different Visual Studio feature.

@rodolfoBee

Copy link
Copy Markdown
MemberAuthor

@phunkeler thank you for the correction :D

@codecov

codecovBot commented Feb 12, 2025

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle nameSizeChange
sentry-docs-server-cjs10.7MB-9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push9.37MB-6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
static/chunks/pages/_app-*.js-3 bytes865.83kB-0.0%
static/chunks/7801-*.js-3 bytes390.91kB-0.0%
server/middleware-*.js5.55kB6.55kB555.3% ⚠️
server/middleware-*.js-5.55kB1.0kB-84.74%
static/J4XrYODc4hCwGEo30X-*.js(New)578 bytes578 bytes100.0% 🚀
static/J4XrYODc4hCwGEo30X-*.js(New)77 bytes77 bytes100.0% 🚀
static/xsi8XB3m-*.js(Deleted)-578 bytes0 bytes-100.0% 🗑️
static/xsi8XB3m-*.js(Deleted)-77 bytes0 bytes-100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
1729.js-3 bytes1.64MB-0.0%
../instrumentation.js-3 bytes968.36kB-0.0%
9523.js-3 bytes944.56kB-0.0%


Then `SentrySession` can be used instead of `Sentry.Session`.

### VS Hot Restart isn't compatible with static assemblies

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Limitation
- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Incompatibility

A bit more concise.

Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated
Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated

> The xcframework sentry.bindings.cocoa\5.0.1\lib\net8.0-ios17.0\Sentry.Bindings.Cocoa.resources.zip has an incorrect or unknown format and cannot be processed.

This happens because Hot Restart does not support static iOS libraries or frameworks containing static libraries, as detailed in the [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/maui/ios/hot-restart?view=net-maui-9.0#limitations).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aritchie curious, nothing we can do about this?

People need to uninstall Sentry to use Hot Restart?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia We may be able to detect hotrestart in a prebuild step, but I'm not sure. I'll look into it. I wish the tooling gave better error messages in these cases

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seems like we at least need to say then: "To use Hot Restart you'll need to remove the Sentry SDK" if that's the solution. But that's quite sub optimal obviously

@aritchiearitchieFeb 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely some form of condition that can be applied to the package reference and if/def constant you can use in code to remove UseSentry. I'll ask around.

Thoughts

<PackageReferenceInclude="Sentry.Maui"Condition="$(HOT_RESTART) == 'false'" />
#if !HOTRESTART.UseSentry(...)
#endif

Comment threadplatform-includes/troubleshooting/dotnet.mdx
@rodolfoBee
rodolfoBee merged commit 49365e6 into masterFeb 26, 2025
@rodolfoBee
rodolfoBee deleted the add-hot-reload-unsupported branch February 26, 2025 08:53
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
feat: Mention that the cookie-sync extension works for previews (#12858)
ref(flags): update unleashIntegration param (#12795)
ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
docs(python): Clarify how to init SDK in `async` app (#12854)
move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
docs(span-links): Add develop docs for span links (#12829)
feat(java): add Reactor integration docs (#12686)
Add Quarkus to community maintained SDKs (#12834)
Adding unsupported hot reload (#12683)
Fix broken links (#12844)
feat(python): Clarification regarding start_transaction (#12835)
docs(flutter): Fix event serverName reset in samples (#12832)
ref(insights): move performance docs under insights (#12720)
Bump API schema to 2e61347a (#12836)
fix(apple): Usages of sendDefaultPii (#12833)
Add `sendDefaultPii: true` to React Native init code snippets (#12812)
Only show Browser vs React Native source maps alert for browser sdks (#12816)
Add Data Collected page for React Native (#12811)
Fix React Native Onboarding Option Buttons (#12813)
Add Hono guide (#12710)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document xcframework errors when using Hot Reload with a remote Mac

5 participants

@rodolfoBee@phunkeler@aritchie@bruno-garcia@coolguyzone
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Adding unsupported hot reload - #12683

Merged
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported
Feb 26, 2025
Merged

Adding unsupported hot reload#12683
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported

Conversation

@rodolfoBee

Copy link
Copy Markdown
Member

As concluded in getsentry/sentry-dotnet#3889 Hot Reload isn't supported with static libraries. Adding a note to the troubleshooting page.

Closesgetsentry/sentry-dotnet#3959

@vercel

vercelBot commented Feb 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
sentry-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 13, 2025 4:23am
2 Skipped Deployments
NameStatusPreviewCommentsUpdated (UTC)
changelog⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am
develop-docs⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am

@phunkeler

Copy link
Copy Markdown

I believe the correct terminology here is Hot Restart. Hot Reload, while somewhat related, refers to a different Visual Studio feature.

@rodolfoBee

Copy link
Copy Markdown
MemberAuthor

@phunkeler thank you for the correction :D

@codecov

codecovBot commented Feb 12, 2025

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle nameSizeChange
sentry-docs-server-cjs10.7MB-9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push9.37MB-6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
static/chunks/pages/_app-*.js-3 bytes865.83kB-0.0%
static/chunks/7801-*.js-3 bytes390.91kB-0.0%
server/middleware-*.js5.55kB6.55kB555.3% ⚠️
server/middleware-*.js-5.55kB1.0kB-84.74%
static/J4XrYODc4hCwGEo30X-*.js(New)578 bytes578 bytes100.0% 🚀
static/J4XrYODc4hCwGEo30X-*.js(New)77 bytes77 bytes100.0% 🚀
static/xsi8XB3m-*.js(Deleted)-578 bytes0 bytes-100.0% 🗑️
static/xsi8XB3m-*.js(Deleted)-77 bytes0 bytes-100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
1729.js-3 bytes1.64MB-0.0%
../instrumentation.js-3 bytes968.36kB-0.0%
9523.js-3 bytes944.56kB-0.0%


Then `SentrySession` can be used instead of `Sentry.Session`.

### VS Hot Restart isn't compatible with static assemblies

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Limitation
- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Incompatibility

A bit more concise.

Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated
Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated

> The xcframework sentry.bindings.cocoa\5.0.1\lib\net8.0-ios17.0\Sentry.Bindings.Cocoa.resources.zip has an incorrect or unknown format and cannot be processed.

This happens because Hot Restart does not support static iOS libraries or frameworks containing static libraries, as detailed in the [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/maui/ios/hot-restart?view=net-maui-9.0#limitations).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aritchie curious, nothing we can do about this?

People need to uninstall Sentry to use Hot Restart?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia We may be able to detect hotrestart in a prebuild step, but I'm not sure. I'll look into it. I wish the tooling gave better error messages in these cases

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seems like we at least need to say then: "To use Hot Restart you'll need to remove the Sentry SDK" if that's the solution. But that's quite sub optimal obviously

@aritchiearitchieFeb 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely some form of condition that can be applied to the package reference and if/def constant you can use in code to remove UseSentry. I'll ask around.

Thoughts

<PackageReferenceInclude="Sentry.Maui"Condition="$(HOT_RESTART) == 'false'" />
#if !HOTRESTART.UseSentry(...)
#endif

Comment threadplatform-includes/troubleshooting/dotnet.mdx
@rodolfoBee
rodolfoBee merged commit 49365e6 into masterFeb 26, 2025
@rodolfoBee
rodolfoBee deleted the add-hot-reload-unsupported branch February 26, 2025 08:53
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
feat: Mention that the cookie-sync extension works for previews (#12858)
ref(flags): update unleashIntegration param (#12795)
ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
docs(python): Clarify how to init SDK in `async` app (#12854)
move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
docs(span-links): Add develop docs for span links (#12829)
feat(java): add Reactor integration docs (#12686)
Add Quarkus to community maintained SDKs (#12834)
Adding unsupported hot reload (#12683)
Fix broken links (#12844)
feat(python): Clarification regarding start_transaction (#12835)
docs(flutter): Fix event serverName reset in samples (#12832)
ref(insights): move performance docs under insights (#12720)
Bump API schema to 2e61347a (#12836)
fix(apple): Usages of sendDefaultPii (#12833)
Add `sendDefaultPii: true` to React Native init code snippets (#12812)
Only show Browser vs React Native source maps alert for browser sdks (#12816)
Add Data Collected page for React Native (#12811)
Fix React Native Onboarding Option Buttons (#12813)
Add Hono guide (#12710)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document xcframework errors when using Hot Reload with a remote Mac

5 participants

@rodolfoBee@phunkeler@aritchie@bruno-garcia@coolguyzone
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Adding unsupported hot reload - #12683

Merged
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported
Feb 26, 2025
Merged

Adding unsupported hot reload#12683
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported

Conversation

@rodolfoBee

Copy link
Copy Markdown
Member

As concluded in getsentry/sentry-dotnet#3889 Hot Reload isn't supported with static libraries. Adding a note to the troubleshooting page.

Closesgetsentry/sentry-dotnet#3959

@vercel

vercelBot commented Feb 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
sentry-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 13, 2025 4:23am
2 Skipped Deployments
NameStatusPreviewCommentsUpdated (UTC)
changelog⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am
develop-docs⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am

@phunkeler

Copy link
Copy Markdown

I believe the correct terminology here is Hot Restart. Hot Reload, while somewhat related, refers to a different Visual Studio feature.

@rodolfoBee

Copy link
Copy Markdown
MemberAuthor

@phunkeler thank you for the correction :D

@codecov

codecovBot commented Feb 12, 2025

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle nameSizeChange
sentry-docs-server-cjs10.7MB-9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push9.37MB-6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
static/chunks/pages/_app-*.js-3 bytes865.83kB-0.0%
static/chunks/7801-*.js-3 bytes390.91kB-0.0%
server/middleware-*.js5.55kB6.55kB555.3% ⚠️
server/middleware-*.js-5.55kB1.0kB-84.74%
static/J4XrYODc4hCwGEo30X-*.js(New)578 bytes578 bytes100.0% 🚀
static/J4XrYODc4hCwGEo30X-*.js(New)77 bytes77 bytes100.0% 🚀
static/xsi8XB3m-*.js(Deleted)-578 bytes0 bytes-100.0% 🗑️
static/xsi8XB3m-*.js(Deleted)-77 bytes0 bytes-100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
1729.js-3 bytes1.64MB-0.0%
../instrumentation.js-3 bytes968.36kB-0.0%
9523.js-3 bytes944.56kB-0.0%


Then `SentrySession` can be used instead of `Sentry.Session`.

### VS Hot Restart isn't compatible with static assemblies

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Limitation
- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Incompatibility

A bit more concise.

Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated
Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated

> The xcframework sentry.bindings.cocoa\5.0.1\lib\net8.0-ios17.0\Sentry.Bindings.Cocoa.resources.zip has an incorrect or unknown format and cannot be processed.

This happens because Hot Restart does not support static iOS libraries or frameworks containing static libraries, as detailed in the [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/maui/ios/hot-restart?view=net-maui-9.0#limitations).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aritchie curious, nothing we can do about this?

People need to uninstall Sentry to use Hot Restart?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia We may be able to detect hotrestart in a prebuild step, but I'm not sure. I'll look into it. I wish the tooling gave better error messages in these cases

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seems like we at least need to say then: "To use Hot Restart you'll need to remove the Sentry SDK" if that's the solution. But that's quite sub optimal obviously

@aritchiearitchieFeb 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely some form of condition that can be applied to the package reference and if/def constant you can use in code to remove UseSentry. I'll ask around.

Thoughts

<PackageReferenceInclude="Sentry.Maui"Condition="$(HOT_RESTART) == 'false'" />
#if !HOTRESTART.UseSentry(...)
#endif

Comment threadplatform-includes/troubleshooting/dotnet.mdx
@rodolfoBee
rodolfoBee merged commit 49365e6 into masterFeb 26, 2025
@rodolfoBee
rodolfoBee deleted the add-hot-reload-unsupported branch February 26, 2025 08:53
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
feat: Mention that the cookie-sync extension works for previews (#12858)
ref(flags): update unleashIntegration param (#12795)
ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
docs(python): Clarify how to init SDK in `async` app (#12854)
move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
docs(span-links): Add develop docs for span links (#12829)
feat(java): add Reactor integration docs (#12686)
Add Quarkus to community maintained SDKs (#12834)
Adding unsupported hot reload (#12683)
Fix broken links (#12844)
feat(python): Clarification regarding start_transaction (#12835)
docs(flutter): Fix event serverName reset in samples (#12832)
ref(insights): move performance docs under insights (#12720)
Bump API schema to 2e61347a (#12836)
fix(apple): Usages of sendDefaultPii (#12833)
Add `sendDefaultPii: true` to React Native init code snippets (#12812)
Only show Browser vs React Native source maps alert for browser sdks (#12816)
Add Data Collected page for React Native (#12811)
Fix React Native Onboarding Option Buttons (#12813)
Add Hono guide (#12710)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document xcframework errors when using Hot Reload with a remote Mac

5 participants

@rodolfoBee@phunkeler@aritchie@bruno-garcia@coolguyzone
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Adding unsupported hot reload - #12683

Merged
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported
Feb 26, 2025
Merged

Adding unsupported hot reload#12683
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported

Conversation

@rodolfoBee

Copy link
Copy Markdown
Member

As concluded in getsentry/sentry-dotnet#3889 Hot Reload isn't supported with static libraries. Adding a note to the troubleshooting page.

Closesgetsentry/sentry-dotnet#3959

@vercel

vercelBot commented Feb 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
sentry-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 13, 2025 4:23am
2 Skipped Deployments
NameStatusPreviewCommentsUpdated (UTC)
changelog⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am
develop-docs⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am

@phunkeler

Copy link
Copy Markdown

I believe the correct terminology here is Hot Restart. Hot Reload, while somewhat related, refers to a different Visual Studio feature.

@rodolfoBee

Copy link
Copy Markdown
MemberAuthor

@phunkeler thank you for the correction :D

@codecov

codecovBot commented Feb 12, 2025

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle nameSizeChange
sentry-docs-server-cjs10.7MB-9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push9.37MB-6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
static/chunks/pages/_app-*.js-3 bytes865.83kB-0.0%
static/chunks/7801-*.js-3 bytes390.91kB-0.0%
server/middleware-*.js5.55kB6.55kB555.3% ⚠️
server/middleware-*.js-5.55kB1.0kB-84.74%
static/J4XrYODc4hCwGEo30X-*.js(New)578 bytes578 bytes100.0% 🚀
static/J4XrYODc4hCwGEo30X-*.js(New)77 bytes77 bytes100.0% 🚀
static/xsi8XB3m-*.js(Deleted)-578 bytes0 bytes-100.0% 🗑️
static/xsi8XB3m-*.js(Deleted)-77 bytes0 bytes-100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
1729.js-3 bytes1.64MB-0.0%
../instrumentation.js-3 bytes968.36kB-0.0%
9523.js-3 bytes944.56kB-0.0%


Then `SentrySession` can be used instead of `Sentry.Session`.

### VS Hot Restart isn't compatible with static assemblies

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Limitation
- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Incompatibility

A bit more concise.

Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated
Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated

> The xcframework sentry.bindings.cocoa\5.0.1\lib\net8.0-ios17.0\Sentry.Bindings.Cocoa.resources.zip has an incorrect or unknown format and cannot be processed.

This happens because Hot Restart does not support static iOS libraries or frameworks containing static libraries, as detailed in the [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/maui/ios/hot-restart?view=net-maui-9.0#limitations).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aritchie curious, nothing we can do about this?

People need to uninstall Sentry to use Hot Restart?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia We may be able to detect hotrestart in a prebuild step, but I'm not sure. I'll look into it. I wish the tooling gave better error messages in these cases

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seems like we at least need to say then: "To use Hot Restart you'll need to remove the Sentry SDK" if that's the solution. But that's quite sub optimal obviously

@aritchiearitchieFeb 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely some form of condition that can be applied to the package reference and if/def constant you can use in code to remove UseSentry. I'll ask around.

Thoughts

<PackageReferenceInclude="Sentry.Maui"Condition="$(HOT_RESTART) == 'false'" />
#if !HOTRESTART.UseSentry(...)
#endif

Comment threadplatform-includes/troubleshooting/dotnet.mdx
@rodolfoBee
rodolfoBee merged commit 49365e6 into masterFeb 26, 2025
@rodolfoBee
rodolfoBee deleted the add-hot-reload-unsupported branch February 26, 2025 08:53
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
feat: Mention that the cookie-sync extension works for previews (#12858)
ref(flags): update unleashIntegration param (#12795)
ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
docs(python): Clarify how to init SDK in `async` app (#12854)
move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
docs(span-links): Add develop docs for span links (#12829)
feat(java): add Reactor integration docs (#12686)
Add Quarkus to community maintained SDKs (#12834)
Adding unsupported hot reload (#12683)
Fix broken links (#12844)
feat(python): Clarification regarding start_transaction (#12835)
docs(flutter): Fix event serverName reset in samples (#12832)
ref(insights): move performance docs under insights (#12720)
Bump API schema to 2e61347a (#12836)
fix(apple): Usages of sendDefaultPii (#12833)
Add `sendDefaultPii: true` to React Native init code snippets (#12812)
Only show Browser vs React Native source maps alert for browser sdks (#12816)
Add Data Collected page for React Native (#12811)
Fix React Native Onboarding Option Buttons (#12813)
Add Hono guide (#12710)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document xcframework errors when using Hot Reload with a remote Mac

5 participants

@rodolfoBee@phunkeler@aritchie@bruno-garcia@coolguyzone
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Adding unsupported hot reload - #12683

Merged
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported
Feb 26, 2025
Merged

Adding unsupported hot reload#12683
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported

Conversation

@rodolfoBee

Copy link
Copy Markdown
Member

As concluded in getsentry/sentry-dotnet#3889 Hot Reload isn't supported with static libraries. Adding a note to the troubleshooting page.

Closesgetsentry/sentry-dotnet#3959

@vercel

vercelBot commented Feb 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
sentry-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 13, 2025 4:23am
2 Skipped Deployments
NameStatusPreviewCommentsUpdated (UTC)
changelog⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am
develop-docs⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am

@phunkeler

Copy link
Copy Markdown

I believe the correct terminology here is Hot Restart. Hot Reload, while somewhat related, refers to a different Visual Studio feature.

@rodolfoBee

Copy link
Copy Markdown
MemberAuthor

@phunkeler thank you for the correction :D

@codecov

codecovBot commented Feb 12, 2025

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle nameSizeChange
sentry-docs-server-cjs10.7MB-9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push9.37MB-6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
static/chunks/pages/_app-*.js-3 bytes865.83kB-0.0%
static/chunks/7801-*.js-3 bytes390.91kB-0.0%
server/middleware-*.js5.55kB6.55kB555.3% ⚠️
server/middleware-*.js-5.55kB1.0kB-84.74%
static/J4XrYODc4hCwGEo30X-*.js(New)578 bytes578 bytes100.0% 🚀
static/J4XrYODc4hCwGEo30X-*.js(New)77 bytes77 bytes100.0% 🚀
static/xsi8XB3m-*.js(Deleted)-578 bytes0 bytes-100.0% 🗑️
static/xsi8XB3m-*.js(Deleted)-77 bytes0 bytes-100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
1729.js-3 bytes1.64MB-0.0%
../instrumentation.js-3 bytes968.36kB-0.0%
9523.js-3 bytes944.56kB-0.0%


Then `SentrySession` can be used instead of `Sentry.Session`.

### VS Hot Restart isn't compatible with static assemblies

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Limitation
- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Incompatibility

A bit more concise.

Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated
Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated

> The xcframework sentry.bindings.cocoa\5.0.1\lib\net8.0-ios17.0\Sentry.Bindings.Cocoa.resources.zip has an incorrect or unknown format and cannot be processed.

This happens because Hot Restart does not support static iOS libraries or frameworks containing static libraries, as detailed in the [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/maui/ios/hot-restart?view=net-maui-9.0#limitations).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aritchie curious, nothing we can do about this?

People need to uninstall Sentry to use Hot Restart?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia We may be able to detect hotrestart in a prebuild step, but I'm not sure. I'll look into it. I wish the tooling gave better error messages in these cases

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seems like we at least need to say then: "To use Hot Restart you'll need to remove the Sentry SDK" if that's the solution. But that's quite sub optimal obviously

@aritchiearitchieFeb 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely some form of condition that can be applied to the package reference and if/def constant you can use in code to remove UseSentry. I'll ask around.

Thoughts

<PackageReferenceInclude="Sentry.Maui"Condition="$(HOT_RESTART) == 'false'" />
#if !HOTRESTART.UseSentry(...)
#endif

Comment threadplatform-includes/troubleshooting/dotnet.mdx
@rodolfoBee
rodolfoBee merged commit 49365e6 into masterFeb 26, 2025
@rodolfoBee
rodolfoBee deleted the add-hot-reload-unsupported branch February 26, 2025 08:53
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
feat: Mention that the cookie-sync extension works for previews (#12858)
ref(flags): update unleashIntegration param (#12795)
ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
docs(python): Clarify how to init SDK in `async` app (#12854)
move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
docs(span-links): Add develop docs for span links (#12829)
feat(java): add Reactor integration docs (#12686)
Add Quarkus to community maintained SDKs (#12834)
Adding unsupported hot reload (#12683)
Fix broken links (#12844)
feat(python): Clarification regarding start_transaction (#12835)
docs(flutter): Fix event serverName reset in samples (#12832)
ref(insights): move performance docs under insights (#12720)
Bump API schema to 2e61347a (#12836)
fix(apple): Usages of sendDefaultPii (#12833)
Add `sendDefaultPii: true` to React Native init code snippets (#12812)
Only show Browser vs React Native source maps alert for browser sdks (#12816)
Add Data Collected page for React Native (#12811)
Fix React Native Onboarding Option Buttons (#12813)
Add Hono guide (#12710)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document xcframework errors when using Hot Reload with a remote Mac

5 participants

@rodolfoBee@phunkeler@aritchie@bruno-garcia@coolguyzone
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Adding unsupported hot reload - #12683

Merged
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported
Feb 26, 2025
Merged

Adding unsupported hot reload#12683
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported

Conversation

@rodolfoBee

Copy link
Copy Markdown
Member

As concluded in getsentry/sentry-dotnet#3889 Hot Reload isn't supported with static libraries. Adding a note to the troubleshooting page.

Closesgetsentry/sentry-dotnet#3959

@vercel

vercelBot commented Feb 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
sentry-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 13, 2025 4:23am
2 Skipped Deployments
NameStatusPreviewCommentsUpdated (UTC)
changelog⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am
develop-docs⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am

@phunkeler

Copy link
Copy Markdown

I believe the correct terminology here is Hot Restart. Hot Reload, while somewhat related, refers to a different Visual Studio feature.

@rodolfoBee

Copy link
Copy Markdown
MemberAuthor

@phunkeler thank you for the correction :D

@codecov

codecovBot commented Feb 12, 2025

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle nameSizeChange
sentry-docs-server-cjs10.7MB-9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push9.37MB-6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
static/chunks/pages/_app-*.js-3 bytes865.83kB-0.0%
static/chunks/7801-*.js-3 bytes390.91kB-0.0%
server/middleware-*.js5.55kB6.55kB555.3% ⚠️
server/middleware-*.js-5.55kB1.0kB-84.74%
static/J4XrYODc4hCwGEo30X-*.js(New)578 bytes578 bytes100.0% 🚀
static/J4XrYODc4hCwGEo30X-*.js(New)77 bytes77 bytes100.0% 🚀
static/xsi8XB3m-*.js(Deleted)-578 bytes0 bytes-100.0% 🗑️
static/xsi8XB3m-*.js(Deleted)-77 bytes0 bytes-100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
1729.js-3 bytes1.64MB-0.0%
../instrumentation.js-3 bytes968.36kB-0.0%
9523.js-3 bytes944.56kB-0.0%


Then `SentrySession` can be used instead of `Sentry.Session`.

### VS Hot Restart isn't compatible with static assemblies

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Limitation
- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Incompatibility

A bit more concise.

Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated
Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated

> The xcframework sentry.bindings.cocoa\5.0.1\lib\net8.0-ios17.0\Sentry.Bindings.Cocoa.resources.zip has an incorrect or unknown format and cannot be processed.

This happens because Hot Restart does not support static iOS libraries or frameworks containing static libraries, as detailed in the [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/maui/ios/hot-restart?view=net-maui-9.0#limitations).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aritchie curious, nothing we can do about this?

People need to uninstall Sentry to use Hot Restart?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia We may be able to detect hotrestart in a prebuild step, but I'm not sure. I'll look into it. I wish the tooling gave better error messages in these cases

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seems like we at least need to say then: "To use Hot Restart you'll need to remove the Sentry SDK" if that's the solution. But that's quite sub optimal obviously

@aritchiearitchieFeb 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely some form of condition that can be applied to the package reference and if/def constant you can use in code to remove UseSentry. I'll ask around.

Thoughts

<PackageReferenceInclude="Sentry.Maui"Condition="$(HOT_RESTART) == 'false'" />
#if !HOTRESTART.UseSentry(...)
#endif

Comment threadplatform-includes/troubleshooting/dotnet.mdx
@rodolfoBee
rodolfoBee merged commit 49365e6 into masterFeb 26, 2025
@rodolfoBee
rodolfoBee deleted the add-hot-reload-unsupported branch February 26, 2025 08:53
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
feat: Mention that the cookie-sync extension works for previews (#12858)
ref(flags): update unleashIntegration param (#12795)
ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
docs(python): Clarify how to init SDK in `async` app (#12854)
move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
docs(span-links): Add develop docs for span links (#12829)
feat(java): add Reactor integration docs (#12686)
Add Quarkus to community maintained SDKs (#12834)
Adding unsupported hot reload (#12683)
Fix broken links (#12844)
feat(python): Clarification regarding start_transaction (#12835)
docs(flutter): Fix event serverName reset in samples (#12832)
ref(insights): move performance docs under insights (#12720)
Bump API schema to 2e61347a (#12836)
fix(apple): Usages of sendDefaultPii (#12833)
Add `sendDefaultPii: true` to React Native init code snippets (#12812)
Only show Browser vs React Native source maps alert for browser sdks (#12816)
Add Data Collected page for React Native (#12811)
Fix React Native Onboarding Option Buttons (#12813)
Add Hono guide (#12710)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document xcframework errors when using Hot Reload with a remote Mac

5 participants

@rodolfoBee@phunkeler@aritchie@bruno-garcia@coolguyzone
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Adding unsupported hot reload - #12683

Merged
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported
Feb 26, 2025
Merged

Adding unsupported hot reload#12683
rodolfoBee merged 3 commits into
masterfrom
add-hot-reload-unsupported

Conversation

@rodolfoBee

Copy link
Copy Markdown
Member

As concluded in getsentry/sentry-dotnet#3889 Hot Reload isn't supported with static libraries. Adding a note to the troubleshooting page.

Closesgetsentry/sentry-dotnet#3959

@vercel

vercelBot commented Feb 12, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
sentry-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackFeb 13, 2025 4:23am
2 Skipped Deployments
NameStatusPreviewCommentsUpdated (UTC)
changelog⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am
develop-docs⬜️ Ignored (Inspect)Visit PreviewFeb 13, 2025 4:23am

@phunkeler

Copy link
Copy Markdown

I believe the correct terminology here is Hot Restart. Hot Reload, while somewhat related, refers to a different Visual Studio feature.

@rodolfoBee

Copy link
Copy Markdown
MemberAuthor

@phunkeler thank you for the correction :D

@codecov

codecovBot commented Feb 12, 2025

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle nameSizeChange
sentry-docs-server-cjs10.7MB-9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push9.37MB-6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
static/chunks/pages/_app-*.js-3 bytes865.83kB-0.0%
static/chunks/7801-*.js-3 bytes390.91kB-0.0%
server/middleware-*.js5.55kB6.55kB555.3% ⚠️
server/middleware-*.js-5.55kB1.0kB-84.74%
static/J4XrYODc4hCwGEo30X-*.js(New)578 bytes578 bytes100.0% 🚀
static/J4XrYODc4hCwGEo30X-*.js(New)77 bytes77 bytes100.0% 🚀
static/xsi8XB3m-*.js(Deleted)-578 bytes0 bytes-100.0% 🗑️
static/xsi8XB3m-*.js(Deleted)-77 bytes0 bytes-100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset NameSize ChangeTotal SizeChange (%)
1729.js-3 bytes1.64MB-0.0%
../instrumentation.js-3 bytes968.36kB-0.0%
9523.js-3 bytes944.56kB-0.0%


Then `SentrySession` can be used instead of `Sentry.Session`.

### VS Hot Restart isn't compatible with static assemblies

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Limitation
- ### VS Hot Restart isn't compatible with static assemblies+ ### Visual Studio Hot Restart Incompatibility

A bit more concise.

Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated
Comment threadplatform-includes/troubleshooting/dotnet.mdx Outdated

> The xcframework sentry.bindings.cocoa\5.0.1\lib\net8.0-ios17.0\Sentry.Bindings.Cocoa.resources.zip has an incorrect or unknown format and cannot be processed.

This happens because Hot Restart does not support static iOS libraries or frameworks containing static libraries, as detailed in the [Microsoft documentation](https://learn.microsoft.com/en-us/dotnet/maui/ios/hot-restart?view=net-maui-9.0#limitations).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aritchie curious, nothing we can do about this?

People need to uninstall Sentry to use Hot Restart?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bruno-garcia We may be able to detect hotrestart in a prebuild step, but I'm not sure. I'll look into it. I wish the tooling gave better error messages in these cases

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seems like we at least need to say then: "To use Hot Restart you'll need to remove the Sentry SDK" if that's the solution. But that's quite sub optimal obviously

@aritchiearitchieFeb 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely some form of condition that can be applied to the package reference and if/def constant you can use in code to remove UseSentry. I'll ask around.

Thoughts

<PackageReferenceInclude="Sentry.Maui"Condition="$(HOT_RESTART) == 'false'" />
#if !HOTRESTART.UseSentry(...)
#endif

Comment threadplatform-includes/troubleshooting/dotnet.mdx
@rodolfoBee
rodolfoBee merged commit 49365e6 into masterFeb 26, 2025
@rodolfoBee
rodolfoBee deleted the add-hot-reload-unsupported branch February 26, 2025 08:53
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
feat: Mention that the cookie-sync extension works for previews (#12858)
ref(flags): update unleashIntegration param (#12795)
ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
docs(python): Clarify how to init SDK in `async` app (#12854)
move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
docs(span-links): Add develop docs for span links (#12829)
feat(java): add Reactor integration docs (#12686)
Add Quarkus to community maintained SDKs (#12834)
Adding unsupported hot reload (#12683)
Fix broken links (#12844)
feat(python): Clarification regarding start_transaction (#12835)
docs(flutter): Fix event serverName reset in samples (#12832)
ref(insights): move performance docs under insights (#12720)
Bump API schema to 2e61347a (#12836)
fix(apple): Usages of sendDefaultPii (#12833)
Add `sendDefaultPii: true` to React Native init code snippets (#12812)
Only show Browser vs React Native source maps alert for browser sdks (#12816)
Add Data Collected page for React Native (#12811)
Fix React Native Onboarding Option Buttons (#12813)
Add Hono guide (#12710)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document xcframework errors when using Hot Reload with a remote Mac

5 participants

@rodolfoBee@phunkeler@aritchie@bruno-garcia@coolguyzone