Skip to content

feat(ruby): Add Profiling docs - #6650

Merged
sl0thentr0py merged 6 commits into
masterfrom
neel/ruby-profiling
Apr 19, 2023
Merged

feat(ruby): Add Profiling docs#6650
sl0thentr0py merged 6 commits into
masterfrom
neel/ruby-profiling

Conversation

@sl0thentr0py

@sl0thentr0pysl0thentr0py commented Apr 13, 2023

Copy link
Copy Markdown
Member

merge after releasing getsentry/sentry-ruby#2024 in 5.9.0

@sl0thentr0pysl0thentr0py mentioned this pull request Apr 13, 2023
Closed
@vercel

vercelBot commented Apr 13, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
sentry-docs✅ Ready (Inspect)Visit Preview💬 Add feedbackApr 19, 2023 5:48pm

indragiek
indragiek reviewed Apr 14, 2023
View reviewed changes
Comment threadsrc/docs/product/profiling/index.mdx Outdated
@shanamatthews

shanamatthews commented Apr 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@sl0thentr0py - Let me or Liza know when you want someone to take a look at this! We generally don't look at PRs if they're marked as draft, but happy to help whenever you're ready :D

@sl0thentr0py

sl0thentr0py commented Apr 18, 2023

Copy link
Copy Markdown
MemberAuthor

ty! @shanamatthews I will release in the next couple of days, and will then update this to ready. But feel free to take a look already, content won't change.

@sl0thentr0py
sl0thentr0py marked this pull request as ready for review April 18, 2023 11:24
@shanamatthewsshanamatthews self-assigned this Apr 18, 2023
@sl0thentr0py

sl0thentr0py commented Apr 19, 2023

Copy link
Copy Markdown
MemberAuthor

alright https://github.com/getsentry/sentry-ruby/releases/tag/5.9.0 is released, so we can update the docs now. @shanamatthews let me know if something needs to be changed!

shanamatthews
shanamatthews approved these changes Apr 19, 2023
View reviewed changes

@shanamatthewsshanamatthews left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! I made some tiny language tweaks.

I wasn't able to preview this locally bc my local sentry is messed up atm, so you may want to preview locally to double check everything looks okay

Comment threadsrc/platforms/common/profiling/index.mdx Outdated
Comment threadsrc/platforms/common/profiling/index.mdx Outdated
Comment threadsrc/wizard/ruby/profiling-onboarding/ruby/2.configure-performance.md Outdated
sl0thentr0pyand others added 3 commits April 19, 2023 19:18
@sl0thentr0py@shanamatthews
Update src/platforms/common/profiling/index.mdx
60b04d2
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@sl0thentr0py@shanamatthews
Update src/platforms/common/profiling/index.mdx
ca2c5c3
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@sl0thentr0py@shanamatthews
Update src/wizard/ruby/profiling-onboarding/ruby/2.configure-performa…
2ae5235
…nce.md
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@sl0thentr0py
sl0thentr0py enabled auto-merge (squash) April 19, 2023 17:19
@sl0thentr0py
sl0thentr0py merged commit d82c4e0 into masterApr 19, 2023
@sl0thentr0py
sl0thentr0py deleted the neel/ruby-profiling branch April 19, 2023 17:36
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@indragiekindragiekindragiek left review comments
@cleptriccleptricAwaiting requested review from cleptric
+1 more reviewer
@shanamatthewsshanamatthewsshanamatthews approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@shanamatthewsshanamatthews

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sl0thentr0py@shanamatthews@indragiek