Uh oh!
There was an error while loading. Please reload this page.
Add stackprof based profiler - #2024
Conversation
2b18591 to
870a751Compare2bba702 to
4a747e8Compare4a747e8 to
0f8a58fCompareCodecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@## master #2024 +/- ##
==========================================
+ Coverage 98.58% 98.60% +0.01%
==========================================
Files 157 159 +2 Lines 10127 10506 +379 ==========================================
+ Hits 9984 10359 +375 - Misses 143 147 +4
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
7c61c0f to
07faa7eCompare09ea283 to
39eda29Comparesl0thentr0py
commented
Apr 7, 2023
2a9245d to
6b206c8Compare6b206c8 to
e99575bCompareThis reverts commit e99575b.
f1dc5dd to
cfd931eCompared368ef1 to
e7def50Comparee7def50 to
207fc04Comparesl0thentr0py
commented
Apr 12, 2023
alright I believe I covered all the comments, @st0012 |
64c3223 to
d84ae71Compared84ae71 to
227e5d3CompareThere was a problem hiding this comment.
IMO using null-object pattern here is an overkill.
Give that:
- All public profiler APIs no-op if not
@sampled @sampledwill never betrueunless@profiling_enabled
Can we do this instead?
- Define a single
Profilerclass - In
Profiler's constructor, we use:
@profiling_enabled=defined?(StackProf) && configuration.profiling_enabled?Alternatively, I think just early returning the initialize method may also work.
a7f0689 to
ec0a24fComparesl0thentr0py
commented
Apr 18, 2023
ok I did one more round of sanity check testing, looks ok. I'm merging! |
resolves#2013
Usage
stackproftoGemfileas a peer dependency