refactor: Rollup/Vite no longer uses unplugin - #858

Merged
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc
Feb 16, 2026
Merged

refactor: Rollup/Vite no longer uses unplugin#858
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc

Conversation

@timfish

@timfishtimfish commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a regular (non-unplugin) Rollup plugin which is also used for Vite.

This involved core changes:

  • Exporting more utilities from bundler-core
  • Adding globFiles core export for reusable asset finding
  • Rename generateGlobalInjectorCode to generateReleaseInjectorCode since that better describes what it does
  • Removing all the Rollup specific code from core

Rollup plugin changes:

  • Creating a new Rollup plugin that incorporates all the Rollup functionality
  • Moving the Rollup renderChunk tests from core to Rollup
  • Removed all the deps/references to unplugin

Note on test removal

This PR removes the disabled-sourcemaps-upload.test.ts‎ test, but all that did was check if a specific plugin was present.

I didn't re-add a test to check for upload because it's currently difficult to do with Jest and the logic is currently very clear:

@github-actions

github-actionsBot commented Jan 29, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (webpack) Deduplicate webpack deploys by chargome in #875

Internal Changes 🔧

  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Migrate to oxfmt by timfish in #880
  • Build with Rolldown by timfish in #872
  • Remove unplugin by timfish in #876
  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Esbuild no longer uses unplugin by timfish in #871
  • Webpack no longer uses unplugin by timfish in #870

🤖 This preview updates automatically when you update the PR.

Comment threadpackages/rollup-plugin/src/index.ts Fixed
@chargomechargome mentioned this pull request Feb 2, 2026
@timfish
timfishforce-pushed the timfish/feat/rollup-plugin-poc branch from a83a80e to 2c77a7dCompareFebruary 9, 2026 18:58
@timfishtimfish closed this Feb 9, 2026
@timfishtimfish reopened this Feb 9, 2026
@timfishtimfish changed the title PoC: Rollup Plugin without Unpluginfeat: Rollup/Vite no longer use unpluginFeb 9, 2026
@timfish
timfish marked this pull request as ready for review February 9, 2026 22:27
@timfish
timfish requested review from Lms24 and chargomeFebruary 9, 2026 22:27
Comment threadpackages/rollup-plugin/src/index.ts Outdated
@timfishtimfish changed the title feat: Rollup/Vite no longer use unpluginfeat: Rollup/Vite no longer uses unpluginFeb 10, 2026
Comment threadpackages/rollup-plugin/src/index.ts Outdated
name: "sentry-vite-injection-plugin",
// run `post` to avoid tripping up @rollup/plugin-commonjs when cjs is used
// as we inject an `import` statement
enforce: "post" as const, // need this so that vite runs the resolveId hook

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Was this intentionally moved to "pre" within the pr? AFAICT all the plugins now run pre right?

@timfishtimfishFeb 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't used the stub + import strategy in the Rollup plugin for a while so this comment seems left over from that. We only retain that approach in esbuild.

We now only have a single plugin and we require pre for component annotations to work.

"jest": "^28.1.3",
"premove": "^4.0.0",
"rollup": "2.77.0",
"rollup": "3.2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Does this major bump in the tests have any implications on the plugin itself? e.g. compatibility testing etc

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollup plugin peer dep and the fact that our plugin returns an array suggests we only support Rollup v3 (3.1 or 3.2 depending on which of the above you consider)!

I have no idea why we were still testing v2 for e2e but changing this to V3 fixed a typescript warning!

@timfish
timfish merged commit 1271ced into getsentry:mainFeb 16, 2026
25 checks passed
@timfish
timfish deleted the timfish/feat/rollup-plugin-poc branch February 17, 2026 18:24
@timfishtimfish changed the title feat: Rollup/Vite no longer uses unpluginrefactor: Rollup/Vite no longer uses unpluginFeb 19, 2026
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 24, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.0.0 |
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@chargome@github-advanced-security@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

refactor: Rollup/Vite no longer uses unplugin - #858

Merged
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc
Feb 16, 2026
Merged

refactor: Rollup/Vite no longer uses unplugin#858
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc

Conversation

@timfish

@timfishtimfish commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a regular (non-unplugin) Rollup plugin which is also used for Vite.

This involved core changes:

  • Exporting more utilities from bundler-core
  • Adding globFiles core export for reusable asset finding
  • Rename generateGlobalInjectorCode to generateReleaseInjectorCode since that better describes what it does
  • Removing all the Rollup specific code from core

Rollup plugin changes:

  • Creating a new Rollup plugin that incorporates all the Rollup functionality
  • Moving the Rollup renderChunk tests from core to Rollup
  • Removed all the deps/references to unplugin

Note on test removal

This PR removes the disabled-sourcemaps-upload.test.ts‎ test, but all that did was check if a specific plugin was present.

I didn't re-add a test to check for upload because it's currently difficult to do with Jest and the logic is currently very clear:

@github-actions

github-actionsBot commented Jan 29, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (webpack) Deduplicate webpack deploys by chargome in #875

Internal Changes 🔧

  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Migrate to oxfmt by timfish in #880
  • Build with Rolldown by timfish in #872
  • Remove unplugin by timfish in #876
  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Esbuild no longer uses unplugin by timfish in #871
  • Webpack no longer uses unplugin by timfish in #870

🤖 This preview updates automatically when you update the PR.

Comment threadpackages/rollup-plugin/src/index.ts Fixed
@chargomechargome mentioned this pull request Feb 2, 2026
@timfish
timfishforce-pushed the timfish/feat/rollup-plugin-poc branch from a83a80e to 2c77a7dCompareFebruary 9, 2026 18:58
@timfishtimfish closed this Feb 9, 2026
@timfishtimfish reopened this Feb 9, 2026
@timfishtimfish changed the title PoC: Rollup Plugin without Unpluginfeat: Rollup/Vite no longer use unpluginFeb 9, 2026
@timfish
timfish marked this pull request as ready for review February 9, 2026 22:27
@timfish
timfish requested review from Lms24 and chargomeFebruary 9, 2026 22:27
Comment threadpackages/rollup-plugin/src/index.ts Outdated
@timfishtimfish changed the title feat: Rollup/Vite no longer use unpluginfeat: Rollup/Vite no longer uses unpluginFeb 10, 2026
Comment threadpackages/rollup-plugin/src/index.ts Outdated
name: "sentry-vite-injection-plugin",
// run `post` to avoid tripping up @rollup/plugin-commonjs when cjs is used
// as we inject an `import` statement
enforce: "post" as const, // need this so that vite runs the resolveId hook

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Was this intentionally moved to "pre" within the pr? AFAICT all the plugins now run pre right?

@timfishtimfishFeb 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't used the stub + import strategy in the Rollup plugin for a while so this comment seems left over from that. We only retain that approach in esbuild.

We now only have a single plugin and we require pre for component annotations to work.

"jest": "^28.1.3",
"premove": "^4.0.0",
"rollup": "2.77.0",
"rollup": "3.2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Does this major bump in the tests have any implications on the plugin itself? e.g. compatibility testing etc

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollup plugin peer dep and the fact that our plugin returns an array suggests we only support Rollup v3 (3.1 or 3.2 depending on which of the above you consider)!

I have no idea why we were still testing v2 for e2e but changing this to V3 fixed a typescript warning!

@timfish
timfish merged commit 1271ced into getsentry:mainFeb 16, 2026
25 checks passed
@timfish
timfish deleted the timfish/feat/rollup-plugin-poc branch February 17, 2026 18:24
@timfishtimfish changed the title feat: Rollup/Vite no longer uses unpluginrefactor: Rollup/Vite no longer uses unpluginFeb 19, 2026
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 24, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.0.0 |
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@chargome@github-advanced-security@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor: Rollup/Vite no longer uses unplugin - #858

Merged
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc
Feb 16, 2026
Merged

refactor: Rollup/Vite no longer uses unplugin#858
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc

Conversation

@timfish

@timfishtimfish commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a regular (non-unplugin) Rollup plugin which is also used for Vite.

This involved core changes:

  • Exporting more utilities from bundler-core
  • Adding globFiles core export for reusable asset finding
  • Rename generateGlobalInjectorCode to generateReleaseInjectorCode since that better describes what it does
  • Removing all the Rollup specific code from core

Rollup plugin changes:

  • Creating a new Rollup plugin that incorporates all the Rollup functionality
  • Moving the Rollup renderChunk tests from core to Rollup
  • Removed all the deps/references to unplugin

Note on test removal

This PR removes the disabled-sourcemaps-upload.test.ts‎ test, but all that did was check if a specific plugin was present.

I didn't re-add a test to check for upload because it's currently difficult to do with Jest and the logic is currently very clear:

@github-actions

github-actionsBot commented Jan 29, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (webpack) Deduplicate webpack deploys by chargome in #875

Internal Changes 🔧

  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Migrate to oxfmt by timfish in #880
  • Build with Rolldown by timfish in #872
  • Remove unplugin by timfish in #876
  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Esbuild no longer uses unplugin by timfish in #871
  • Webpack no longer uses unplugin by timfish in #870

🤖 This preview updates automatically when you update the PR.

Comment threadpackages/rollup-plugin/src/index.ts Fixed
@chargomechargome mentioned this pull request Feb 2, 2026
@timfish
timfishforce-pushed the timfish/feat/rollup-plugin-poc branch from a83a80e to 2c77a7dCompareFebruary 9, 2026 18:58
@timfishtimfish closed this Feb 9, 2026
@timfishtimfish reopened this Feb 9, 2026
@timfishtimfish changed the title PoC: Rollup Plugin without Unpluginfeat: Rollup/Vite no longer use unpluginFeb 9, 2026
@timfish
timfish marked this pull request as ready for review February 9, 2026 22:27
@timfish
timfish requested review from Lms24 and chargomeFebruary 9, 2026 22:27
Comment threadpackages/rollup-plugin/src/index.ts Outdated
@timfishtimfish changed the title feat: Rollup/Vite no longer use unpluginfeat: Rollup/Vite no longer uses unpluginFeb 10, 2026
Comment threadpackages/rollup-plugin/src/index.ts Outdated
name: "sentry-vite-injection-plugin",
// run `post` to avoid tripping up @rollup/plugin-commonjs when cjs is used
// as we inject an `import` statement
enforce: "post" as const, // need this so that vite runs the resolveId hook

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Was this intentionally moved to "pre" within the pr? AFAICT all the plugins now run pre right?

@timfishtimfishFeb 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't used the stub + import strategy in the Rollup plugin for a while so this comment seems left over from that. We only retain that approach in esbuild.

We now only have a single plugin and we require pre for component annotations to work.

"jest": "^28.1.3",
"premove": "^4.0.0",
"rollup": "2.77.0",
"rollup": "3.2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Does this major bump in the tests have any implications on the plugin itself? e.g. compatibility testing etc

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollup plugin peer dep and the fact that our plugin returns an array suggests we only support Rollup v3 (3.1 or 3.2 depending on which of the above you consider)!

I have no idea why we were still testing v2 for e2e but changing this to V3 fixed a typescript warning!

@timfish
timfish merged commit 1271ced into getsentry:mainFeb 16, 2026
25 checks passed
@timfish
timfish deleted the timfish/feat/rollup-plugin-poc branch February 17, 2026 18:24
@timfishtimfish changed the title feat: Rollup/Vite no longer uses unpluginrefactor: Rollup/Vite no longer uses unpluginFeb 19, 2026
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 24, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.0.0 |
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@chargome@github-advanced-security@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor: Rollup/Vite no longer uses unplugin - #858

Merged
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc
Feb 16, 2026
Merged

refactor: Rollup/Vite no longer uses unplugin#858
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc

Conversation

@timfish

@timfishtimfish commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a regular (non-unplugin) Rollup plugin which is also used for Vite.

This involved core changes:

  • Exporting more utilities from bundler-core
  • Adding globFiles core export for reusable asset finding
  • Rename generateGlobalInjectorCode to generateReleaseInjectorCode since that better describes what it does
  • Removing all the Rollup specific code from core

Rollup plugin changes:

  • Creating a new Rollup plugin that incorporates all the Rollup functionality
  • Moving the Rollup renderChunk tests from core to Rollup
  • Removed all the deps/references to unplugin

Note on test removal

This PR removes the disabled-sourcemaps-upload.test.ts‎ test, but all that did was check if a specific plugin was present.

I didn't re-add a test to check for upload because it's currently difficult to do with Jest and the logic is currently very clear:

@github-actions

github-actionsBot commented Jan 29, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (webpack) Deduplicate webpack deploys by chargome in #875

Internal Changes 🔧

  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Migrate to oxfmt by timfish in #880
  • Build with Rolldown by timfish in #872
  • Remove unplugin by timfish in #876
  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Esbuild no longer uses unplugin by timfish in #871
  • Webpack no longer uses unplugin by timfish in #870

🤖 This preview updates automatically when you update the PR.

Comment threadpackages/rollup-plugin/src/index.ts Fixed
@chargomechargome mentioned this pull request Feb 2, 2026
@timfish
timfishforce-pushed the timfish/feat/rollup-plugin-poc branch from a83a80e to 2c77a7dCompareFebruary 9, 2026 18:58
@timfishtimfish closed this Feb 9, 2026
@timfishtimfish reopened this Feb 9, 2026
@timfishtimfish changed the title PoC: Rollup Plugin without Unpluginfeat: Rollup/Vite no longer use unpluginFeb 9, 2026
@timfish
timfish marked this pull request as ready for review February 9, 2026 22:27
@timfish
timfish requested review from Lms24 and chargomeFebruary 9, 2026 22:27
Comment threadpackages/rollup-plugin/src/index.ts Outdated
@timfishtimfish changed the title feat: Rollup/Vite no longer use unpluginfeat: Rollup/Vite no longer uses unpluginFeb 10, 2026
Comment threadpackages/rollup-plugin/src/index.ts Outdated
name: "sentry-vite-injection-plugin",
// run `post` to avoid tripping up @rollup/plugin-commonjs when cjs is used
// as we inject an `import` statement
enforce: "post" as const, // need this so that vite runs the resolveId hook

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Was this intentionally moved to "pre" within the pr? AFAICT all the plugins now run pre right?

@timfishtimfishFeb 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't used the stub + import strategy in the Rollup plugin for a while so this comment seems left over from that. We only retain that approach in esbuild.

We now only have a single plugin and we require pre for component annotations to work.

"jest": "^28.1.3",
"premove": "^4.0.0",
"rollup": "2.77.0",
"rollup": "3.2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Does this major bump in the tests have any implications on the plugin itself? e.g. compatibility testing etc

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollup plugin peer dep and the fact that our plugin returns an array suggests we only support Rollup v3 (3.1 or 3.2 depending on which of the above you consider)!

I have no idea why we were still testing v2 for e2e but changing this to V3 fixed a typescript warning!

@timfish
timfish merged commit 1271ced into getsentry:mainFeb 16, 2026
25 checks passed
@timfish
timfish deleted the timfish/feat/rollup-plugin-poc branch February 17, 2026 18:24
@timfishtimfish changed the title feat: Rollup/Vite no longer uses unpluginrefactor: Rollup/Vite no longer uses unpluginFeb 19, 2026
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 24, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.0.0 |
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@chargome@github-advanced-security@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

refactor: Rollup/Vite no longer uses unplugin - #858

Merged
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc
Feb 16, 2026
Merged

refactor: Rollup/Vite no longer uses unplugin#858
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc

Conversation

@timfish

@timfishtimfish commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a regular (non-unplugin) Rollup plugin which is also used for Vite.

This involved core changes:

  • Exporting more utilities from bundler-core
  • Adding globFiles core export for reusable asset finding
  • Rename generateGlobalInjectorCode to generateReleaseInjectorCode since that better describes what it does
  • Removing all the Rollup specific code from core

Rollup plugin changes:

  • Creating a new Rollup plugin that incorporates all the Rollup functionality
  • Moving the Rollup renderChunk tests from core to Rollup
  • Removed all the deps/references to unplugin

Note on test removal

This PR removes the disabled-sourcemaps-upload.test.ts‎ test, but all that did was check if a specific plugin was present.

I didn't re-add a test to check for upload because it's currently difficult to do with Jest and the logic is currently very clear:

@github-actions

github-actionsBot commented Jan 29, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (webpack) Deduplicate webpack deploys by chargome in #875

Internal Changes 🔧

  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Migrate to oxfmt by timfish in #880
  • Build with Rolldown by timfish in #872
  • Remove unplugin by timfish in #876
  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Esbuild no longer uses unplugin by timfish in #871
  • Webpack no longer uses unplugin by timfish in #870

🤖 This preview updates automatically when you update the PR.

Comment threadpackages/rollup-plugin/src/index.ts Fixed
@chargomechargome mentioned this pull request Feb 2, 2026
@timfish
timfishforce-pushed the timfish/feat/rollup-plugin-poc branch from a83a80e to 2c77a7dCompareFebruary 9, 2026 18:58
@timfishtimfish closed this Feb 9, 2026
@timfishtimfish reopened this Feb 9, 2026
@timfishtimfish changed the title PoC: Rollup Plugin without Unpluginfeat: Rollup/Vite no longer use unpluginFeb 9, 2026
@timfish
timfish marked this pull request as ready for review February 9, 2026 22:27
@timfish
timfish requested review from Lms24 and chargomeFebruary 9, 2026 22:27
Comment threadpackages/rollup-plugin/src/index.ts Outdated
@timfishtimfish changed the title feat: Rollup/Vite no longer use unpluginfeat: Rollup/Vite no longer uses unpluginFeb 10, 2026
Comment threadpackages/rollup-plugin/src/index.ts Outdated
name: "sentry-vite-injection-plugin",
// run `post` to avoid tripping up @rollup/plugin-commonjs when cjs is used
// as we inject an `import` statement
enforce: "post" as const, // need this so that vite runs the resolveId hook

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Was this intentionally moved to "pre" within the pr? AFAICT all the plugins now run pre right?

@timfishtimfishFeb 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't used the stub + import strategy in the Rollup plugin for a while so this comment seems left over from that. We only retain that approach in esbuild.

We now only have a single plugin and we require pre for component annotations to work.

"jest": "^28.1.3",
"premove": "^4.0.0",
"rollup": "2.77.0",
"rollup": "3.2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Does this major bump in the tests have any implications on the plugin itself? e.g. compatibility testing etc

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollup plugin peer dep and the fact that our plugin returns an array suggests we only support Rollup v3 (3.1 or 3.2 depending on which of the above you consider)!

I have no idea why we were still testing v2 for e2e but changing this to V3 fixed a typescript warning!

@timfish
timfish merged commit 1271ced into getsentry:mainFeb 16, 2026
25 checks passed
@timfish
timfish deleted the timfish/feat/rollup-plugin-poc branch February 17, 2026 18:24
@timfishtimfish changed the title feat: Rollup/Vite no longer uses unpluginrefactor: Rollup/Vite no longer uses unpluginFeb 19, 2026
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 24, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.0.0 |
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@chargome@github-advanced-security@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor: Rollup/Vite no longer uses unplugin - #858

Merged
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc
Feb 16, 2026
Merged

refactor: Rollup/Vite no longer uses unplugin#858
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc

Conversation

@timfish

@timfishtimfish commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a regular (non-unplugin) Rollup plugin which is also used for Vite.

This involved core changes:

  • Exporting more utilities from bundler-core
  • Adding globFiles core export for reusable asset finding
  • Rename generateGlobalInjectorCode to generateReleaseInjectorCode since that better describes what it does
  • Removing all the Rollup specific code from core

Rollup plugin changes:

  • Creating a new Rollup plugin that incorporates all the Rollup functionality
  • Moving the Rollup renderChunk tests from core to Rollup
  • Removed all the deps/references to unplugin

Note on test removal

This PR removes the disabled-sourcemaps-upload.test.ts‎ test, but all that did was check if a specific plugin was present.

I didn't re-add a test to check for upload because it's currently difficult to do with Jest and the logic is currently very clear:

@github-actions

github-actionsBot commented Jan 29, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (webpack) Deduplicate webpack deploys by chargome in #875

Internal Changes 🔧

  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Migrate to oxfmt by timfish in #880
  • Build with Rolldown by timfish in #872
  • Remove unplugin by timfish in #876
  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Esbuild no longer uses unplugin by timfish in #871
  • Webpack no longer uses unplugin by timfish in #870

🤖 This preview updates automatically when you update the PR.

Comment threadpackages/rollup-plugin/src/index.ts Fixed
@chargomechargome mentioned this pull request Feb 2, 2026
@timfish
timfishforce-pushed the timfish/feat/rollup-plugin-poc branch from a83a80e to 2c77a7dCompareFebruary 9, 2026 18:58
@timfishtimfish closed this Feb 9, 2026
@timfishtimfish reopened this Feb 9, 2026
@timfishtimfish changed the title PoC: Rollup Plugin without Unpluginfeat: Rollup/Vite no longer use unpluginFeb 9, 2026
@timfish
timfish marked this pull request as ready for review February 9, 2026 22:27
@timfish
timfish requested review from Lms24 and chargomeFebruary 9, 2026 22:27
Comment threadpackages/rollup-plugin/src/index.ts Outdated
@timfishtimfish changed the title feat: Rollup/Vite no longer use unpluginfeat: Rollup/Vite no longer uses unpluginFeb 10, 2026
Comment threadpackages/rollup-plugin/src/index.ts Outdated
name: "sentry-vite-injection-plugin",
// run `post` to avoid tripping up @rollup/plugin-commonjs when cjs is used
// as we inject an `import` statement
enforce: "post" as const, // need this so that vite runs the resolveId hook

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Was this intentionally moved to "pre" within the pr? AFAICT all the plugins now run pre right?

@timfishtimfishFeb 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't used the stub + import strategy in the Rollup plugin for a while so this comment seems left over from that. We only retain that approach in esbuild.

We now only have a single plugin and we require pre for component annotations to work.

"jest": "^28.1.3",
"premove": "^4.0.0",
"rollup": "2.77.0",
"rollup": "3.2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Does this major bump in the tests have any implications on the plugin itself? e.g. compatibility testing etc

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollup plugin peer dep and the fact that our plugin returns an array suggests we only support Rollup v3 (3.1 or 3.2 depending on which of the above you consider)!

I have no idea why we were still testing v2 for e2e but changing this to V3 fixed a typescript warning!

@timfish
timfish merged commit 1271ced into getsentry:mainFeb 16, 2026
25 checks passed
@timfish
timfish deleted the timfish/feat/rollup-plugin-poc branch February 17, 2026 18:24
@timfishtimfish changed the title feat: Rollup/Vite no longer uses unpluginrefactor: Rollup/Vite no longer uses unpluginFeb 19, 2026
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 24, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.0.0 |
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@chargome@github-advanced-security@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor: Rollup/Vite no longer uses unplugin - #858

Merged
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc
Feb 16, 2026
Merged

refactor: Rollup/Vite no longer uses unplugin#858
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc

Conversation

@timfish

@timfishtimfish commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a regular (non-unplugin) Rollup plugin which is also used for Vite.

This involved core changes:

  • Exporting more utilities from bundler-core
  • Adding globFiles core export for reusable asset finding
  • Rename generateGlobalInjectorCode to generateReleaseInjectorCode since that better describes what it does
  • Removing all the Rollup specific code from core

Rollup plugin changes:

  • Creating a new Rollup plugin that incorporates all the Rollup functionality
  • Moving the Rollup renderChunk tests from core to Rollup
  • Removed all the deps/references to unplugin

Note on test removal

This PR removes the disabled-sourcemaps-upload.test.ts‎ test, but all that did was check if a specific plugin was present.

I didn't re-add a test to check for upload because it's currently difficult to do with Jest and the logic is currently very clear:

@github-actions

github-actionsBot commented Jan 29, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (webpack) Deduplicate webpack deploys by chargome in #875

Internal Changes 🔧

  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Migrate to oxfmt by timfish in #880
  • Build with Rolldown by timfish in #872
  • Remove unplugin by timfish in #876
  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Esbuild no longer uses unplugin by timfish in #871
  • Webpack no longer uses unplugin by timfish in #870

🤖 This preview updates automatically when you update the PR.

Comment threadpackages/rollup-plugin/src/index.ts Fixed
@chargomechargome mentioned this pull request Feb 2, 2026
@timfish
timfishforce-pushed the timfish/feat/rollup-plugin-poc branch from a83a80e to 2c77a7dCompareFebruary 9, 2026 18:58
@timfishtimfish closed this Feb 9, 2026
@timfishtimfish reopened this Feb 9, 2026
@timfishtimfish changed the title PoC: Rollup Plugin without Unpluginfeat: Rollup/Vite no longer use unpluginFeb 9, 2026
@timfish
timfish marked this pull request as ready for review February 9, 2026 22:27
@timfish
timfish requested review from Lms24 and chargomeFebruary 9, 2026 22:27
Comment threadpackages/rollup-plugin/src/index.ts Outdated
@timfishtimfish changed the title feat: Rollup/Vite no longer use unpluginfeat: Rollup/Vite no longer uses unpluginFeb 10, 2026
Comment threadpackages/rollup-plugin/src/index.ts Outdated
name: "sentry-vite-injection-plugin",
// run `post` to avoid tripping up @rollup/plugin-commonjs when cjs is used
// as we inject an `import` statement
enforce: "post" as const, // need this so that vite runs the resolveId hook

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Was this intentionally moved to "pre" within the pr? AFAICT all the plugins now run pre right?

@timfishtimfishFeb 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't used the stub + import strategy in the Rollup plugin for a while so this comment seems left over from that. We only retain that approach in esbuild.

We now only have a single plugin and we require pre for component annotations to work.

"jest": "^28.1.3",
"premove": "^4.0.0",
"rollup": "2.77.0",
"rollup": "3.2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Does this major bump in the tests have any implications on the plugin itself? e.g. compatibility testing etc

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollup plugin peer dep and the fact that our plugin returns an array suggests we only support Rollup v3 (3.1 or 3.2 depending on which of the above you consider)!

I have no idea why we were still testing v2 for e2e but changing this to V3 fixed a typescript warning!

@timfish
timfish merged commit 1271ced into getsentry:mainFeb 16, 2026
25 checks passed
@timfish
timfish deleted the timfish/feat/rollup-plugin-poc branch February 17, 2026 18:24
@timfishtimfish changed the title feat: Rollup/Vite no longer uses unpluginrefactor: Rollup/Vite no longer uses unpluginFeb 19, 2026
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 24, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.0.0 |
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@chargome@github-advanced-security@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

refactor: Rollup/Vite no longer uses unplugin - #858

Merged
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc
Feb 16, 2026
Merged

refactor: Rollup/Vite no longer uses unplugin#858
timfish merged 9 commits into
getsentry:mainfrom
timfish:timfish/feat/rollup-plugin-poc

Conversation

@timfish

@timfishtimfish commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a regular (non-unplugin) Rollup plugin which is also used for Vite.

This involved core changes:

  • Exporting more utilities from bundler-core
  • Adding globFiles core export for reusable asset finding
  • Rename generateGlobalInjectorCode to generateReleaseInjectorCode since that better describes what it does
  • Removing all the Rollup specific code from core

Rollup plugin changes:

  • Creating a new Rollup plugin that incorporates all the Rollup functionality
  • Moving the Rollup renderChunk tests from core to Rollup
  • Removed all the deps/references to unplugin

Note on test removal

This PR removes the disabled-sourcemaps-upload.test.ts‎ test, but all that did was check if a specific plugin was present.

I didn't re-add a test to check for upload because it's currently difficult to do with Jest and the logic is currently very clear:

@github-actions

github-actionsBot commented Jan 29, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • (webpack) Deduplicate webpack deploys by chargome in #875

Internal Changes 🔧

  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Migrate to oxfmt by timfish in #880
  • Build with Rolldown by timfish in #872
  • Remove unplugin by timfish in #876
  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Esbuild no longer uses unplugin by timfish in #871
  • Webpack no longer uses unplugin by timfish in #870

🤖 This preview updates automatically when you update the PR.

Comment threadpackages/rollup-plugin/src/index.ts Fixed
@chargomechargome mentioned this pull request Feb 2, 2026
@timfish
timfishforce-pushed the timfish/feat/rollup-plugin-poc branch from a83a80e to 2c77a7dCompareFebruary 9, 2026 18:58
@timfishtimfish closed this Feb 9, 2026
@timfishtimfish reopened this Feb 9, 2026
@timfishtimfish changed the title PoC: Rollup Plugin without Unpluginfeat: Rollup/Vite no longer use unpluginFeb 9, 2026
@timfish
timfish marked this pull request as ready for review February 9, 2026 22:27
@timfish
timfish requested review from Lms24 and chargomeFebruary 9, 2026 22:27
Comment threadpackages/rollup-plugin/src/index.ts Outdated
@timfishtimfish changed the title feat: Rollup/Vite no longer use unpluginfeat: Rollup/Vite no longer uses unpluginFeb 10, 2026
Comment threadpackages/rollup-plugin/src/index.ts Outdated
name: "sentry-vite-injection-plugin",
// run `post` to avoid tripping up @rollup/plugin-commonjs when cjs is used
// as we inject an `import` statement
enforce: "post" as const, // need this so that vite runs the resolveId hook

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Was this intentionally moved to "pre" within the pr? AFAICT all the plugins now run pre right?

@timfishtimfishFeb 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't used the stub + import strategy in the Rollup plugin for a while so this comment seems left over from that. We only retain that approach in esbuild.

We now only have a single plugin and we require pre for component annotations to work.

"jest": "^28.1.3",
"premove": "^4.0.0",
"rollup": "2.77.0",
"rollup": "3.2.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Does this major bump in the tests have any implications on the plugin itself? e.g. compatibility testing etc

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rollup plugin peer dep and the fact that our plugin returns an array suggests we only support Rollup v3 (3.1 or 3.2 depending on which of the above you consider)!

I have no idea why we were still testing v2 for e2e but changing this to V3 fixed a typescript warning!

@timfish
timfish merged commit 1271ced into getsentry:mainFeb 16, 2026
25 checks passed
@timfish
timfish deleted the timfish/feat/rollup-plugin-poc branch February 17, 2026 18:24
@timfishtimfish changed the title feat: Rollup/Vite no longer uses unpluginrefactor: Rollup/Vite no longer uses unpluginFeb 19, 2026
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 24, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.0.0 |
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
renovateBot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Mar 2, 2026
| datasource | package | from | to |
| ---------- | ------------------- | ----- | ----- |
| npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 |
## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511)
##### Bug Fixes 🐛
- Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893)
##### Internal Changes 🔧
- Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891)
## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510)
##### New Features ✨
- Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890)
## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500)
##### Breaking Changes 🛠
- Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885)
- Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886)
##### Bug Fixes 🐛
- (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875)
##### Internal Changes 🔧
- Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883)
- Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880)
- Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872)
- Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876)
- Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858)
- Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871)
- Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@timfish@chargome@github-advanced-security@andreiborza