Uh oh!
There was an error while loading. Please reload this page.
chore!: updating minimatch - #885
Conversation
Semver Impact of This PR🔴 Major (breaking changes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Breaking Changes 🛠
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Add minimatch@10.2.2 dev dep in the root to push outdated versions into duplicates, and local packages were updated to use minimatch v10. The following packages depend on minimatch v3: - @eslint/eslintrc - @humanwhocodes/config-array - @jest/core - copy-concurrently - eslint - eslint-plugin-react - jest-circus - jest-config - jest-runner - move-concurrently - rimraf - terser-webpack-plugin - test-exclude Finally, `@rollup/plugin-commonjs` depends on minimatch 5.1.6. A fix will be backported to resolve the ReDOS on v3 and v5, which can then be updated here.
9c89009 to
f1d3304Compare- Adding a devDependency on minimatch in the root, so that all outdated versions get pushed into duplicates. - Updated `minimatch` direct dependency packages/node, packages/react-router, and packages/remix - Once getsentry/sentry-javascript-bundler-plugins#885 lands, we can update the dependency coming in from `@sentry/bundler-plugin-core` There are several other dependencies that transitively bring in a minimatch v3, v5, v8, or v9. Fixes for the ReDOS will be backported where those dependencies cannot be easily updated.
Add minimatch@10.2.2 dev dep in the root to push outdated versions into duplicates, and local packages were updated to use minimatch v10. The following packages depend on minimatch v3: - @eslint/eslintrc - @humanwhocodes/config-array - @jest/core - copy-concurrently - eslint - eslint-plugin-react - jest-circus - jest-config - jest-runner - move-concurrently - rimraf - terser-webpack-plugin - test-exclude Finally, `@rollup/plugin-commonjs` depends on minimatch 5.1.6. A fix will be backported to resolve the ReDOS on v3 and v5, which can then be updated here.
f1d3304 to
3d46820CompareUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "dotenv": "^16.3.1", | ||
| "find-up": "^5.0.0", | ||
| "glob": "^10.5.0", | ||
| "glob": "^13.0.6", |
There was a problem hiding this comment.
Node version mismatch with glob dependency
High Severity
The package specifies engines.node >= 14 but includes glob@^13.0.6 as a production dependency, which requires Node.js >= 20. This creates a version mismatch where users on Node 14-19 can install the package but glob will fail at runtime, causing crashes when glob operations are executed.
Add minimatch@10.2.2 dev dep in the root to push outdated versions into duplicates, and local packages were updated to use minimatch v10. The following packages depend on minimatch v3: - @eslint/eslintrc - @humanwhocodes/config-array - @jest/core - copy-concurrently - eslint - eslint-plugin-react - jest-circus - jest-config - jest-runner - move-concurrently - rimraf - terser-webpack-plugin - test-exclude Finally, `@rollup/plugin-commonjs` depends on minimatch 5.1.6. A fix will be backported to resolve the ReDOS on v3 and v5, which can then be updated here.
5bb07e0 to
6b2327aCompare- minimatch 3.1.2 → 3.1.3 - minimatch 5.1.6 → 5.1.7 - brace-expansion 5.0.2 → 5.0.3
andreiborza
commented
Feb 23, 2026
I bumped to the latest v3 and v5 of minimatch and the latest v5 of brace-expansion, all published recently.
|
Uh oh!
There was an error while loading. Please reload this page.
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 4.9.1 | 5.0.0 | ## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500) ##### Breaking Changes 🛠 - Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885) - Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886) ##### Bug Fixes 🐛 - (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875) ##### Internal Changes 🔧 - Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883) - Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880) - Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872) - Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876) - Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858) - Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871) - Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
- Adding a devDependency on minimatch in the root, so that all outdated versions get pushed into duplicates. - Updated `minimatch` direct dependency packages/node, packages/react-router, and packages/remix - Once getsentry/sentry-javascript-bundler-plugins#885 lands, we can update the dependency coming in from `@sentry/bundler-plugin-core` There are several other dependencies that transitively bring in a minimatch v3, v5, v8, or v9. Fixes for the ReDOS will be backported where those dependencies cannot be easily updated. Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ ] If you've added code that should be tested, please add tests. - [ ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`). - [ ] Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked. Closes #issue_link_here
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 | ## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511) ##### Bug Fixes 🐛 - Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893) ##### Internal Changes 🔧 - Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891) ## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510) ##### New Features ✨ - Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890) ## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500) ##### Breaking Changes 🛠 - Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885) - Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886) ##### Bug Fixes 🐛 - (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875) ##### Internal Changes 🔧 - Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883) - Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880) - Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872) - Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876) - Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858) - Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871) - Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 | ## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511) ##### Bug Fixes 🐛 - Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893) ##### Internal Changes 🔧 - Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891) ## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510) ##### New Features ✨ - Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890) ## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500) ##### Breaking Changes 🛠 - Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885) - Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886) ##### Bug Fixes 🐛 - (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875) ##### Internal Changes 🔧 - Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883) - Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880) - Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872) - Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876) - Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858) - Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871) - Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 4.9.1 | 5.1.1 | ## [v5.1.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#511) ##### Bug Fixes 🐛 - Align `engines` with Node support by [@timfish](https://github.com/timfish) in [#893](getsentry/sentry-javascript-bundler-plugins#893) ##### Internal Changes 🔧 - Use version range for magic-string by [@JPeer264](https://github.com/JPeer264) in [#891](getsentry/sentry-javascript-bundler-plugins#891) ## [v5.1.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#510) ##### New Features ✨ - Bump [@sentry/cli](https://github.com/sentry/cli) from 2.57.0 to 2.58.5 by [@andreiborza](https://github.com/andreiborza) in [#890](getsentry/sentry-javascript-bundler-plugins#890) ## [v5.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#500) ##### Breaking Changes 🛠 - Updating minimatch by [@isaacs](https://github.com/isaacs) in [#885](getsentry/sentry-javascript-bundler-plugins#885) - Remove support for Node < v18 and webpack v4 by [@timfish](https://github.com/timfish) in [#886](getsentry/sentry-javascript-bundler-plugins#886) ##### Bug Fixes 🐛 - (webpack) Deduplicate webpack deploys by [@chargome](https://github.com/chargome) in [#875](getsentry/sentry-javascript-bundler-plugins#875) ##### Internal Changes 🔧 - Avoid direct usage of glob, extract into `globFiles` helper by [@andreiborza](https://github.com/andreiborza) in [#883](getsentry/sentry-javascript-bundler-plugins#883) - Migrate to oxfmt by [@timfish](https://github.com/timfish) in [#880](getsentry/sentry-javascript-bundler-plugins#880) - Build with Rolldown by [@timfish](https://github.com/timfish) in [#872](getsentry/sentry-javascript-bundler-plugins#872) - Remove unplugin by [@timfish](https://github.com/timfish) in [#876](getsentry/sentry-javascript-bundler-plugins#876) - Rollup/Vite no longer uses unplugin by [@timfish](https://github.com/timfish) in [#858](getsentry/sentry-javascript-bundler-plugins#858) - Esbuild no longer uses unplugin by [@timfish](https://github.com/timfish) in [#871](getsentry/sentry-javascript-bundler-plugins#871) - Webpack no longer uses unplugin by [@timfish](https://github.com/timfish) in [#870](getsentry/sentry-javascript-bundler-plugins#870)


Add minimatch@10.2.2 dev dep in the root to push outdated versions into duplicates, and local packages were updated to use minimatch v10.
The following packages depend on minimatch v3:
Finally,
@rollup/plugin-commonjsdepends on minimatch 5.1.6.A fix will be backported to resolve the ReDOS on v3 and v5, which can then be updated here.