Consola logging add object as extra data/context

[luuktap]

Problem Statement

When logging with Consola, it'd be nice to be able to pass an object and have Sentry treat it as (searchable) context/data, instead of serializing it into the main log message.

Solution Brainstorm

This should be very easy to implement since Consola exposes an args array on a logObj which contains all the parameters passed into a log call. Looping through the elements in the array, taking out all objects and passing them as context.

https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/integrations/consola.ts#L215

Additional Context

No response

Priority

_{React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it.}

[linear]

JS-1348

[s1gr1d]

Hi, I think this would be a good addition. The only challenge I see here is that those objects could be quite nested.

And would you expect the stringified objects to be still within the body or just within the attributes?

This is how it would currently look like in the Pino integration for this log:

logger.info({ user: 'user-id', something: { more: 3, complex: 'nope' } }, 'hello world')

sentry-javascript/dev-packages/node-integration-tests/suites/pino/test.ts

Lines 64 to 74 in 0ae9369

	body: 'hello world',
	trace_id: expect.any(String),
	severity_number: 9,
	attributes: {
	name: { value: 'myapp', type: 'string' },
	'pino.logger.level': { value: 30, type: 'integer' },
	user: { value: 'user-id', type: 'string' },
	something: {
	type: 'string',
	value: '{"more":3,"complex":"nope"}',
	},

[luuktap]

Nested objects should follow default behavior configured by the normalizeDepth option when initializing the SDK, right?
Another case to consider could be JS Error objects w/ stack traces. Not sure how those should get handled so they're readable in the logs.

I don't know the pros/cons for having the stringified objects either in body or attributes, I'm new to Sentry, but in general I'd think match the Pino implementation.