Uh oh!
There was an error while loading. Please reload this page.
feat(consola): Enhance Consola integration to extract first-param object as searchable attributes - #19534
Merged
Conversation
s1gr1dforce-pushed
the
sig/consola-obj-keys
branch
from
February 26, 2026 13:51
c71c835 to
fcfd91cCompares1gr1d
commented
Feb 26, 2026
| /** | ||
| * Extracts structured attributes from console arguments. If the first argument is a plain object, its properties are extracted as attributes. | ||
| */ | ||
| function defaultExtractAttributes( |
MemberAuthor
There was a problem hiding this comment.
This is a function that could be theoretically added by users (as a future feature). That's why this function is extra from the processExtractedAttributes. In theory, it could just be one function.
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Uh oh!
There was an error while loading. Please reload this page.
chargome
approved these changes
Feb 26, 2026
Uh oh!
There was an error while loading. Please reload this page.
| /** | ||
| * Result of extracting structured attributes from console arguments. | ||
| */ | ||
| export interface ExtractAttributesResult { |
Member
There was a problem hiding this comment.
l: I would not export this as long as the functions stays internal.
s1gr1dforce-pushed
the
sig/consola-obj-keys
branch
from
February 27, 2026 09:20
fcfd91c to
282b963CompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Uh oh!
There was an error while loading. Please reload this page.
s1gr1d
enabled auto-merge (squash)
March 2, 2026 10:08
Uh oh!
There was an error while loading. Please reload this page.
s1gr1d added a commit
that referenced
this pull request
Jun 9, 2026
…gration` (#21385) Aligns the console integration so object-first logs are structured, matching the consola integration behavior. If the first argument is an object, the keys are added as log attributes. Reference PR (consola): #19534 The universal principle is this: ``` IF first_argument is plain_object: attributes ← first_argument keys/values message ← second_argument (if string) OR empty remaining_args → sentry.message.parameter.{0, 1, 2...} ELSE: message ← formatted(all_args) args[1:] → sentry.message.parameter.{0, 1, 2...} ``` ### Example Snippet ```js console.warn({ component: 'PaymentService', retryCount: 3 }, 500, 'TIMEOUT'); console.info( { userId: 42, action: 'purchase' }, 'Console [OBJ-FIRST+PARAMS]: Checkout complete', testOrder.orderId, testOrder.total, ); ``` #### Before <img width="1434" height="662" alt="image" src="https://github.com/user-attachments/assets/19f310dd-d417-48fd-acb3-7695e28417b7" /> #### After <img width="1425" height="665" alt="image" src="https://github.com/user-attachments/assets/6f722ce3-e698-46fa-ba22-5f1f42304f65" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the Consola integration so object-first logs are structured and fallback logs get template + parameters.
Universal principle
Consola-specific behavior
consola.log({ message: "x", userId, action })Consola passesargs: ["x"]and spreads the rest on the log object. We detect this (single string in args + extra keys on logObj) and treat it as one logical object: message =args[0], attributes = extra keys.consola.log.raw({ message: "raw-hello" })produces attributes from the object and an empty message.sentry.message.parameter.*).Example
Console String substitutions are not added as a template attribute because parsing is too complicated on the client-side (see here: #17703)
Closes#18593