feat(utils): Use globalThis - #11351

Merged
AbhiPrasad merged 1 commit into
developfrom
timfish/globalThis
Apr 2, 2024
Merged

feat(utils): Use globalThis#11351
AbhiPrasad merged 1 commit into
developfrom
timfish/globalThis

Conversation

@timfish

@timfishtimfish commented Mar 29, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

Now we've dropped Node v12 we can simplify to globalThis:

#5611 (comment)

@codecov

codecovBot commented Mar 29, 2024•
edited
Loading

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 71.33kB ⬇️

Bundle nameSizeChange
@sentry-internal/replay-esm306.46kB0 bytes
@sentry-internal/replay-cjs306.35kB0 bytes
@sentry-internal/replay-canvas-esm29.43kB0 bytes
@sentry/node-cjs334.49kB2.47kB ⬇️
@sentry-internal/node-integration-tests-cjs1.04kB0 bytes
@sentry/bun-esm10.05kB0 bytes
@sentry/node-esm331.09kB2.47kB ⬇️
@sentry/utils-cjs176.9kB1.85kB ⬇️
@sentry/google-cloud-serverless-cjs23.0kB0 bytes
@sentry/utils-esm172.32kB1.85kB ⬇️
@sentry/core-cjs240.44kB0 bytes
@sentry/react-esm41.18kB0 bytes
@sentry/browser-cjs107.36kB0 bytes
@sentry/astro-cjs27.13kB0 bytes
@sentry/wasm-cjs5.2kB0 bytes
@sentry-internal/replay-canvas-cjs29.51kB0 bytes
@sentry/svelte-cjs13.84kB0 bytes
@sentry/google-cloud-serverless-esm19.16kB0 bytes
@sentry/astro-esm23.39kB0 bytes
@sentry-internal/node-integration-tests-esm888 bytes0 bytes
@sentry/aws-serverless-cjs14.62kB0 bytes
@sentry/browser-esm104.53kB0 bytes
@sentry/bun-cjs13.5kB0 bytes
@sentry/core-esm236.82kB0 bytes
@sentry/gatsby-cjs905 bytes0 bytes
@sentry/vue-esm18.85kB0 bytes
@sentry-internal/integration-shims-cjs3.65kB0 bytes
@sentry/sveltekit-cjs69.31kB0 bytes
@sentry/sveltekit-esm61.08kB0 bytes
@sentry/remix-cjs53.62kB0 bytes
@sentry/gatsby-esm385 bytes0 bytes
@sentry/remix-esm48.23kB0 bytes
@sentry/nextjs-cjs20.52kB0 bytes
@sentry/profiling-node-cjs25.5kB0 bytes
@sentry/profiling-node-esm25.52kB0 bytes
@sentry/nextjs-esm20.02kB0 bytes
@sentry/vue-cjs20.19kB0 bytes
@sentry/vercel-edge-cjs18.23kB0 bytes
@sentry-internal/integration-shims-esm2.99kB0 bytes
@sentry-internal/feedback-cjs65.81kB0 bytes
@sentry/vercel-edge-esm16.13kB0 bytes
@sentry/opentelemetry-cjs68.45kB0 bytes
@sentry-internal/tracing-cjs108.01kB0 bytes
@sentry-internal/feedback-esm65.5kB0 bytes
@sentry/opentelemetry-esm67.4kB0 bytes
@sentry-internal/tracing-esm107.26kB0 bytes
@sentry/types-cjs(removed)35 bytes ⬇️
@sentry/types-esm(removed)35 bytes ⬇️
@sentry/wasm-esm(removed)4.85kB ⬇️
@sentry/svelte-esm(removed)12.72kB ⬇️
@sentry/react-cjs(removed)45.04kB ⬇️

@github-actions

github-actionsBot commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser (incl. Tracing, Replay, Feedback)80.41 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay)71.75 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas)75.56 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags65.32 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. browserTracingIntegration)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. feedbackIntegration)31.46 KB (-0.23% 🔽)
@sentry/browser (incl. feedbackModalIntegration)31.57 KB (-0.21% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration)31.58 KB (-0.21% 🔽)
@sentry/browser (incl. sendFeedback)27.54 KB (-0.21% 🔽)
@sentry/browser22.69 KB (-0.26% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback)74.86 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing, Replay)69.67 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing)36.22 KB (-0.15% 🔽)
CDN Bundle23.96 KB (-0.27% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed218.59 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing) - uncompressed109.24 KB (-0.2% 🔽)
CDN Bundle - uncompressed70.87 KB (-0.29% 🔽)
@sentry/react (incl. Tracing, Replay)71.73 KB (-0.07% 🔽)
@sentry/react22.71 KB (-0.31% 🔽)

@timfish
timfish marked this pull request as ready for review March 29, 2024 22:59
@AbhiPrasad

AbhiPrasad commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

I think this is a good idea, but I'm a little scared about edge cases that we will encounter if we are less defensive of how we access the global in the browser environment. Does that fear seem reasonable?

@timfish

timfish commented Apr 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Does that fear seem reasonable?

I don't think this is any riskier than the changes to target ES20xx. Every browser we support has supported it since at least late 2019 and for older browsers it's easy to polyfill.

The MDN docs say:

it's guaranteed to work in window and non-window contexts

What sort of edge cases are you thinking about?

@AbhiPrasad

AbhiPrasad commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

What sort of edge cases are you thinking about?

breaking react native, web workers, or extension context, but you know what - doing more reading I think we are fine. Let's merge!

@AbhiPrasad
AbhiPrasad merged commit ed4a751 into developApr 2, 2024
@AbhiPrasad
AbhiPrasad deleted the timfish/globalThis branch April 2, 2024 20:33
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@timfish@cadesalaberry
feat(utils): UseglobalThis(getsentry#11351)
9259c01
Now we've dropped Nove v12 we can simplify to `globalThis`:
getsentry#5611 (comment)
@timfishtimfish mentioned this pull request Jul 31, 2024
Merged
Lms24 pushed a commit that referenced this pull request Jul 31, 2024
@timfish
fix: UseglobalThisfor code injection (#13132)
4972604
Since v8, all platforms and versions we support have support for
`globalThis`. Since [this
PR](#11351) we also
use `globalThis` when reading these injectected values.
This was referenced Sep 23, 2024
Merged
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timfish@AbhiPrasad@mydea
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(utils): Use globalThis - #11351
Merged
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Apr 2, 2024
Merged
feat(utils): Use globalThis#11351
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Conversation
@timfish
@timfishtimfish
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Collaborator
Now we've dropped Node v12 we can simplify to globalThis:
#5611 (comment)
@codecov
codecovBot
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Bundle Report
Changes will decrease total bundle size by 71.33kB ⬇️
Bundle nameSizeChange
@sentry-internal/replay-esm306.46kB0 bytes
@sentry-internal/replay-cjs306.35kB0 bytes
@sentry-internal/replay-canvas-esm29.43kB0 bytes
@sentry/node-cjs334.49kB2.47kB ⬇️
@sentry-internal/node-integration-tests-cjs1.04kB0 bytes
@sentry/bun-esm10.05kB0 bytes
@sentry/node-esm331.09kB2.47kB ⬇️
@sentry/utils-cjs176.9kB1.85kB ⬇️
@sentry/google-cloud-serverless-cjs23.0kB0 bytes
@sentry/utils-esm172.32kB1.85kB ⬇️
@sentry/core-cjs240.44kB0 bytes
@sentry/react-esm41.18kB0 bytes
@sentry/browser-cjs107.36kB0 bytes
@sentry/astro-cjs27.13kB0 bytes
@sentry/wasm-cjs5.2kB0 bytes
@sentry-internal/replay-canvas-cjs29.51kB0 bytes
@sentry/svelte-cjs13.84kB0 bytes
@sentry/google-cloud-serverless-esm19.16kB0 bytes
@sentry/astro-esm23.39kB0 bytes
@sentry-internal/node-integration-tests-esm888 bytes0 bytes
@sentry/aws-serverless-cjs14.62kB0 bytes
@sentry/browser-esm104.53kB0 bytes
@sentry/bun-cjs13.5kB0 bytes
@sentry/core-esm236.82kB0 bytes
@sentry/gatsby-cjs905 bytes0 bytes
@sentry/vue-esm18.85kB0 bytes
@sentry-internal/integration-shims-cjs3.65kB0 bytes
@sentry/sveltekit-cjs69.31kB0 bytes
@sentry/sveltekit-esm61.08kB0 bytes
@sentry/remix-cjs53.62kB0 bytes
@sentry/gatsby-esm385 bytes0 bytes
@sentry/remix-esm48.23kB0 bytes
@sentry/nextjs-cjs20.52kB0 bytes
@sentry/profiling-node-cjs25.5kB0 bytes
@sentry/profiling-node-esm25.52kB0 bytes
@sentry/nextjs-esm20.02kB0 bytes
@sentry/vue-cjs20.19kB0 bytes
@sentry/vercel-edge-cjs18.23kB0 bytes
@sentry-internal/integration-shims-esm2.99kB0 bytes
@sentry-internal/feedback-cjs65.81kB0 bytes
@sentry/vercel-edge-esm16.13kB0 bytes
@sentry/opentelemetry-cjs68.45kB0 bytes
@sentry-internal/tracing-cjs108.01kB0 bytes
@sentry-internal/feedback-esm65.5kB0 bytes
@sentry/opentelemetry-esm67.4kB0 bytes
@sentry-internal/tracing-esm107.26kB0 bytes
@sentry/types-cjs(removed)35 bytes ⬇️
@sentry/types-esm(removed)35 bytes ⬇️
@sentry/wasm-esm(removed)4.85kB ⬇️
@sentry/svelte-esm(removed)12.72kB ⬇️
@sentry/react-cjs(removed)45.04kB ⬇️
@github-actions
github-actionsBot
commented
Mar 29, 2024

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback)80.41 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay)71.75 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas)75.56 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags65.32 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. browserTracingIntegration)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. feedbackIntegration)31.46 KB (-0.23% 🔽)
@sentry/browser (incl. feedbackModalIntegration)31.57 KB (-0.21% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration)31.58 KB (-0.21% 🔽)
@sentry/browser (incl. sendFeedback)27.54 KB (-0.21% 🔽)
@sentry/browser22.69 KB (-0.26% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback)74.86 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing, Replay)69.67 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing)36.22 KB (-0.15% 🔽)
CDN Bundle23.96 KB (-0.27% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed218.59 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing) - uncompressed109.24 KB (-0.2% 🔽)
CDN Bundle - uncompressed70.87 KB (-0.29% 🔽)
@sentry/react (incl. Tracing, Replay)71.73 KB (-0.07% 🔽)
@sentry/react22.71 KB (-0.31% 🔽)
@timfish
timfish
marked this pull request as ready for review
March 29, 2024 22:59
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
I think this is a good idea, but I'm a little scared about edge cases that we will encounter if we are less defensive of how we access the global in the browser environment. Does that fear seem reasonable?
@timfish
timfish
commented
Apr 2, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Does that fear seem reasonable?
I don't think this is any riskier than the changes to target ES20xx. Every browser we support has supported it since at least late 2019 and for older browsers it's easy to polyfill.
The MDN docs say:
it's guaranteed to work in window and non-window contexts
What sort of edge cases are you thinking about?
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
What sort of edge cases are you thinking about?
breaking react native, web workers, or extension context, but you know what - doing more reading I think we are fine. Let's merge!
@AbhiPrasad
AbhiPrasad
merged commit ed4a751
into
developApr 2, 2024
@AbhiPrasad
AbhiPrasad
deleted the

timfish/globalThis

branch
April 2, 2024 20:33
cadesalaberry pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
@timfish@cadesalaberry
feat(utils): UseglobalThis(getsentry#11351)
9259c01
Now we've dropped Nove v12 we can simplify to `globalThis`:
getsentry#5611 (comment)
@timfishtimfish
mentioned this pull request
Jul 31, 2024
 Merged

Lms24 pushed a commit
that referenced
this pull request
Jul 31, 2024
@timfish
fix: UseglobalThisfor code injection (#13132)
4972604
Since v8, all platforms and versions we support have support for
`globalThis`. Since [this
PR](#11351) we also
use `globalThis` when reading these injectected values.

This was referenced Sep 23, 2024
 Merged

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@timfish@AbhiPrasad@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(utils): Use globalThis - #11351
Merged
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Apr 2, 2024
Merged
feat(utils): Use globalThis#11351
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Conversation
@timfish
@timfishtimfish
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Collaborator
Now we've dropped Node v12 we can simplify to globalThis:
#5611 (comment)
@codecov
codecovBot
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Bundle Report
Changes will decrease total bundle size by 71.33kB ⬇️
Bundle nameSizeChange
@sentry-internal/replay-esm306.46kB0 bytes
@sentry-internal/replay-cjs306.35kB0 bytes
@sentry-internal/replay-canvas-esm29.43kB0 bytes
@sentry/node-cjs334.49kB2.47kB ⬇️
@sentry-internal/node-integration-tests-cjs1.04kB0 bytes
@sentry/bun-esm10.05kB0 bytes
@sentry/node-esm331.09kB2.47kB ⬇️
@sentry/utils-cjs176.9kB1.85kB ⬇️
@sentry/google-cloud-serverless-cjs23.0kB0 bytes
@sentry/utils-esm172.32kB1.85kB ⬇️
@sentry/core-cjs240.44kB0 bytes
@sentry/react-esm41.18kB0 bytes
@sentry/browser-cjs107.36kB0 bytes
@sentry/astro-cjs27.13kB0 bytes
@sentry/wasm-cjs5.2kB0 bytes
@sentry-internal/replay-canvas-cjs29.51kB0 bytes
@sentry/svelte-cjs13.84kB0 bytes
@sentry/google-cloud-serverless-esm19.16kB0 bytes
@sentry/astro-esm23.39kB0 bytes
@sentry-internal/node-integration-tests-esm888 bytes0 bytes
@sentry/aws-serverless-cjs14.62kB0 bytes
@sentry/browser-esm104.53kB0 bytes
@sentry/bun-cjs13.5kB0 bytes
@sentry/core-esm236.82kB0 bytes
@sentry/gatsby-cjs905 bytes0 bytes
@sentry/vue-esm18.85kB0 bytes
@sentry-internal/integration-shims-cjs3.65kB0 bytes
@sentry/sveltekit-cjs69.31kB0 bytes
@sentry/sveltekit-esm61.08kB0 bytes
@sentry/remix-cjs53.62kB0 bytes
@sentry/gatsby-esm385 bytes0 bytes
@sentry/remix-esm48.23kB0 bytes
@sentry/nextjs-cjs20.52kB0 bytes
@sentry/profiling-node-cjs25.5kB0 bytes
@sentry/profiling-node-esm25.52kB0 bytes
@sentry/nextjs-esm20.02kB0 bytes
@sentry/vue-cjs20.19kB0 bytes
@sentry/vercel-edge-cjs18.23kB0 bytes
@sentry-internal/integration-shims-esm2.99kB0 bytes
@sentry-internal/feedback-cjs65.81kB0 bytes
@sentry/vercel-edge-esm16.13kB0 bytes
@sentry/opentelemetry-cjs68.45kB0 bytes
@sentry-internal/tracing-cjs108.01kB0 bytes
@sentry-internal/feedback-esm65.5kB0 bytes
@sentry/opentelemetry-esm67.4kB0 bytes
@sentry-internal/tracing-esm107.26kB0 bytes
@sentry/types-cjs(removed)35 bytes ⬇️
@sentry/types-esm(removed)35 bytes ⬇️
@sentry/wasm-esm(removed)4.85kB ⬇️
@sentry/svelte-esm(removed)12.72kB ⬇️
@sentry/react-cjs(removed)45.04kB ⬇️
@github-actions
github-actionsBot
commented
Mar 29, 2024

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback)80.41 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay)71.75 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas)75.56 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags65.32 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. browserTracingIntegration)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. feedbackIntegration)31.46 KB (-0.23% 🔽)
@sentry/browser (incl. feedbackModalIntegration)31.57 KB (-0.21% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration)31.58 KB (-0.21% 🔽)
@sentry/browser (incl. sendFeedback)27.54 KB (-0.21% 🔽)
@sentry/browser22.69 KB (-0.26% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback)74.86 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing, Replay)69.67 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing)36.22 KB (-0.15% 🔽)
CDN Bundle23.96 KB (-0.27% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed218.59 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing) - uncompressed109.24 KB (-0.2% 🔽)
CDN Bundle - uncompressed70.87 KB (-0.29% 🔽)
@sentry/react (incl. Tracing, Replay)71.73 KB (-0.07% 🔽)
@sentry/react22.71 KB (-0.31% 🔽)
@timfish
timfish
marked this pull request as ready for review
March 29, 2024 22:59
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
I think this is a good idea, but I'm a little scared about edge cases that we will encounter if we are less defensive of how we access the global in the browser environment. Does that fear seem reasonable?
@timfish
timfish
commented
Apr 2, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Does that fear seem reasonable?
I don't think this is any riskier than the changes to target ES20xx. Every browser we support has supported it since at least late 2019 and for older browsers it's easy to polyfill.
The MDN docs say:
it's guaranteed to work in window and non-window contexts
What sort of edge cases are you thinking about?
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
What sort of edge cases are you thinking about?
breaking react native, web workers, or extension context, but you know what - doing more reading I think we are fine. Let's merge!
@AbhiPrasad
AbhiPrasad
merged commit ed4a751
into
developApr 2, 2024
@AbhiPrasad
AbhiPrasad
deleted the

timfish/globalThis

branch
April 2, 2024 20:33
cadesalaberry pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
@timfish@cadesalaberry
feat(utils): UseglobalThis(getsentry#11351)
9259c01
Now we've dropped Nove v12 we can simplify to `globalThis`:
getsentry#5611 (comment)
@timfishtimfish
mentioned this pull request
Jul 31, 2024
 Merged

Lms24 pushed a commit
that referenced
this pull request
Jul 31, 2024
@timfish
fix: UseglobalThisfor code injection (#13132)
4972604
Since v8, all platforms and versions we support have support for
`globalThis`. Since [this
PR](#11351) we also
use `globalThis` when reading these injectected values.

This was referenced Sep 23, 2024
 Merged

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@timfish@AbhiPrasad@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(utils): Use globalThis - #11351
Merged
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Apr 2, 2024
Merged
feat(utils): Use globalThis#11351
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Conversation
@timfish
@timfishtimfish
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Collaborator
Now we've dropped Node v12 we can simplify to globalThis:
#5611 (comment)
@codecov
codecovBot
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Bundle Report
Changes will decrease total bundle size by 71.33kB ⬇️
Bundle nameSizeChange
@sentry-internal/replay-esm306.46kB0 bytes
@sentry-internal/replay-cjs306.35kB0 bytes
@sentry-internal/replay-canvas-esm29.43kB0 bytes
@sentry/node-cjs334.49kB2.47kB ⬇️
@sentry-internal/node-integration-tests-cjs1.04kB0 bytes
@sentry/bun-esm10.05kB0 bytes
@sentry/node-esm331.09kB2.47kB ⬇️
@sentry/utils-cjs176.9kB1.85kB ⬇️
@sentry/google-cloud-serverless-cjs23.0kB0 bytes
@sentry/utils-esm172.32kB1.85kB ⬇️
@sentry/core-cjs240.44kB0 bytes
@sentry/react-esm41.18kB0 bytes
@sentry/browser-cjs107.36kB0 bytes
@sentry/astro-cjs27.13kB0 bytes
@sentry/wasm-cjs5.2kB0 bytes
@sentry-internal/replay-canvas-cjs29.51kB0 bytes
@sentry/svelte-cjs13.84kB0 bytes
@sentry/google-cloud-serverless-esm19.16kB0 bytes
@sentry/astro-esm23.39kB0 bytes
@sentry-internal/node-integration-tests-esm888 bytes0 bytes
@sentry/aws-serverless-cjs14.62kB0 bytes
@sentry/browser-esm104.53kB0 bytes
@sentry/bun-cjs13.5kB0 bytes
@sentry/core-esm236.82kB0 bytes
@sentry/gatsby-cjs905 bytes0 bytes
@sentry/vue-esm18.85kB0 bytes
@sentry-internal/integration-shims-cjs3.65kB0 bytes
@sentry/sveltekit-cjs69.31kB0 bytes
@sentry/sveltekit-esm61.08kB0 bytes
@sentry/remix-cjs53.62kB0 bytes
@sentry/gatsby-esm385 bytes0 bytes
@sentry/remix-esm48.23kB0 bytes
@sentry/nextjs-cjs20.52kB0 bytes
@sentry/profiling-node-cjs25.5kB0 bytes
@sentry/profiling-node-esm25.52kB0 bytes
@sentry/nextjs-esm20.02kB0 bytes
@sentry/vue-cjs20.19kB0 bytes
@sentry/vercel-edge-cjs18.23kB0 bytes
@sentry-internal/integration-shims-esm2.99kB0 bytes
@sentry-internal/feedback-cjs65.81kB0 bytes
@sentry/vercel-edge-esm16.13kB0 bytes
@sentry/opentelemetry-cjs68.45kB0 bytes
@sentry-internal/tracing-cjs108.01kB0 bytes
@sentry-internal/feedback-esm65.5kB0 bytes
@sentry/opentelemetry-esm67.4kB0 bytes
@sentry-internal/tracing-esm107.26kB0 bytes
@sentry/types-cjs(removed)35 bytes ⬇️
@sentry/types-esm(removed)35 bytes ⬇️
@sentry/wasm-esm(removed)4.85kB ⬇️
@sentry/svelte-esm(removed)12.72kB ⬇️
@sentry/react-cjs(removed)45.04kB ⬇️
@github-actions
github-actionsBot
commented
Mar 29, 2024

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback)80.41 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay)71.75 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas)75.56 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags65.32 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. browserTracingIntegration)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. feedbackIntegration)31.46 KB (-0.23% 🔽)
@sentry/browser (incl. feedbackModalIntegration)31.57 KB (-0.21% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration)31.58 KB (-0.21% 🔽)
@sentry/browser (incl. sendFeedback)27.54 KB (-0.21% 🔽)
@sentry/browser22.69 KB (-0.26% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback)74.86 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing, Replay)69.67 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing)36.22 KB (-0.15% 🔽)
CDN Bundle23.96 KB (-0.27% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed218.59 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing) - uncompressed109.24 KB (-0.2% 🔽)
CDN Bundle - uncompressed70.87 KB (-0.29% 🔽)
@sentry/react (incl. Tracing, Replay)71.73 KB (-0.07% 🔽)
@sentry/react22.71 KB (-0.31% 🔽)
@timfish
timfish
marked this pull request as ready for review
March 29, 2024 22:59
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
I think this is a good idea, but I'm a little scared about edge cases that we will encounter if we are less defensive of how we access the global in the browser environment. Does that fear seem reasonable?
@timfish
timfish
commented
Apr 2, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Does that fear seem reasonable?
I don't think this is any riskier than the changes to target ES20xx. Every browser we support has supported it since at least late 2019 and for older browsers it's easy to polyfill.
The MDN docs say:
it's guaranteed to work in window and non-window contexts
What sort of edge cases are you thinking about?
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
What sort of edge cases are you thinking about?
breaking react native, web workers, or extension context, but you know what - doing more reading I think we are fine. Let's merge!
@AbhiPrasad
AbhiPrasad
merged commit ed4a751
into
developApr 2, 2024
@AbhiPrasad
AbhiPrasad
deleted the

timfish/globalThis

branch
April 2, 2024 20:33
cadesalaberry pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
@timfish@cadesalaberry
feat(utils): UseglobalThis(getsentry#11351)
9259c01
Now we've dropped Nove v12 we can simplify to `globalThis`:
getsentry#5611 (comment)
@timfishtimfish
mentioned this pull request
Jul 31, 2024
 Merged

Lms24 pushed a commit
that referenced
this pull request
Jul 31, 2024
@timfish
fix: UseglobalThisfor code injection (#13132)
4972604
Since v8, all platforms and versions we support have support for
`globalThis`. Since [this
PR](#11351) we also
use `globalThis` when reading these injectected values.

This was referenced Sep 23, 2024
 Merged

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@timfish@AbhiPrasad@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(utils): Use globalThis - #11351
Merged
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Apr 2, 2024
Merged
feat(utils): Use globalThis#11351
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Conversation
@timfish
@timfishtimfish
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Collaborator
Now we've dropped Node v12 we can simplify to globalThis:
#5611 (comment)
@codecov
codecovBot
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Bundle Report
Changes will decrease total bundle size by 71.33kB ⬇️
Bundle nameSizeChange
@sentry-internal/replay-esm306.46kB0 bytes
@sentry-internal/replay-cjs306.35kB0 bytes
@sentry-internal/replay-canvas-esm29.43kB0 bytes
@sentry/node-cjs334.49kB2.47kB ⬇️
@sentry-internal/node-integration-tests-cjs1.04kB0 bytes
@sentry/bun-esm10.05kB0 bytes
@sentry/node-esm331.09kB2.47kB ⬇️
@sentry/utils-cjs176.9kB1.85kB ⬇️
@sentry/google-cloud-serverless-cjs23.0kB0 bytes
@sentry/utils-esm172.32kB1.85kB ⬇️
@sentry/core-cjs240.44kB0 bytes
@sentry/react-esm41.18kB0 bytes
@sentry/browser-cjs107.36kB0 bytes
@sentry/astro-cjs27.13kB0 bytes
@sentry/wasm-cjs5.2kB0 bytes
@sentry-internal/replay-canvas-cjs29.51kB0 bytes
@sentry/svelte-cjs13.84kB0 bytes
@sentry/google-cloud-serverless-esm19.16kB0 bytes
@sentry/astro-esm23.39kB0 bytes
@sentry-internal/node-integration-tests-esm888 bytes0 bytes
@sentry/aws-serverless-cjs14.62kB0 bytes
@sentry/browser-esm104.53kB0 bytes
@sentry/bun-cjs13.5kB0 bytes
@sentry/core-esm236.82kB0 bytes
@sentry/gatsby-cjs905 bytes0 bytes
@sentry/vue-esm18.85kB0 bytes
@sentry-internal/integration-shims-cjs3.65kB0 bytes
@sentry/sveltekit-cjs69.31kB0 bytes
@sentry/sveltekit-esm61.08kB0 bytes
@sentry/remix-cjs53.62kB0 bytes
@sentry/gatsby-esm385 bytes0 bytes
@sentry/remix-esm48.23kB0 bytes
@sentry/nextjs-cjs20.52kB0 bytes
@sentry/profiling-node-cjs25.5kB0 bytes
@sentry/profiling-node-esm25.52kB0 bytes
@sentry/nextjs-esm20.02kB0 bytes
@sentry/vue-cjs20.19kB0 bytes
@sentry/vercel-edge-cjs18.23kB0 bytes
@sentry-internal/integration-shims-esm2.99kB0 bytes
@sentry-internal/feedback-cjs65.81kB0 bytes
@sentry/vercel-edge-esm16.13kB0 bytes
@sentry/opentelemetry-cjs68.45kB0 bytes
@sentry-internal/tracing-cjs108.01kB0 bytes
@sentry-internal/feedback-esm65.5kB0 bytes
@sentry/opentelemetry-esm67.4kB0 bytes
@sentry-internal/tracing-esm107.26kB0 bytes
@sentry/types-cjs(removed)35 bytes ⬇️
@sentry/types-esm(removed)35 bytes ⬇️
@sentry/wasm-esm(removed)4.85kB ⬇️
@sentry/svelte-esm(removed)12.72kB ⬇️
@sentry/react-cjs(removed)45.04kB ⬇️
@github-actions
github-actionsBot
commented
Mar 29, 2024

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback)80.41 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay)71.75 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas)75.56 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags65.32 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. browserTracingIntegration)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. feedbackIntegration)31.46 KB (-0.23% 🔽)
@sentry/browser (incl. feedbackModalIntegration)31.57 KB (-0.21% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration)31.58 KB (-0.21% 🔽)
@sentry/browser (incl. sendFeedback)27.54 KB (-0.21% 🔽)
@sentry/browser22.69 KB (-0.26% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback)74.86 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing, Replay)69.67 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing)36.22 KB (-0.15% 🔽)
CDN Bundle23.96 KB (-0.27% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed218.59 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing) - uncompressed109.24 KB (-0.2% 🔽)
CDN Bundle - uncompressed70.87 KB (-0.29% 🔽)
@sentry/react (incl. Tracing, Replay)71.73 KB (-0.07% 🔽)
@sentry/react22.71 KB (-0.31% 🔽)
@timfish
timfish
marked this pull request as ready for review
March 29, 2024 22:59
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
I think this is a good idea, but I'm a little scared about edge cases that we will encounter if we are less defensive of how we access the global in the browser environment. Does that fear seem reasonable?
@timfish
timfish
commented
Apr 2, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Does that fear seem reasonable?
I don't think this is any riskier than the changes to target ES20xx. Every browser we support has supported it since at least late 2019 and for older browsers it's easy to polyfill.
The MDN docs say:
it's guaranteed to work in window and non-window contexts
What sort of edge cases are you thinking about?
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
What sort of edge cases are you thinking about?
breaking react native, web workers, or extension context, but you know what - doing more reading I think we are fine. Let's merge!
@AbhiPrasad
AbhiPrasad
merged commit ed4a751
into
developApr 2, 2024
@AbhiPrasad
AbhiPrasad
deleted the

timfish/globalThis

branch
April 2, 2024 20:33
cadesalaberry pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
@timfish@cadesalaberry
feat(utils): UseglobalThis(getsentry#11351)
9259c01
Now we've dropped Nove v12 we can simplify to `globalThis`:
getsentry#5611 (comment)
@timfishtimfish
mentioned this pull request
Jul 31, 2024
 Merged

Lms24 pushed a commit
that referenced
this pull request
Jul 31, 2024
@timfish
fix: UseglobalThisfor code injection (#13132)
4972604
Since v8, all platforms and versions we support have support for
`globalThis`. Since [this
PR](#11351) we also
use `globalThis` when reading these injectected values.

This was referenced Sep 23, 2024
 Merged

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@timfish@AbhiPrasad@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(utils): Use globalThis - #11351
Merged
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Apr 2, 2024
Merged
feat(utils): Use globalThis#11351
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Conversation
@timfish
@timfishtimfish
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Collaborator
Now we've dropped Node v12 we can simplify to globalThis:
#5611 (comment)
@codecov
codecovBot
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Bundle Report
Changes will decrease total bundle size by 71.33kB ⬇️
Bundle nameSizeChange
@sentry-internal/replay-esm306.46kB0 bytes
@sentry-internal/replay-cjs306.35kB0 bytes
@sentry-internal/replay-canvas-esm29.43kB0 bytes
@sentry/node-cjs334.49kB2.47kB ⬇️
@sentry-internal/node-integration-tests-cjs1.04kB0 bytes
@sentry/bun-esm10.05kB0 bytes
@sentry/node-esm331.09kB2.47kB ⬇️
@sentry/utils-cjs176.9kB1.85kB ⬇️
@sentry/google-cloud-serverless-cjs23.0kB0 bytes
@sentry/utils-esm172.32kB1.85kB ⬇️
@sentry/core-cjs240.44kB0 bytes
@sentry/react-esm41.18kB0 bytes
@sentry/browser-cjs107.36kB0 bytes
@sentry/astro-cjs27.13kB0 bytes
@sentry/wasm-cjs5.2kB0 bytes
@sentry-internal/replay-canvas-cjs29.51kB0 bytes
@sentry/svelte-cjs13.84kB0 bytes
@sentry/google-cloud-serverless-esm19.16kB0 bytes
@sentry/astro-esm23.39kB0 bytes
@sentry-internal/node-integration-tests-esm888 bytes0 bytes
@sentry/aws-serverless-cjs14.62kB0 bytes
@sentry/browser-esm104.53kB0 bytes
@sentry/bun-cjs13.5kB0 bytes
@sentry/core-esm236.82kB0 bytes
@sentry/gatsby-cjs905 bytes0 bytes
@sentry/vue-esm18.85kB0 bytes
@sentry-internal/integration-shims-cjs3.65kB0 bytes
@sentry/sveltekit-cjs69.31kB0 bytes
@sentry/sveltekit-esm61.08kB0 bytes
@sentry/remix-cjs53.62kB0 bytes
@sentry/gatsby-esm385 bytes0 bytes
@sentry/remix-esm48.23kB0 bytes
@sentry/nextjs-cjs20.52kB0 bytes
@sentry/profiling-node-cjs25.5kB0 bytes
@sentry/profiling-node-esm25.52kB0 bytes
@sentry/nextjs-esm20.02kB0 bytes
@sentry/vue-cjs20.19kB0 bytes
@sentry/vercel-edge-cjs18.23kB0 bytes
@sentry-internal/integration-shims-esm2.99kB0 bytes
@sentry-internal/feedback-cjs65.81kB0 bytes
@sentry/vercel-edge-esm16.13kB0 bytes
@sentry/opentelemetry-cjs68.45kB0 bytes
@sentry-internal/tracing-cjs108.01kB0 bytes
@sentry-internal/feedback-esm65.5kB0 bytes
@sentry/opentelemetry-esm67.4kB0 bytes
@sentry-internal/tracing-esm107.26kB0 bytes
@sentry/types-cjs(removed)35 bytes ⬇️
@sentry/types-esm(removed)35 bytes ⬇️
@sentry/wasm-esm(removed)4.85kB ⬇️
@sentry/svelte-esm(removed)12.72kB ⬇️
@sentry/react-cjs(removed)45.04kB ⬇️
@github-actions
github-actionsBot
commented
Mar 29, 2024

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback)80.41 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay)71.75 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas)75.56 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags65.32 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. browserTracingIntegration)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. feedbackIntegration)31.46 KB (-0.23% 🔽)
@sentry/browser (incl. feedbackModalIntegration)31.57 KB (-0.21% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration)31.58 KB (-0.21% 🔽)
@sentry/browser (incl. sendFeedback)27.54 KB (-0.21% 🔽)
@sentry/browser22.69 KB (-0.26% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback)74.86 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing, Replay)69.67 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing)36.22 KB (-0.15% 🔽)
CDN Bundle23.96 KB (-0.27% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed218.59 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing) - uncompressed109.24 KB (-0.2% 🔽)
CDN Bundle - uncompressed70.87 KB (-0.29% 🔽)
@sentry/react (incl. Tracing, Replay)71.73 KB (-0.07% 🔽)
@sentry/react22.71 KB (-0.31% 🔽)
@timfish
timfish
marked this pull request as ready for review
March 29, 2024 22:59
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
I think this is a good idea, but I'm a little scared about edge cases that we will encounter if we are less defensive of how we access the global in the browser environment. Does that fear seem reasonable?
@timfish
timfish
commented
Apr 2, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Does that fear seem reasonable?
I don't think this is any riskier than the changes to target ES20xx. Every browser we support has supported it since at least late 2019 and for older browsers it's easy to polyfill.
The MDN docs say:
it's guaranteed to work in window and non-window contexts
What sort of edge cases are you thinking about?
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
What sort of edge cases are you thinking about?
breaking react native, web workers, or extension context, but you know what - doing more reading I think we are fine. Let's merge!
@AbhiPrasad
AbhiPrasad
merged commit ed4a751
into
developApr 2, 2024
@AbhiPrasad
AbhiPrasad
deleted the

timfish/globalThis

branch
April 2, 2024 20:33
cadesalaberry pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
@timfish@cadesalaberry
feat(utils): UseglobalThis(getsentry#11351)
9259c01
Now we've dropped Nove v12 we can simplify to `globalThis`:
getsentry#5611 (comment)
@timfishtimfish
mentioned this pull request
Jul 31, 2024
 Merged

Lms24 pushed a commit
that referenced
this pull request
Jul 31, 2024
@timfish
fix: UseglobalThisfor code injection (#13132)
4972604
Since v8, all platforms and versions we support have support for
`globalThis`. Since [this
PR](#11351) we also
use `globalThis` when reading these injectected values.

This was referenced Sep 23, 2024
 Merged

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@timfish@AbhiPrasad@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(utils): Use globalThis - #11351
Merged
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Apr 2, 2024
Merged
feat(utils): Use globalThis#11351
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Conversation
@timfish
@timfishtimfish
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Collaborator
Now we've dropped Node v12 we can simplify to globalThis:
#5611 (comment)
@codecov
codecovBot
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Bundle Report
Changes will decrease total bundle size by 71.33kB ⬇️
Bundle nameSizeChange
@sentry-internal/replay-esm306.46kB0 bytes
@sentry-internal/replay-cjs306.35kB0 bytes
@sentry-internal/replay-canvas-esm29.43kB0 bytes
@sentry/node-cjs334.49kB2.47kB ⬇️
@sentry-internal/node-integration-tests-cjs1.04kB0 bytes
@sentry/bun-esm10.05kB0 bytes
@sentry/node-esm331.09kB2.47kB ⬇️
@sentry/utils-cjs176.9kB1.85kB ⬇️
@sentry/google-cloud-serverless-cjs23.0kB0 bytes
@sentry/utils-esm172.32kB1.85kB ⬇️
@sentry/core-cjs240.44kB0 bytes
@sentry/react-esm41.18kB0 bytes
@sentry/browser-cjs107.36kB0 bytes
@sentry/astro-cjs27.13kB0 bytes
@sentry/wasm-cjs5.2kB0 bytes
@sentry-internal/replay-canvas-cjs29.51kB0 bytes
@sentry/svelte-cjs13.84kB0 bytes
@sentry/google-cloud-serverless-esm19.16kB0 bytes
@sentry/astro-esm23.39kB0 bytes
@sentry-internal/node-integration-tests-esm888 bytes0 bytes
@sentry/aws-serverless-cjs14.62kB0 bytes
@sentry/browser-esm104.53kB0 bytes
@sentry/bun-cjs13.5kB0 bytes
@sentry/core-esm236.82kB0 bytes
@sentry/gatsby-cjs905 bytes0 bytes
@sentry/vue-esm18.85kB0 bytes
@sentry-internal/integration-shims-cjs3.65kB0 bytes
@sentry/sveltekit-cjs69.31kB0 bytes
@sentry/sveltekit-esm61.08kB0 bytes
@sentry/remix-cjs53.62kB0 bytes
@sentry/gatsby-esm385 bytes0 bytes
@sentry/remix-esm48.23kB0 bytes
@sentry/nextjs-cjs20.52kB0 bytes
@sentry/profiling-node-cjs25.5kB0 bytes
@sentry/profiling-node-esm25.52kB0 bytes
@sentry/nextjs-esm20.02kB0 bytes
@sentry/vue-cjs20.19kB0 bytes
@sentry/vercel-edge-cjs18.23kB0 bytes
@sentry-internal/integration-shims-esm2.99kB0 bytes
@sentry-internal/feedback-cjs65.81kB0 bytes
@sentry/vercel-edge-esm16.13kB0 bytes
@sentry/opentelemetry-cjs68.45kB0 bytes
@sentry-internal/tracing-cjs108.01kB0 bytes
@sentry-internal/feedback-esm65.5kB0 bytes
@sentry/opentelemetry-esm67.4kB0 bytes
@sentry-internal/tracing-esm107.26kB0 bytes
@sentry/types-cjs(removed)35 bytes ⬇️
@sentry/types-esm(removed)35 bytes ⬇️
@sentry/wasm-esm(removed)4.85kB ⬇️
@sentry/svelte-esm(removed)12.72kB ⬇️
@sentry/react-cjs(removed)45.04kB ⬇️
@github-actions
github-actionsBot
commented
Mar 29, 2024

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback)80.41 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay)71.75 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas)75.56 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags65.32 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. browserTracingIntegration)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. feedbackIntegration)31.46 KB (-0.23% 🔽)
@sentry/browser (incl. feedbackModalIntegration)31.57 KB (-0.21% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration)31.58 KB (-0.21% 🔽)
@sentry/browser (incl. sendFeedback)27.54 KB (-0.21% 🔽)
@sentry/browser22.69 KB (-0.26% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback)74.86 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing, Replay)69.67 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing)36.22 KB (-0.15% 🔽)
CDN Bundle23.96 KB (-0.27% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed218.59 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing) - uncompressed109.24 KB (-0.2% 🔽)
CDN Bundle - uncompressed70.87 KB (-0.29% 🔽)
@sentry/react (incl. Tracing, Replay)71.73 KB (-0.07% 🔽)
@sentry/react22.71 KB (-0.31% 🔽)
@timfish
timfish
marked this pull request as ready for review
March 29, 2024 22:59
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
I think this is a good idea, but I'm a little scared about edge cases that we will encounter if we are less defensive of how we access the global in the browser environment. Does that fear seem reasonable?
@timfish
timfish
commented
Apr 2, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Does that fear seem reasonable?
I don't think this is any riskier than the changes to target ES20xx. Every browser we support has supported it since at least late 2019 and for older browsers it's easy to polyfill.
The MDN docs say:
it's guaranteed to work in window and non-window contexts
What sort of edge cases are you thinking about?
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
What sort of edge cases are you thinking about?
breaking react native, web workers, or extension context, but you know what - doing more reading I think we are fine. Let's merge!
@AbhiPrasad
AbhiPrasad
merged commit ed4a751
into
developApr 2, 2024
@AbhiPrasad
AbhiPrasad
deleted the

timfish/globalThis

branch
April 2, 2024 20:33
cadesalaberry pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
@timfish@cadesalaberry
feat(utils): UseglobalThis(getsentry#11351)
9259c01
Now we've dropped Nove v12 we can simplify to `globalThis`:
getsentry#5611 (comment)
@timfishtimfish
mentioned this pull request
Jul 31, 2024
 Merged

Lms24 pushed a commit
that referenced
this pull request
Jul 31, 2024
@timfish
fix: UseglobalThisfor code injection (#13132)
4972604
Since v8, all platforms and versions we support have support for
`globalThis`. Since [this
PR](#11351) we also
use `globalThis` when reading these injectected values.

This was referenced Sep 23, 2024
 Merged

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@timfish@AbhiPrasad@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(utils): Use globalThis - #11351
Merged
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Apr 2, 2024
Merged
feat(utils): Use globalThis#11351
AbhiPrasad merged 1 commit into
developfrom 
timfish/globalThis
Conversation
@timfish
@timfishtimfish
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Collaborator
Now we've dropped Node v12 we can simplify to globalThis:
#5611 (comment)
@codecov
codecovBot
commented
Mar 29, 2024•

edited

Loading

Copy link


Copy Markdown

Bundle Report
Changes will decrease total bundle size by 71.33kB ⬇️
Bundle nameSizeChange
@sentry-internal/replay-esm306.46kB0 bytes
@sentry-internal/replay-cjs306.35kB0 bytes
@sentry-internal/replay-canvas-esm29.43kB0 bytes
@sentry/node-cjs334.49kB2.47kB ⬇️
@sentry-internal/node-integration-tests-cjs1.04kB0 bytes
@sentry/bun-esm10.05kB0 bytes
@sentry/node-esm331.09kB2.47kB ⬇️
@sentry/utils-cjs176.9kB1.85kB ⬇️
@sentry/google-cloud-serverless-cjs23.0kB0 bytes
@sentry/utils-esm172.32kB1.85kB ⬇️
@sentry/core-cjs240.44kB0 bytes
@sentry/react-esm41.18kB0 bytes
@sentry/browser-cjs107.36kB0 bytes
@sentry/astro-cjs27.13kB0 bytes
@sentry/wasm-cjs5.2kB0 bytes
@sentry-internal/replay-canvas-cjs29.51kB0 bytes
@sentry/svelte-cjs13.84kB0 bytes
@sentry/google-cloud-serverless-esm19.16kB0 bytes
@sentry/astro-esm23.39kB0 bytes
@sentry-internal/node-integration-tests-esm888 bytes0 bytes
@sentry/aws-serverless-cjs14.62kB0 bytes
@sentry/browser-esm104.53kB0 bytes
@sentry/bun-cjs13.5kB0 bytes
@sentry/core-esm236.82kB0 bytes
@sentry/gatsby-cjs905 bytes0 bytes
@sentry/vue-esm18.85kB0 bytes
@sentry-internal/integration-shims-cjs3.65kB0 bytes
@sentry/sveltekit-cjs69.31kB0 bytes
@sentry/sveltekit-esm61.08kB0 bytes
@sentry/remix-cjs53.62kB0 bytes
@sentry/gatsby-esm385 bytes0 bytes
@sentry/remix-esm48.23kB0 bytes
@sentry/nextjs-cjs20.52kB0 bytes
@sentry/profiling-node-cjs25.5kB0 bytes
@sentry/profiling-node-esm25.52kB0 bytes
@sentry/nextjs-esm20.02kB0 bytes
@sentry/vue-cjs20.19kB0 bytes
@sentry/vercel-edge-cjs18.23kB0 bytes
@sentry-internal/integration-shims-esm2.99kB0 bytes
@sentry-internal/feedback-cjs65.81kB0 bytes
@sentry/vercel-edge-esm16.13kB0 bytes
@sentry/opentelemetry-cjs68.45kB0 bytes
@sentry-internal/tracing-cjs108.01kB0 bytes
@sentry-internal/feedback-esm65.5kB0 bytes
@sentry/opentelemetry-esm67.4kB0 bytes
@sentry-internal/tracing-esm107.26kB0 bytes
@sentry/types-cjs(removed)35 bytes ⬇️
@sentry/types-esm(removed)35 bytes ⬇️
@sentry/wasm-esm(removed)4.85kB ⬇️
@sentry/svelte-esm(removed)12.72kB ⬇️
@sentry/react-cjs(removed)45.04kB ⬇️
@github-actions
github-actionsBot
commented
Mar 29, 2024

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser (incl. Tracing, Replay, Feedback)80.41 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay)71.75 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas)75.56 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags65.32 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. browserTracingIntegration)36.58 KB (-0.12% 🔽)
@sentry/browser (incl. feedbackIntegration)31.46 KB (-0.23% 🔽)
@sentry/browser (incl. feedbackModalIntegration)31.57 KB (-0.21% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration)31.58 KB (-0.21% 🔽)
@sentry/browser (incl. sendFeedback)27.54 KB (-0.21% 🔽)
@sentry/browser22.69 KB (-0.26% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback)74.86 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing, Replay)69.67 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing)36.22 KB (-0.15% 🔽)
CDN Bundle23.96 KB (-0.27% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed218.59 KB (-0.1% 🔽)
CDN Bundle (incl. Tracing) - uncompressed109.24 KB (-0.2% 🔽)
CDN Bundle - uncompressed70.87 KB (-0.29% 🔽)
@sentry/react (incl. Tracing, Replay)71.73 KB (-0.07% 🔽)
@sentry/react22.71 KB (-0.31% 🔽)
@timfish
timfish
marked this pull request as ready for review
March 29, 2024 22:59
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
I think this is a good idea, but I'm a little scared about edge cases that we will encounter if we are less defensive of how we access the global in the browser environment. Does that fear seem reasonable?
@timfish
timfish
commented
Apr 2, 2024

Copy link


Copy Markdown

CollaboratorAuthor
Does that fear seem reasonable?
I don't think this is any riskier than the changes to target ES20xx. Every browser we support has supported it since at least late 2019 and for older browsers it's easy to polyfill.
The MDN docs say:
it's guaranteed to work in window and non-window contexts
What sort of edge cases are you thinking about?
@AbhiPrasad
AbhiPrasad
commented
Apr 2, 2024

Copy link


Copy Markdown

Contributor
What sort of edge cases are you thinking about?
breaking react native, web workers, or extension context, but you know what - doing more reading I think we are fine. Let's merge!
@AbhiPrasad
AbhiPrasad
merged commit ed4a751
into
developApr 2, 2024
@AbhiPrasad
AbhiPrasad
deleted the

timfish/globalThis

branch
April 2, 2024 20:33
cadesalaberry pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
@timfish@cadesalaberry
feat(utils): UseglobalThis(getsentry#11351)
9259c01
Now we've dropped Nove v12 we can simplify to `globalThis`:
getsentry#5611 (comment)
@timfishtimfish
mentioned this pull request
Jul 31, 2024
 Merged

Lms24 pushed a commit
that referenced
this pull request
Jul 31, 2024
@timfish
fix: UseglobalThisfor code injection (#13132)
4972604
Since v8, all platforms and versions we support have support for
`globalThis`. Since [this
PR](#11351) we also
use `globalThis` when reading these injectected values.

This was referenced Sep 23, 2024
 Merged

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@timfish@AbhiPrasad@mydea