Raven-js likes to share, let's make it more introverted.

[hamishcampbell]

• All functions (e.g. 'private' ones, like each) moved into the
  Raven global to prevent them polluting the window object. Misc
  variables too (cachedAuth etc).
• Added hitch to apply scope to callbacks, primarily
  so that each can recieve callbacks with scope set. each
  now applies this instead of null.
• Moved global* variables into Raven object properties - since
  Raven is global anyway. Included legacy support for loading
  but possible issues if you're running multiple Raven versions
  and changing global settings after it's loaded.
• Refactored for cleanliness:
  • Remove one line control structures (inconsistently applied
    and linters don't like them)
  • Declare functions nicely (wrapped, success, etc) so the
    test runner doesn't complain about strict violations
  • Use function level strict directive so sources can be concatenated
    and strict behaviour maintained.
  • Wrap it all up, put a bow on it.
• Update tests.

[mattrobenolt]

Umm, not quite sure what all is going on here because I'm distracted by the noise of moving everythign into the Raven object, which is wrong.

When compiling the script, a header and footer are applied making a closure out of the entire script, not exposing anything except Raven.

What you did also makes the compressed file size much larger since the names of the functions can't be munged smaller.

If you want to resubmit, I'd be happy to look at the other things.

Also, try and keep pull requests as simple as possible. One pull request per idea. If, for example, I agreed on some but not all of the things, it's harder to cherry-pick just the things we both agree on. :)

[hamishcampbell]

Erwoops. Should've looked before leaping.

In that case, my only issue is it would be useful to have a build command that only produced the concatenated (un uglified) source so I can let the dojo build system handle that side of it.

[mattrobenolt]

So make raven gives you a minified and unminified version. I also distribute builds that are unminifed in the repository. Is that not enough?

[hamishcampbell]

• All functions (e.g. 'private' ones, like each) moved into the
  Raven global to prevent them polluting the window object. Misc
  variables too (cachedAuth etc).
• Added hitch to apply scope to callbacks, primarily
  so that each can recieve callbacks with scope set. each
  now applies this instead of null.
• Moved global* variables into Raven object properties - since
  Raven is global anyway. Included legacy support for loading
  but possible issues if you're running multiple Raven versions
  and changing global settings after it's loaded.
• Refactored for cleanliness:
  • Remove one line control structures (inconsistently applied
    and linters don't like them)
  • Declare functions nicely (wrapped, success, etc) so the
    test runner doesn't complain about strict violations
  • Use function level strict directive so sources can be concatenated
    and strict behaviour maintained.
  • Wrap it all up, put a bow on it.
• Update tests.

[mattrobenolt]

Umm, not quite sure what all is going on here because I'm distracted by the noise of moving everythign into the Raven object, which is wrong.

When compiling the script, a header and footer are applied making a closure out of the entire script, not exposing anything except Raven.

What you did also makes the compressed file size much larger since the names of the functions can't be munged smaller.

If you want to resubmit, I'd be happy to look at the other things.

Also, try and keep pull requests as simple as possible. One pull request per idea. If, for example, I agreed on some but not all of the things, it's harder to cherry-pick just the things we both agree on. :)

[hamishcampbell]

Erwoops. Should've looked before leaping.

In that case, my only issue is it would be useful to have a build command that only produced the concatenated (un uglified) source so I can let the dojo build system handle that side of it.

[mattrobenolt]

So make raven gives you a minified and unminified version. I also distribute builds that are unminifed in the repository. Is that not enough?

[hamishcampbell]

• All functions (e.g. 'private' ones, like each) moved into the
  Raven global to prevent them polluting the window object. Misc
  variables too (cachedAuth etc).
• Added hitch to apply scope to callbacks, primarily
  so that each can recieve callbacks with scope set. each
  now applies this instead of null.
• Moved global* variables into Raven object properties - since
  Raven is global anyway. Included legacy support for loading
  but possible issues if you're running multiple Raven versions
  and changing global settings after it's loaded.
• Refactored for cleanliness:
  • Remove one line control structures (inconsistently applied
    and linters don't like them)
  • Declare functions nicely (wrapped, success, etc) so the
    test runner doesn't complain about strict violations
  • Use function level strict directive so sources can be concatenated
    and strict behaviour maintained.
  • Wrap it all up, put a bow on it.
• Update tests.

[mattrobenolt]

Umm, not quite sure what all is going on here because I'm distracted by the noise of moving everythign into the Raven object, which is wrong.

When compiling the script, a header and footer are applied making a closure out of the entire script, not exposing anything except Raven.

What you did also makes the compressed file size much larger since the names of the functions can't be munged smaller.

If you want to resubmit, I'd be happy to look at the other things.

Also, try and keep pull requests as simple as possible. One pull request per idea. If, for example, I agreed on some but not all of the things, it's harder to cherry-pick just the things we both agree on. :)

[hamishcampbell]

Erwoops. Should've looked before leaping.

In that case, my only issue is it would be useful to have a build command that only produced the concatenated (un uglified) source so I can let the dojo build system handle that side of it.

[mattrobenolt]

So make raven gives you a minified and unminified version. I also distribute builds that are unminifed in the repository. Is that not enough?

[hamishcampbell]

• All functions (e.g. 'private' ones, like each) moved into the
  Raven global to prevent them polluting the window object. Misc
  variables too (cachedAuth etc).
• Added hitch to apply scope to callbacks, primarily
  so that each can recieve callbacks with scope set. each
  now applies this instead of null.
• Moved global* variables into Raven object properties - since
  Raven is global anyway. Included legacy support for loading
  but possible issues if you're running multiple Raven versions
  and changing global settings after it's loaded.
• Refactored for cleanliness:
  • Remove one line control structures (inconsistently applied
    and linters don't like them)
  • Declare functions nicely (wrapped, success, etc) so the
    test runner doesn't complain about strict violations
  • Use function level strict directive so sources can be concatenated
    and strict behaviour maintained.
  • Wrap it all up, put a bow on it.
• Update tests.

[mattrobenolt]

Umm, not quite sure what all is going on here because I'm distracted by the noise of moving everythign into the Raven object, which is wrong.

When compiling the script, a header and footer are applied making a closure out of the entire script, not exposing anything except Raven.

What you did also makes the compressed file size much larger since the names of the functions can't be munged smaller.

If you want to resubmit, I'd be happy to look at the other things.

Also, try and keep pull requests as simple as possible. One pull request per idea. If, for example, I agreed on some but not all of the things, it's harder to cherry-pick just the things we both agree on. :)

[hamishcampbell]

Erwoops. Should've looked before leaping.

In that case, my only issue is it would be useful to have a build command that only produced the concatenated (un uglified) source so I can let the dojo build system handle that side of it.

[mattrobenolt]

So make raven gives you a minified and unminified version. I also distribute builds that are unminifed in the repository. Is that not enough?

[hamishcampbell]

• All functions (e.g. 'private' ones, like each) moved into the
  Raven global to prevent them polluting the window object. Misc
  variables too (cachedAuth etc).
• Added hitch to apply scope to callbacks, primarily
  so that each can recieve callbacks with scope set. each
  now applies this instead of null.
• Moved global* variables into Raven object properties - since
  Raven is global anyway. Included legacy support for loading
  but possible issues if you're running multiple Raven versions
  and changing global settings after it's loaded.
• Refactored for cleanliness:
  • Remove one line control structures (inconsistently applied
    and linters don't like them)
  • Declare functions nicely (wrapped, success, etc) so the
    test runner doesn't complain about strict violations
  • Use function level strict directive so sources can be concatenated
    and strict behaviour maintained.
  • Wrap it all up, put a bow on it.
• Update tests.

[mattrobenolt]

Umm, not quite sure what all is going on here because I'm distracted by the noise of moving everythign into the Raven object, which is wrong.

When compiling the script, a header and footer are applied making a closure out of the entire script, not exposing anything except Raven.

What you did also makes the compressed file size much larger since the names of the functions can't be munged smaller.

If you want to resubmit, I'd be happy to look at the other things.

Also, try and keep pull requests as simple as possible. One pull request per idea. If, for example, I agreed on some but not all of the things, it's harder to cherry-pick just the things we both agree on. :)

[hamishcampbell]

Erwoops. Should've looked before leaping.

In that case, my only issue is it would be useful to have a build command that only produced the concatenated (un uglified) source so I can let the dojo build system handle that side of it.

[mattrobenolt]

So make raven gives you a minified and unminified version. I also distribute builds that are unminifed in the repository. Is that not enough?

[hamishcampbell]

• All functions (e.g. 'private' ones, like each) moved into the
  Raven global to prevent them polluting the window object. Misc
  variables too (cachedAuth etc).
• Added hitch to apply scope to callbacks, primarily
  so that each can recieve callbacks with scope set. each
  now applies this instead of null.
• Moved global* variables into Raven object properties - since
  Raven is global anyway. Included legacy support for loading
  but possible issues if you're running multiple Raven versions
  and changing global settings after it's loaded.
• Refactored for cleanliness:
  • Remove one line control structures (inconsistently applied
    and linters don't like them)
  • Declare functions nicely (wrapped, success, etc) so the
    test runner doesn't complain about strict violations
  • Use function level strict directive so sources can be concatenated
    and strict behaviour maintained.
  • Wrap it all up, put a bow on it.
• Update tests.

[mattrobenolt]

Umm, not quite sure what all is going on here because I'm distracted by the noise of moving everythign into the Raven object, which is wrong.

When compiling the script, a header and footer are applied making a closure out of the entire script, not exposing anything except Raven.

What you did also makes the compressed file size much larger since the names of the functions can't be munged smaller.

If you want to resubmit, I'd be happy to look at the other things.

Also, try and keep pull requests as simple as possible. One pull request per idea. If, for example, I agreed on some but not all of the things, it's harder to cherry-pick just the things we both agree on. :)

[hamishcampbell]

Erwoops. Should've looked before leaping.

In that case, my only issue is it would be useful to have a build command that only produced the concatenated (un uglified) source so I can let the dojo build system handle that side of it.

[mattrobenolt]

So make raven gives you a minified and unminified version. I also distribute builds that are unminifed in the repository. Is that not enough?

[hamishcampbell]

• All functions (e.g. 'private' ones, like each) moved into the
  Raven global to prevent them polluting the window object. Misc
  variables too (cachedAuth etc).
• Added hitch to apply scope to callbacks, primarily
  so that each can recieve callbacks with scope set. each
  now applies this instead of null.
• Moved global* variables into Raven object properties - since
  Raven is global anyway. Included legacy support for loading
  but possible issues if you're running multiple Raven versions
  and changing global settings after it's loaded.
• Refactored for cleanliness:
  • Remove one line control structures (inconsistently applied
    and linters don't like them)
  • Declare functions nicely (wrapped, success, etc) so the
    test runner doesn't complain about strict violations
  • Use function level strict directive so sources can be concatenated
    and strict behaviour maintained.
  • Wrap it all up, put a bow on it.
• Update tests.

[mattrobenolt]

Umm, not quite sure what all is going on here because I'm distracted by the noise of moving everythign into the Raven object, which is wrong.

When compiling the script, a header and footer are applied making a closure out of the entire script, not exposing anything except Raven.

What you did also makes the compressed file size much larger since the names of the functions can't be munged smaller.

If you want to resubmit, I'd be happy to look at the other things.

Also, try and keep pull requests as simple as possible. One pull request per idea. If, for example, I agreed on some but not all of the things, it's harder to cherry-pick just the things we both agree on. :)

[hamishcampbell]

Erwoops. Should've looked before leaping.

In that case, my only issue is it would be useful to have a build command that only produced the concatenated (un uglified) source so I can let the dojo build system handle that side of it.

[mattrobenolt]

So make raven gives you a minified and unminified version. I also distribute builds that are unminifed in the repository. Is that not enough?

[hamishcampbell]

• All functions (e.g. 'private' ones, like each) moved into the
  Raven global to prevent them polluting the window object. Misc
  variables too (cachedAuth etc).
• Added hitch to apply scope to callbacks, primarily
  so that each can recieve callbacks with scope set. each
  now applies this instead of null.
• Moved global* variables into Raven object properties - since
  Raven is global anyway. Included legacy support for loading
  but possible issues if you're running multiple Raven versions
  and changing global settings after it's loaded.
• Refactored for cleanliness:
  • Remove one line control structures (inconsistently applied
    and linters don't like them)
  • Declare functions nicely (wrapped, success, etc) so the
    test runner doesn't complain about strict violations
  • Use function level strict directive so sources can be concatenated
    and strict behaviour maintained.
  • Wrap it all up, put a bow on it.
• Update tests.

[mattrobenolt]

Umm, not quite sure what all is going on here because I'm distracted by the noise of moving everythign into the Raven object, which is wrong.

When compiling the script, a header and footer are applied making a closure out of the entire script, not exposing anything except Raven.

What you did also makes the compressed file size much larger since the names of the functions can't be munged smaller.

If you want to resubmit, I'd be happy to look at the other things.

Also, try and keep pull requests as simple as possible. One pull request per idea. If, for example, I agreed on some but not all of the things, it's harder to cherry-pick just the things we both agree on. :)

[hamishcampbell]

Erwoops. Should've looked before leaping.

In that case, my only issue is it would be useful to have a build command that only produced the concatenated (un uglified) source so I can let the dojo build system handle that side of it.

[mattrobenolt]

So make raven gives you a minified and unminified version. I also distribute builds that are unminifed in the repository. Is that not enough?