Uh oh!
There was an error while loading. Please reload this page.
feat(cloudflare): Add plugin for cloudflare pages - #13123
Merged
Conversation
AbhiPrasad
requested review from
andreiborza, lforst and s1gr1d
and removed request for
a teamJuly 30, 2024 21:12
This was referenced Jul 30, 2024
AbhiPrasadforce-pushed
the
abhi-cloudflare-pages-plugin
branch
2 times, most recently
from
July 30, 2024 21:24
a793bd5 to
0499776CompareAbhiPrasad
commented
Jul 30, 2024
ContributorAuthor
Note: sourcemaps for pages don't work very well, and I'm not sure why.
digging into it further, but hopefully the answer is easy. Regardless that should not block this PR. |
s1gr1d
approved these changes
Jul 31, 2024
Comment on lines
+5
to
+24
| /** | ||
| * | ||
| * @param _options | ||
| * @returns | ||
| */ | ||
| export function sentryPagesPlugin< |
ContributorAuthor
There was a problem hiding this comment.
Good catch, thank you!
AbhiPrasadforce-pushed
the
abhi-cloudflare-pages-plugin
branch
from
July 31, 2024 12:56
0499776 to
c7ac38cCompareContributor
size-limit report 📦
|
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #12620
Before reviewing this PR, I recommend reading through a GH discussion I wrote up that explains the reasoning behind the API surface of the cloudflare SDK: #13007
The PR that adds Cloudflare Workers support is also helpful context: #13025
This PR adds support for Cloudflare Pages, Cloudflare's fullstack development deployment platform that is powered by Cloudflare Workers under the hood. Think of this platform having very similar capabilities (and constraints) as Vercel.
To set the plugin up, you do something like so:
We have to use the middleware instead of a global init because we need to call
initfor every single new incoming request to make sure the sentry instance does not get stale with redeployments.While implementing
sentryPagesPlugin, I noticed that there was a logic that was redundant between it andwithSentry, the API for cloudflare workers.This led me to refactor this into a common helper,
wrapRequestHandler, which is contained inpackages/cloudflare/src/request.ts. That is why there is diffs in this PR forpackages/cloudflare/src/handler.ts.