Uh oh!
There was an error while loading. Please reload this page.
meta: Update changelog for 8.22 - #13135
Merged
Merged
Conversation
NodeId has been replaced with nodeIds which now accepts several nodes since CLS scores are cumulative. Also updated CLS metrics to match CLS captured from browserTracing. Relates to getsentry/sentry#69881
…rt happens (#13072) We currently have no visibility when this client report happens. Lets capture the exception if our experimental flag is on. Also refactors `_handleException()` to be a public method instead of private.
ref #12620 Adds a basic e2e test for cloudflare workers that installs the SDK, builds the worker, ~and validates deploying a worker to cloudflare~ This PR previously added a build step in CI that validates deploying the worker to cloudflare, but there seems to be some API permissions issues. For now not including that in the PR, but will come back to address it later on.
So far we are filtering exceptions on the status code and do not report 4xx errors. However, we actually only want to capture unexpected exceptions but all HttpExceptions are only ever thrown explicitly. Hence, we do not want to capture them and they should be filtered. In `@sentry/nest` we can use the nest `HttpException` directly, since we have `@nest/common` as a dependency. In `@sentry/node` this is not the case, so we filter based on whether a property called status is defined.
Runtime tags are already set by e.g. Relay, so the Meta-Framework SDKs do not need to set them anymore. Comment why this change was made: #13101 (review)
[Gitflow] Merge master into develop
This PR changes the `beforeSendSpan` JSDoc analogously to the docs change (getsentry/sentry-docs#10907). It now more clearly points out that `beforeSendSpan` is only called for child spans but not for root spans. ref #13119
Since v8, all platforms and versions we support have support for `globalThis`. Since [this PR](#11351) we also use `globalThis` when reading these injectected values.
Adds automatic instrumentation to `@sentry/nestjs`. Guards in nest have a `@Injectable` decorator and implement a `canActivate` function. So we can simply extend the existing instrumentation to add a proxy for `canActivate`. Also fixed a mistake with the middleware instrumentation (missing return).
lforst
approved these changes
Jul 31, 2024
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jul 31, 2024
mydea
approved these changes
Jul 31, 2024
mydea
left a comment
Member
There was a problem hiding this comment.
So fast! At this point we'll reach v8.100.0 by the end of the year xD
AbhiPrasad
commented
Jul 31, 2024
Contributor
Could we include #13123 in this release? Rebasing that PR right now, but should be ready to merge. I also added a changelog entry for that change so you should just be able to grab and use that. |
nicohrubec
commented
Jul 31, 2024
MemberAuthor
@AbhiPrasad sure no problem |
Before reviewing this change, I recommend reading through a GH discussion I wrote up that explains the reasoning behind the API surface of the cloudflare SDK: #13007 This PR adds support for [Cloudflare Pages](https://developers.cloudflare.com/pages/), Cloudflare's fullstack development deployment platform that is powered by Cloudflare Workers under the hood. Think of this platform having very similar capabilities (and constraints) as Vercel. To set the plugin up, you do something like so: ```javascript // functions/_middleware.js import * as Sentry from '@sentry/cloudflare'; export const onRequest = Sentry.sentryPagesPlugin({ dsn: process.env.SENTRY_DSN, tracesSampleRate: 1.0, }); ``` We have to use the middleware instead of a global init because we need to call `init` for every single new incoming request to make sure the sentry instance does not get stale with redeployments. While implementing `sentryPagesPlugin`, I noticed that there was a logic that was redundant between it and `withSentry`, the API for cloudflare workers. This led me to refactor this into a common helper, `wrapRequestHandler`, which is contained in `packages/cloudflare/src/request.ts`. That is why there is diffs in this PR for `packages/cloudflare/src/handler.ts`.
AbhiPrasad
commented
Jul 31, 2024
Contributor
#13123 has been merged in! |
lforstforce-pushed
the
prepare-release/8.22
branch
from
July 31, 2024 14:08
4a0704b to
1f9fc26Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the changelog for the 8.22 release.