feat(node): Add genericPool integration using opentelemetry instrumentation by Zen-cronic · Pull Request #13356 · getsentry/sentry-javascript

Zen-cronic · 2024-08-13T14:53:40Z

Implement genericPool OTL instrumentation in packages/node

Todo:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-15T02:18:50Z

hey @lforst , thanks for assigning to this pr.

This is how I'm currently testing the updated @sentry/node package in node-integration-tests:

yarn build (in root)
yarn yalc:publish (in root)
cd dev-packages/node-integration-tests && yalc add @sentry/node @sentry/utils @sentry/types @sentry/core (according to this guide)

The changes are observed (so it's working!), but yalc generates a .yalc dir and yalc.lock in node-integration-tests that contains the linked packages. But it doesn't seem like the right approach (we can't push those yalc-related to CI).

Is yarn link a more suitable approach (but this also generates yalc.lock)?

…ted (getsentry#13278) [ref](getsentry#12351) This PR moves the `SentryGlobalFilter` out of the root module, which led to the filter overriding user exception filters in certain scenarios. Now there is two ways to setup sentry error monitoring: - If users have no catch-all exception filter in their application they add the `SentryGlobalFilter` as a provider in their main module. - If users have a catch-all exception filter (annotated with `@Catch()` they can use the newly introduced `SentryCaptureException()` decorator to capture alle exceptions caught by this filter. Testing: Added a new sample application to test the second setup option and expanded the test suite in general. Side note: - Also removed the `@sentry/microservices` dependency again, since it does not come out of the box with every nest application so we cannot rely on it.

…ntry#13327)

This streamlines some caching stuff for CI: 1. Extract dependency installation & cache out into a composite action for reusability 2. Updated the cache key for dependencies to only include package & dev-package `package.json`, not the E2E test ones.

Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary. This way, we should no longer have problems where tests are either run multiple times, or not in the correct env - just add the test to the `browser` list in `ci-unit-tests.ts` to make sure it is not run in multiple node versions unnecessarily. I also added this step to the new package checklist.

🤞 Closes: getsentry#13345

Should reduce amount of cached data.

…ry#13347)

This improves a few things in our size-limit CI action: 1. Show change in bytes, in addition to the change in percentage. 2. Add a link below the table to the base comparison run. 3. If we detect that the workflow run we used as base is not the latest one, show a warning on top. ![image](https://github.com/user-attachments/assets/4678ff04-a463-4579-ad91-74cbf9b7d781)

…etsentry#13338) This streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully). The biggest change is that instead of always building into `dist` for each test file, each test will now build into a random subfolder, e.g. `dist/abc`. This way, multiple tests in a single file will never conflict with each other. Additionally it also streamlines some of the tests I encountered while looking at stuff, hopefully reducing flakes further. Closesgetsentry#13321

Reverts getsentry#13118 There has been quite a bit of segmentation faults in CI after this PR was merged. I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.

relax the pageload transaction assertion. Web vitals are too flaky to hard-assert on them and they are covered in browser integration tests

Minor changes: I realized that the formatting was broken for `v8` and that the migration guide wasn't linking to the specific section like other changelogs.

CI is angery. Crypto is only on global from Node 19 onwards.

This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#13395 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>

Fixes spacing in readme snippet

If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixesgetsentry#9856

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-26T18:28:08Z

Apologies for the mess. Please check out the new PR at #13465

Zen-cronic · 2024-08-13T14:53:40Z

For #13308

Implement genericPool OTL instrumentation in packages/node

Todo:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-15T02:18:50Z

hey @lforst , thanks for assigning to this pr.

This is how I'm currently testing the updated @sentry/node package in node-integration-tests:

yarn build (in root)
yarn yalc:publish (in root)
cd dev-packages/node-integration-tests && yalc add @sentry/node @sentry/utils @sentry/types @sentry/core (according to this guide)

The changes are observed (so it's working!), but yalc generates a .yalc dir and yalc.lock in node-integration-tests that contains the linked packages. But it doesn't seem like the right approach (we can't push those yalc-related to CI).

Is yarn link a more suitable approach (but this also generates yalc.lock)?

…ted (getsentry#13278) [ref](getsentry#12351) This PR moves the `SentryGlobalFilter` out of the root module, which led to the filter overriding user exception filters in certain scenarios. Now there is two ways to setup sentry error monitoring: - If users have no catch-all exception filter in their application they add the `SentryGlobalFilter` as a provider in their main module. - If users have a catch-all exception filter (annotated with `@Catch()` they can use the newly introduced `SentryCaptureException()` decorator to capture alle exceptions caught by this filter. Testing: Added a new sample application to test the second setup option and expanded the test suite in general. Side note: - Also removed the `@sentry/microservices` dependency again, since it does not come out of the box with every nest application so we cannot rely on it.

…ntry#13327)

This streamlines some caching stuff for CI: 1. Extract dependency installation & cache out into a composite action for reusability 2. Updated the cache key for dependencies to only include package & dev-package `package.json`, not the E2E test ones.

Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary. This way, we should no longer have problems where tests are either run multiple times, or not in the correct env - just add the test to the `browser` list in `ci-unit-tests.ts` to make sure it is not run in multiple node versions unnecessarily. I also added this step to the new package checklist.

🤞 Closes: getsentry#13345

Should reduce amount of cached data.

…ry#13347)

This improves a few things in our size-limit CI action: 1. Show change in bytes, in addition to the change in percentage. 2. Add a link below the table to the base comparison run. 3. If we detect that the workflow run we used as base is not the latest one, show a warning on top. ![image](https://github.com/user-attachments/assets/4678ff04-a463-4579-ad91-74cbf9b7d781)

…etsentry#13338) This streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully). The biggest change is that instead of always building into `dist` for each test file, each test will now build into a random subfolder, e.g. `dist/abc`. This way, multiple tests in a single file will never conflict with each other. Additionally it also streamlines some of the tests I encountered while looking at stuff, hopefully reducing flakes further. Closesgetsentry#13321

Reverts getsentry#13118 There has been quite a bit of segmentation faults in CI after this PR was merged. I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.

relax the pageload transaction assertion. Web vitals are too flaky to hard-assert on them and they are covered in browser integration tests

Minor changes: I realized that the formatting was broken for `v8` and that the migration guide wasn't linking to the specific section like other changelogs.

CI is angery. Crypto is only on global from Node 19 onwards.

This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#13395 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>

Fixes spacing in readme snippet

If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixesgetsentry#9856

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-26T18:28:08Z

Apologies for the mess. Please check out the new PR at #13465

Zen-cronic · 2024-08-13T14:53:40Z

For #13308

Implement genericPool OTL instrumentation in packages/node

Todo:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-15T02:18:50Z

hey @lforst , thanks for assigning to this pr.

This is how I'm currently testing the updated @sentry/node package in node-integration-tests:

yarn build (in root)
yarn yalc:publish (in root)
cd dev-packages/node-integration-tests && yalc add @sentry/node @sentry/utils @sentry/types @sentry/core (according to this guide)

The changes are observed (so it's working!), but yalc generates a .yalc dir and yalc.lock in node-integration-tests that contains the linked packages. But it doesn't seem like the right approach (we can't push those yalc-related to CI).

Is yarn link a more suitable approach (but this also generates yalc.lock)?

…ted (getsentry#13278) [ref](getsentry#12351) This PR moves the `SentryGlobalFilter` out of the root module, which led to the filter overriding user exception filters in certain scenarios. Now there is two ways to setup sentry error monitoring: - If users have no catch-all exception filter in their application they add the `SentryGlobalFilter` as a provider in their main module. - If users have a catch-all exception filter (annotated with `@Catch()` they can use the newly introduced `SentryCaptureException()` decorator to capture alle exceptions caught by this filter. Testing: Added a new sample application to test the second setup option and expanded the test suite in general. Side note: - Also removed the `@sentry/microservices` dependency again, since it does not come out of the box with every nest application so we cannot rely on it.

…ntry#13327)

This streamlines some caching stuff for CI: 1. Extract dependency installation & cache out into a composite action for reusability 2. Updated the cache key for dependencies to only include package & dev-package `package.json`, not the E2E test ones.

Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary. This way, we should no longer have problems where tests are either run multiple times, or not in the correct env - just add the test to the `browser` list in `ci-unit-tests.ts` to make sure it is not run in multiple node versions unnecessarily. I also added this step to the new package checklist.

🤞 Closes: getsentry#13345

Should reduce amount of cached data.

…ry#13347)

This improves a few things in our size-limit CI action: 1. Show change in bytes, in addition to the change in percentage. 2. Add a link below the table to the base comparison run. 3. If we detect that the workflow run we used as base is not the latest one, show a warning on top. ![image](https://github.com/user-attachments/assets/4678ff04-a463-4579-ad91-74cbf9b7d781)

…etsentry#13338) This streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully). The biggest change is that instead of always building into `dist` for each test file, each test will now build into a random subfolder, e.g. `dist/abc`. This way, multiple tests in a single file will never conflict with each other. Additionally it also streamlines some of the tests I encountered while looking at stuff, hopefully reducing flakes further. Closesgetsentry#13321

Reverts getsentry#13118 There has been quite a bit of segmentation faults in CI after this PR was merged. I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.

relax the pageload transaction assertion. Web vitals are too flaky to hard-assert on them and they are covered in browser integration tests

Minor changes: I realized that the formatting was broken for `v8` and that the migration guide wasn't linking to the specific section like other changelogs.

CI is angery. Crypto is only on global from Node 19 onwards.

This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#13395 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>

Fixes spacing in readme snippet

If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixesgetsentry#9856

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-26T18:28:08Z

Apologies for the mess. Please check out the new PR at #13465

Zen-cronic · 2024-08-13T14:53:40Z

For #13308

Implement genericPool OTL instrumentation in packages/node

Todo:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-15T02:18:50Z

hey @lforst , thanks for assigning to this pr.

This is how I'm currently testing the updated @sentry/node package in node-integration-tests:

yarn build (in root)
yarn yalc:publish (in root)
cd dev-packages/node-integration-tests && yalc add @sentry/node @sentry/utils @sentry/types @sentry/core (according to this guide)

The changes are observed (so it's working!), but yalc generates a .yalc dir and yalc.lock in node-integration-tests that contains the linked packages. But it doesn't seem like the right approach (we can't push those yalc-related to CI).

Is yarn link a more suitable approach (but this also generates yalc.lock)?

…ted (getsentry#13278) [ref](getsentry#12351) This PR moves the `SentryGlobalFilter` out of the root module, which led to the filter overriding user exception filters in certain scenarios. Now there is two ways to setup sentry error monitoring: - If users have no catch-all exception filter in their application they add the `SentryGlobalFilter` as a provider in their main module. - If users have a catch-all exception filter (annotated with `@Catch()` they can use the newly introduced `SentryCaptureException()` decorator to capture alle exceptions caught by this filter. Testing: Added a new sample application to test the second setup option and expanded the test suite in general. Side note: - Also removed the `@sentry/microservices` dependency again, since it does not come out of the box with every nest application so we cannot rely on it.

…ntry#13327)

This streamlines some caching stuff for CI: 1. Extract dependency installation & cache out into a composite action for reusability 2. Updated the cache key for dependencies to only include package & dev-package `package.json`, not the E2E test ones.

Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary. This way, we should no longer have problems where tests are either run multiple times, or not in the correct env - just add the test to the `browser` list in `ci-unit-tests.ts` to make sure it is not run in multiple node versions unnecessarily. I also added this step to the new package checklist.

🤞 Closes: getsentry#13345

Should reduce amount of cached data.

…ry#13347)

This improves a few things in our size-limit CI action: 1. Show change in bytes, in addition to the change in percentage. 2. Add a link below the table to the base comparison run. 3. If we detect that the workflow run we used as base is not the latest one, show a warning on top. ![image](https://github.com/user-attachments/assets/4678ff04-a463-4579-ad91-74cbf9b7d781)

…etsentry#13338) This streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully). The biggest change is that instead of always building into `dist` for each test file, each test will now build into a random subfolder, e.g. `dist/abc`. This way, multiple tests in a single file will never conflict with each other. Additionally it also streamlines some of the tests I encountered while looking at stuff, hopefully reducing flakes further. Closesgetsentry#13321

Reverts getsentry#13118 There has been quite a bit of segmentation faults in CI after this PR was merged. I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.

relax the pageload transaction assertion. Web vitals are too flaky to hard-assert on them and they are covered in browser integration tests

Minor changes: I realized that the formatting was broken for `v8` and that the migration guide wasn't linking to the specific section like other changelogs.

CI is angery. Crypto is only on global from Node 19 onwards.

This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#13395 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>

Fixes spacing in readme snippet

If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixesgetsentry#9856

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-26T18:28:08Z

Apologies for the mess. Please check out the new PR at #13465

Zen-cronic · 2024-08-13T14:53:40Z

For #13308

Implement genericPool OTL instrumentation in packages/node

Todo:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-15T02:18:50Z

hey @lforst , thanks for assigning to this pr.

This is how I'm currently testing the updated @sentry/node package in node-integration-tests:

yarn build (in root)
yarn yalc:publish (in root)
cd dev-packages/node-integration-tests && yalc add @sentry/node @sentry/utils @sentry/types @sentry/core (according to this guide)

The changes are observed (so it's working!), but yalc generates a .yalc dir and yalc.lock in node-integration-tests that contains the linked packages. But it doesn't seem like the right approach (we can't push those yalc-related to CI).

Is yarn link a more suitable approach (but this also generates yalc.lock)?

…ted (getsentry#13278) [ref](getsentry#12351) This PR moves the `SentryGlobalFilter` out of the root module, which led to the filter overriding user exception filters in certain scenarios. Now there is two ways to setup sentry error monitoring: - If users have no catch-all exception filter in their application they add the `SentryGlobalFilter` as a provider in their main module. - If users have a catch-all exception filter (annotated with `@Catch()` they can use the newly introduced `SentryCaptureException()` decorator to capture alle exceptions caught by this filter. Testing: Added a new sample application to test the second setup option and expanded the test suite in general. Side note: - Also removed the `@sentry/microservices` dependency again, since it does not come out of the box with every nest application so we cannot rely on it.

…ntry#13327)

This streamlines some caching stuff for CI: 1. Extract dependency installation & cache out into a composite action for reusability 2. Updated the cache key for dependencies to only include package & dev-package `package.json`, not the E2E test ones.

Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary. This way, we should no longer have problems where tests are either run multiple times, or not in the correct env - just add the test to the `browser` list in `ci-unit-tests.ts` to make sure it is not run in multiple node versions unnecessarily. I also added this step to the new package checklist.

🤞 Closes: getsentry#13345

Should reduce amount of cached data.

…ry#13347)

This improves a few things in our size-limit CI action: 1. Show change in bytes, in addition to the change in percentage. 2. Add a link below the table to the base comparison run. 3. If we detect that the workflow run we used as base is not the latest one, show a warning on top. ![image](https://github.com/user-attachments/assets/4678ff04-a463-4579-ad91-74cbf9b7d781)

…etsentry#13338) This streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully). The biggest change is that instead of always building into `dist` for each test file, each test will now build into a random subfolder, e.g. `dist/abc`. This way, multiple tests in a single file will never conflict with each other. Additionally it also streamlines some of the tests I encountered while looking at stuff, hopefully reducing flakes further. Closesgetsentry#13321

Reverts getsentry#13118 There has been quite a bit of segmentation faults in CI after this PR was merged. I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.

relax the pageload transaction assertion. Web vitals are too flaky to hard-assert on them and they are covered in browser integration tests

Minor changes: I realized that the formatting was broken for `v8` and that the migration guide wasn't linking to the specific section like other changelogs.

CI is angery. Crypto is only on global from Node 19 onwards.

This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#13395 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>

Fixes spacing in readme snippet

If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixesgetsentry#9856

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-26T18:28:08Z

Apologies for the mess. Please check out the new PR at #13465

Zen-cronic · 2024-08-13T14:53:40Z

For #13308

Implement genericPool OTL instrumentation in packages/node

Todo:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-15T02:18:50Z

hey @lforst , thanks for assigning to this pr.

This is how I'm currently testing the updated @sentry/node package in node-integration-tests:

yarn build (in root)
yarn yalc:publish (in root)
cd dev-packages/node-integration-tests && yalc add @sentry/node @sentry/utils @sentry/types @sentry/core (according to this guide)

The changes are observed (so it's working!), but yalc generates a .yalc dir and yalc.lock in node-integration-tests that contains the linked packages. But it doesn't seem like the right approach (we can't push those yalc-related to CI).

Is yarn link a more suitable approach (but this also generates yalc.lock)?

…ted (getsentry#13278) [ref](getsentry#12351) This PR moves the `SentryGlobalFilter` out of the root module, which led to the filter overriding user exception filters in certain scenarios. Now there is two ways to setup sentry error monitoring: - If users have no catch-all exception filter in their application they add the `SentryGlobalFilter` as a provider in their main module. - If users have a catch-all exception filter (annotated with `@Catch()` they can use the newly introduced `SentryCaptureException()` decorator to capture alle exceptions caught by this filter. Testing: Added a new sample application to test the second setup option and expanded the test suite in general. Side note: - Also removed the `@sentry/microservices` dependency again, since it does not come out of the box with every nest application so we cannot rely on it.

…ntry#13327)

This streamlines some caching stuff for CI: 1. Extract dependency installation & cache out into a composite action for reusability 2. Updated the cache key for dependencies to only include package & dev-package `package.json`, not the E2E test ones.

Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary. This way, we should no longer have problems where tests are either run multiple times, or not in the correct env - just add the test to the `browser` list in `ci-unit-tests.ts` to make sure it is not run in multiple node versions unnecessarily. I also added this step to the new package checklist.

🤞 Closes: getsentry#13345

Should reduce amount of cached data.

…ry#13347)

This improves a few things in our size-limit CI action: 1. Show change in bytes, in addition to the change in percentage. 2. Add a link below the table to the base comparison run. 3. If we detect that the workflow run we used as base is not the latest one, show a warning on top. ![image](https://github.com/user-attachments/assets/4678ff04-a463-4579-ad91-74cbf9b7d781)

…etsentry#13338) This streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully). The biggest change is that instead of always building into `dist` for each test file, each test will now build into a random subfolder, e.g. `dist/abc`. This way, multiple tests in a single file will never conflict with each other. Additionally it also streamlines some of the tests I encountered while looking at stuff, hopefully reducing flakes further. Closesgetsentry#13321

Reverts getsentry#13118 There has been quite a bit of segmentation faults in CI after this PR was merged. I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.

relax the pageload transaction assertion. Web vitals are too flaky to hard-assert on them and they are covered in browser integration tests

Minor changes: I realized that the formatting was broken for `v8` and that the migration guide wasn't linking to the specific section like other changelogs.

CI is angery. Crypto is only on global from Node 19 onwards.

This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#13395 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>

Fixes spacing in readme snippet

If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixesgetsentry#9856

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-26T18:28:08Z

Apologies for the mess. Please check out the new PR at #13465

Zen-cronic · 2024-08-13T14:53:40Z

For #13308

Implement genericPool OTL instrumentation in packages/node

Todo:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-15T02:18:50Z

hey @lforst , thanks for assigning to this pr.

This is how I'm currently testing the updated @sentry/node package in node-integration-tests:

yarn build (in root)
yarn yalc:publish (in root)
cd dev-packages/node-integration-tests && yalc add @sentry/node @sentry/utils @sentry/types @sentry/core (according to this guide)

The changes are observed (so it's working!), but yalc generates a .yalc dir and yalc.lock in node-integration-tests that contains the linked packages. But it doesn't seem like the right approach (we can't push those yalc-related to CI).

Is yarn link a more suitable approach (but this also generates yalc.lock)?

…ted (getsentry#13278) [ref](getsentry#12351) This PR moves the `SentryGlobalFilter` out of the root module, which led to the filter overriding user exception filters in certain scenarios. Now there is two ways to setup sentry error monitoring: - If users have no catch-all exception filter in their application they add the `SentryGlobalFilter` as a provider in their main module. - If users have a catch-all exception filter (annotated with `@Catch()` they can use the newly introduced `SentryCaptureException()` decorator to capture alle exceptions caught by this filter. Testing: Added a new sample application to test the second setup option and expanded the test suite in general. Side note: - Also removed the `@sentry/microservices` dependency again, since it does not come out of the box with every nest application so we cannot rely on it.

…ntry#13327)

This streamlines some caching stuff for CI: 1. Extract dependency installation & cache out into a composite action for reusability 2. Updated the cache key for dependencies to only include package & dev-package `package.json`, not the E2E test ones.

Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary. This way, we should no longer have problems where tests are either run multiple times, or not in the correct env - just add the test to the `browser` list in `ci-unit-tests.ts` to make sure it is not run in multiple node versions unnecessarily. I also added this step to the new package checklist.

🤞 Closes: getsentry#13345

Should reduce amount of cached data.

…ry#13347)

This improves a few things in our size-limit CI action: 1. Show change in bytes, in addition to the change in percentage. 2. Add a link below the table to the base comparison run. 3. If we detect that the workflow run we used as base is not the latest one, show a warning on top. ![image](https://github.com/user-attachments/assets/4678ff04-a463-4579-ad91-74cbf9b7d781)

…etsentry#13338) This streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully). The biggest change is that instead of always building into `dist` for each test file, each test will now build into a random subfolder, e.g. `dist/abc`. This way, multiple tests in a single file will never conflict with each other. Additionally it also streamlines some of the tests I encountered while looking at stuff, hopefully reducing flakes further. Closesgetsentry#13321

Reverts getsentry#13118 There has been quite a bit of segmentation faults in CI after this PR was merged. I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.

relax the pageload transaction assertion. Web vitals are too flaky to hard-assert on them and they are covered in browser integration tests

Minor changes: I realized that the formatting was broken for `v8` and that the migration guide wasn't linking to the specific section like other changelogs.

CI is angery. Crypto is only on global from Node 19 onwards.

This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#13395 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>

Fixes spacing in readme snippet

If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixesgetsentry#9856

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-26T18:28:08Z

Apologies for the mess. Please check out the new PR at #13465

Zen-cronic · 2024-08-13T14:53:40Z

For #13308

Implement genericPool OTL instrumentation in packages/node

Todo:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-15T02:18:50Z

hey @lforst , thanks for assigning to this pr.

This is how I'm currently testing the updated @sentry/node package in node-integration-tests:

yarn build (in root)
yarn yalc:publish (in root)
cd dev-packages/node-integration-tests && yalc add @sentry/node @sentry/utils @sentry/types @sentry/core (according to this guide)

The changes are observed (so it's working!), but yalc generates a .yalc dir and yalc.lock in node-integration-tests that contains the linked packages. But it doesn't seem like the right approach (we can't push those yalc-related to CI).

Is yarn link a more suitable approach (but this also generates yalc.lock)?

…ted (getsentry#13278) [ref](getsentry#12351) This PR moves the `SentryGlobalFilter` out of the root module, which led to the filter overriding user exception filters in certain scenarios. Now there is two ways to setup sentry error monitoring: - If users have no catch-all exception filter in their application they add the `SentryGlobalFilter` as a provider in their main module. - If users have a catch-all exception filter (annotated with `@Catch()` they can use the newly introduced `SentryCaptureException()` decorator to capture alle exceptions caught by this filter. Testing: Added a new sample application to test the second setup option and expanded the test suite in general. Side note: - Also removed the `@sentry/microservices` dependency again, since it does not come out of the box with every nest application so we cannot rely on it.

…ntry#13327)

This streamlines some caching stuff for CI: 1. Extract dependency installation & cache out into a composite action for reusability 2. Updated the cache key for dependencies to only include package & dev-package `package.json`, not the E2E test ones.

Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary. This way, we should no longer have problems where tests are either run multiple times, or not in the correct env - just add the test to the `browser` list in `ci-unit-tests.ts` to make sure it is not run in multiple node versions unnecessarily. I also added this step to the new package checklist.

🤞 Closes: getsentry#13345

Should reduce amount of cached data.

…ry#13347)

This improves a few things in our size-limit CI action: 1. Show change in bytes, in addition to the change in percentage. 2. Add a link below the table to the base comparison run. 3. If we detect that the workflow run we used as base is not the latest one, show a warning on top. ![image](https://github.com/user-attachments/assets/4678ff04-a463-4579-ad91-74cbf9b7d781)

…etsentry#13338) This streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully). The biggest change is that instead of always building into `dist` for each test file, each test will now build into a random subfolder, e.g. `dist/abc`. This way, multiple tests in a single file will never conflict with each other. Additionally it also streamlines some of the tests I encountered while looking at stuff, hopefully reducing flakes further. Closesgetsentry#13321

Reverts getsentry#13118 There has been quite a bit of segmentation faults in CI after this PR was merged. I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.

relax the pageload transaction assertion. Web vitals are too flaky to hard-assert on them and they are covered in browser integration tests

Minor changes: I realized that the formatting was broken for `v8` and that the migration guide wasn't linking to the specific section like other changelogs.

CI is angery. Crypto is only on global from Node 19 onwards.

This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#13395 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>

Fixes spacing in readme snippet

If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixesgetsentry#9856

…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic · 2024-08-26T18:28:08Z

Apologies for the mess. Please check out the new PR at #13465

Zen-cronicand others added 3 commits August 13, 2024 10:47

feat(node): add genericPool integration using opentelemetry instrumen…
1adaaac
…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Merge branch 'develop' into feat/genericPoolIntegration-node
11b6ffe

feat(node): Add genericPool integration using opentelemetry instrumen…
69f52db
…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

lforst self-assigned this Aug 14, 2024

nicohrubecand others added 23 commits August 26, 2024 13:37

feat(deps): bump @prisma/instrumentation from 5.17.0 to 5.18.0 (getse…
c0239b1
…ntry#13327)

meta: Update Changelog for 8.26.0
6d5c5c6

release: 8.26.0
c1a775b

fix(solidstart): Make back navigation test less flaky (getsentry#13374)
94ad46a
🤞 Closes: getsentry#13345

ci: Only store playwright cache on develop (getsentry#13358)
5e26092
Should reduce amount of cached data.

feat: Add options for passing nonces to feedback integration (getsent…
d4c7a09
…ry#13347)

fix(deno): Don't rely onDeno.permissions.querySync(getsentry#13378)
46988f3

test(e2e): Fix flake in default browser e2e test (getsentry#13379)
7c6d97f
relax the pageload transaction assertion. Web vitals are too flaky to hard-assert on them and they are covered in browser integration tests

test(e2e): Add Astro 4 E2E test app (getsentry#13375)
6dbffe8

docs: Fix v7 changelog format and link (getsentry#13395)
2f11b7e
Minor changes: I realized that the formatting was broken for `v8` and that the migration guide wasn't linking to the specific section like other changelogs.

ci: Fix crypto not being available (getsentry#13385)
a7aa35c
CI is angery. Crypto is only on global from Node 19 onwards.

ref: Add external contributor to CHANGELOG.md (getsentry#13400)
ba9a704
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See getsentry#13395 Co-authored-by: mydea <2411343+mydea@users.noreply.github.com>

docs(cloudflare): Fix spacing in README snippet (getsentry#13368)
0d3d2a1
Fixes spacing in readme snippet

feat(feedback): Improve error message for 403 errors (getsentry#13441)
fba8cc7
If the domain is not in `Allowed Domains` in the Sentry project settings, it would cause a 403 error. The default setting is `*` so this only occurs when the user changes these settings. Fixesgetsentry#9856

feat(node): add genericPool integration using opentelemetry instrumen…
f1182d3
…tation Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

feat(node): Add genericPool integration using opentelemetry instrumen…
43c40f8
…tation Set up initial code and include this instrumentation as a default integration. Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

test(node): Add tests for genericPoolIntegration
37cc42e
Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>

Zen-cronic closed this Aug 26, 2024

lforst removed their assignment Aug 28, 2024