Uh oh!
There was an error while loading. Please reload this page.
fix(node): Don't overwrite local variables for re-thrown errors - #13644
Merged
Conversation
Comment on lines
+121
to
+123
| functionDeclaration: `function() { this.${LOCAL_VARIABLES_KEY} = this.${LOCAL_VARIABLES_KEY} || ${JSON.stringify( | ||
| frames, | ||
| )}; }`, |
Check warning
Code scanning / CodeQL
Improper code sanitization
Contributor
size-limit report 📦
|
timfish
marked this pull request as draft
September 10, 2024 10:10
Comment on lines
+161
to
+164
| async _ => { | ||
| if (isPaused) { | ||
| await session.post('Debugger.resume'); | ||
| } |
There was a problem hiding this comment.
good idea to add some more resiliency.
Comment on lines
+121
to
+123
| functionDeclaration: `function() { this.${LOCAL_VARIABLES_KEY} = this.${LOCAL_VARIABLES_KEY} || ${JSON.stringify( | ||
| frames, | ||
| )}; }`, |
There was a problem hiding this comment.
I love how simple this change is now after the redesign.
CollaboratorAuthor
There was a problem hiding this comment.
Shame it doesn't appear to work now I'm adding a test for it!
CollaboratorAuthor
There was a problem hiding this comment.
Ah no, I forgot the recent changes only fix this issue in Node v20+ 🤦🏻♂️
timfish
marked this pull request as ready for review
September 10, 2024 10:41
AbhiPrasad
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#13416
Another way to fix this issue would be to check via the debugger if the property exists already on the error object and bail early before we have local variables. However, this would add an extra round trip call via the debugger for every error. Since re-thrown errors are far less likely, I decided instead to just not overwrite existing local variables.
This PR also adds a
Debugger.resumecall in the catch case to ensure that they debugger will always resume even if we get errors while debugging.It's worth noting that this only fixes the issue in Node v20+ where we use the async debugging interface.