Uh oh!
There was an error while loading. Please reload this page.
meta: Update CHANGELOG for 8.30.0 - #13648
Merged
Merged
Conversation
meta(changelog): Update changelog for 8.29.0
…cing (#13485) This PR migrates the `nativeNodeFetchIntegration` to use `@opentelemetry/instrumentation-undici` instead of `opentelemetry-instrumentation-fetch-node`. The instrumentation is still exported as `nativeNodeFetchIntegration` and is named `NodeFetch` to ensure backwards compatibility and the tests pass ~~without changes~~. Note: One `nextjs-14` e2e test did need a change due to the new/differing attribute names. It's worth noting that `@opentelemetry/instrumentation-undici` [uses different attributes](open-telemetry/opentelemetry-js-contrib#2417 (comment)) from the latest semantic convention version vs what we are using and what's used by `opentelemetry-instrumentation-fetch-node`. It looks like the [http instrumentation is migrating to these too](open-telemetry/opentelemetry-js#4940) so some of the changes in this PR will ensure that the http instrumentation continues to work after these updates.
…r without `<>` (#13543) Ensure that the component names listed in the `trackComponent` option match regardless of if they were specified as `<Name>` or `Name`. Add unit and e2e tests for component tracking. --------- Signed-off-by: Kaung Zin Hein <kaungzinhein113@gmail.com>
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13543 Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
Changes the rate-limiting tests to use fake timers. This takes the test time from 24s to 4s.
[Gitflow] Merge master into develop
> This is a draft PR as this approach leads to an error as `hook.mjs` is not included in the `node_modules`. This has been fixed upstream but was not yet released for nuxt. Makes it possible to include a `sentry.server.config.ts` file in the root folder alongside `sentry.client.config.ts`. Currently, it has to be added in the `public` folder which is not 100% ideal.
While working on updating [`sentry-javascript-bundler-plugins` to use v8 of the JavaScript SDK](getsentry/sentry-javascript-bundler-plugins#579), I found that I was unable to set measurements as the global client is not used. If you're not using a global client, there is currently no way to add measurements because `Sentry.setMeasurement()` relies on `getActiveSpan()` which in turn relies on `getCurrentScope()`. This PR moves the `activeSpan` into the last parameter which defaults to `getActiveSpan()`.
…13541) `PerformanceObserver` is available on iOS 11 and later, but the `supportedEntryTypes` method is available on iOS 13 and later. ref: https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver Therefore, a runtime error will occur if we use Sentry on iOS 11 or iOS 12.
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13541 Co-authored-by: AbhiPrasad <18689448+AbhiPrasad@users.noreply.github.com>
…t and opentelemetry (#13640) Looks like we overlooked two packages when updating deps previously in #13587. See: #13587 (comment)Closes: #13219
I failed to update the description in my PR when we improved the property name after some discussion in the PR, so the wrong property name was used in the changelog: https://github.com/getsentry/sentry-javascript/blob/bcf571d9954094be76a99edbb12c23eff7f7b5dc/packages/node/src/types.ts#L20 Thanks to @torickjdavis for reporting this [here](#12414 (comment))!
The shims should only be applied if the globals are not present, else it results in double decl and a runtime error. The profiling SDK should gracefully handle env where the shims are already provided. I couldn't find a way to modify the shim as it is hardcoded in the plugin we are using so I went with the replace plugin approach and a placeholder value #poormansmacros.
…ariables to exceptions (#13501) Closes#13415 This PR only modifies the async version of this integration which is used for Node > v19. I tried applying similar changes to the sync integration and I cannot get it to work without causing memory leaks. @bruno-dasilva has been helping me explore different ways to fix a few fundamental issues with the local variables integration. Bruno found a way to [write to the error object](#13415 (comment)) from the debugger which removes any ambiguity over which variables go with which exception. This allows us to remove the stack parsing and hashing which we were using previously to match up exceptions. Rather than write the `objectId` to the error, I have used this to write the entire local variables array directly to the error object. This completely negates the need to post the local variables from the worker thread which removes any possibility of race conditions. We then later pull the local variables directly from `hint.originalException.__SENTRY_ERROR_LOCAL_VARIABLES__`.
On app router, transactions like `GET /404` get created that we don't like.
…3631) resolves#13627 In 1.26.0 otel-js has updated the deprecations for the attributes based on the new changes to semantic conventions. They also changed the name of some exports, for example: `SEMATTRS_HTTP_ROUTE` -> `ATTR_HTTP_ROUTE`. Some exports names were not able to be changed because they are imported from a subpath export @opentelemetry/semantic-conventions/incubating. This subpath breaks some bundling setups, so we are unable to use it.
AbhiPrasad
requested review from
andreiborza, lforst and mydea
and removed request for
a teamSeptember 10, 2024 11:59
mydea
reviewed
Sep 10, 2024
Uh oh!
There was an error while loading. Please reload this page.
mydea
reviewed
Sep 10, 2024
Uh oh!
There was an error while loading. Please reload this page.
AbhiPrasadforce-pushed
the
prepare-release/8.30.0
branch
from
September 10, 2024 12:36
b4d9e70 to
221ffebCompareAbhiPrasad
commented
Sep 10, 2024
ContributorAuthor
Woops - good catch @mydea on the missing parts. Updated and also changed branch to point at |
mydea
approved these changes
Sep 10, 2024
AbhiPrasad
commented
Sep 10, 2024
ContributorAuthor
waiting on #13649 |
Fix a bug in the initial experimental CLS standalone span implementation. Previously we'd add the CLS start timestamp value in ms to the performance time origin timestamp which was already converted to seconds. Ensure that we first add time origin and the CLS start timestamp and then convert to seconds --------- Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Follow up to #13608, after some tweaks and a rebase! * When a PR is opened in draft mode, move to "In Progress" on the board * When a PR is opened for review, move to "In Review" on the board * When a PR is closed but not merged, move it directly to "Done" (instead of "Ready for Release") Note that for now, this only applies to PRs that are on the board themselves, not to PRs linked to an issue.
AbhiPrasadforce-pushed
the
prepare-release/8.30.0
branch
from
September 10, 2024 13:12
221ffeb to
aba68f7CompareAbhiPrasad
commented
Sep 10, 2024
ContributorAuthor
updated branch to include a2d1b2c |
Lms24
approved these changes
Sep 10, 2024
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves#13646
Getting a new release out so we can fix some of the peer dep issues with installing the SDK.