feat(browser): Add `graphqlClientIntegration` by Zen-cronic · Pull Request #13783 · getsentry/sentry-javascript

Zen-cronic · 2024-09-25T02:39:03Z

Resolves#13399

Todo:

~~Support fetch spans and tests~~
~~Support graphql queries without a name~~
~~Enhance breadcrumb data~~

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Zen-cronic · 2024-09-26T16:07:17Z

~~Todo: fix failing fetch tests by removing body from non-graphql requests~~

Zen-cronic · 2024-10-18T00:46:23Z

Just wanted to inform about the failing tests:

size limit exceeded by 3 bytes! (CDN Bundle (incl. Tracing, Replay))
all the playwright tests related to bundle (e.g., bundle_min, bundle_replay) have been failing with a timeout

mydea

I finally found the time to review this in depth. Overall, I really like it, I left some comments with requests for changes. Mostly it is about moving stuff around, and avoiding any graphql-specific code in the "general" places. Also, please note that if you rebase this in develop, there are/will be a bunch of conflicts - this is mostly because the utils package is deprecated and all that code was moved to core.

Zen-cronic · 2024-12-20T03:54:07Z

noted, i'll implement the feedback. thanks for the comprehensive review!

update span hook
update breadcrumb hook
resolve rebase conflicts

will move on with the conflicts if the current implementation checks out

billyvg · 2025-01-07T16:41:34Z

@@ -0,0 +1,121 @@
+import { SENTRY_XHR_DATA_KEY } from '@sentry-internal/browser-utils';
+import { getBodyString } from '@sentry-internal/replay';


@mydea should this util be in the replay package?

if we use/need it here, I would move it to @sentry-internal/browser-utils, and use it from there both in replay and here!

otherwise, this will lead to circular dependency issues :)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

…n-cronic/sentry-javascript into feat/graphqlClientIntegration

mydea · 2025-02-05T08:59:05Z

I can't push changes on your branch, so I opened a PR here: Zen-cronic#1 which should fix the remaining CI issues on your branch!

…y#15265) Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the `(before|after)Update` hooks to track component update spans. For v9, this patch therefore disables update tracking by default.

Removes a no longer necessary fallback check that we only needed in SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the `event.isSubRequest` flag to identify sub vs. actual requests in our request handler. fixesgetsentry#15244

…ntry#15277)

…try#15282) - adds a toolbar for cropping and annotations - changes from inline styles to multiple class names in BEM format With annotation option: ![Screenshot 2025-02-03 at 3 51 04 PM](https://github.com/user-attachments/assets/97e4ac38-4926-49e5-a6f3-d474174e3c38) Without annotation option (to confirm that it looks the same as before): ![Screenshot 2025-02-03 at 5 09 01 PM](https://github.com/user-attachments/assets/8b614c38-3c1b-4d7e-986e-ead86a3f4349) Closesgetsentry#15252

…etsentry#15288) The debugging ability for Azure Functions when using Azure Static Web Apps is very limited. But as I could see some Sentry-related logs I **think** Sentry is generally initialized. However, server-related logs don't show up in Sentry. This is **probably** because the Azure Function finishes before the error can be sent to Sentry. By adding the Azure environment variable to check whether we should flush with a timeout, this should possibly fix the issue. Logs in Application Insights: ![image](https://github.com/user-attachments/assets/ed5ccd37-be87-4338-946b-94ec543e08c5)

mydea

left two more comments, where we should use the passed in logger instance - other than, this this is ready to go 🚀 thanks for the work, this was a tricky one but it turned out pretty great! (also needs a rebase, there is one small conflict)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

Zen-cronic · 2025-02-06T14:35:38Z

all resolved now!

## DESCRIBE YOUR PR Documents PR getsentry/sentry-javascript#13783 mentioned in issue getsentry/sentry-javascript#13399closes#13800 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)

Zen-cronic · 2024-09-25T02:39:03Z

Resolves#13399

Todo:

~~Support fetch spans and tests~~
~~Support graphql queries without a name~~
~~Enhance breadcrumb data~~

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Zen-cronic · 2024-09-26T16:07:17Z

~~Todo: fix failing fetch tests by removing body from non-graphql requests~~

Zen-cronic · 2024-10-18T00:46:23Z

Just wanted to inform about the failing tests:

size limit exceeded by 3 bytes! (CDN Bundle (incl. Tracing, Replay))
all the playwright tests related to bundle (e.g., bundle_min, bundle_replay) have been failing with a timeout

mydea

I finally found the time to review this in depth. Overall, I really like it, I left some comments with requests for changes. Mostly it is about moving stuff around, and avoiding any graphql-specific code in the "general" places. Also, please note that if you rebase this in develop, there are/will be a bunch of conflicts - this is mostly because the utils package is deprecated and all that code was moved to core.

Zen-cronic · 2024-12-20T03:54:07Z

noted, i'll implement the feedback. thanks for the comprehensive review!

update span hook
update breadcrumb hook
resolve rebase conflicts

will move on with the conflicts if the current implementation checks out

billyvg · 2025-01-07T16:41:34Z

@@ -0,0 +1,121 @@
+import { SENTRY_XHR_DATA_KEY } from '@sentry-internal/browser-utils';
+import { getBodyString } from '@sentry-internal/replay';


@mydea should this util be in the replay package?

if we use/need it here, I would move it to @sentry-internal/browser-utils, and use it from there both in replay and here!

otherwise, this will lead to circular dependency issues :)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

…n-cronic/sentry-javascript into feat/graphqlClientIntegration

mydea · 2025-02-05T08:59:05Z

I can't push changes on your branch, so I opened a PR here: Zen-cronic#1 which should fix the remaining CI issues on your branch!

…y#15265) Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the `(before|after)Update` hooks to track component update spans. For v9, this patch therefore disables update tracking by default.

Removes a no longer necessary fallback check that we only needed in SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the `event.isSubRequest` flag to identify sub vs. actual requests in our request handler. fixesgetsentry#15244

…ntry#15277)

…try#15282) - adds a toolbar for cropping and annotations - changes from inline styles to multiple class names in BEM format With annotation option: ![Screenshot 2025-02-03 at 3 51 04 PM](https://github.com/user-attachments/assets/97e4ac38-4926-49e5-a6f3-d474174e3c38) Without annotation option (to confirm that it looks the same as before): ![Screenshot 2025-02-03 at 5 09 01 PM](https://github.com/user-attachments/assets/8b614c38-3c1b-4d7e-986e-ead86a3f4349) Closesgetsentry#15252

…etsentry#15288) The debugging ability for Azure Functions when using Azure Static Web Apps is very limited. But as I could see some Sentry-related logs I **think** Sentry is generally initialized. However, server-related logs don't show up in Sentry. This is **probably** because the Azure Function finishes before the error can be sent to Sentry. By adding the Azure environment variable to check whether we should flush with a timeout, this should possibly fix the issue. Logs in Application Insights: ![image](https://github.com/user-attachments/assets/ed5ccd37-be87-4338-946b-94ec543e08c5)

mydea

left two more comments, where we should use the passed in logger instance - other than, this this is ready to go 🚀 thanks for the work, this was a tricky one but it turned out pretty great! (also needs a rebase, there is one small conflict)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

Zen-cronic · 2025-02-06T14:35:38Z

all resolved now!

## DESCRIBE YOUR PR Documents PR getsentry/sentry-javascript#13783 mentioned in issue getsentry/sentry-javascript#13399closes#13800 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)

Zen-cronic · 2024-09-25T02:39:03Z

Resolves#13399

Todo:

~~Support fetch spans and tests~~
~~Support graphql queries without a name~~
~~Enhance breadcrumb data~~

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Zen-cronic · 2024-09-26T16:07:17Z

~~Todo: fix failing fetch tests by removing body from non-graphql requests~~

Zen-cronic · 2024-10-18T00:46:23Z

Just wanted to inform about the failing tests:

size limit exceeded by 3 bytes! (CDN Bundle (incl. Tracing, Replay))
all the playwright tests related to bundle (e.g., bundle_min, bundle_replay) have been failing with a timeout

mydea

I finally found the time to review this in depth. Overall, I really like it, I left some comments with requests for changes. Mostly it is about moving stuff around, and avoiding any graphql-specific code in the "general" places. Also, please note that if you rebase this in develop, there are/will be a bunch of conflicts - this is mostly because the utils package is deprecated and all that code was moved to core.

Zen-cronic · 2024-12-20T03:54:07Z

noted, i'll implement the feedback. thanks for the comprehensive review!

update span hook
update breadcrumb hook
resolve rebase conflicts

will move on with the conflicts if the current implementation checks out

billyvg · 2025-01-07T16:41:34Z

@@ -0,0 +1,121 @@
+import { SENTRY_XHR_DATA_KEY } from '@sentry-internal/browser-utils';
+import { getBodyString } from '@sentry-internal/replay';


@mydea should this util be in the replay package?

if we use/need it here, I would move it to @sentry-internal/browser-utils, and use it from there both in replay and here!

otherwise, this will lead to circular dependency issues :)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

…n-cronic/sentry-javascript into feat/graphqlClientIntegration

mydea · 2025-02-05T08:59:05Z

I can't push changes on your branch, so I opened a PR here: Zen-cronic#1 which should fix the remaining CI issues on your branch!

…y#15265) Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the `(before|after)Update` hooks to track component update spans. For v9, this patch therefore disables update tracking by default.

Removes a no longer necessary fallback check that we only needed in SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the `event.isSubRequest` flag to identify sub vs. actual requests in our request handler. fixesgetsentry#15244

…ntry#15277)

…try#15282) - adds a toolbar for cropping and annotations - changes from inline styles to multiple class names in BEM format With annotation option: ![Screenshot 2025-02-03 at 3 51 04 PM](https://github.com/user-attachments/assets/97e4ac38-4926-49e5-a6f3-d474174e3c38) Without annotation option (to confirm that it looks the same as before): ![Screenshot 2025-02-03 at 5 09 01 PM](https://github.com/user-attachments/assets/8b614c38-3c1b-4d7e-986e-ead86a3f4349) Closesgetsentry#15252

…etsentry#15288) The debugging ability for Azure Functions when using Azure Static Web Apps is very limited. But as I could see some Sentry-related logs I **think** Sentry is generally initialized. However, server-related logs don't show up in Sentry. This is **probably** because the Azure Function finishes before the error can be sent to Sentry. By adding the Azure environment variable to check whether we should flush with a timeout, this should possibly fix the issue. Logs in Application Insights: ![image](https://github.com/user-attachments/assets/ed5ccd37-be87-4338-946b-94ec543e08c5)

mydea

left two more comments, where we should use the passed in logger instance - other than, this this is ready to go 🚀 thanks for the work, this was a tricky one but it turned out pretty great! (also needs a rebase, there is one small conflict)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

Zen-cronic · 2025-02-06T14:35:38Z

all resolved now!

## DESCRIBE YOUR PR Documents PR getsentry/sentry-javascript#13783 mentioned in issue getsentry/sentry-javascript#13399closes#13800 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)

Zen-cronic · 2024-09-25T02:39:03Z

Resolves#13399

Todo:

~~Support fetch spans and tests~~
~~Support graphql queries without a name~~
~~Enhance breadcrumb data~~

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Zen-cronic · 2024-09-26T16:07:17Z

~~Todo: fix failing fetch tests by removing body from non-graphql requests~~

Zen-cronic · 2024-10-18T00:46:23Z

Just wanted to inform about the failing tests:

size limit exceeded by 3 bytes! (CDN Bundle (incl. Tracing, Replay))
all the playwright tests related to bundle (e.g., bundle_min, bundle_replay) have been failing with a timeout

mydea

I finally found the time to review this in depth. Overall, I really like it, I left some comments with requests for changes. Mostly it is about moving stuff around, and avoiding any graphql-specific code in the "general" places. Also, please note that if you rebase this in develop, there are/will be a bunch of conflicts - this is mostly because the utils package is deprecated and all that code was moved to core.

Zen-cronic · 2024-12-20T03:54:07Z

noted, i'll implement the feedback. thanks for the comprehensive review!

update span hook
update breadcrumb hook
resolve rebase conflicts

will move on with the conflicts if the current implementation checks out

billyvg · 2025-01-07T16:41:34Z

@@ -0,0 +1,121 @@
+import { SENTRY_XHR_DATA_KEY } from '@sentry-internal/browser-utils';
+import { getBodyString } from '@sentry-internal/replay';


@mydea should this util be in the replay package?

if we use/need it here, I would move it to @sentry-internal/browser-utils, and use it from there both in replay and here!

otherwise, this will lead to circular dependency issues :)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

…n-cronic/sentry-javascript into feat/graphqlClientIntegration

mydea · 2025-02-05T08:59:05Z

I can't push changes on your branch, so I opened a PR here: Zen-cronic#1 which should fix the remaining CI issues on your branch!

…y#15265) Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the `(before|after)Update` hooks to track component update spans. For v9, this patch therefore disables update tracking by default.

Removes a no longer necessary fallback check that we only needed in SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the `event.isSubRequest` flag to identify sub vs. actual requests in our request handler. fixesgetsentry#15244

…ntry#15277)

…try#15282) - adds a toolbar for cropping and annotations - changes from inline styles to multiple class names in BEM format With annotation option: ![Screenshot 2025-02-03 at 3 51 04 PM](https://github.com/user-attachments/assets/97e4ac38-4926-49e5-a6f3-d474174e3c38) Without annotation option (to confirm that it looks the same as before): ![Screenshot 2025-02-03 at 5 09 01 PM](https://github.com/user-attachments/assets/8b614c38-3c1b-4d7e-986e-ead86a3f4349) Closesgetsentry#15252

…etsentry#15288) The debugging ability for Azure Functions when using Azure Static Web Apps is very limited. But as I could see some Sentry-related logs I **think** Sentry is generally initialized. However, server-related logs don't show up in Sentry. This is **probably** because the Azure Function finishes before the error can be sent to Sentry. By adding the Azure environment variable to check whether we should flush with a timeout, this should possibly fix the issue. Logs in Application Insights: ![image](https://github.com/user-attachments/assets/ed5ccd37-be87-4338-946b-94ec543e08c5)

mydea

left two more comments, where we should use the passed in logger instance - other than, this this is ready to go 🚀 thanks for the work, this was a tricky one but it turned out pretty great! (also needs a rebase, there is one small conflict)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

Zen-cronic · 2025-02-06T14:35:38Z

all resolved now!

## DESCRIBE YOUR PR Documents PR getsentry/sentry-javascript#13783 mentioned in issue getsentry/sentry-javascript#13399closes#13800 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)

Zen-cronic · 2024-09-25T02:39:03Z

Resolves#13399

Todo:

~~Support fetch spans and tests~~
~~Support graphql queries without a name~~
~~Enhance breadcrumb data~~

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Zen-cronic · 2024-09-26T16:07:17Z

~~Todo: fix failing fetch tests by removing body from non-graphql requests~~

Zen-cronic · 2024-10-18T00:46:23Z

Just wanted to inform about the failing tests:

size limit exceeded by 3 bytes! (CDN Bundle (incl. Tracing, Replay))
all the playwright tests related to bundle (e.g., bundle_min, bundle_replay) have been failing with a timeout

mydea

I finally found the time to review this in depth. Overall, I really like it, I left some comments with requests for changes. Mostly it is about moving stuff around, and avoiding any graphql-specific code in the "general" places. Also, please note that if you rebase this in develop, there are/will be a bunch of conflicts - this is mostly because the utils package is deprecated and all that code was moved to core.

Zen-cronic · 2024-12-20T03:54:07Z

noted, i'll implement the feedback. thanks for the comprehensive review!

update span hook
update breadcrumb hook
resolve rebase conflicts

will move on with the conflicts if the current implementation checks out

billyvg · 2025-01-07T16:41:34Z

@@ -0,0 +1,121 @@
+import { SENTRY_XHR_DATA_KEY } from '@sentry-internal/browser-utils';
+import { getBodyString } from '@sentry-internal/replay';


@mydea should this util be in the replay package?

if we use/need it here, I would move it to @sentry-internal/browser-utils, and use it from there both in replay and here!

otherwise, this will lead to circular dependency issues :)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

…n-cronic/sentry-javascript into feat/graphqlClientIntegration

mydea · 2025-02-05T08:59:05Z

I can't push changes on your branch, so I opened a PR here: Zen-cronic#1 which should fix the remaining CI issues on your branch!

…y#15265) Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the `(before|after)Update` hooks to track component update spans. For v9, this patch therefore disables update tracking by default.

Removes a no longer necessary fallback check that we only needed in SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the `event.isSubRequest` flag to identify sub vs. actual requests in our request handler. fixesgetsentry#15244

…ntry#15277)

…try#15282) - adds a toolbar for cropping and annotations - changes from inline styles to multiple class names in BEM format With annotation option: ![Screenshot 2025-02-03 at 3 51 04 PM](https://github.com/user-attachments/assets/97e4ac38-4926-49e5-a6f3-d474174e3c38) Without annotation option (to confirm that it looks the same as before): ![Screenshot 2025-02-03 at 5 09 01 PM](https://github.com/user-attachments/assets/8b614c38-3c1b-4d7e-986e-ead86a3f4349) Closesgetsentry#15252

…etsentry#15288) The debugging ability for Azure Functions when using Azure Static Web Apps is very limited. But as I could see some Sentry-related logs I **think** Sentry is generally initialized. However, server-related logs don't show up in Sentry. This is **probably** because the Azure Function finishes before the error can be sent to Sentry. By adding the Azure environment variable to check whether we should flush with a timeout, this should possibly fix the issue. Logs in Application Insights: ![image](https://github.com/user-attachments/assets/ed5ccd37-be87-4338-946b-94ec543e08c5)

mydea

left two more comments, where we should use the passed in logger instance - other than, this this is ready to go 🚀 thanks for the work, this was a tricky one but it turned out pretty great! (also needs a rebase, there is one small conflict)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

Zen-cronic · 2025-02-06T14:35:38Z

all resolved now!

## DESCRIBE YOUR PR Documents PR getsentry/sentry-javascript#13783 mentioned in issue getsentry/sentry-javascript#13399closes#13800 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)

Zen-cronic · 2024-09-25T02:39:03Z

Resolves#13399

Todo:

~~Support fetch spans and tests~~
~~Support graphql queries without a name~~
~~Enhance breadcrumb data~~

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Zen-cronic · 2024-09-26T16:07:17Z

~~Todo: fix failing fetch tests by removing body from non-graphql requests~~

Zen-cronic · 2024-10-18T00:46:23Z

Just wanted to inform about the failing tests:

size limit exceeded by 3 bytes! (CDN Bundle (incl. Tracing, Replay))
all the playwright tests related to bundle (e.g., bundle_min, bundle_replay) have been failing with a timeout

mydea

I finally found the time to review this in depth. Overall, I really like it, I left some comments with requests for changes. Mostly it is about moving stuff around, and avoiding any graphql-specific code in the "general" places. Also, please note that if you rebase this in develop, there are/will be a bunch of conflicts - this is mostly because the utils package is deprecated and all that code was moved to core.

Zen-cronic · 2024-12-20T03:54:07Z

noted, i'll implement the feedback. thanks for the comprehensive review!

update span hook
update breadcrumb hook
resolve rebase conflicts

will move on with the conflicts if the current implementation checks out

billyvg · 2025-01-07T16:41:34Z

@@ -0,0 +1,121 @@
+import { SENTRY_XHR_DATA_KEY } from '@sentry-internal/browser-utils';
+import { getBodyString } from '@sentry-internal/replay';


@mydea should this util be in the replay package?

if we use/need it here, I would move it to @sentry-internal/browser-utils, and use it from there both in replay and here!

otherwise, this will lead to circular dependency issues :)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

…n-cronic/sentry-javascript into feat/graphqlClientIntegration

mydea · 2025-02-05T08:59:05Z

I can't push changes on your branch, so I opened a PR here: Zen-cronic#1 which should fix the remaining CI issues on your branch!

…y#15265) Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the `(before|after)Update` hooks to track component update spans. For v9, this patch therefore disables update tracking by default.

Removes a no longer necessary fallback check that we only needed in SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the `event.isSubRequest` flag to identify sub vs. actual requests in our request handler. fixesgetsentry#15244

…ntry#15277)

…try#15282) - adds a toolbar for cropping and annotations - changes from inline styles to multiple class names in BEM format With annotation option: ![Screenshot 2025-02-03 at 3 51 04 PM](https://github.com/user-attachments/assets/97e4ac38-4926-49e5-a6f3-d474174e3c38) Without annotation option (to confirm that it looks the same as before): ![Screenshot 2025-02-03 at 5 09 01 PM](https://github.com/user-attachments/assets/8b614c38-3c1b-4d7e-986e-ead86a3f4349) Closesgetsentry#15252

…etsentry#15288) The debugging ability for Azure Functions when using Azure Static Web Apps is very limited. But as I could see some Sentry-related logs I **think** Sentry is generally initialized. However, server-related logs don't show up in Sentry. This is **probably** because the Azure Function finishes before the error can be sent to Sentry. By adding the Azure environment variable to check whether we should flush with a timeout, this should possibly fix the issue. Logs in Application Insights: ![image](https://github.com/user-attachments/assets/ed5ccd37-be87-4338-946b-94ec543e08c5)

mydea

left two more comments, where we should use the passed in logger instance - other than, this this is ready to go 🚀 thanks for the work, this was a tricky one but it turned out pretty great! (also needs a rebase, there is one small conflict)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

Zen-cronic · 2025-02-06T14:35:38Z

all resolved now!

## DESCRIBE YOUR PR Documents PR getsentry/sentry-javascript#13783 mentioned in issue getsentry/sentry-javascript#13399closes#13800 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)

Zen-cronic · 2024-09-25T02:39:03Z

Resolves#13399

Todo:

~~Support fetch spans and tests~~
~~Support graphql queries without a name~~
~~Enhance breadcrumb data~~

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Zen-cronic · 2024-09-26T16:07:17Z

~~Todo: fix failing fetch tests by removing body from non-graphql requests~~

Zen-cronic · 2024-10-18T00:46:23Z

Just wanted to inform about the failing tests:

size limit exceeded by 3 bytes! (CDN Bundle (incl. Tracing, Replay))
all the playwright tests related to bundle (e.g., bundle_min, bundle_replay) have been failing with a timeout

mydea

I finally found the time to review this in depth. Overall, I really like it, I left some comments with requests for changes. Mostly it is about moving stuff around, and avoiding any graphql-specific code in the "general" places. Also, please note that if you rebase this in develop, there are/will be a bunch of conflicts - this is mostly because the utils package is deprecated and all that code was moved to core.

Zen-cronic · 2024-12-20T03:54:07Z

noted, i'll implement the feedback. thanks for the comprehensive review!

update span hook
update breadcrumb hook
resolve rebase conflicts

will move on with the conflicts if the current implementation checks out

billyvg · 2025-01-07T16:41:34Z

@@ -0,0 +1,121 @@
+import { SENTRY_XHR_DATA_KEY } from '@sentry-internal/browser-utils';
+import { getBodyString } from '@sentry-internal/replay';


@mydea should this util be in the replay package?

if we use/need it here, I would move it to @sentry-internal/browser-utils, and use it from there both in replay and here!

otherwise, this will lead to circular dependency issues :)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

…n-cronic/sentry-javascript into feat/graphqlClientIntegration

mydea · 2025-02-05T08:59:05Z

I can't push changes on your branch, so I opened a PR here: Zen-cronic#1 which should fix the remaining CI issues on your branch!

…y#15265) Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the `(before|after)Update` hooks to track component update spans. For v9, this patch therefore disables update tracking by default.

Removes a no longer necessary fallback check that we only needed in SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the `event.isSubRequest` flag to identify sub vs. actual requests in our request handler. fixesgetsentry#15244

…ntry#15277)

…try#15282) - adds a toolbar for cropping and annotations - changes from inline styles to multiple class names in BEM format With annotation option: ![Screenshot 2025-02-03 at 3 51 04 PM](https://github.com/user-attachments/assets/97e4ac38-4926-49e5-a6f3-d474174e3c38) Without annotation option (to confirm that it looks the same as before): ![Screenshot 2025-02-03 at 5 09 01 PM](https://github.com/user-attachments/assets/8b614c38-3c1b-4d7e-986e-ead86a3f4349) Closesgetsentry#15252

…etsentry#15288) The debugging ability for Azure Functions when using Azure Static Web Apps is very limited. But as I could see some Sentry-related logs I **think** Sentry is generally initialized. However, server-related logs don't show up in Sentry. This is **probably** because the Azure Function finishes before the error can be sent to Sentry. By adding the Azure environment variable to check whether we should flush with a timeout, this should possibly fix the issue. Logs in Application Insights: ![image](https://github.com/user-attachments/assets/ed5ccd37-be87-4338-946b-94ec543e08c5)

mydea

left two more comments, where we should use the passed in logger instance - other than, this this is ready to go 🚀 thanks for the work, this was a tricky one but it turned out pretty great! (also needs a rebase, there is one small conflict)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

Zen-cronic · 2025-02-06T14:35:38Z

all resolved now!

## DESCRIBE YOUR PR Documents PR getsentry/sentry-javascript#13783 mentioned in issue getsentry/sentry-javascript#13399closes#13800 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)

Zen-cronic · 2024-09-25T02:39:03Z

Resolves#13399

Todo:

~~Support fetch spans and tests~~
~~Support graphql queries without a name~~
~~Enhance breadcrumb data~~

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Zen-cronic · 2024-09-26T16:07:17Z

~~Todo: fix failing fetch tests by removing body from non-graphql requests~~

Zen-cronic · 2024-10-18T00:46:23Z

Just wanted to inform about the failing tests:

size limit exceeded by 3 bytes! (CDN Bundle (incl. Tracing, Replay))
all the playwright tests related to bundle (e.g., bundle_min, bundle_replay) have been failing with a timeout

mydea

I finally found the time to review this in depth. Overall, I really like it, I left some comments with requests for changes. Mostly it is about moving stuff around, and avoiding any graphql-specific code in the "general" places. Also, please note that if you rebase this in develop, there are/will be a bunch of conflicts - this is mostly because the utils package is deprecated and all that code was moved to core.

Zen-cronic · 2024-12-20T03:54:07Z

noted, i'll implement the feedback. thanks for the comprehensive review!

update span hook
update breadcrumb hook
resolve rebase conflicts

will move on with the conflicts if the current implementation checks out

billyvg · 2025-01-07T16:41:34Z

@@ -0,0 +1,121 @@
+import { SENTRY_XHR_DATA_KEY } from '@sentry-internal/browser-utils';
+import { getBodyString } from '@sentry-internal/replay';


@mydea should this util be in the replay package?

if we use/need it here, I would move it to @sentry-internal/browser-utils, and use it from there both in replay and here!

otherwise, this will lead to circular dependency issues :)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

…n-cronic/sentry-javascript into feat/graphqlClientIntegration

mydea · 2025-02-05T08:59:05Z

I can't push changes on your branch, so I opened a PR here: Zen-cronic#1 which should fix the remaining CI issues on your branch!

…y#15265) Due to a change in the lifecycle of Svelte components in Svelte 5 (using Rune mode), our SDK can no longer leverage the `(before|after)Update` hooks to track component update spans. For v9, this patch therefore disables update tracking by default.

Removes a no longer necessary fallback check that we only needed in SvelteKit 1.26.0 or older. For Kit 2.x, we can rely on the `event.isSubRequest` flag to identify sub vs. actual requests in our request handler. fixesgetsentry#15244

…ntry#15277)

…try#15282) - adds a toolbar for cropping and annotations - changes from inline styles to multiple class names in BEM format With annotation option: ![Screenshot 2025-02-03 at 3 51 04 PM](https://github.com/user-attachments/assets/97e4ac38-4926-49e5-a6f3-d474174e3c38) Without annotation option (to confirm that it looks the same as before): ![Screenshot 2025-02-03 at 5 09 01 PM](https://github.com/user-attachments/assets/8b614c38-3c1b-4d7e-986e-ead86a3f4349) Closesgetsentry#15252

…etsentry#15288) The debugging ability for Azure Functions when using Azure Static Web Apps is very limited. But as I could see some Sentry-related logs I **think** Sentry is generally initialized. However, server-related logs don't show up in Sentry. This is **probably** because the Azure Function finishes before the error can be sent to Sentry. By adding the Azure environment variable to check whether we should flush with a timeout, this should possibly fix the issue. Logs in Application Insights: ![image](https://github.com/user-attachments/assets/ed5ccd37-be87-4338-946b-94ec543e08c5)

mydea

left two more comments, where we should use the passed in logger instance - other than, this this is ready to go 🚀 thanks for the work, this was a tricky one but it turned out pretty great! (also needs a rebase, there is one small conflict)

Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

Zen-cronic · 2025-02-06T14:35:38Z

all resolved now!

## DESCRIBE YOUR PR Documents PR getsentry/sentry-javascript#13783 mentioned in issue getsentry/sentry-javascript#13399closes#13800 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)

mydea reviewed Sep 25, 2024
View reviewed changes

Comment threadpackages/browser/src/integrations/graphqlClient.ts Outdated

mydea reviewed Sep 25, 2024
View reviewed changes

Comment threadpackages/browser/src/integrations/graphqlClient.ts Outdated

mydea reviewed Sep 25, 2024
View reviewed changes

Comment threadpackages/browser/src/tracing/request.ts Outdated

mydea reviewed Sep 25, 2024
View reviewed changes

Comment threadpackages/browser/src/tracing/request.ts Outdated

Zen-cronic commented Sep 26, 2024
View reviewed changes

Comment threadpackages/utils/src/instrument/fetch.ts Outdated

Zen-cronic commented Sep 26, 2024
View reviewed changes

Comment threadpackages/utils/src/instrument/fetch.ts Outdated

Zen-cronic requested a review from mydea September 26, 2024 15:05

Zen-cronic commented Sep 27, 2024
View reviewed changes

Comment threadpackages/utils/src/graphql.ts Outdated

mydea reviewed Sep 27, 2024
View reviewed changes

Comment threadpackages/browser/src/integrations/graphqlClient.ts Outdated

mydea reviewed Sep 27, 2024
View reviewed changes

Comment threadpackages/browser/src/tracing/request.ts Outdated

Zen-cronic requested a review from mydea September 30, 2024 13:02

mydea reviewed Dec 11, 2024
View reviewed changes

Comment threaddev-packages/browser-integration-tests/suites/integrations/graphqlClient/xhr/test.ts Outdated

mydea reviewed Dec 11, 2024
View reviewed changes

Comment threadpackages/browser/src/integrations/breadcrumbs.ts Outdated

mydea reviewed Dec 11, 2024
View reviewed changes

Comment threadpackages/browser/src/integrations/breadcrumbs.ts Outdated

mydea reviewed Dec 11, 2024
View reviewed changes

Comment threadpackages/browser/src/tracing/request.ts Outdated

mydea reviewed Dec 11, 2024
View reviewed changes

Comment threadpackages/browser/src/integrations/graphqlClient.ts Outdated

mydea reviewed Dec 11, 2024
View reviewed changes

Comment threadpackages/browser/src/integrations/graphqlClient.ts Outdated

mydea reviewed Dec 11, 2024
View reviewed changes

Comment threadpackages/browser/src/integrations/graphqlClient.ts

mydea reviewed Dec 11, 2024
View reviewed changes

Comment threadpackages/browser/src/integrations/graphqlClient.ts Outdated

mydea requested changes Dec 11, 2024
View reviewed changes

Zen-cronic requested a review from a team as a code owner January 7, 2025 15:53

billyvg reviewed Jan 7, 2025
View reviewed changes

Zen-cronic commented Jan 7, 2025
View reviewed changes

Comment threadpackages/browser/src/integrations/graphqlClient.ts Outdated

Zen-cronic requested a review from mydea January 7, 2025 18:58

mydea reviewed Jan 13, 2025
View reviewed changes

Comment threadpackages/browser/src/integrations/graphqlClient.ts Outdated

mydea reviewed Jan 13, 2025
View reviewed changes

Comment threadpackages/types/src/client.ts Outdated

mydea reviewed Jan 13, 2025
View reviewed changes

Comment threadpackages/types/src/client.ts Outdated

Zen-cronic added 5 commits January 30, 2025 20:01

feat(browser): Add support for queries with operation name
e7876d7
Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

feat(browser): Add support for queries without operation name
694da93
Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

Merge branch 'feat/graphqlClientIntegration' ofhttps://github.com/Ze…
998a3fe
…n-cronic/sentry-javascript into feat/graphqlClientIntegration

Merge branch 'getsentry:develop' into feat/graphqlClientIntegration
d8b0a83

Merge branch 'getsentry:develop' into feat/graphqlClientIntegration
68f7d1a

Lms24and others added 7 commits February 5, 2025 09:33

feat(core): AddinheritOrSampleWithhelper totraceSampler(getse…
f490c91
…ntry#15277)

Add graphqlclient CDN bundle & fix bundle tests
c8f69fe

Merge branch 'develop' into feat/graphqlClientIntegration
7150923

mydea approved these changes Feb 6, 2025
View reviewed changes

Comment threadpackages/browser-utils/src/networkUtils.ts Outdated
Comment threadpackages/browser-utils/src/networkUtils.ts Outdated

Zen-cronic added 2 commits February 6, 2025 09:27

fix(browser-utils): Use passed in logger
286f0d7
Signed-off-by: Kaung Zin Hein <83657429+Zen-cronic@users.noreply.github.com>

Merge branch 'develop' into feat/graphqlClientIntegration
681fe9e

lforst self-assigned this Feb 7, 2025

Zen-cronic added 3 commits February 7, 2025 18:45

Merge branch 'getsentry:develop' into feat/graphqlClientIntegration
a0f7aeb

Merge branch 'getsentry:develop' into feat/graphqlClientIntegration
141c67e

Merge branch 'getsentry:develop' into feat/graphqlClientIntegration
054ac5e

lforst merged commit cea9484 into getsentry:developFeb 11, 2025

HazAT mentioned this pull request Feb 11, 2025
chore: Add external contributor to CHANGELOG.md #15373
Closed

github-actionsBot mentioned this pull request Feb 13, 2025
Add optional graphqlClientIntegration to @sentry/browser#13399
Closed

ab-pm mentioned this pull request Apr 16, 2025
Does this integration follow the graphql client guidelines of sentry? DiederikvandenB/apollo-link-sentry#484
Open

s1gr1d mentioned this pull request May 22, 2025
docs(javascript): Add docs for GraphQL Client getsentry/sentry-docs#13801
Merged
6 tasks

Martinocom-Switcho mentioned this pull request Oct 15, 2025
GraphQL Client Integration for React Native - Sentry.graphqlClientIntegrationgetsentry/sentry-react-native#5271
Closed