Uh oh!
There was an error while loading. Please reload this page.
feat(core): Add inheritOrSampleWith helper to traceSampler - #15277
Merged
Conversation
mydea
reviewed
Feb 4, 2025
| sampleRate = options.tracesSampler(samplingContext); | ||
| sampleRate = options.tracesSampler({ | ||
| ...samplingContext, | ||
| inheritOrSampleWith(fallbackSampleRate) { |
Member
There was a problem hiding this comment.
Suggested change
| inheritOrSampleWith(fallbackSampleRate){ | |
| inheritOrSampleWith: (fallbackSampleRate)=>{ |
is this maybe slightly cleaner regarding this context? 🤔
mydea
reviewed
Feb 4, 2025
| // Fallback if parent sample rate is not on the incoming trace (e.g. if there is no baggage) | ||
| if (typeof samplingContext.parentSampled === 'boolean') { | ||
| return 1; |
Member
There was a problem hiding this comment.
Suggested change
| return1; | |
| returnNumber(samplingContext.parentSampled); |
!! otherwise this would propagate 1 for false :D
Contributor
size-limit report 📦
|
added 2 commits
February 4, 2025 10:13
mydea
commented
Feb 4, 2025
Member
Should we backport this? 🤔 I think it may be worth it, makes docs much easier in that regard..? |
Zen-cronic pushed a commit
to Zen-cronic/sentry-javascript
that referenced
this pull request
Feb 5, 2025
10 tasks
12 tasks
Lms24 pushed a commit
that referenced
this pull request
Sep 15, 2025
In #15277, `TracesSamplerSamplingContext` is added to and exported from [types-hoist], but is not being exported from [index.ts]. I'm following the [instruction], and I want to inject `(samplingContext: TracesSamplerSamplingContext) => number | boolean` to a function that is wrapping `Sentry.init`, but I can't because `TracesSamplerSamplingContext` is not recognized :( <!--link--> [types-hoist]: https://github.com/getsentry/sentry-javascript/blob/14eba5676149317f2e2b31143a0590256d32c094/packages/core/src/types-hoist/samplingcontext.ts#L47 [index.ts]: https://github.com/getsentry/sentry-javascript/blob/14eba5676149317f2e2b31143a0590256d32c094/packages/core/src/index.ts#L403 [instruction]: https://docs.sentry.io/platforms/javascript/guides/react/tracing/configure-sampling/#sampling-function-tracessampler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found in getsentry/sentry-docs#12544 that the proposed ux is horrible because nobody would understand what it does, so we're adding a helper that facilitates inheriting a sampling decision that also allows for catching more edge-cases without worsening ux and is self explanatory in what it does.