feat(flags): Adds LaunchDarkly and OpenFeature integrations - #14207

Merged
aliu39 merged 84 commits into
developfrom
aliu/launch-darkly-integration
Dec 4, 2024
Merged

feat(flags): Adds LaunchDarkly and OpenFeature integrations#14207
aliu39 merged 84 commits into
developfrom
aliu/launch-darkly-integration

Conversation

@aliu39

@aliu39aliu39 commented Nov 7, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Adds browser integrations for tracking feature flag evaluations through the LaunchDarkly JS SDK and OpenFeature Web SDK

Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.

Also see https://develop.sentry.dev/sdk/expected-features/#feature-flags

Ref

Decisions:

  1. we are storing the flags in the current scope's context, and copying them to the event context on error. This way we don't have to extend the scope class/core package. Potential follow-ups:
  1. users have to manually register the FF SDK hook (e.g. LDInspectionFlagUsedHandler) separately from Sentry.init(). Unlike python, it's not possible to do this when instantiating the integration.
  2. this hook is available for client SDKs only, hence why this is a browser only integration.
  3. To keep bundle sizes light, this integration is not exported to CDN bundles. Users should install with npm, and we expect tree-shaking to help if this integration is unused.

Both integrations are live and verified to work, in

  • @sentry/browser 8.41.0-beta.1
  • @sentry/react 8.41.0-beta.0

DOCS:
launchdarkly
openfeature
feature flags product index

aliu39and others added 26 commits October 29, 2024 14:03
@aliu39
Init package files
26722d7
@aliu39
Merge branch 'develop' into aliu/launch-darkly
72f9cc0
@aliu39
Revert changelog and move types file
419cd83
@aliu39
Add ld to dependencies and skeleton code. Get rid of core/
610da4d
@aliu39
Fix readme, rename types file, bring back core/
5b2e5ec
@aliu39
Fix readme 2
66b1253
@aliu39
Merge branch 'develop' into aliu/launch-darkly
023604a
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
1f99c28
…try-javascript into aliu/launch-darkly
@aliu39
Finish implementing, minus scope.flags
85acc6d
@aliu39
Implement flag buffer in sentry scope
3b3a767
@aliu39
Revert changelog
ab3181d
@michellewzhang
fix types
22684ea
@michellewzhang
docstring
79e5b24
@aliu39
Export FeatureFlag type in index.ts
63649c5
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
923500f
…try-javascript into aliu/launch-darkly
@aliu39
Clean up comments
bd04755
@aliu39
Fix build (uses yalc for scope changes) and use LRUMap util
91a4db9
@aliu39
Merge branch 'develop' into aliu/launch-darkly
1849673
@aliu39
Tweak hook name and docs
1ca9d53
@aliu39
FlagBuffer class and interface, add to scope._contexts. Remove old fl…
893cd62
…ag field and methods
@aliu39
Call clone in scope.clone()
f172683
@aliu39
Rewrite as a util fx instead of class. Use in LD integration
b96c17f
@aliu39
Delete LD pkg
f9a659b
@aliu39
Delete LD from package.json and update lock
d9c5860
@aliu39
Readd LD integration
cf24b75
@aliu39
Fix dependencies and rename exports
5561633
aliu39
aliu39 commented Nov 7, 2024
View reviewed changes
Comment threadpackages/types/src/context.ts Outdated
aliu39
aliu39 commented Nov 8, 2024
View reviewed changes
Comment threadpackages/launchdarkly/src/core/integration.ts Outdated
@billyvgbillyvg mentioned this pull request Nov 25, 2024
Merged
@cmanallen
Merge pull request#14326from getsentry/cmanallen/open-feature-integ…
a292a60
…ration
feat(flags): Add OpenFeature integration
@cmanallen
Merge pull request#14369from getsentry/ref-ff-launch-darkly-integra…
049e312
…tion-abstraction
ref(flags): Refactor LaunchDarkly integration to reusable functions
@cmanallencmanallen changed the title feat(flags): Add LaunchDarkly integrationfeat(flags): Adds LaunchDarkly and OpenFeature integrationsDec 2, 2024
@aliu39
aliu39 requested a review from billyvgDecember 4, 2024 19:07
billyvg
billyvg reviewed Dec 4, 2024
View reviewed changes
Comment threadpackages/browser/src/index.ts Outdated
export { makeBrowserOfflineTransport } from './transports/offline';
export { browserProfilingIntegration } from './profiling/integration';
export { spotlightBrowserIntegration } from './integrations/spotlight';
export { copyFlagsFromScopeToEvent, insertFlagToScope } from './utils/featureFlags';

@billyvgbillyvgDec 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these exports - they shouldn't be public

@aliu39
aliu39 requested a review from billyvgDecember 4, 2024 19:55
@aliu39
aliu39 merged commit 2a41c84 into developDec 4, 2024
@aliu39
aliu39 deleted the aliu/launch-darkly-integration branch December 4, 2024 20:56
@aliu39aliu39 mentioned this pull request Dec 4, 2024
Merged
@mydea

mydea commented Dec 5, 2024

Copy link
Copy Markdown
Member

Just for reference for the next time @aliu39 , please make sure to use squash merge :) No big deal, and we know it is not ideal that we cannot enforce this right now in this repo, so it's a bit of a manual thing sadly 😬

@lforstlforst mentioned this pull request Dec 5, 2024
Merged
aliu39 added a commit that referenced this pull request Dec 6, 2024
@aliu39
feat(flags): Add featureFlagsIntegration for custom tracking of flag …
a985d64
…evaluations (#14582)
Follow-up to #14207. Sentry integration for buffering feature flags manually with an API and auto-capturing them on error events.
@billyvgbillyvg mentioned this pull request Dec 11, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyvgbillyvgbillyvg approved these changes
@cmanallencmanallencmanallen approved these changes
@chargomechargomechargome approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@aliu39@HofmannZ@cmanallen@mydea@billyvg@AbhiPrasad@chargome@github-advanced-security@michellewzhang
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(flags): Adds LaunchDarkly and OpenFeature integrations - #14207
Merged
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Dec 4, 2024
Merged
feat(flags): Adds LaunchDarkly and OpenFeature integrations#14207
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Conversation
@aliu39
@aliu39aliu39
commented
Nov 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds browser integrations for tracking feature flag evaluations through the LaunchDarkly JS SDK and OpenFeature Web SDK
Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.
Also see https://develop.sentry.dev/sdk/expected-features/#feature-flags
Ref
Decisions:
  1. we are storing the flags in the current scope's context, and copying them to the event context on error. This way we don't have to extend the scope class/core package. Potential follow-ups:
  1. users have to manually register the FF SDK hook (e.g. LDInspectionFlagUsedHandler) separately from Sentry.init(). Unlike python, it's not possible to do this when instantiating the integration.
  2. this hook is available for client SDKs only, hence why this is a browser only integration.
  3. To keep bundle sizes light, this integration is not exported to CDN bundles. Users should install with npm, and we expect tree-shaking to help if this integration is unused.
Both integrations are live and verified to work, in
  • @sentry/browser 8.41.0-beta.1
  • @sentry/react 8.41.0-beta.0
DOCS:
launchdarkly
openfeature
feature flags product index
aliu39and others
added 26 commits
October 29, 2024 14:03
@aliu39
Init package files
26722d7
@aliu39
Merge branch 'develop' into aliu/launch-darkly
72f9cc0
@aliu39
Revert changelog and move types file
419cd83
@aliu39
Add ld to dependencies and skeleton code. Get rid of core/
610da4d
@aliu39
Fix readme, rename types file, bring back core/
5b2e5ec
@aliu39
Fix readme 2
66b1253
@aliu39
Merge branch 'develop' into aliu/launch-darkly
023604a
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
1f99c28
…try-javascript into aliu/launch-darkly
@aliu39
Finish implementing, minus scope.flags
85acc6d
@aliu39
Implement flag buffer in sentry scope
3b3a767
@aliu39
Revert changelog
ab3181d
@michellewzhang
fix types
22684ea
@michellewzhang
docstring
79e5b24
@aliu39
Export FeatureFlag type in index.ts
63649c5
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
923500f
…try-javascript into aliu/launch-darkly
@aliu39
Clean up comments
bd04755
@aliu39
Fix build (uses yalc for scope changes) and use LRUMap util
91a4db9
@aliu39
Merge branch 'develop' into aliu/launch-darkly
1849673
@aliu39
Tweak hook name and docs
1ca9d53
@aliu39
FlagBuffer class and interface, add to scope._contexts. Remove old fl…
893cd62
…ag field and methods
@aliu39
Call clone in scope.clone()
f172683
@aliu39
Rewrite as a util fx instead of class. Use in LD integration
b96c17f
@aliu39
Delete LD pkg
f9a659b
@aliu39
Delete LD from package.json and update lock
d9c5860
@aliu39
Readd LD integration
cf24b75
@aliu39
Fix dependencies and rename exports
5561633
aliu39
aliu39
commented
Nov 7, 2024
View reviewed changes
Comment threadpackages/types/src/context.ts
Outdated

aliu39
aliu39
commented
Nov 8, 2024
View reviewed changes
Comment threadpackages/launchdarkly/src/core/integration.ts
Outdated

@billyvgbillyvg
mentioned this pull request
Nov 25, 2024
 Merged

@cmanallen
Merge pull request#14326from getsentry/cmanallen/open-feature-integ…
a292a60
…ration
feat(flags): Add OpenFeature integration
@cmanallen
Merge pull request#14369from getsentry/ref-ff-launch-darkly-integra…
049e312
…tion-abstraction
ref(flags): Refactor LaunchDarkly integration to reusable functions
@cmanallencmanallen
changed the title
feat(flags): Add LaunchDarkly integrationfeat(flags): Adds LaunchDarkly and OpenFeature integrationsDec 2, 2024
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:07
billyvg
billyvg
reviewed
Dec 4, 2024
View reviewed changes
Comment threadpackages/browser/src/index.ts
Outdated

export { makeBrowserOfflineTransport } from './transports/offline';
export { browserProfilingIntegration } from './profiling/integration';
export { spotlightBrowserIntegration } from './integrations/spotlight';
export { copyFlagsFromScopeToEvent, insertFlagToScope } from './utils/featureFlags';
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these exports - they shouldn't be public
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:55
@aliu39
aliu39
merged commit 2a41c84
into
developDec 4, 2024
@aliu39
aliu39
deleted the

aliu/launch-darkly-integration

branch
December 4, 2024 20:56
@aliu39aliu39
mentioned this pull request
Dec 4, 2024
 Merged

@mydea
mydea
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
Just for reference for the next time @aliu39 , please make sure to use squash merge :) No big deal, and we know it is not ideal that we cannot enforce this right now in this repo, so it's a bit of a manual thing sadly 😬
@lforstlforst
mentioned this pull request
Dec 5, 2024
 Merged

aliu39 added a commit
that referenced
this pull request
Dec 6, 2024
@aliu39
feat(flags): Add featureFlagsIntegration for custom tracking of flag …
a985d64
…evaluations (#14582)
Follow-up to #14207. Sentry integration for buffering feature flags manually with an API and auto-capturing them on error events.
@billyvgbillyvg
mentioned this pull request
Dec 11, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@billyvgbillyvgbillyvg approved these changes
@cmanallencmanallencmanallen approved these changes
@chargomechargomechargome approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@aliu39@HofmannZ@cmanallen@mydea@billyvg@AbhiPrasad@chargome@github-advanced-security@michellewzhang

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(flags): Adds LaunchDarkly and OpenFeature integrations - #14207
Merged
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Dec 4, 2024
Merged
feat(flags): Adds LaunchDarkly and OpenFeature integrations#14207
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Conversation
@aliu39
@aliu39aliu39
commented
Nov 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds browser integrations for tracking feature flag evaluations through the LaunchDarkly JS SDK and OpenFeature Web SDK
Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.
Also see https://develop.sentry.dev/sdk/expected-features/#feature-flags
Ref
Decisions:
  1. we are storing the flags in the current scope's context, and copying them to the event context on error. This way we don't have to extend the scope class/core package. Potential follow-ups:
  1. users have to manually register the FF SDK hook (e.g. LDInspectionFlagUsedHandler) separately from Sentry.init(). Unlike python, it's not possible to do this when instantiating the integration.
  2. this hook is available for client SDKs only, hence why this is a browser only integration.
  3. To keep bundle sizes light, this integration is not exported to CDN bundles. Users should install with npm, and we expect tree-shaking to help if this integration is unused.
Both integrations are live and verified to work, in
  • @sentry/browser 8.41.0-beta.1
  • @sentry/react 8.41.0-beta.0
DOCS:
launchdarkly
openfeature
feature flags product index
aliu39and others
added 26 commits
October 29, 2024 14:03
@aliu39
Init package files
26722d7
@aliu39
Merge branch 'develop' into aliu/launch-darkly
72f9cc0
@aliu39
Revert changelog and move types file
419cd83
@aliu39
Add ld to dependencies and skeleton code. Get rid of core/
610da4d
@aliu39
Fix readme, rename types file, bring back core/
5b2e5ec
@aliu39
Fix readme 2
66b1253
@aliu39
Merge branch 'develop' into aliu/launch-darkly
023604a
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
1f99c28
…try-javascript into aliu/launch-darkly
@aliu39
Finish implementing, minus scope.flags
85acc6d
@aliu39
Implement flag buffer in sentry scope
3b3a767
@aliu39
Revert changelog
ab3181d
@michellewzhang
fix types
22684ea
@michellewzhang
docstring
79e5b24
@aliu39
Export FeatureFlag type in index.ts
63649c5
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
923500f
…try-javascript into aliu/launch-darkly
@aliu39
Clean up comments
bd04755
@aliu39
Fix build (uses yalc for scope changes) and use LRUMap util
91a4db9
@aliu39
Merge branch 'develop' into aliu/launch-darkly
1849673
@aliu39
Tweak hook name and docs
1ca9d53
@aliu39
FlagBuffer class and interface, add to scope._contexts. Remove old fl…
893cd62
…ag field and methods
@aliu39
Call clone in scope.clone()
f172683
@aliu39
Rewrite as a util fx instead of class. Use in LD integration
b96c17f
@aliu39
Delete LD pkg
f9a659b
@aliu39
Delete LD from package.json and update lock
d9c5860
@aliu39
Readd LD integration
cf24b75
@aliu39
Fix dependencies and rename exports
5561633
aliu39
aliu39
commented
Nov 7, 2024
View reviewed changes
Comment threadpackages/types/src/context.ts
Outdated

aliu39
aliu39
commented
Nov 8, 2024
View reviewed changes
Comment threadpackages/launchdarkly/src/core/integration.ts
Outdated

@billyvgbillyvg
mentioned this pull request
Nov 25, 2024
 Merged

@cmanallen
Merge pull request#14326from getsentry/cmanallen/open-feature-integ…
a292a60
…ration
feat(flags): Add OpenFeature integration
@cmanallen
Merge pull request#14369from getsentry/ref-ff-launch-darkly-integra…
049e312
…tion-abstraction
ref(flags): Refactor LaunchDarkly integration to reusable functions
@cmanallencmanallen
changed the title
feat(flags): Add LaunchDarkly integrationfeat(flags): Adds LaunchDarkly and OpenFeature integrationsDec 2, 2024
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:07
billyvg
billyvg
reviewed
Dec 4, 2024
View reviewed changes
Comment threadpackages/browser/src/index.ts
Outdated

export { makeBrowserOfflineTransport } from './transports/offline';
export { browserProfilingIntegration } from './profiling/integration';
export { spotlightBrowserIntegration } from './integrations/spotlight';
export { copyFlagsFromScopeToEvent, insertFlagToScope } from './utils/featureFlags';
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these exports - they shouldn't be public
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:55
@aliu39
aliu39
merged commit 2a41c84
into
developDec 4, 2024
@aliu39
aliu39
deleted the

aliu/launch-darkly-integration

branch
December 4, 2024 20:56
@aliu39aliu39
mentioned this pull request
Dec 4, 2024
 Merged

@mydea
mydea
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
Just for reference for the next time @aliu39 , please make sure to use squash merge :) No big deal, and we know it is not ideal that we cannot enforce this right now in this repo, so it's a bit of a manual thing sadly 😬
@lforstlforst
mentioned this pull request
Dec 5, 2024
 Merged

aliu39 added a commit
that referenced
this pull request
Dec 6, 2024
@aliu39
feat(flags): Add featureFlagsIntegration for custom tracking of flag …
a985d64
…evaluations (#14582)
Follow-up to #14207. Sentry integration for buffering feature flags manually with an API and auto-capturing them on error events.
@billyvgbillyvg
mentioned this pull request
Dec 11, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@billyvgbillyvgbillyvg approved these changes
@cmanallencmanallencmanallen approved these changes
@chargomechargomechargome approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@aliu39@HofmannZ@cmanallen@mydea@billyvg@AbhiPrasad@chargome@github-advanced-security@michellewzhang

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(flags): Adds LaunchDarkly and OpenFeature integrations - #14207
Merged
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Dec 4, 2024
Merged
feat(flags): Adds LaunchDarkly and OpenFeature integrations#14207
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Conversation
@aliu39
@aliu39aliu39
commented
Nov 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds browser integrations for tracking feature flag evaluations through the LaunchDarkly JS SDK and OpenFeature Web SDK
Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.
Also see https://develop.sentry.dev/sdk/expected-features/#feature-flags
Ref
Decisions:
  1. we are storing the flags in the current scope's context, and copying them to the event context on error. This way we don't have to extend the scope class/core package. Potential follow-ups:
  1. users have to manually register the FF SDK hook (e.g. LDInspectionFlagUsedHandler) separately from Sentry.init(). Unlike python, it's not possible to do this when instantiating the integration.
  2. this hook is available for client SDKs only, hence why this is a browser only integration.
  3. To keep bundle sizes light, this integration is not exported to CDN bundles. Users should install with npm, and we expect tree-shaking to help if this integration is unused.
Both integrations are live and verified to work, in
  • @sentry/browser 8.41.0-beta.1
  • @sentry/react 8.41.0-beta.0
DOCS:
launchdarkly
openfeature
feature flags product index
aliu39and others
added 26 commits
October 29, 2024 14:03
@aliu39
Init package files
26722d7
@aliu39
Merge branch 'develop' into aliu/launch-darkly
72f9cc0
@aliu39
Revert changelog and move types file
419cd83
@aliu39
Add ld to dependencies and skeleton code. Get rid of core/
610da4d
@aliu39
Fix readme, rename types file, bring back core/
5b2e5ec
@aliu39
Fix readme 2
66b1253
@aliu39
Merge branch 'develop' into aliu/launch-darkly
023604a
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
1f99c28
…try-javascript into aliu/launch-darkly
@aliu39
Finish implementing, minus scope.flags
85acc6d
@aliu39
Implement flag buffer in sentry scope
3b3a767
@aliu39
Revert changelog
ab3181d
@michellewzhang
fix types
22684ea
@michellewzhang
docstring
79e5b24
@aliu39
Export FeatureFlag type in index.ts
63649c5
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
923500f
…try-javascript into aliu/launch-darkly
@aliu39
Clean up comments
bd04755
@aliu39
Fix build (uses yalc for scope changes) and use LRUMap util
91a4db9
@aliu39
Merge branch 'develop' into aliu/launch-darkly
1849673
@aliu39
Tweak hook name and docs
1ca9d53
@aliu39
FlagBuffer class and interface, add to scope._contexts. Remove old fl…
893cd62
…ag field and methods
@aliu39
Call clone in scope.clone()
f172683
@aliu39
Rewrite as a util fx instead of class. Use in LD integration
b96c17f
@aliu39
Delete LD pkg
f9a659b
@aliu39
Delete LD from package.json and update lock
d9c5860
@aliu39
Readd LD integration
cf24b75
@aliu39
Fix dependencies and rename exports
5561633
aliu39
aliu39
commented
Nov 7, 2024
View reviewed changes
Comment threadpackages/types/src/context.ts
Outdated

aliu39
aliu39
commented
Nov 8, 2024
View reviewed changes
Comment threadpackages/launchdarkly/src/core/integration.ts
Outdated

@billyvgbillyvg
mentioned this pull request
Nov 25, 2024
 Merged

@cmanallen
Merge pull request#14326from getsentry/cmanallen/open-feature-integ…
a292a60
…ration
feat(flags): Add OpenFeature integration
@cmanallen
Merge pull request#14369from getsentry/ref-ff-launch-darkly-integra…
049e312
…tion-abstraction
ref(flags): Refactor LaunchDarkly integration to reusable functions
@cmanallencmanallen
changed the title
feat(flags): Add LaunchDarkly integrationfeat(flags): Adds LaunchDarkly and OpenFeature integrationsDec 2, 2024
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:07
billyvg
billyvg
reviewed
Dec 4, 2024
View reviewed changes
Comment threadpackages/browser/src/index.ts
Outdated

export { makeBrowserOfflineTransport } from './transports/offline';
export { browserProfilingIntegration } from './profiling/integration';
export { spotlightBrowserIntegration } from './integrations/spotlight';
export { copyFlagsFromScopeToEvent, insertFlagToScope } from './utils/featureFlags';
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these exports - they shouldn't be public
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:55
@aliu39
aliu39
merged commit 2a41c84
into
developDec 4, 2024
@aliu39
aliu39
deleted the

aliu/launch-darkly-integration

branch
December 4, 2024 20:56
@aliu39aliu39
mentioned this pull request
Dec 4, 2024
 Merged

@mydea
mydea
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
Just for reference for the next time @aliu39 , please make sure to use squash merge :) No big deal, and we know it is not ideal that we cannot enforce this right now in this repo, so it's a bit of a manual thing sadly 😬
@lforstlforst
mentioned this pull request
Dec 5, 2024
 Merged

aliu39 added a commit
that referenced
this pull request
Dec 6, 2024
@aliu39
feat(flags): Add featureFlagsIntegration for custom tracking of flag …
a985d64
…evaluations (#14582)
Follow-up to #14207. Sentry integration for buffering feature flags manually with an API and auto-capturing them on error events.
@billyvgbillyvg
mentioned this pull request
Dec 11, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@billyvgbillyvgbillyvg approved these changes
@cmanallencmanallencmanallen approved these changes
@chargomechargomechargome approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@aliu39@HofmannZ@cmanallen@mydea@billyvg@AbhiPrasad@chargome@github-advanced-security@michellewzhang

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(flags): Adds LaunchDarkly and OpenFeature integrations - #14207
Merged
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Dec 4, 2024
Merged
feat(flags): Adds LaunchDarkly and OpenFeature integrations#14207
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Conversation
@aliu39
@aliu39aliu39
commented
Nov 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds browser integrations for tracking feature flag evaluations through the LaunchDarkly JS SDK and OpenFeature Web SDK
Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.
Also see https://develop.sentry.dev/sdk/expected-features/#feature-flags
Ref
Decisions:
  1. we are storing the flags in the current scope's context, and copying them to the event context on error. This way we don't have to extend the scope class/core package. Potential follow-ups:
  1. users have to manually register the FF SDK hook (e.g. LDInspectionFlagUsedHandler) separately from Sentry.init(). Unlike python, it's not possible to do this when instantiating the integration.
  2. this hook is available for client SDKs only, hence why this is a browser only integration.
  3. To keep bundle sizes light, this integration is not exported to CDN bundles. Users should install with npm, and we expect tree-shaking to help if this integration is unused.
Both integrations are live and verified to work, in
  • @sentry/browser 8.41.0-beta.1
  • @sentry/react 8.41.0-beta.0
DOCS:
launchdarkly
openfeature
feature flags product index
aliu39and others
added 26 commits
October 29, 2024 14:03
@aliu39
Init package files
26722d7
@aliu39
Merge branch 'develop' into aliu/launch-darkly
72f9cc0
@aliu39
Revert changelog and move types file
419cd83
@aliu39
Add ld to dependencies and skeleton code. Get rid of core/
610da4d
@aliu39
Fix readme, rename types file, bring back core/
5b2e5ec
@aliu39
Fix readme 2
66b1253
@aliu39
Merge branch 'develop' into aliu/launch-darkly
023604a
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
1f99c28
…try-javascript into aliu/launch-darkly
@aliu39
Finish implementing, minus scope.flags
85acc6d
@aliu39
Implement flag buffer in sentry scope
3b3a767
@aliu39
Revert changelog
ab3181d
@michellewzhang
fix types
22684ea
@michellewzhang
docstring
79e5b24
@aliu39
Export FeatureFlag type in index.ts
63649c5
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
923500f
…try-javascript into aliu/launch-darkly
@aliu39
Clean up comments
bd04755
@aliu39
Fix build (uses yalc for scope changes) and use LRUMap util
91a4db9
@aliu39
Merge branch 'develop' into aliu/launch-darkly
1849673
@aliu39
Tweak hook name and docs
1ca9d53
@aliu39
FlagBuffer class and interface, add to scope._contexts. Remove old fl…
893cd62
…ag field and methods
@aliu39
Call clone in scope.clone()
f172683
@aliu39
Rewrite as a util fx instead of class. Use in LD integration
b96c17f
@aliu39
Delete LD pkg
f9a659b
@aliu39
Delete LD from package.json and update lock
d9c5860
@aliu39
Readd LD integration
cf24b75
@aliu39
Fix dependencies and rename exports
5561633
aliu39
aliu39
commented
Nov 7, 2024
View reviewed changes
Comment threadpackages/types/src/context.ts
Outdated

aliu39
aliu39
commented
Nov 8, 2024
View reviewed changes
Comment threadpackages/launchdarkly/src/core/integration.ts
Outdated

@billyvgbillyvg
mentioned this pull request
Nov 25, 2024
 Merged

@cmanallen
Merge pull request#14326from getsentry/cmanallen/open-feature-integ…
a292a60
…ration
feat(flags): Add OpenFeature integration
@cmanallen
Merge pull request#14369from getsentry/ref-ff-launch-darkly-integra…
049e312
…tion-abstraction
ref(flags): Refactor LaunchDarkly integration to reusable functions
@cmanallencmanallen
changed the title
feat(flags): Add LaunchDarkly integrationfeat(flags): Adds LaunchDarkly and OpenFeature integrationsDec 2, 2024
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:07
billyvg
billyvg
reviewed
Dec 4, 2024
View reviewed changes
Comment threadpackages/browser/src/index.ts
Outdated

export { makeBrowserOfflineTransport } from './transports/offline';
export { browserProfilingIntegration } from './profiling/integration';
export { spotlightBrowserIntegration } from './integrations/spotlight';
export { copyFlagsFromScopeToEvent, insertFlagToScope } from './utils/featureFlags';
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these exports - they shouldn't be public
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:55
@aliu39
aliu39
merged commit 2a41c84
into
developDec 4, 2024
@aliu39
aliu39
deleted the

aliu/launch-darkly-integration

branch
December 4, 2024 20:56
@aliu39aliu39
mentioned this pull request
Dec 4, 2024
 Merged

@mydea
mydea
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
Just for reference for the next time @aliu39 , please make sure to use squash merge :) No big deal, and we know it is not ideal that we cannot enforce this right now in this repo, so it's a bit of a manual thing sadly 😬
@lforstlforst
mentioned this pull request
Dec 5, 2024
 Merged

aliu39 added a commit
that referenced
this pull request
Dec 6, 2024
@aliu39
feat(flags): Add featureFlagsIntegration for custom tracking of flag …
a985d64
…evaluations (#14582)
Follow-up to #14207. Sentry integration for buffering feature flags manually with an API and auto-capturing them on error events.
@billyvgbillyvg
mentioned this pull request
Dec 11, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@billyvgbillyvgbillyvg approved these changes
@cmanallencmanallencmanallen approved these changes
@chargomechargomechargome approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@aliu39@HofmannZ@cmanallen@mydea@billyvg@AbhiPrasad@chargome@github-advanced-security@michellewzhang

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(flags): Adds LaunchDarkly and OpenFeature integrations - #14207
Merged
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Dec 4, 2024
Merged
feat(flags): Adds LaunchDarkly and OpenFeature integrations#14207
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Conversation
@aliu39
@aliu39aliu39
commented
Nov 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds browser integrations for tracking feature flag evaluations through the LaunchDarkly JS SDK and OpenFeature Web SDK
Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.
Also see https://develop.sentry.dev/sdk/expected-features/#feature-flags
Ref
Decisions:
  1. we are storing the flags in the current scope's context, and copying them to the event context on error. This way we don't have to extend the scope class/core package. Potential follow-ups:
  1. users have to manually register the FF SDK hook (e.g. LDInspectionFlagUsedHandler) separately from Sentry.init(). Unlike python, it's not possible to do this when instantiating the integration.
  2. this hook is available for client SDKs only, hence why this is a browser only integration.
  3. To keep bundle sizes light, this integration is not exported to CDN bundles. Users should install with npm, and we expect tree-shaking to help if this integration is unused.
Both integrations are live and verified to work, in
  • @sentry/browser 8.41.0-beta.1
  • @sentry/react 8.41.0-beta.0
DOCS:
launchdarkly
openfeature
feature flags product index
aliu39and others
added 26 commits
October 29, 2024 14:03
@aliu39
Init package files
26722d7
@aliu39
Merge branch 'develop' into aliu/launch-darkly
72f9cc0
@aliu39
Revert changelog and move types file
419cd83
@aliu39
Add ld to dependencies and skeleton code. Get rid of core/
610da4d
@aliu39
Fix readme, rename types file, bring back core/
5b2e5ec
@aliu39
Fix readme 2
66b1253
@aliu39
Merge branch 'develop' into aliu/launch-darkly
023604a
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
1f99c28
…try-javascript into aliu/launch-darkly
@aliu39
Finish implementing, minus scope.flags
85acc6d
@aliu39
Implement flag buffer in sentry scope
3b3a767
@aliu39
Revert changelog
ab3181d
@michellewzhang
fix types
22684ea
@michellewzhang
docstring
79e5b24
@aliu39
Export FeatureFlag type in index.ts
63649c5
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
923500f
…try-javascript into aliu/launch-darkly
@aliu39
Clean up comments
bd04755
@aliu39
Fix build (uses yalc for scope changes) and use LRUMap util
91a4db9
@aliu39
Merge branch 'develop' into aliu/launch-darkly
1849673
@aliu39
Tweak hook name and docs
1ca9d53
@aliu39
FlagBuffer class and interface, add to scope._contexts. Remove old fl…
893cd62
…ag field and methods
@aliu39
Call clone in scope.clone()
f172683
@aliu39
Rewrite as a util fx instead of class. Use in LD integration
b96c17f
@aliu39
Delete LD pkg
f9a659b
@aliu39
Delete LD from package.json and update lock
d9c5860
@aliu39
Readd LD integration
cf24b75
@aliu39
Fix dependencies and rename exports
5561633
aliu39
aliu39
commented
Nov 7, 2024
View reviewed changes
Comment threadpackages/types/src/context.ts
Outdated

aliu39
aliu39
commented
Nov 8, 2024
View reviewed changes
Comment threadpackages/launchdarkly/src/core/integration.ts
Outdated

@billyvgbillyvg
mentioned this pull request
Nov 25, 2024
 Merged

@cmanallen
Merge pull request#14326from getsentry/cmanallen/open-feature-integ…
a292a60
…ration
feat(flags): Add OpenFeature integration
@cmanallen
Merge pull request#14369from getsentry/ref-ff-launch-darkly-integra…
049e312
…tion-abstraction
ref(flags): Refactor LaunchDarkly integration to reusable functions
@cmanallencmanallen
changed the title
feat(flags): Add LaunchDarkly integrationfeat(flags): Adds LaunchDarkly and OpenFeature integrationsDec 2, 2024
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:07
billyvg
billyvg
reviewed
Dec 4, 2024
View reviewed changes
Comment threadpackages/browser/src/index.ts
Outdated

export { makeBrowserOfflineTransport } from './transports/offline';
export { browserProfilingIntegration } from './profiling/integration';
export { spotlightBrowserIntegration } from './integrations/spotlight';
export { copyFlagsFromScopeToEvent, insertFlagToScope } from './utils/featureFlags';
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these exports - they shouldn't be public
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:55
@aliu39
aliu39
merged commit 2a41c84
into
developDec 4, 2024
@aliu39
aliu39
deleted the

aliu/launch-darkly-integration

branch
December 4, 2024 20:56
@aliu39aliu39
mentioned this pull request
Dec 4, 2024
 Merged

@mydea
mydea
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
Just for reference for the next time @aliu39 , please make sure to use squash merge :) No big deal, and we know it is not ideal that we cannot enforce this right now in this repo, so it's a bit of a manual thing sadly 😬
@lforstlforst
mentioned this pull request
Dec 5, 2024
 Merged

aliu39 added a commit
that referenced
this pull request
Dec 6, 2024
@aliu39
feat(flags): Add featureFlagsIntegration for custom tracking of flag …
a985d64
…evaluations (#14582)
Follow-up to #14207. Sentry integration for buffering feature flags manually with an API and auto-capturing them on error events.
@billyvgbillyvg
mentioned this pull request
Dec 11, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@billyvgbillyvgbillyvg approved these changes
@cmanallencmanallencmanallen approved these changes
@chargomechargomechargome approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@aliu39@HofmannZ@cmanallen@mydea@billyvg@AbhiPrasad@chargome@github-advanced-security@michellewzhang

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(flags): Adds LaunchDarkly and OpenFeature integrations - #14207
Merged
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Dec 4, 2024
Merged
feat(flags): Adds LaunchDarkly and OpenFeature integrations#14207
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Conversation
@aliu39
@aliu39aliu39
commented
Nov 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds browser integrations for tracking feature flag evaluations through the LaunchDarkly JS SDK and OpenFeature Web SDK
Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.
Also see https://develop.sentry.dev/sdk/expected-features/#feature-flags
Ref
Decisions:
  1. we are storing the flags in the current scope's context, and copying them to the event context on error. This way we don't have to extend the scope class/core package. Potential follow-ups:
  1. users have to manually register the FF SDK hook (e.g. LDInspectionFlagUsedHandler) separately from Sentry.init(). Unlike python, it's not possible to do this when instantiating the integration.
  2. this hook is available for client SDKs only, hence why this is a browser only integration.
  3. To keep bundle sizes light, this integration is not exported to CDN bundles. Users should install with npm, and we expect tree-shaking to help if this integration is unused.
Both integrations are live and verified to work, in
  • @sentry/browser 8.41.0-beta.1
  • @sentry/react 8.41.0-beta.0
DOCS:
launchdarkly
openfeature
feature flags product index
aliu39and others
added 26 commits
October 29, 2024 14:03
@aliu39
Init package files
26722d7
@aliu39
Merge branch 'develop' into aliu/launch-darkly
72f9cc0
@aliu39
Revert changelog and move types file
419cd83
@aliu39
Add ld to dependencies and skeleton code. Get rid of core/
610da4d
@aliu39
Fix readme, rename types file, bring back core/
5b2e5ec
@aliu39
Fix readme 2
66b1253
@aliu39
Merge branch 'develop' into aliu/launch-darkly
023604a
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
1f99c28
…try-javascript into aliu/launch-darkly
@aliu39
Finish implementing, minus scope.flags
85acc6d
@aliu39
Implement flag buffer in sentry scope
3b3a767
@aliu39
Revert changelog
ab3181d
@michellewzhang
fix types
22684ea
@michellewzhang
docstring
79e5b24
@aliu39
Export FeatureFlag type in index.ts
63649c5
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
923500f
…try-javascript into aliu/launch-darkly
@aliu39
Clean up comments
bd04755
@aliu39
Fix build (uses yalc for scope changes) and use LRUMap util
91a4db9
@aliu39
Merge branch 'develop' into aliu/launch-darkly
1849673
@aliu39
Tweak hook name and docs
1ca9d53
@aliu39
FlagBuffer class and interface, add to scope._contexts. Remove old fl…
893cd62
…ag field and methods
@aliu39
Call clone in scope.clone()
f172683
@aliu39
Rewrite as a util fx instead of class. Use in LD integration
b96c17f
@aliu39
Delete LD pkg
f9a659b
@aliu39
Delete LD from package.json and update lock
d9c5860
@aliu39
Readd LD integration
cf24b75
@aliu39
Fix dependencies and rename exports
5561633
aliu39
aliu39
commented
Nov 7, 2024
View reviewed changes
Comment threadpackages/types/src/context.ts
Outdated

aliu39
aliu39
commented
Nov 8, 2024
View reviewed changes
Comment threadpackages/launchdarkly/src/core/integration.ts
Outdated

@billyvgbillyvg
mentioned this pull request
Nov 25, 2024
 Merged

@cmanallen
Merge pull request#14326from getsentry/cmanallen/open-feature-integ…
a292a60
…ration
feat(flags): Add OpenFeature integration
@cmanallen
Merge pull request#14369from getsentry/ref-ff-launch-darkly-integra…
049e312
…tion-abstraction
ref(flags): Refactor LaunchDarkly integration to reusable functions
@cmanallencmanallen
changed the title
feat(flags): Add LaunchDarkly integrationfeat(flags): Adds LaunchDarkly and OpenFeature integrationsDec 2, 2024
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:07
billyvg
billyvg
reviewed
Dec 4, 2024
View reviewed changes
Comment threadpackages/browser/src/index.ts
Outdated

export { makeBrowserOfflineTransport } from './transports/offline';
export { browserProfilingIntegration } from './profiling/integration';
export { spotlightBrowserIntegration } from './integrations/spotlight';
export { copyFlagsFromScopeToEvent, insertFlagToScope } from './utils/featureFlags';
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these exports - they shouldn't be public
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:55
@aliu39
aliu39
merged commit 2a41c84
into
developDec 4, 2024
@aliu39
aliu39
deleted the

aliu/launch-darkly-integration

branch
December 4, 2024 20:56
@aliu39aliu39
mentioned this pull request
Dec 4, 2024
 Merged

@mydea
mydea
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
Just for reference for the next time @aliu39 , please make sure to use squash merge :) No big deal, and we know it is not ideal that we cannot enforce this right now in this repo, so it's a bit of a manual thing sadly 😬
@lforstlforst
mentioned this pull request
Dec 5, 2024
 Merged

aliu39 added a commit
that referenced
this pull request
Dec 6, 2024
@aliu39
feat(flags): Add featureFlagsIntegration for custom tracking of flag …
a985d64
…evaluations (#14582)
Follow-up to #14207. Sentry integration for buffering feature flags manually with an API and auto-capturing them on error events.
@billyvgbillyvg
mentioned this pull request
Dec 11, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@billyvgbillyvgbillyvg approved these changes
@cmanallencmanallencmanallen approved these changes
@chargomechargomechargome approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@aliu39@HofmannZ@cmanallen@mydea@billyvg@AbhiPrasad@chargome@github-advanced-security@michellewzhang

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(flags): Adds LaunchDarkly and OpenFeature integrations - #14207
Merged
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Dec 4, 2024
Merged
feat(flags): Adds LaunchDarkly and OpenFeature integrations#14207
aliu39 merged 84 commits into
developfrom 
aliu/launch-darkly-integration
Conversation
@aliu39
@aliu39aliu39
commented
Nov 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Adds browser integrations for tracking feature flag evaluations through the LaunchDarkly JS SDK and OpenFeature Web SDK
Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.
Also see https://develop.sentry.dev/sdk/expected-features/#feature-flags
Ref
Decisions:
  1. we are storing the flags in the current scope's context, and copying them to the event context on error. This way we don't have to extend the scope class/core package. Potential follow-ups:
  1. users have to manually register the FF SDK hook (e.g. LDInspectionFlagUsedHandler) separately from Sentry.init(). Unlike python, it's not possible to do this when instantiating the integration.
  2. this hook is available for client SDKs only, hence why this is a browser only integration.
  3. To keep bundle sizes light, this integration is not exported to CDN bundles. Users should install with npm, and we expect tree-shaking to help if this integration is unused.
Both integrations are live and verified to work, in
  • @sentry/browser 8.41.0-beta.1
  • @sentry/react 8.41.0-beta.0
DOCS:
launchdarkly
openfeature
feature flags product index
aliu39and others
added 26 commits
October 29, 2024 14:03
@aliu39
Init package files
26722d7
@aliu39
Merge branch 'develop' into aliu/launch-darkly
72f9cc0
@aliu39
Revert changelog and move types file
419cd83
@aliu39
Add ld to dependencies and skeleton code. Get rid of core/
610da4d
@aliu39
Fix readme, rename types file, bring back core/
5b2e5ec
@aliu39
Fix readme 2
66b1253
@aliu39
Merge branch 'develop' into aliu/launch-darkly
023604a
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
1f99c28
…try-javascript into aliu/launch-darkly
@aliu39
Finish implementing, minus scope.flags
85acc6d
@aliu39
Implement flag buffer in sentry scope
3b3a767
@aliu39
Revert changelog
ab3181d
@michellewzhang
fix types
22684ea
@michellewzhang
docstring
79e5b24
@aliu39
Export FeatureFlag type in index.ts
63649c5
@aliu39
Merge branch 'aliu/launch-darkly' ofhttps://github.com/getsentry/sen…
923500f
…try-javascript into aliu/launch-darkly
@aliu39
Clean up comments
bd04755
@aliu39
Fix build (uses yalc for scope changes) and use LRUMap util
91a4db9
@aliu39
Merge branch 'develop' into aliu/launch-darkly
1849673
@aliu39
Tweak hook name and docs
1ca9d53
@aliu39
FlagBuffer class and interface, add to scope._contexts. Remove old fl…
893cd62
…ag field and methods
@aliu39
Call clone in scope.clone()
f172683
@aliu39
Rewrite as a util fx instead of class. Use in LD integration
b96c17f
@aliu39
Delete LD pkg
f9a659b
@aliu39
Delete LD from package.json and update lock
d9c5860
@aliu39
Readd LD integration
cf24b75
@aliu39
Fix dependencies and rename exports
5561633
aliu39
aliu39
commented
Nov 7, 2024
View reviewed changes
Comment threadpackages/types/src/context.ts
Outdated

aliu39
aliu39
commented
Nov 8, 2024
View reviewed changes
Comment threadpackages/launchdarkly/src/core/integration.ts
Outdated

@billyvgbillyvg
mentioned this pull request
Nov 25, 2024
 Merged

@cmanallen
Merge pull request#14326from getsentry/cmanallen/open-feature-integ…
a292a60
…ration
feat(flags): Add OpenFeature integration
@cmanallen
Merge pull request#14369from getsentry/ref-ff-launch-darkly-integra…
049e312
…tion-abstraction
ref(flags): Refactor LaunchDarkly integration to reusable functions
@cmanallencmanallen
changed the title
feat(flags): Add LaunchDarkly integrationfeat(flags): Adds LaunchDarkly and OpenFeature integrationsDec 2, 2024
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:07
billyvg
billyvg
reviewed
Dec 4, 2024
View reviewed changes
Comment threadpackages/browser/src/index.ts
Outdated

export { makeBrowserOfflineTransport } from './transports/offline';
export { browserProfilingIntegration } from './profiling/integration';
export { spotlightBrowserIntegration } from './integrations/spotlight';
export { copyFlagsFromScopeToEvent, insertFlagToScope } from './utils/featureFlags';
@billyvgbillyvgDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these exports - they shouldn't be public
@aliu39
aliu39
requested a review
from billyvgDecember 4, 2024 19:55
@aliu39
aliu39
merged commit 2a41c84
into
developDec 4, 2024
@aliu39
aliu39
deleted the

aliu/launch-darkly-integration

branch
December 4, 2024 20:56
@aliu39aliu39
mentioned this pull request
Dec 4, 2024
 Merged

@mydea
mydea
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
Just for reference for the next time @aliu39 , please make sure to use squash merge :) No big deal, and we know it is not ideal that we cannot enforce this right now in this repo, so it's a bit of a manual thing sadly 😬
@lforstlforst
mentioned this pull request
Dec 5, 2024
 Merged

aliu39 added a commit
that referenced
this pull request
Dec 6, 2024
@aliu39
feat(flags): Add featureFlagsIntegration for custom tracking of flag …
a985d64
…evaluations (#14582)
Follow-up to #14207. Sentry integration for buffering feature flags manually with an API and auto-capturing them on error events.
@billyvgbillyvg
mentioned this pull request
Dec 11, 2024

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@billyvgbillyvgbillyvg approved these changes
@cmanallencmanallencmanallen approved these changes
@chargomechargomechargome approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad
@andreiborzaandreiborzaAwaiting requested review from andreiborzaandreiborza was automatically assigned from getsentry/team-javascript-sdks

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@aliu39@HofmannZ@cmanallen@mydea@billyvg@AbhiPrasad@chargome@github-advanced-security@michellewzhang