Uh oh!
There was an error while loading. Please reload this page.
ref(flags): Refactor LaunchDarkly integration to reusable functions - #14369
Merged
cmanallen merged 12 commits intoDec 2, 2024
Merged
Conversation
billyvg
changed the base branch from
develop
to
aliu/launch-darkly-integrationNovember 19, 2024 18:57
Contributor
size-limit report 📦
|
billyvg
commented
Nov 19, 2024
MemberAuthor
There was a problem hiding this comment.
I imagine we'll want to use this in node/server environments as well, would it make sense to move these to core?
Member
There was a problem hiding this comment.
I think the handler being used in the LD integration is only available for client-side js, that's why this was moved to the browser. Not sure if this will change for other integrations in the future
MemberAuthor
There was a problem hiding this comment.
Nothing in these util functions are specific to LD integration, it stores flag values to scope. It's possible for a server side implementation to re-use these functions.
billyvg
marked this pull request as ready for review
November 19, 2024 22:09
chargome
approved these changes
Nov 20, 2024
Uh oh!
There was an error while loading. Please reload this page.
Member
There was a problem hiding this comment.
I think the handler being used in the LD integration is only available for client-side js, that's why this was moved to the browser. Not sure if this will change for other integrations in the future
billyvgforce-pushed
the
ref-ff-launch-darkly-integration-abstraction
branch
from
November 20, 2024 16:58
a094ad5 to
d124fefCompareMoves core logic into re-usable functions so that we can re-use for other integrations.
billyvgforce-pushed
the
ref-ff-launch-darkly-integration-abstraction
branch
from
November 20, 2024 17:48
39583db to
4195a8eCompareMoves core logic into re-usable functions so that we can re-use for other integrations.
…ration feat(flags): Add OpenFeature integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves core logic into re-usable functions so that we can re-use for other integrations.
Depends on #14207