Skip to content

fix(v8/vue): Re-throw error when no errorHandler exists - #14943

Merged
s1gr1d merged 2 commits into
v8from
sig/vue-error-throw
Jan 9, 2025
Merged

fix(v8/vue): Re-throw error when no errorHandler exists#14943
s1gr1d merged 2 commits into
v8from
sig/vue-error-throw

Conversation

@s1gr1d

@s1gr1ds1gr1d commented Jan 8, 2025•
edited
Loading

Copy link
Copy Markdown
Member

PR for v9: #14958

Lms24
Lms24 reviewed Jan 8, 2025
View reviewed changes

@Lms24Lms24 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once we added/updated tests for this :shipit:

@github-actions

github-actionsBot commented Jan 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser23.29 KBaddedadded
@sentry/browser - with treeshaking flags21.96 KBaddedadded
@sentry/browser (incl. Tracing)35.85 KBaddedadded
@sentry/browser (incl. Tracing, Replay)73.09 KBaddedadded
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags63.48 KBaddedadded
@sentry/browser (incl. Tracing, Replay with Canvas)77.4 KBaddedadded
@sentry/browser (incl. Tracing, Replay, Feedback)89.34 KBaddedadded
@sentry/browser (incl. Feedback)39.5 KBaddedadded
@sentry/browser (incl. sendFeedback)27.89 KBaddedadded
@sentry/browser (incl. FeedbackAsync)32.69 KBaddedadded
@sentry/react25.96 KBaddedadded
@sentry/react (incl. Tracing)38.66 KBaddedadded
@sentry/vue27.57 KBaddedadded
@sentry/vue (incl. Tracing)37.71 KBaddedadded
@sentry/svelte23.45 KBaddedadded
CDN Bundle24.49 KBaddedadded
CDN Bundle (incl. Tracing)37.56 KBaddedadded
CDN Bundle (incl. Tracing, Replay)72.75 KBaddedadded
CDN Bundle (incl. Tracing, Replay, Feedback)78.11 KBaddedadded
CDN Bundle - uncompressed71.93 KBaddedadded
CDN Bundle (incl. Tracing) - uncompressed111.42 KBaddedadded
CDN Bundle (incl. Tracing, Replay) - uncompressed225.5 KBaddedadded
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed238.6 KBaddedadded
@sentry/nextjs (client)38.92 KBaddedadded
@sentry/sveltekit (client)36.36 KBaddedadded
@sentry/node162.8 KBaddedadded
@sentry/node - without tracing98.94 KBaddedadded
@sentry/aws-serverless126.63 KBaddedadded

Lms24
Lms24 approved these changes Jan 9, 2025
View reviewed changes

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realizing we already have tests that need to be adjusted anyway, so feel free to merge once this is done (ofc feel free to add tests if it makes sense). Thanks for tackling this!

Lms24
Lms24 reviewed Jan 9, 2025
View reviewed changes

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more Q but feel free to merge once it is addressed :)

Comment threadpackages/vue/test/errorHandler.test.ts
@s1gr1d
s1gr1dforce-pushed the sig/vue-error-throw branch from 70c98ae to a6459e2CompareJanuary 9, 2025 13:04
@s1gr1d
s1gr1d requested review from a team as code ownersJanuary 9, 2025 13:04
@s1gr1d
s1gr1d changed the base branch from develop to v8January 9, 2025 13:05
@s1gr1ds1gr1d changed the title fix(vue): Re-throw error when no errorHandler existsfix(v8/vue): Re-throw error when no errorHandler existsJan 9, 2025
@s1gr1ds1gr1d mentioned this pull request Jan 9, 2025
Merged
@s1gr1d
s1gr1d merged commit 8926cb7 into v8Jan 9, 2025
@s1gr1d
s1gr1d deleted the sig/vue-error-throw branch January 9, 2025 15:26
s1gr1d added a commit that referenced this pull request Jan 10, 2025
@s1gr1d
fix(vue): RemovelogErrorfromvueIntegration(#14958)
04711c2
Removes `logError` and always re-throws the error when it's not handled
by the user.
PR for v8 (without removing `logError`):
#14943
Logging the error has been a problem in the past already (see
#7310). By just
re-throwing the error we don't mess around with the initial message and
stacktrace.
This was referenced Jan 10, 2025
Merged
Merged
This was referenced Jan 27, 2025
Merged
Merged
Merged
@Lms24Lms24 mentioned this pull request Feb 7, 2025
Merged
@Lms24Lms24 mentioned this pull request Mar 25, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s1gr1d@Lms24