Uh oh!
There was an error while loading. Please reload this page.
fix(v8/publish): Ensure all packages are tagged with v8 on when publishing to NPM - #19974
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛V8/Publish
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Missing
v8tag fix for@sentry/utilspackage- Changed publishConfig tag from 'latest' to 'v8' in packages/utils/package.json to prevent overwriting the latest NPM dist-tag.
Or push these changes by commenting:
@cursor push 8d56c6e414
Preview (8d56c6e414)
diff --git a/packages/utils/package.json b/packages/utils/package.json--- a/packages/utils/package.json+++ b/packages/utils/package.json@@ -37,7 +37,7 @@
},
"publishConfig": {
"access": "public",
- "tag": "latest"+ "tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1"This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
| "publishConfig": { | ||
| "access": "public" | ||
| "access": "public", | ||
| "tag": "v8" |
There was a problem hiding this comment.
Missing v8 tag fix for @sentry/utils package
High Severity
This PR aims to ensure all packages are tagged with v8 when publishing to NPM, but packages/utils/package.json still has "tag": "latest" in its publishConfig instead of "tag": "v8". Since @sentry/utils is a public, non-private package at version 8.55.1, publishing it from the v8 branch would overwrite the latest NPM dist-tag — exactly the problem this PR is trying to prevent.
There was a problem hiding this comment.
We stopped publishing utils with v9 so I think having latest there is fine
| "access": "public", | ||
| "tag": "v8" | ||
| }, | ||
| "dependencies": { |
There was a problem hiding this comment.
Bug: The @sentry/utils package is missing the "tag": "v8" update in its publishConfig, which will cause it to be incorrectly published as latest on npm.
Severity: HIGH
Suggested Fix
In packages/utils/package.json, update the publishConfig to use the "v8" tag instead of "latest". This will align it with the other public packages in the v8 branch and ensure the correct version is tagged as latest on npm.
"publishConfig": {
"access": "public",
"tag": "v8"
},Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/browser-utils/package.json#L39-L42
Potential issue: The pull request updates the `publishConfig` for several packages to
use `"tag": "v8"` instead of `"latest"`, preventing v8 releases from overriding the
`latest` npm dist-tag. However, the public package `@sentry/utils` was missed in this
change. Its `package.json` still contains `"tag": "latest"`. When the v8 branch is
published, this will cause the deprecated v8 version of `@sentry/utils` to be tagged as
`latest` on npm, overriding the expected v9 version. Users running `npm install
@sentry/utils` will then receive the incorrect, older major version.
Did we get this right? 👍 / 👎 to inform future reviews.
Uh oh!
There was an error while loading. Please reload this page.
This adds a missing
"tag": "v8"entry to the package.json of various packages on thev8branch. Not sure why we missed so many packages in the aftermath of the v9 release (#15358) but this just broke installs for a lot of packages after publishing a patch release on v8.ref #19972