Skip to content

feat(v8/deps): Upgrade all OpenTelemetry dependencies - #15098

Merged
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps
Jan 31, 2025
Merged

feat(v8/deps): Upgrade all OpenTelemetry dependencies#15098
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps

Conversation

@nwalters512

@nwalters512nwalters512 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Backport of #14967 to v8. The diff here will shrink a lot when #15094 is merged.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

The tests here are expected to fail until #15094 lands.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

@AbhiPrasad hello again! Wondering if you can offer any insight into why the suites/tracing/tedious/test.ts integration test is failing. It fails for me locally too, but only when I run the suite as a whole. If I run yarn test suites/tracing/tedious/test.ts to run it in isolation, it fails.

I added some logging of expected and envelope here:

if(expectedType!==envelopeItemType){
thrownewError(`Expected envelope item type '${expectedType}' but got '${envelopeItemType}'`);
}

It looks like the connection to the mssql server is failing:

breadcrumbs: [{timestamp: 1737481330.83,category: 'console',level: 'error',message: "ConnectionError: Login failed for user 'sa'.\n"+' at Login7TokenHandler.onErrorMessage (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/handler.js:186:19)\n'+' at Readable.<anonymous> (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js:19:33)\n'+' at Readable.emit (node:events:519:28)\n'+' at addChunk (node:internal/streams/readable:559:12)\n'+' at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)\n'+' at Readable.push (node:internal/streams/readable:391:5)\n'+' at nextAsync (node:internal/streams/from:194:22)\n'+' at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {\n'+" code: 'ELOGIN'\n"+'}'}],

@AbhiPrasad

Copy link
Copy Markdown
Contributor

closing up some of my other tasks for the day - this is top of my todo alongside getting #15119 to a mergeable state tomorrow morning.

Thanks again for all the PRs and effort @nwalters512! If you want some Sentry swag, please shoot me an email at a + prasad + @ + sentry.io (remove the pluses) and we'll get something to you 😄

@AbhiPrasadAbhiPrasad self-assigned this Jan 21, 2025
@nwalters512nwalters512 mentioned this pull request Jan 29, 2025
@klippx

Copy link
Copy Markdown

Thanks @nwalters512 you are a champion! 🏆

@andreiborza
andreiborza marked this pull request as ready for review January 31, 2025 15:35

@andreiborzaandreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now passing, this backport LGTM.

Thanks so much for this @nwalters512!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nwalters512@AbhiPrasad@klippx@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(v8/deps): Upgrade all OpenTelemetry dependencies by nwalters512 · Pull Request #15098 · getsentry/sentry-javascript · GitHub
Skip to content

feat(v8/deps): Upgrade all OpenTelemetry dependencies - #15098

Merged
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps
Jan 31, 2025
Merged

feat(v8/deps): Upgrade all OpenTelemetry dependencies#15098
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps

Conversation

@nwalters512

@nwalters512nwalters512 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Backport of #14967 to v8. The diff here will shrink a lot when #15094 is merged.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

The tests here are expected to fail until #15094 lands.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

@AbhiPrasad hello again! Wondering if you can offer any insight into why the suites/tracing/tedious/test.ts integration test is failing. It fails for me locally too, but only when I run the suite as a whole. If I run yarn test suites/tracing/tedious/test.ts to run it in isolation, it fails.

I added some logging of expected and envelope here:

if(expectedType!==envelopeItemType){
thrownewError(`Expected envelope item type '${expectedType}' but got '${envelopeItemType}'`);
}

It looks like the connection to the mssql server is failing:

breadcrumbs: [{timestamp: 1737481330.83,category: 'console',level: 'error',message: "ConnectionError: Login failed for user 'sa'.\n"+' at Login7TokenHandler.onErrorMessage (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/handler.js:186:19)\n'+' at Readable.<anonymous> (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js:19:33)\n'+' at Readable.emit (node:events:519:28)\n'+' at addChunk (node:internal/streams/readable:559:12)\n'+' at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)\n'+' at Readable.push (node:internal/streams/readable:391:5)\n'+' at nextAsync (node:internal/streams/from:194:22)\n'+' at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {\n'+" code: 'ELOGIN'\n"+'}'}],

@AbhiPrasad

Copy link
Copy Markdown
Contributor

closing up some of my other tasks for the day - this is top of my todo alongside getting #15119 to a mergeable state tomorrow morning.

Thanks again for all the PRs and effort @nwalters512! If you want some Sentry swag, please shoot me an email at a + prasad + @ + sentry.io (remove the pluses) and we'll get something to you 😄

@AbhiPrasadAbhiPrasad self-assigned this Jan 21, 2025
@nwalters512nwalters512 mentioned this pull request Jan 29, 2025
@klippx

Copy link
Copy Markdown

Thanks @nwalters512 you are a champion! 🏆

@andreiborza
andreiborza marked this pull request as ready for review January 31, 2025 15:35

@andreiborzaandreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now passing, this backport LGTM.

Thanks so much for this @nwalters512!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nwalters512@AbhiPrasad@klippx@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(v8/deps): Upgrade all OpenTelemetry dependencies by nwalters512 · Pull Request #15098 · getsentry/sentry-javascript · GitHub
Skip to content

feat(v8/deps): Upgrade all OpenTelemetry dependencies - #15098

Merged
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps
Jan 31, 2025
Merged

feat(v8/deps): Upgrade all OpenTelemetry dependencies#15098
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps

Conversation

@nwalters512

@nwalters512nwalters512 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Backport of #14967 to v8. The diff here will shrink a lot when #15094 is merged.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

The tests here are expected to fail until #15094 lands.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

@AbhiPrasad hello again! Wondering if you can offer any insight into why the suites/tracing/tedious/test.ts integration test is failing. It fails for me locally too, but only when I run the suite as a whole. If I run yarn test suites/tracing/tedious/test.ts to run it in isolation, it fails.

I added some logging of expected and envelope here:

if(expectedType!==envelopeItemType){
thrownewError(`Expected envelope item type '${expectedType}' but got '${envelopeItemType}'`);
}

It looks like the connection to the mssql server is failing:

breadcrumbs: [{timestamp: 1737481330.83,category: 'console',level: 'error',message: "ConnectionError: Login failed for user 'sa'.\n"+' at Login7TokenHandler.onErrorMessage (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/handler.js:186:19)\n'+' at Readable.<anonymous> (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js:19:33)\n'+' at Readable.emit (node:events:519:28)\n'+' at addChunk (node:internal/streams/readable:559:12)\n'+' at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)\n'+' at Readable.push (node:internal/streams/readable:391:5)\n'+' at nextAsync (node:internal/streams/from:194:22)\n'+' at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {\n'+" code: 'ELOGIN'\n"+'}'}],

@AbhiPrasad

Copy link
Copy Markdown
Contributor

closing up some of my other tasks for the day - this is top of my todo alongside getting #15119 to a mergeable state tomorrow morning.

Thanks again for all the PRs and effort @nwalters512! If you want some Sentry swag, please shoot me an email at a + prasad + @ + sentry.io (remove the pluses) and we'll get something to you 😄

@AbhiPrasadAbhiPrasad self-assigned this Jan 21, 2025
@nwalters512nwalters512 mentioned this pull request Jan 29, 2025
@klippx

Copy link
Copy Markdown

Thanks @nwalters512 you are a champion! 🏆

@andreiborza
andreiborza marked this pull request as ready for review January 31, 2025 15:35

@andreiborzaandreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now passing, this backport LGTM.

Thanks so much for this @nwalters512!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nwalters512@AbhiPrasad@klippx@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(v8/deps): Upgrade all OpenTelemetry dependencies by nwalters512 · Pull Request #15098 · getsentry/sentry-javascript · GitHub
Skip to content

feat(v8/deps): Upgrade all OpenTelemetry dependencies - #15098

Merged
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps
Jan 31, 2025
Merged

feat(v8/deps): Upgrade all OpenTelemetry dependencies#15098
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps

Conversation

@nwalters512

@nwalters512nwalters512 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Backport of #14967 to v8. The diff here will shrink a lot when #15094 is merged.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

The tests here are expected to fail until #15094 lands.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

@AbhiPrasad hello again! Wondering if you can offer any insight into why the suites/tracing/tedious/test.ts integration test is failing. It fails for me locally too, but only when I run the suite as a whole. If I run yarn test suites/tracing/tedious/test.ts to run it in isolation, it fails.

I added some logging of expected and envelope here:

if(expectedType!==envelopeItemType){
thrownewError(`Expected envelope item type '${expectedType}' but got '${envelopeItemType}'`);
}

It looks like the connection to the mssql server is failing:

breadcrumbs: [{timestamp: 1737481330.83,category: 'console',level: 'error',message: "ConnectionError: Login failed for user 'sa'.\n"+' at Login7TokenHandler.onErrorMessage (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/handler.js:186:19)\n'+' at Readable.<anonymous> (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js:19:33)\n'+' at Readable.emit (node:events:519:28)\n'+' at addChunk (node:internal/streams/readable:559:12)\n'+' at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)\n'+' at Readable.push (node:internal/streams/readable:391:5)\n'+' at nextAsync (node:internal/streams/from:194:22)\n'+' at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {\n'+" code: 'ELOGIN'\n"+'}'}],

@AbhiPrasad

Copy link
Copy Markdown
Contributor

closing up some of my other tasks for the day - this is top of my todo alongside getting #15119 to a mergeable state tomorrow morning.

Thanks again for all the PRs and effort @nwalters512! If you want some Sentry swag, please shoot me an email at a + prasad + @ + sentry.io (remove the pluses) and we'll get something to you 😄

@AbhiPrasadAbhiPrasad self-assigned this Jan 21, 2025
@nwalters512nwalters512 mentioned this pull request Jan 29, 2025
@klippx

Copy link
Copy Markdown

Thanks @nwalters512 you are a champion! 🏆

@andreiborza
andreiborza marked this pull request as ready for review January 31, 2025 15:35

@andreiborzaandreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now passing, this backport LGTM.

Thanks so much for this @nwalters512!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nwalters512@AbhiPrasad@klippx@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(v8/deps): Upgrade all OpenTelemetry dependencies by nwalters512 · Pull Request #15098 · getsentry/sentry-javascript · GitHub
Skip to content

feat(v8/deps): Upgrade all OpenTelemetry dependencies - #15098

Merged
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps
Jan 31, 2025
Merged

feat(v8/deps): Upgrade all OpenTelemetry dependencies#15098
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps

Conversation

@nwalters512

@nwalters512nwalters512 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Backport of #14967 to v8. The diff here will shrink a lot when #15094 is merged.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

The tests here are expected to fail until #15094 lands.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

@AbhiPrasad hello again! Wondering if you can offer any insight into why the suites/tracing/tedious/test.ts integration test is failing. It fails for me locally too, but only when I run the suite as a whole. If I run yarn test suites/tracing/tedious/test.ts to run it in isolation, it fails.

I added some logging of expected and envelope here:

if(expectedType!==envelopeItemType){
thrownewError(`Expected envelope item type '${expectedType}' but got '${envelopeItemType}'`);
}

It looks like the connection to the mssql server is failing:

breadcrumbs: [{timestamp: 1737481330.83,category: 'console',level: 'error',message: "ConnectionError: Login failed for user 'sa'.\n"+' at Login7TokenHandler.onErrorMessage (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/handler.js:186:19)\n'+' at Readable.<anonymous> (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js:19:33)\n'+' at Readable.emit (node:events:519:28)\n'+' at addChunk (node:internal/streams/readable:559:12)\n'+' at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)\n'+' at Readable.push (node:internal/streams/readable:391:5)\n'+' at nextAsync (node:internal/streams/from:194:22)\n'+' at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {\n'+" code: 'ELOGIN'\n"+'}'}],

@AbhiPrasad

Copy link
Copy Markdown
Contributor

closing up some of my other tasks for the day - this is top of my todo alongside getting #15119 to a mergeable state tomorrow morning.

Thanks again for all the PRs and effort @nwalters512! If you want some Sentry swag, please shoot me an email at a + prasad + @ + sentry.io (remove the pluses) and we'll get something to you 😄

@AbhiPrasadAbhiPrasad self-assigned this Jan 21, 2025
@nwalters512nwalters512 mentioned this pull request Jan 29, 2025
@klippx

Copy link
Copy Markdown

Thanks @nwalters512 you are a champion! 🏆

@andreiborza
andreiborza marked this pull request as ready for review January 31, 2025 15:35

@andreiborzaandreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now passing, this backport LGTM.

Thanks so much for this @nwalters512!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nwalters512@AbhiPrasad@klippx@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(v8/deps): Upgrade all OpenTelemetry dependencies by nwalters512 · Pull Request #15098 · getsentry/sentry-javascript · GitHub
Skip to content

feat(v8/deps): Upgrade all OpenTelemetry dependencies - #15098

Merged
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps
Jan 31, 2025
Merged

feat(v8/deps): Upgrade all OpenTelemetry dependencies#15098
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps

Conversation

@nwalters512

@nwalters512nwalters512 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Backport of #14967 to v8. The diff here will shrink a lot when #15094 is merged.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

The tests here are expected to fail until #15094 lands.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

@AbhiPrasad hello again! Wondering if you can offer any insight into why the suites/tracing/tedious/test.ts integration test is failing. It fails for me locally too, but only when I run the suite as a whole. If I run yarn test suites/tracing/tedious/test.ts to run it in isolation, it fails.

I added some logging of expected and envelope here:

if(expectedType!==envelopeItemType){
thrownewError(`Expected envelope item type '${expectedType}' but got '${envelopeItemType}'`);
}

It looks like the connection to the mssql server is failing:

breadcrumbs: [{timestamp: 1737481330.83,category: 'console',level: 'error',message: "ConnectionError: Login failed for user 'sa'.\n"+' at Login7TokenHandler.onErrorMessage (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/handler.js:186:19)\n'+' at Readable.<anonymous> (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js:19:33)\n'+' at Readable.emit (node:events:519:28)\n'+' at addChunk (node:internal/streams/readable:559:12)\n'+' at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)\n'+' at Readable.push (node:internal/streams/readable:391:5)\n'+' at nextAsync (node:internal/streams/from:194:22)\n'+' at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {\n'+" code: 'ELOGIN'\n"+'}'}],

@AbhiPrasad

Copy link
Copy Markdown
Contributor

closing up some of my other tasks for the day - this is top of my todo alongside getting #15119 to a mergeable state tomorrow morning.

Thanks again for all the PRs and effort @nwalters512! If you want some Sentry swag, please shoot me an email at a + prasad + @ + sentry.io (remove the pluses) and we'll get something to you 😄

@AbhiPrasadAbhiPrasad self-assigned this Jan 21, 2025
@nwalters512nwalters512 mentioned this pull request Jan 29, 2025
@klippx

Copy link
Copy Markdown

Thanks @nwalters512 you are a champion! 🏆

@andreiborza
andreiborza marked this pull request as ready for review January 31, 2025 15:35

@andreiborzaandreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now passing, this backport LGTM.

Thanks so much for this @nwalters512!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nwalters512@AbhiPrasad@klippx@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(v8/deps): Upgrade all OpenTelemetry dependencies by nwalters512 · Pull Request #15098 · getsentry/sentry-javascript · GitHub
Skip to content

feat(v8/deps): Upgrade all OpenTelemetry dependencies - #15098

Merged
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps
Jan 31, 2025
Merged

feat(v8/deps): Upgrade all OpenTelemetry dependencies#15098
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps

Conversation

@nwalters512

@nwalters512nwalters512 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Backport of #14967 to v8. The diff here will shrink a lot when #15094 is merged.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

The tests here are expected to fail until #15094 lands.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

@AbhiPrasad hello again! Wondering if you can offer any insight into why the suites/tracing/tedious/test.ts integration test is failing. It fails for me locally too, but only when I run the suite as a whole. If I run yarn test suites/tracing/tedious/test.ts to run it in isolation, it fails.

I added some logging of expected and envelope here:

if(expectedType!==envelopeItemType){
thrownewError(`Expected envelope item type '${expectedType}' but got '${envelopeItemType}'`);
}

It looks like the connection to the mssql server is failing:

breadcrumbs: [{timestamp: 1737481330.83,category: 'console',level: 'error',message: "ConnectionError: Login failed for user 'sa'.\n"+' at Login7TokenHandler.onErrorMessage (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/handler.js:186:19)\n'+' at Readable.<anonymous> (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js:19:33)\n'+' at Readable.emit (node:events:519:28)\n'+' at addChunk (node:internal/streams/readable:559:12)\n'+' at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)\n'+' at Readable.push (node:internal/streams/readable:391:5)\n'+' at nextAsync (node:internal/streams/from:194:22)\n'+' at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {\n'+" code: 'ELOGIN'\n"+'}'}],

@AbhiPrasad

Copy link
Copy Markdown
Contributor

closing up some of my other tasks for the day - this is top of my todo alongside getting #15119 to a mergeable state tomorrow morning.

Thanks again for all the PRs and effort @nwalters512! If you want some Sentry swag, please shoot me an email at a + prasad + @ + sentry.io (remove the pluses) and we'll get something to you 😄

@AbhiPrasadAbhiPrasad self-assigned this Jan 21, 2025
@nwalters512nwalters512 mentioned this pull request Jan 29, 2025
@klippx

Copy link
Copy Markdown

Thanks @nwalters512 you are a champion! 🏆

@andreiborza
andreiborza marked this pull request as ready for review January 31, 2025 15:35

@andreiborzaandreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now passing, this backport LGTM.

Thanks so much for this @nwalters512!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nwalters512@AbhiPrasad@klippx@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(v8/deps): Upgrade all OpenTelemetry dependencies by nwalters512 · Pull Request #15098 · getsentry/sentry-javascript · GitHub
Skip to content

feat(v8/deps): Upgrade all OpenTelemetry dependencies - #15098

Merged
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps
Jan 31, 2025
Merged

feat(v8/deps): Upgrade all OpenTelemetry dependencies#15098
andreiborza merged 5 commits into
getsentry:v8from
nwalters512:v8-upgrade-otel-deps

Conversation

@nwalters512

@nwalters512nwalters512 commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Backport of #14967 to v8. The diff here will shrink a lot when #15094 is merged.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

The tests here are expected to fail until #15094 lands.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

@AbhiPrasad hello again! Wondering if you can offer any insight into why the suites/tracing/tedious/test.ts integration test is failing. It fails for me locally too, but only when I run the suite as a whole. If I run yarn test suites/tracing/tedious/test.ts to run it in isolation, it fails.

I added some logging of expected and envelope here:

if(expectedType!==envelopeItemType){
thrownewError(`Expected envelope item type '${expectedType}' but got '${envelopeItemType}'`);
}

It looks like the connection to the mssql server is failing:

breadcrumbs: [{timestamp: 1737481330.83,category: 'console',level: 'error',message: "ConnectionError: Login failed for user 'sa'.\n"+' at Login7TokenHandler.onErrorMessage (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/handler.js:186:19)\n'+' at Readable.<anonymous> (/Users/nathan/git/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js:19:33)\n'+' at Readable.emit (node:events:519:28)\n'+' at addChunk (node:internal/streams/readable:559:12)\n'+' at readableAddChunkPushObjectMode (node:internal/streams/readable:536:3)\n'+' at Readable.push (node:internal/streams/readable:391:5)\n'+' at nextAsync (node:internal/streams/from:194:22)\n'+' at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {\n'+" code: 'ELOGIN'\n"+'}'}],

@AbhiPrasad

Copy link
Copy Markdown
Contributor

closing up some of my other tasks for the day - this is top of my todo alongside getting #15119 to a mergeable state tomorrow morning.

Thanks again for all the PRs and effort @nwalters512! If you want some Sentry swag, please shoot me an email at a + prasad + @ + sentry.io (remove the pluses) and we'll get something to you 😄

@AbhiPrasadAbhiPrasad self-assigned this Jan 21, 2025
@nwalters512nwalters512 mentioned this pull request Jan 29, 2025
@klippx

Copy link
Copy Markdown

Thanks @nwalters512 you are a champion! 🏆

@andreiborza
andreiborza marked this pull request as ready for review January 31, 2025 15:35

@andreiborzaandreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now passing, this backport LGTM.

Thanks so much for this @nwalters512!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nwalters512@AbhiPrasad@klippx@andreiborza