Uh oh!
There was an error while loading. Please reload this page.
feat(sveltekit): Only inject fetch proxy script for SvelteKit < 2.16.0 - #15126
Merged
Lms24 merged 10 commits intoJan 31, 2025
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24force-pushed
the
lms/feat-sveltekit-check-version-for-proxy-script-inject
branch
from
January 22, 2025 11:10
44f6aea to
ce32c24Compare
Base automatically changed from
lms/feat-sveltekit-remove-fetch-proxy-nonce to
developJanuary 22, 2025 11:32
Lms24force-pushed
the
lms/feat-sveltekit-check-version-for-proxy-script-inject
branch
3 times, most recently
from
January 23, 2025 07:44
46cc1a4 to
a0bc030Compare❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Lms24force-pushed
the
lms/feat-sveltekit-check-version-for-proxy-script-inject
branch
from
January 28, 2025 15:05
383920f to
f52fd16CompareLms24
commented
Jan 28, 2025
Uh oh!
There was an error while loading. Please reload this page.
Lms24
requested review from
a team, mydea and s1gr1d
and removed request for
a teamJanuary 28, 2025 15:25
Lms24
marked this pull request as ready for review
January 28, 2025 15:25
Lms24force-pushed
the
lms/feat-sveltekit-check-version-for-proxy-script-inject
branch
from
January 31, 2025 07:59
f52fd16 to
0b53e27Comparemydea
reviewed
Jan 31, 2025
| if (options.injectFetchProxyScript == null) { | ||
| try { | ||
| // @ts-expect-error - the dynamic import is fine here | ||
| const { VERSION } = await import('@sveltejs/kit'); |
Member
There was a problem hiding this comment.
l: Does it make sense to cache this somewhere? 🤔
MemberAuthor
There was a problem hiding this comment.
We do :) options.injectFetchProxyScript will only be set once
Lms24
deleted the
lms/feat-sveltekit-check-version-for-proxy-script-inject
branch
January 31, 2025 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With v9 onwards, we'll only inject the fetch proxy script into SvelteKit versions where we actually need it. This is all kit versions below 2.16.0. I'll update docs in a follow-up PR.
fixes#15007