Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
{
"name": "sveltekit-2-svelte-5",
"name": "sveltekit-2.5.0-twp",
"version": "0.0.1",
"private": true,
"scripts": {
Expand All@@ -22,7 +22,7 @@
"@sentry-internal/test-utils": "link:../../../test-utils",
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/kit": "2.5.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^5.0.0-next.115",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
port: 3031,
proxyServerName: 'sveltekit-2-twp',
proxyServerName: 'sveltekit-2.5.0-twp',
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,11 @@ import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('errors on frontend and backend are connected by the same trace', async ({ page }) => {
const clientErrorPromise = waitForError('sveltekit-2-twp', evt => {
const clientErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'Client Error';
});

const serverErrorPromise = waitForError('sveltekit-2-twp', evt => {
const serverErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'No search query provided';
});

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';

test.describe('SDK-internal behavior', () => {
test('Injects fetch proxy script for SvelteKit<2.16.0', async ({ page }) => {
await page.goto('/');

const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script ran
expect(proxyHandle).toBe('function');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/adapter-node": "^2.0.0",
"@sveltejs/kit": "^2.5.0",
"@sveltejs/kit": "^2.16.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^4.2.8",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';
import { waitForInitialPageload } from './utils';

test.describe('SDK-internal behavior', () => {
test("Doesn't inject fetch proxy script for SvelteKit>=2.16.0", async ({ page }) => {
await waitForInitialPageload(page, { route: '/' });
const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script didn't run
expect(proxyHandle).toBe('undefined');
});
});
4 changes: 1 addition & 3 deletions packages/sveltekit/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,9 +9,7 @@
"engines": {
"node": ">=18"
},
"files": [
"/build"
],
"files": ["/build"],
"main": "build/cjs/index.server.js",
"module": "build/esm/index.server.js",
"browser": "build/esm/index.client.js",
Expand Down
40 changes: 34 additions & 6 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,10 +93,10 @@ export function addSentryCodeToPage(options: { injectFetchProxyScript: boolean }
* ```
*/
export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {
const options: Required<SentryHandleOptions> = {
handleUnknownRoutes: false,
injectFetchProxyScript: true,
...handlerOptions,
const { handleUnknownRoutes, ...rest } = handlerOptions ?? {};
const options = {
handleUnknownRoutes: handleUnknownRoutes ?? false,
...rest,
};

const sentryRequestHandler: Handle = input => {
Expand DownExpand Up@@ -131,12 +131,24 @@ export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {

async function instrumentHandle(
{ event, resolve }: Parameters<Handle>[0],
options: Required<SentryHandleOptions>,
options: SentryHandleOptions,
): Promise<Response> {
if (!event.route?.id && !options.handleUnknownRoutes) {
return resolve(event);
}

// caching the result of the version check in `options.injectFetchProxyScript`
// to avoid doing the dynamic import on every request
if (options.injectFetchProxyScript == null) {
try {
// @ts-expect-error - the dynamic import is fine here
const { VERSION } = await import('@sveltejs/kit');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Does it make sense to cache this somewhere? 🤔

@Lms24Lms24Jan 31, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do :) options.injectFetchProxyScript will only be set once

options.injectFetchProxyScript = isFetchProxyRequired(VERSION);
} catch {
options.injectFetchProxyScript = true;
}
}

const routeName = `${event.request.method} ${event.route?.id || event.url.pathname}`;

if (getIsolationScope() !== getDefaultIsolationScope()) {
Expand All@@ -161,7 +173,7 @@ async function instrumentHandle(
normalizedRequest: winterCGRequestToRequestData(event.request.clone()),
});
const res = await resolve(event, {
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript }),
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript ?? true }),
});
if (span) {
setHttpStatus(span, res.status);
Expand All@@ -177,3 +189,19 @@ async function instrumentHandle(
await flushIfServerless();
}
}

/**
* We only need to inject the fetch proxy script for SvelteKit versions < 2.16.0.
* Exported only for testing.
*/
export function isFetchProxyRequired(version: string): boolean {
try {
const [major, minor] = version.trim().replace(/-.*/, '').split('.').map(Number);
if (major != null && minor != null && (major > 2 || (major === 2 && minor >= 16))) {
return false;
}
} catch {
// ignore
}
return true;
}
19 changes: 18 additions & 1 deletion packages/sveltekit/test/server/handle.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import type { Handle } from '@sveltejs/kit';
import { redirect } from '@sveltejs/kit';
import { vi } from 'vitest';

import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, sentryHandle } from '../../src/server/handle';
import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, isFetchProxyRequired, sentryHandle } from '../../src/server/handle';
import { getDefaultNodeClientOptions } from '../utils';

const mockCaptureException = vi.spyOn(SentryNode, 'captureException').mockImplementation(() => 'xx');
Expand DownExpand Up@@ -462,3 +462,20 @@ describe('addSentryCodeToPage', () => {
expect(transformed).not.toContain(`<script >${FETCH_PROXY_SCRIPT}</script>`);
});
});

describe('isFetchProxyRequired', () => {
it.each(['2.16.0', '2.16.1', '2.17.0', '3.0.0', '3.0.0-alpha.0'])(
'returns false if the version is greater than or equal to 2.16.0 (%s)',
version => {
expect(isFetchProxyRequired(version)).toBe(false);
},
);

it.each(['2.15.0', '2.15.1', '1.30.0', '1.0.0'])('returns true if the version is lower than 2.16.0 (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});

it.each(['invalid', 'a.b.c'])('returns true for an invalid version (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
{
"name": "sveltekit-2-svelte-5",
"name": "sveltekit-2.5.0-twp",
"version": "0.0.1",
"private": true,
"scripts": {
Expand All@@ -22,7 +22,7 @@
"@sentry-internal/test-utils": "link:../../../test-utils",
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/kit": "2.5.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^5.0.0-next.115",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
port: 3031,
proxyServerName: 'sveltekit-2-twp',
proxyServerName: 'sveltekit-2.5.0-twp',
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,11 @@ import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('errors on frontend and backend are connected by the same trace', async ({ page }) => {
const clientErrorPromise = waitForError('sveltekit-2-twp', evt => {
const clientErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'Client Error';
});

const serverErrorPromise = waitForError('sveltekit-2-twp', evt => {
const serverErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'No search query provided';
});

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';

test.describe('SDK-internal behavior', () => {
test('Injects fetch proxy script for SvelteKit<2.16.0', async ({ page }) => {
await page.goto('/');

const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script ran
expect(proxyHandle).toBe('function');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/adapter-node": "^2.0.0",
"@sveltejs/kit": "^2.5.0",
"@sveltejs/kit": "^2.16.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^4.2.8",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';
import { waitForInitialPageload } from './utils';

test.describe('SDK-internal behavior', () => {
test("Doesn't inject fetch proxy script for SvelteKit>=2.16.0", async ({ page }) => {
await waitForInitialPageload(page, { route: '/' });
const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script didn't run
expect(proxyHandle).toBe('undefined');
});
});
4 changes: 1 addition & 3 deletions packages/sveltekit/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,9 +9,7 @@
"engines": {
"node": ">=18"
},
"files": [
"/build"
],
"files": ["/build"],
"main": "build/cjs/index.server.js",
"module": "build/esm/index.server.js",
"browser": "build/esm/index.client.js",
Expand Down
40 changes: 34 additions & 6 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,10 +93,10 @@ export function addSentryCodeToPage(options: { injectFetchProxyScript: boolean }
* ```
*/
export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {
const options: Required<SentryHandleOptions> = {
handleUnknownRoutes: false,
injectFetchProxyScript: true,
...handlerOptions,
const { handleUnknownRoutes, ...rest } = handlerOptions ?? {};
const options = {
handleUnknownRoutes: handleUnknownRoutes ?? false,
...rest,
};

const sentryRequestHandler: Handle = input => {
Expand DownExpand Up@@ -131,12 +131,24 @@ export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {

async function instrumentHandle(
{ event, resolve }: Parameters<Handle>[0],
options: Required<SentryHandleOptions>,
options: SentryHandleOptions,
): Promise<Response> {
if (!event.route?.id && !options.handleUnknownRoutes) {
return resolve(event);
}

// caching the result of the version check in `options.injectFetchProxyScript`
// to avoid doing the dynamic import on every request
if (options.injectFetchProxyScript == null) {
try {
// @ts-expect-error - the dynamic import is fine here
const { VERSION } = await import('@sveltejs/kit');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Does it make sense to cache this somewhere? 🤔

@Lms24Lms24Jan 31, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do :) options.injectFetchProxyScript will only be set once

options.injectFetchProxyScript = isFetchProxyRequired(VERSION);
} catch {
options.injectFetchProxyScript = true;
}
}

const routeName = `${event.request.method} ${event.route?.id || event.url.pathname}`;

if (getIsolationScope() !== getDefaultIsolationScope()) {
Expand All@@ -161,7 +173,7 @@ async function instrumentHandle(
normalizedRequest: winterCGRequestToRequestData(event.request.clone()),
});
const res = await resolve(event, {
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript }),
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript ?? true }),
});
if (span) {
setHttpStatus(span, res.status);
Expand All@@ -177,3 +189,19 @@ async function instrumentHandle(
await flushIfServerless();
}
}

/**
* We only need to inject the fetch proxy script for SvelteKit versions < 2.16.0.
* Exported only for testing.
*/
export function isFetchProxyRequired(version: string): boolean {
try {
const [major, minor] = version.trim().replace(/-.*/, '').split('.').map(Number);
if (major != null && minor != null && (major > 2 || (major === 2 && minor >= 16))) {
return false;
}
} catch {
// ignore
}
return true;
}
19 changes: 18 additions & 1 deletion packages/sveltekit/test/server/handle.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import type { Handle } from '@sveltejs/kit';
import { redirect } from '@sveltejs/kit';
import { vi } from 'vitest';

import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, sentryHandle } from '../../src/server/handle';
import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, isFetchProxyRequired, sentryHandle } from '../../src/server/handle';
import { getDefaultNodeClientOptions } from '../utils';

const mockCaptureException = vi.spyOn(SentryNode, 'captureException').mockImplementation(() => 'xx');
Expand DownExpand Up@@ -462,3 +462,20 @@ describe('addSentryCodeToPage', () => {
expect(transformed).not.toContain(`<script >${FETCH_PROXY_SCRIPT}</script>`);
});
});

describe('isFetchProxyRequired', () => {
it.each(['2.16.0', '2.16.1', '2.17.0', '3.0.0', '3.0.0-alpha.0'])(
'returns false if the version is greater than or equal to 2.16.0 (%s)',
version => {
expect(isFetchProxyRequired(version)).toBe(false);
},
);

it.each(['2.15.0', '2.15.1', '1.30.0', '1.0.0'])('returns true if the version is lower than 2.16.0 (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});

it.each(['invalid', 'a.b.c'])('returns true for an invalid version (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
{
"name": "sveltekit-2-svelte-5",
"name": "sveltekit-2.5.0-twp",
"version": "0.0.1",
"private": true,
"scripts": {
Expand All@@ -22,7 +22,7 @@
"@sentry-internal/test-utils": "link:../../../test-utils",
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/kit": "2.5.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^5.0.0-next.115",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
port: 3031,
proxyServerName: 'sveltekit-2-twp',
proxyServerName: 'sveltekit-2.5.0-twp',
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,11 @@ import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('errors on frontend and backend are connected by the same trace', async ({ page }) => {
const clientErrorPromise = waitForError('sveltekit-2-twp', evt => {
const clientErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'Client Error';
});

const serverErrorPromise = waitForError('sveltekit-2-twp', evt => {
const serverErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'No search query provided';
});

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';

test.describe('SDK-internal behavior', () => {
test('Injects fetch proxy script for SvelteKit<2.16.0', async ({ page }) => {
await page.goto('/');

const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script ran
expect(proxyHandle).toBe('function');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/adapter-node": "^2.0.0",
"@sveltejs/kit": "^2.5.0",
"@sveltejs/kit": "^2.16.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^4.2.8",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';
import { waitForInitialPageload } from './utils';

test.describe('SDK-internal behavior', () => {
test("Doesn't inject fetch proxy script for SvelteKit>=2.16.0", async ({ page }) => {
await waitForInitialPageload(page, { route: '/' });
const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script didn't run
expect(proxyHandle).toBe('undefined');
});
});
4 changes: 1 addition & 3 deletions packages/sveltekit/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,9 +9,7 @@
"engines": {
"node": ">=18"
},
"files": [
"/build"
],
"files": ["/build"],
"main": "build/cjs/index.server.js",
"module": "build/esm/index.server.js",
"browser": "build/esm/index.client.js",
Expand Down
40 changes: 34 additions & 6 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,10 +93,10 @@ export function addSentryCodeToPage(options: { injectFetchProxyScript: boolean }
* ```
*/
export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {
const options: Required<SentryHandleOptions> = {
handleUnknownRoutes: false,
injectFetchProxyScript: true,
...handlerOptions,
const { handleUnknownRoutes, ...rest } = handlerOptions ?? {};
const options = {
handleUnknownRoutes: handleUnknownRoutes ?? false,
...rest,
};

const sentryRequestHandler: Handle = input => {
Expand DownExpand Up@@ -131,12 +131,24 @@ export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {

async function instrumentHandle(
{ event, resolve }: Parameters<Handle>[0],
options: Required<SentryHandleOptions>,
options: SentryHandleOptions,
): Promise<Response> {
if (!event.route?.id && !options.handleUnknownRoutes) {
return resolve(event);
}

// caching the result of the version check in `options.injectFetchProxyScript`
// to avoid doing the dynamic import on every request
if (options.injectFetchProxyScript == null) {
try {
// @ts-expect-error - the dynamic import is fine here
const { VERSION } = await import('@sveltejs/kit');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Does it make sense to cache this somewhere? 🤔

@Lms24Lms24Jan 31, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do :) options.injectFetchProxyScript will only be set once

options.injectFetchProxyScript = isFetchProxyRequired(VERSION);
} catch {
options.injectFetchProxyScript = true;
}
}

const routeName = `${event.request.method} ${event.route?.id || event.url.pathname}`;

if (getIsolationScope() !== getDefaultIsolationScope()) {
Expand All@@ -161,7 +173,7 @@ async function instrumentHandle(
normalizedRequest: winterCGRequestToRequestData(event.request.clone()),
});
const res = await resolve(event, {
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript }),
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript ?? true }),
});
if (span) {
setHttpStatus(span, res.status);
Expand All@@ -177,3 +189,19 @@ async function instrumentHandle(
await flushIfServerless();
}
}

/**
* We only need to inject the fetch proxy script for SvelteKit versions < 2.16.0.
* Exported only for testing.
*/
export function isFetchProxyRequired(version: string): boolean {
try {
const [major, minor] = version.trim().replace(/-.*/, '').split('.').map(Number);
if (major != null && minor != null && (major > 2 || (major === 2 && minor >= 16))) {
return false;
}
} catch {
// ignore
}
return true;
}
19 changes: 18 additions & 1 deletion packages/sveltekit/test/server/handle.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import type { Handle } from '@sveltejs/kit';
import { redirect } from '@sveltejs/kit';
import { vi } from 'vitest';

import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, sentryHandle } from '../../src/server/handle';
import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, isFetchProxyRequired, sentryHandle } from '../../src/server/handle';
import { getDefaultNodeClientOptions } from '../utils';

const mockCaptureException = vi.spyOn(SentryNode, 'captureException').mockImplementation(() => 'xx');
Expand DownExpand Up@@ -462,3 +462,20 @@ describe('addSentryCodeToPage', () => {
expect(transformed).not.toContain(`<script >${FETCH_PROXY_SCRIPT}</script>`);
});
});

describe('isFetchProxyRequired', () => {
it.each(['2.16.0', '2.16.1', '2.17.0', '3.0.0', '3.0.0-alpha.0'])(
'returns false if the version is greater than or equal to 2.16.0 (%s)',
version => {
expect(isFetchProxyRequired(version)).toBe(false);
},
);

it.each(['2.15.0', '2.15.1', '1.30.0', '1.0.0'])('returns true if the version is lower than 2.16.0 (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});

it.each(['invalid', 'a.b.c'])('returns true for an invalid version (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
{
"name": "sveltekit-2-svelte-5",
"name": "sveltekit-2.5.0-twp",
"version": "0.0.1",
"private": true,
"scripts": {
Expand All@@ -22,7 +22,7 @@
"@sentry-internal/test-utils": "link:../../../test-utils",
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/kit": "2.5.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^5.0.0-next.115",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
port: 3031,
proxyServerName: 'sveltekit-2-twp',
proxyServerName: 'sveltekit-2.5.0-twp',
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,11 @@ import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('errors on frontend and backend are connected by the same trace', async ({ page }) => {
const clientErrorPromise = waitForError('sveltekit-2-twp', evt => {
const clientErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'Client Error';
});

const serverErrorPromise = waitForError('sveltekit-2-twp', evt => {
const serverErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'No search query provided';
});

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';

test.describe('SDK-internal behavior', () => {
test('Injects fetch proxy script for SvelteKit<2.16.0', async ({ page }) => {
await page.goto('/');

const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script ran
expect(proxyHandle).toBe('function');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/adapter-node": "^2.0.0",
"@sveltejs/kit": "^2.5.0",
"@sveltejs/kit": "^2.16.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^4.2.8",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';
import { waitForInitialPageload } from './utils';

test.describe('SDK-internal behavior', () => {
test("Doesn't inject fetch proxy script for SvelteKit>=2.16.0", async ({ page }) => {
await waitForInitialPageload(page, { route: '/' });
const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script didn't run
expect(proxyHandle).toBe('undefined');
});
});
4 changes: 1 addition & 3 deletions packages/sveltekit/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,9 +9,7 @@
"engines": {
"node": ">=18"
},
"files": [
"/build"
],
"files": ["/build"],
"main": "build/cjs/index.server.js",
"module": "build/esm/index.server.js",
"browser": "build/esm/index.client.js",
Expand Down
40 changes: 34 additions & 6 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,10 +93,10 @@ export function addSentryCodeToPage(options: { injectFetchProxyScript: boolean }
* ```
*/
export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {
const options: Required<SentryHandleOptions> = {
handleUnknownRoutes: false,
injectFetchProxyScript: true,
...handlerOptions,
const { handleUnknownRoutes, ...rest } = handlerOptions ?? {};
const options = {
handleUnknownRoutes: handleUnknownRoutes ?? false,
...rest,
};

const sentryRequestHandler: Handle = input => {
Expand DownExpand Up@@ -131,12 +131,24 @@ export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {

async function instrumentHandle(
{ event, resolve }: Parameters<Handle>[0],
options: Required<SentryHandleOptions>,
options: SentryHandleOptions,
): Promise<Response> {
if (!event.route?.id && !options.handleUnknownRoutes) {
return resolve(event);
}

// caching the result of the version check in `options.injectFetchProxyScript`
// to avoid doing the dynamic import on every request
if (options.injectFetchProxyScript == null) {
try {
// @ts-expect-error - the dynamic import is fine here
const { VERSION } = await import('@sveltejs/kit');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Does it make sense to cache this somewhere? 🤔

@Lms24Lms24Jan 31, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do :) options.injectFetchProxyScript will only be set once

options.injectFetchProxyScript = isFetchProxyRequired(VERSION);
} catch {
options.injectFetchProxyScript = true;
}
}

const routeName = `${event.request.method} ${event.route?.id || event.url.pathname}`;

if (getIsolationScope() !== getDefaultIsolationScope()) {
Expand All@@ -161,7 +173,7 @@ async function instrumentHandle(
normalizedRequest: winterCGRequestToRequestData(event.request.clone()),
});
const res = await resolve(event, {
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript }),
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript ?? true }),
});
if (span) {
setHttpStatus(span, res.status);
Expand All@@ -177,3 +189,19 @@ async function instrumentHandle(
await flushIfServerless();
}
}

/**
* We only need to inject the fetch proxy script for SvelteKit versions < 2.16.0.
* Exported only for testing.
*/
export function isFetchProxyRequired(version: string): boolean {
try {
const [major, minor] = version.trim().replace(/-.*/, '').split('.').map(Number);
if (major != null && minor != null && (major > 2 || (major === 2 && minor >= 16))) {
return false;
}
} catch {
// ignore
}
return true;
}
19 changes: 18 additions & 1 deletion packages/sveltekit/test/server/handle.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import type { Handle } from '@sveltejs/kit';
import { redirect } from '@sveltejs/kit';
import { vi } from 'vitest';

import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, sentryHandle } from '../../src/server/handle';
import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, isFetchProxyRequired, sentryHandle } from '../../src/server/handle';
import { getDefaultNodeClientOptions } from '../utils';

const mockCaptureException = vi.spyOn(SentryNode, 'captureException').mockImplementation(() => 'xx');
Expand DownExpand Up@@ -462,3 +462,20 @@ describe('addSentryCodeToPage', () => {
expect(transformed).not.toContain(`<script >${FETCH_PROXY_SCRIPT}</script>`);
});
});

describe('isFetchProxyRequired', () => {
it.each(['2.16.0', '2.16.1', '2.17.0', '3.0.0', '3.0.0-alpha.0'])(
'returns false if the version is greater than or equal to 2.16.0 (%s)',
version => {
expect(isFetchProxyRequired(version)).toBe(false);
},
);

it.each(['2.15.0', '2.15.1', '1.30.0', '1.0.0'])('returns true if the version is lower than 2.16.0 (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});

it.each(['invalid', 'a.b.c'])('returns true for an invalid version (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
{
"name": "sveltekit-2-svelte-5",
"name": "sveltekit-2.5.0-twp",
"version": "0.0.1",
"private": true,
"scripts": {
Expand All@@ -22,7 +22,7 @@
"@sentry-internal/test-utils": "link:../../../test-utils",
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/kit": "2.5.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^5.0.0-next.115",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
port: 3031,
proxyServerName: 'sveltekit-2-twp',
proxyServerName: 'sveltekit-2.5.0-twp',
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,11 @@ import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('errors on frontend and backend are connected by the same trace', async ({ page }) => {
const clientErrorPromise = waitForError('sveltekit-2-twp', evt => {
const clientErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'Client Error';
});

const serverErrorPromise = waitForError('sveltekit-2-twp', evt => {
const serverErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'No search query provided';
});

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';

test.describe('SDK-internal behavior', () => {
test('Injects fetch proxy script for SvelteKit<2.16.0', async ({ page }) => {
await page.goto('/');

const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script ran
expect(proxyHandle).toBe('function');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/adapter-node": "^2.0.0",
"@sveltejs/kit": "^2.5.0",
"@sveltejs/kit": "^2.16.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^4.2.8",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';
import { waitForInitialPageload } from './utils';

test.describe('SDK-internal behavior', () => {
test("Doesn't inject fetch proxy script for SvelteKit>=2.16.0", async ({ page }) => {
await waitForInitialPageload(page, { route: '/' });
const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script didn't run
expect(proxyHandle).toBe('undefined');
});
});
4 changes: 1 addition & 3 deletions packages/sveltekit/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,9 +9,7 @@
"engines": {
"node": ">=18"
},
"files": [
"/build"
],
"files": ["/build"],
"main": "build/cjs/index.server.js",
"module": "build/esm/index.server.js",
"browser": "build/esm/index.client.js",
Expand Down
40 changes: 34 additions & 6 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,10 +93,10 @@ export function addSentryCodeToPage(options: { injectFetchProxyScript: boolean }
* ```
*/
export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {
const options: Required<SentryHandleOptions> = {
handleUnknownRoutes: false,
injectFetchProxyScript: true,
...handlerOptions,
const { handleUnknownRoutes, ...rest } = handlerOptions ?? {};
const options = {
handleUnknownRoutes: handleUnknownRoutes ?? false,
...rest,
};

const sentryRequestHandler: Handle = input => {
Expand DownExpand Up@@ -131,12 +131,24 @@ export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {

async function instrumentHandle(
{ event, resolve }: Parameters<Handle>[0],
options: Required<SentryHandleOptions>,
options: SentryHandleOptions,
): Promise<Response> {
if (!event.route?.id && !options.handleUnknownRoutes) {
return resolve(event);
}

// caching the result of the version check in `options.injectFetchProxyScript`
// to avoid doing the dynamic import on every request
if (options.injectFetchProxyScript == null) {
try {
// @ts-expect-error - the dynamic import is fine here
const { VERSION } = await import('@sveltejs/kit');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Does it make sense to cache this somewhere? 🤔

@Lms24Lms24Jan 31, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do :) options.injectFetchProxyScript will only be set once

options.injectFetchProxyScript = isFetchProxyRequired(VERSION);
} catch {
options.injectFetchProxyScript = true;
}
}

const routeName = `${event.request.method} ${event.route?.id || event.url.pathname}`;

if (getIsolationScope() !== getDefaultIsolationScope()) {
Expand All@@ -161,7 +173,7 @@ async function instrumentHandle(
normalizedRequest: winterCGRequestToRequestData(event.request.clone()),
});
const res = await resolve(event, {
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript }),
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript ?? true }),
});
if (span) {
setHttpStatus(span, res.status);
Expand All@@ -177,3 +189,19 @@ async function instrumentHandle(
await flushIfServerless();
}
}

/**
* We only need to inject the fetch proxy script for SvelteKit versions < 2.16.0.
* Exported only for testing.
*/
export function isFetchProxyRequired(version: string): boolean {
try {
const [major, minor] = version.trim().replace(/-.*/, '').split('.').map(Number);
if (major != null && minor != null && (major > 2 || (major === 2 && minor >= 16))) {
return false;
}
} catch {
// ignore
}
return true;
}
19 changes: 18 additions & 1 deletion packages/sveltekit/test/server/handle.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import type { Handle } from '@sveltejs/kit';
import { redirect } from '@sveltejs/kit';
import { vi } from 'vitest';

import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, sentryHandle } from '../../src/server/handle';
import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, isFetchProxyRequired, sentryHandle } from '../../src/server/handle';
import { getDefaultNodeClientOptions } from '../utils';

const mockCaptureException = vi.spyOn(SentryNode, 'captureException').mockImplementation(() => 'xx');
Expand DownExpand Up@@ -462,3 +462,20 @@ describe('addSentryCodeToPage', () => {
expect(transformed).not.toContain(`<script >${FETCH_PROXY_SCRIPT}</script>`);
});
});

describe('isFetchProxyRequired', () => {
it.each(['2.16.0', '2.16.1', '2.17.0', '3.0.0', '3.0.0-alpha.0'])(
'returns false if the version is greater than or equal to 2.16.0 (%s)',
version => {
expect(isFetchProxyRequired(version)).toBe(false);
},
);

it.each(['2.15.0', '2.15.1', '1.30.0', '1.0.0'])('returns true if the version is lower than 2.16.0 (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});

it.each(['invalid', 'a.b.c'])('returns true for an invalid version (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
{
"name": "sveltekit-2-svelte-5",
"name": "sveltekit-2.5.0-twp",
"version": "0.0.1",
"private": true,
"scripts": {
Expand All@@ -22,7 +22,7 @@
"@sentry-internal/test-utils": "link:../../../test-utils",
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/kit": "2.5.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^5.0.0-next.115",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
port: 3031,
proxyServerName: 'sveltekit-2-twp',
proxyServerName: 'sveltekit-2.5.0-twp',
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,11 @@ import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('errors on frontend and backend are connected by the same trace', async ({ page }) => {
const clientErrorPromise = waitForError('sveltekit-2-twp', evt => {
const clientErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'Client Error';
});

const serverErrorPromise = waitForError('sveltekit-2-twp', evt => {
const serverErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'No search query provided';
});

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';

test.describe('SDK-internal behavior', () => {
test('Injects fetch proxy script for SvelteKit<2.16.0', async ({ page }) => {
await page.goto('/');

const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script ran
expect(proxyHandle).toBe('function');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/adapter-node": "^2.0.0",
"@sveltejs/kit": "^2.5.0",
"@sveltejs/kit": "^2.16.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^4.2.8",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';
import { waitForInitialPageload } from './utils';

test.describe('SDK-internal behavior', () => {
test("Doesn't inject fetch proxy script for SvelteKit>=2.16.0", async ({ page }) => {
await waitForInitialPageload(page, { route: '/' });
const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script didn't run
expect(proxyHandle).toBe('undefined');
});
});
4 changes: 1 addition & 3 deletions packages/sveltekit/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,9 +9,7 @@
"engines": {
"node": ">=18"
},
"files": [
"/build"
],
"files": ["/build"],
"main": "build/cjs/index.server.js",
"module": "build/esm/index.server.js",
"browser": "build/esm/index.client.js",
Expand Down
40 changes: 34 additions & 6 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,10 +93,10 @@ export function addSentryCodeToPage(options: { injectFetchProxyScript: boolean }
* ```
*/
export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {
const options: Required<SentryHandleOptions> = {
handleUnknownRoutes: false,
injectFetchProxyScript: true,
...handlerOptions,
const { handleUnknownRoutes, ...rest } = handlerOptions ?? {};
const options = {
handleUnknownRoutes: handleUnknownRoutes ?? false,
...rest,
};

const sentryRequestHandler: Handle = input => {
Expand DownExpand Up@@ -131,12 +131,24 @@ export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {

async function instrumentHandle(
{ event, resolve }: Parameters<Handle>[0],
options: Required<SentryHandleOptions>,
options: SentryHandleOptions,
): Promise<Response> {
if (!event.route?.id && !options.handleUnknownRoutes) {
return resolve(event);
}

// caching the result of the version check in `options.injectFetchProxyScript`
// to avoid doing the dynamic import on every request
if (options.injectFetchProxyScript == null) {
try {
// @ts-expect-error - the dynamic import is fine here
const { VERSION } = await import('@sveltejs/kit');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Does it make sense to cache this somewhere? 🤔

@Lms24Lms24Jan 31, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do :) options.injectFetchProxyScript will only be set once

options.injectFetchProxyScript = isFetchProxyRequired(VERSION);
} catch {
options.injectFetchProxyScript = true;
}
}

const routeName = `${event.request.method} ${event.route?.id || event.url.pathname}`;

if (getIsolationScope() !== getDefaultIsolationScope()) {
Expand All@@ -161,7 +173,7 @@ async function instrumentHandle(
normalizedRequest: winterCGRequestToRequestData(event.request.clone()),
});
const res = await resolve(event, {
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript }),
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript ?? true }),
});
if (span) {
setHttpStatus(span, res.status);
Expand All@@ -177,3 +189,19 @@ async function instrumentHandle(
await flushIfServerless();
}
}

/**
* We only need to inject the fetch proxy script for SvelteKit versions < 2.16.0.
* Exported only for testing.
*/
export function isFetchProxyRequired(version: string): boolean {
try {
const [major, minor] = version.trim().replace(/-.*/, '').split('.').map(Number);
if (major != null && minor != null && (major > 2 || (major === 2 && minor >= 16))) {
return false;
}
} catch {
// ignore
}
return true;
}
19 changes: 18 additions & 1 deletion packages/sveltekit/test/server/handle.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import type { Handle } from '@sveltejs/kit';
import { redirect } from '@sveltejs/kit';
import { vi } from 'vitest';

import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, sentryHandle } from '../../src/server/handle';
import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, isFetchProxyRequired, sentryHandle } from '../../src/server/handle';
import { getDefaultNodeClientOptions } from '../utils';

const mockCaptureException = vi.spyOn(SentryNode, 'captureException').mockImplementation(() => 'xx');
Expand DownExpand Up@@ -462,3 +462,20 @@ describe('addSentryCodeToPage', () => {
expect(transformed).not.toContain(`<script >${FETCH_PROXY_SCRIPT}</script>`);
});
});

describe('isFetchProxyRequired', () => {
it.each(['2.16.0', '2.16.1', '2.17.0', '3.0.0', '3.0.0-alpha.0'])(
'returns false if the version is greater than or equal to 2.16.0 (%s)',
version => {
expect(isFetchProxyRequired(version)).toBe(false);
},
);

it.each(['2.15.0', '2.15.1', '1.30.0', '1.0.0'])('returns true if the version is lower than 2.16.0 (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});

it.each(['invalid', 'a.b.c'])('returns true for an invalid version (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
{
"name": "sveltekit-2-svelte-5",
"name": "sveltekit-2.5.0-twp",
"version": "0.0.1",
"private": true,
"scripts": {
Expand All@@ -22,7 +22,7 @@
"@sentry-internal/test-utils": "link:../../../test-utils",
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/kit": "2.5.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^5.0.0-next.115",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
port: 3031,
proxyServerName: 'sveltekit-2-twp',
proxyServerName: 'sveltekit-2.5.0-twp',
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,11 @@ import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('errors on frontend and backend are connected by the same trace', async ({ page }) => {
const clientErrorPromise = waitForError('sveltekit-2-twp', evt => {
const clientErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'Client Error';
});

const serverErrorPromise = waitForError('sveltekit-2-twp', evt => {
const serverErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'No search query provided';
});

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';

test.describe('SDK-internal behavior', () => {
test('Injects fetch proxy script for SvelteKit<2.16.0', async ({ page }) => {
await page.goto('/');

const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script ran
expect(proxyHandle).toBe('function');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/adapter-node": "^2.0.0",
"@sveltejs/kit": "^2.5.0",
"@sveltejs/kit": "^2.16.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^4.2.8",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';
import { waitForInitialPageload } from './utils';

test.describe('SDK-internal behavior', () => {
test("Doesn't inject fetch proxy script for SvelteKit>=2.16.0", async ({ page }) => {
await waitForInitialPageload(page, { route: '/' });
const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script didn't run
expect(proxyHandle).toBe('undefined');
});
});
4 changes: 1 addition & 3 deletions packages/sveltekit/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,9 +9,7 @@
"engines": {
"node": ">=18"
},
"files": [
"/build"
],
"files": ["/build"],
"main": "build/cjs/index.server.js",
"module": "build/esm/index.server.js",
"browser": "build/esm/index.client.js",
Expand Down
40 changes: 34 additions & 6 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,10 +93,10 @@ export function addSentryCodeToPage(options: { injectFetchProxyScript: boolean }
* ```
*/
export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {
const options: Required<SentryHandleOptions> = {
handleUnknownRoutes: false,
injectFetchProxyScript: true,
...handlerOptions,
const { handleUnknownRoutes, ...rest } = handlerOptions ?? {};
const options = {
handleUnknownRoutes: handleUnknownRoutes ?? false,
...rest,
};

const sentryRequestHandler: Handle = input => {
Expand DownExpand Up@@ -131,12 +131,24 @@ export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {

async function instrumentHandle(
{ event, resolve }: Parameters<Handle>[0],
options: Required<SentryHandleOptions>,
options: SentryHandleOptions,
): Promise<Response> {
if (!event.route?.id && !options.handleUnknownRoutes) {
return resolve(event);
}

// caching the result of the version check in `options.injectFetchProxyScript`
// to avoid doing the dynamic import on every request
if (options.injectFetchProxyScript == null) {
try {
// @ts-expect-error - the dynamic import is fine here
const { VERSION } = await import('@sveltejs/kit');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Does it make sense to cache this somewhere? 🤔

@Lms24Lms24Jan 31, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do :) options.injectFetchProxyScript will only be set once

options.injectFetchProxyScript = isFetchProxyRequired(VERSION);
} catch {
options.injectFetchProxyScript = true;
}
}

const routeName = `${event.request.method} ${event.route?.id || event.url.pathname}`;

if (getIsolationScope() !== getDefaultIsolationScope()) {
Expand All@@ -161,7 +173,7 @@ async function instrumentHandle(
normalizedRequest: winterCGRequestToRequestData(event.request.clone()),
});
const res = await resolve(event, {
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript }),
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript ?? true }),
});
if (span) {
setHttpStatus(span, res.status);
Expand All@@ -177,3 +189,19 @@ async function instrumentHandle(
await flushIfServerless();
}
}

/**
* We only need to inject the fetch proxy script for SvelteKit versions < 2.16.0.
* Exported only for testing.
*/
export function isFetchProxyRequired(version: string): boolean {
try {
const [major, minor] = version.trim().replace(/-.*/, '').split('.').map(Number);
if (major != null && minor != null && (major > 2 || (major === 2 && minor >= 16))) {
return false;
}
} catch {
// ignore
}
return true;
}
19 changes: 18 additions & 1 deletion packages/sveltekit/test/server/handle.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import type { Handle } from '@sveltejs/kit';
import { redirect } from '@sveltejs/kit';
import { vi } from 'vitest';

import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, sentryHandle } from '../../src/server/handle';
import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, isFetchProxyRequired, sentryHandle } from '../../src/server/handle';
import { getDefaultNodeClientOptions } from '../utils';

const mockCaptureException = vi.spyOn(SentryNode, 'captureException').mockImplementation(() => 'xx');
Expand DownExpand Up@@ -462,3 +462,20 @@ describe('addSentryCodeToPage', () => {
expect(transformed).not.toContain(`<script >${FETCH_PROXY_SCRIPT}</script>`);
});
});

describe('isFetchProxyRequired', () => {
it.each(['2.16.0', '2.16.1', '2.17.0', '3.0.0', '3.0.0-alpha.0'])(
'returns false if the version is greater than or equal to 2.16.0 (%s)',
version => {
expect(isFetchProxyRequired(version)).toBe(false);
},
);

it.each(['2.15.0', '2.15.1', '1.30.0', '1.0.0'])('returns true if the version is lower than 2.16.0 (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});

it.each(['invalid', 'a.b.c'])('returns true for an invalid version (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
{
"name": "sveltekit-2-svelte-5",
"name": "sveltekit-2.5.0-twp",
"version": "0.0.1",
"private": true,
"scripts": {
Expand All@@ -22,7 +22,7 @@
"@sentry-internal/test-utils": "link:../../../test-utils",
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/kit": "^2.0.0",
"@sveltejs/kit": "2.5.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^5.0.0-next.115",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';

startEventProxyServer({
port: 3031,
proxyServerName: 'sveltekit-2-twp',
proxyServerName: 'sveltekit-2.5.0-twp',
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,11 @@ import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('errors on frontend and backend are connected by the same trace', async ({ page }) => {
const clientErrorPromise = waitForError('sveltekit-2-twp', evt => {
const clientErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'Client Error';
});

const serverErrorPromise = waitForError('sveltekit-2-twp', evt => {
const serverErrorPromise = waitForError('sveltekit-2.5.0-twp', evt => {
return evt.exception?.values?.[0].value === 'No search query provided';
});

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';

test.describe('SDK-internal behavior', () => {
test('Injects fetch proxy script for SvelteKit<2.16.0', async ({ page }) => {
await page.goto('/');

const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script ran
expect(proxyHandle).toBe('function');
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@
"@sentry/core": "latest || *",
"@sveltejs/adapter-auto": "^3.0.0",
"@sveltejs/adapter-node": "^2.0.0",
"@sveltejs/kit": "^2.5.0",
"@sveltejs/kit": "^2.16.0",
"@sveltejs/vite-plugin-svelte": "^3.0.0",
"svelte": "^4.2.8",
"svelte-check": "^3.6.0",
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
import { expect, test } from '@playwright/test';
import { waitForInitialPageload } from './utils';

test.describe('SDK-internal behavior', () => {
test("Doesn't inject fetch proxy script for SvelteKit>=2.16.0", async ({ page }) => {
await waitForInitialPageload(page, { route: '/' });
const sentryCarrier = await page.evaluate('typeof window.__SENTRY__');
const proxyHandle = await page.evaluate('typeof window._sentryFetchProxy');

// sanity check
expect(sentryCarrier).toBe('object');

// fetch proxy script didn't run
expect(proxyHandle).toBe('undefined');
});
});
4 changes: 1 addition & 3 deletions packages/sveltekit/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,9 +9,7 @@
"engines": {
"node": ">=18"
},
"files": [
"/build"
],
"files": ["/build"],
"main": "build/cjs/index.server.js",
"module": "build/esm/index.server.js",
"browser": "build/esm/index.client.js",
Expand Down
40 changes: 34 additions & 6 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,10 +93,10 @@ export function addSentryCodeToPage(options: { injectFetchProxyScript: boolean }
* ```
*/
export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {
const options: Required<SentryHandleOptions> = {
handleUnknownRoutes: false,
injectFetchProxyScript: true,
...handlerOptions,
const { handleUnknownRoutes, ...rest } = handlerOptions ?? {};
const options = {
handleUnknownRoutes: handleUnknownRoutes ?? false,
...rest,
};

const sentryRequestHandler: Handle = input => {
Expand DownExpand Up@@ -131,12 +131,24 @@ export function sentryHandle(handlerOptions?: SentryHandleOptions): Handle {

async function instrumentHandle(
{ event, resolve }: Parameters<Handle>[0],
options: Required<SentryHandleOptions>,
options: SentryHandleOptions,
): Promise<Response> {
if (!event.route?.id && !options.handleUnknownRoutes) {
return resolve(event);
}

// caching the result of the version check in `options.injectFetchProxyScript`
// to avoid doing the dynamic import on every request
if (options.injectFetchProxyScript == null) {
try {
// @ts-expect-error - the dynamic import is fine here
const { VERSION } = await import('@sveltejs/kit');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Does it make sense to cache this somewhere? 🤔

@Lms24Lms24Jan 31, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do :) options.injectFetchProxyScript will only be set once

options.injectFetchProxyScript = isFetchProxyRequired(VERSION);
} catch {
options.injectFetchProxyScript = true;
}
}

const routeName = `${event.request.method} ${event.route?.id || event.url.pathname}`;

if (getIsolationScope() !== getDefaultIsolationScope()) {
Expand All@@ -161,7 +173,7 @@ async function instrumentHandle(
normalizedRequest: winterCGRequestToRequestData(event.request.clone()),
});
const res = await resolve(event, {
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript }),
transformPageChunk: addSentryCodeToPage({ injectFetchProxyScript: options.injectFetchProxyScript ?? true }),
});
if (span) {
setHttpStatus(span, res.status);
Expand All@@ -177,3 +189,19 @@ async function instrumentHandle(
await flushIfServerless();
}
}

/**
* We only need to inject the fetch proxy script for SvelteKit versions < 2.16.0.
* Exported only for testing.
*/
export function isFetchProxyRequired(version: string): boolean {
try {
const [major, minor] = version.trim().replace(/-.*/, '').split('.').map(Number);
if (major != null && minor != null && (major > 2 || (major === 2 && minor >= 16))) {
return false;
}
} catch {
// ignore
}
return true;
}
19 changes: 18 additions & 1 deletion packages/sveltekit/test/server/handle.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,7 @@ import type { Handle } from '@sveltejs/kit';
import { redirect } from '@sveltejs/kit';
import { vi } from 'vitest';

import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, sentryHandle } from '../../src/server/handle';
import { FETCH_PROXY_SCRIPT, addSentryCodeToPage, isFetchProxyRequired, sentryHandle } from '../../src/server/handle';
import { getDefaultNodeClientOptions } from '../utils';

const mockCaptureException = vi.spyOn(SentryNode, 'captureException').mockImplementation(() => 'xx');
Expand DownExpand Up@@ -462,3 +462,20 @@ describe('addSentryCodeToPage', () => {
expect(transformed).not.toContain(`<script >${FETCH_PROXY_SCRIPT}</script>`);
});
});

describe('isFetchProxyRequired', () => {
it.each(['2.16.0', '2.16.1', '2.17.0', '3.0.0', '3.0.0-alpha.0'])(
'returns false if the version is greater than or equal to 2.16.0 (%s)',
version => {
expect(isFetchProxyRequired(version)).toBe(false);
},
);

it.each(['2.15.0', '2.15.1', '1.30.0', '1.0.0'])('returns true if the version is lower than 2.16.0 (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});

it.each(['invalid', 'a.b.c'])('returns true for an invalid version (%s)', version => {
expect(isFetchProxyRequired(version)).toBe(true);
});
});