Skip to content

Branch for 9.7.0-alpha#15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chargome wants to merge 10 commits into from
Closed

Branch for 9.7.0-alpha #15738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ce13e76
fix(node): Ensure httpIntegration propagates traces
mydea Mar 19, 2025
2271282
small ref
mydea Mar 19, 2025
9024c1a
fix the test
mydea Mar 19, 2025
e3b6bc3
feat(browser): Attach top-level domain to "Failed to fetch" errors
mydea Mar 19, 2025
52829ca
adjust size limit
mydea Mar 19, 2025
76e3c0d
take top level domain only
mydea Mar 19, 2025
334bf41
meta(changelog): Update changelog for 9.7.0-alpha (#15740)
chargome Mar 19, 2025
e1c17b4
meta(changelog): Update changelog for 9.7.0-alpha.0 (#15742)
chargome Mar 19, 2025
c047605
release: 9.7.0-alpha.0
getsentry-bot Mar 19, 2025
7a60a58
Merge branch 'release/9.7.0-alpha.0' into 9.7.0-alpha
Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .size-limit.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '75.2 KB',
limit: '76 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,13 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0-alpha.0

This is an alpha release that includes experimental features which are subject to breaking changes.

- fix(node): Ensure httpIntegration propagates traces #15735
- feat(browser): Attach top-level domain to "Failed to fetch" errors #15729

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/browser-integration-tests/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "@sentry-internal/browser-integration-tests",
"version": "9.6.1",
"version": "9.7.0-alpha.0",
"main": "index.js",
"license": "MIT",
"engines": {
Expand DownExpand Up@@ -42,7 +42,7 @@
"@babel/preset-typescript": "^7.16.7",
"@playwright/test": "~1.50.0",
"@sentry-internal/rrweb": "2.34.0",
"@sentry/browser": "9.6.1",
"@sentry/browser": "9.7.0-alpha.0",
"axios": "1.8.2",
"babel-loader": "^8.2.2",
"fflate": "0.8.2",
Expand Down
13 changes: 13 additions & 0 deletions dev-packages/browser-integration-tests/suites/errors/fetch/init.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
transportOptions: {
fetchOptions: {
// See: https://github.com/microsoft/playwright/issues/34497
keepalive: false,
},
},
});
45 changes: 45 additions & 0 deletions dev-packages/browser-integration-tests/suites/errors/fetch/subject.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
// Based on possible TypeError exceptions from https://developer.mozilla.org/en-US/docs/Web/API/Window/fetch

// Network error (e.g. ad-blocked, offline, page does not exist, ...)
window.networkError = () => {
fetch('http://sentry-test-external.io/does-not-exist');
};

window.networkErrorSubdomain = () => {
fetch('http://subdomain.sentry-test-external.io/does-not-exist');
};

// Invalid header also produces TypeError
window.invalidHeaderName = () => {
fetch('http://sentry-test-external.io/invalid-header-name', { headers: { 'C ontent-Type': 'text/xml' } });
};

// Invalid header value also produces TypeError
window.invalidHeaderValue = () => {
fetch('http://sentry-test-external.io/invalid-header-value', { headers: ['Content-Type', 'text/html', 'extra'] });
};

// Invalid URL scheme
window.invalidUrlScheme = () => {
fetch('blub://sentry-test-external.io/invalid-scheme');
};

// URL includes credentials
window.credentialsInUrl = () => {
fetch('https://user:password@sentry-test-external.io/credentials-in-url');
};

// Invalid mode
window.invalidMode = () => {
fetch('https://sentry-test-external.io/invalid-mode', { mode: 'navigate' });
};

// Invalid request method
window.invalidMethod = () => {
fetch('http://sentry-test-external.io/invalid-method', { method: 'CONNECT' });
};

// No-cors mode with cors-required method
window.noCorsMethod = () => {
fetch('http://sentry-test-external.io/no-cors-method', { mode: 'no-cors', method: 'PUT' });
};
288 changes: 288 additions & 0 deletions dev-packages/browser-integration-tests/suites/errors/fetch/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,288 @@
import { expect } from '@playwright/test';
import { sentryTest } from '../../../utils/fixtures';
import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';

sentryTest('handles fetch network errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
const url = await getLocalTestUrl({ testDir: __dirname });
const reqPromise = waitForErrorRequest(page);
await page.goto(url);
await page.evaluate('networkError()');

const eventData = envelopeRequestParser(await reqPromise);

const errorMap: Record<string, string> = {
chromium: 'Failed to fetch (sentry-test-external.io)',
webkit: 'Load failed (sentry-test-external.io)',
firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
};

const error = errorMap[browserName];

expect(eventData.exception?.values).toHaveLength(1);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'TypeError',
value: error,
mechanism: {
handled: false,
type: 'onunhandledrejection',
},
});
});


sentryTest('handles fetch network errors on subdomains @firefox', async ({ getLocalTestUrl, page, browserName }) => {
const url = await getLocalTestUrl({ testDir: __dirname });
const reqPromise = waitForErrorRequest(page);
await page.goto(url);
await page.evaluate('networkErrorSubdomain()');

const eventData = envelopeRequestParser(await reqPromise);

const errorMap: Record<string, string> = {
chromium: 'Failed to fetch (sentry-test-external.io)',
webkit: 'Load failed (sentry-test-external.io)',
firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
};

const error = errorMap[browserName];

expect(eventData.exception?.values).toHaveLength(1);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'TypeError',
value: error,
mechanism: {
handled: false,
type: 'onunhandledrejection',
},
});
});

sentryTest('handles fetch invalid header name errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
const url = await getLocalTestUrl({ testDir: __dirname });
const reqPromise = waitForErrorRequest(page);
await page.goto(url);
await page.evaluate('invalidHeaderName()');

const eventData = envelopeRequestParser(await reqPromise);

const errorMap: Record<string, string> = {
chromium: "Failed to execute 'fetch' on 'Window': Invalid name",
webkit: "Invalid header name: 'C ontent-Type'",
firefox: 'Window.fetch: c ontent-type is an invalid header name.',
};

const error = errorMap[browserName];

expect(eventData.exception?.values).toHaveLength(1);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'TypeError',
value: error,
mechanism: {
handled: false,
type: 'onunhandledrejection',
},
stacktrace: {
frames: expect.any(Array),
},
});
});

sentryTest('handles fetch invalid header value errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
const url = await getLocalTestUrl({ testDir: __dirname });
const reqPromise = waitForErrorRequest(page);
await page.goto(url);
await page.evaluate('invalidHeaderValue()');

const eventData = envelopeRequestParser(await reqPromise);

const errorMap: Record<string, string> = {
chromium:
"Failed to execute 'fetch' on 'Window': Failed to read the 'headers' property from 'RequestInit': The provided value cannot be converted to a sequence.",
webkit: 'Value is not a sequence',
firefox:
"Window.fetch: Element of sequence<sequence<ByteString>> branch of (sequence<sequence<ByteString>> or record<ByteString, ByteString>) can't be converted to a sequence.",
};

const error = errorMap[browserName];

expect(eventData.exception?.values).toHaveLength(1);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'TypeError',
value: error,
mechanism: {
handled: false,
type: 'onunhandledrejection',
},
stacktrace: {
frames: expect.any(Array),
},
});
});

sentryTest('handles fetch invalid URL scheme errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
await page.route('http://sentry-test-external.io/**', route => {
return route.fulfill({
status: 200,
});
});

const url = await getLocalTestUrl({ testDir: __dirname });
const reqPromise = waitForErrorRequest(page);
await page.goto(url);
await page.evaluate('invalidUrlScheme()');

const eventData = envelopeRequestParser(await reqPromise);

const errorMap: Record<string, string> = {
chromium: 'Failed to fetch (sentry-test-external.io)',
webkit: 'Load failed (sentry-test-external.io)',
firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
};

const error = errorMap[browserName];

/**
* This kind of error does show a helpful warning in the console, e.g.:
* Fetch API cannot load blub://sentry-test-external.io/invalid-scheme. URL scheme "blub" is not supported.
* But it seems we cannot really access this in the SDK :(
*/

expect(eventData.exception?.values).toHaveLength(1);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'TypeError',
value: error,
mechanism: {
handled: false,
type: 'onunhandledrejection',
},
stacktrace: {
frames: expect.any(Array),
},
});
});

sentryTest('handles fetch credentials in url errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
const url = await getLocalTestUrl({ testDir: __dirname });
const reqPromise = waitForErrorRequest(page);
await page.goto(url);
await page.evaluate('credentialsInUrl()');

const eventData = envelopeRequestParser(await reqPromise);

const errorMap: Record<string, string> = {
chromium:
"Failed to execute 'fetch' on 'Window': Request cannot be constructed from a URL that includes credentials: https://user:password@sentry-test-external.io/credentials-in-url",
webkit: 'URL is not valid or contains user credentials.',
firefox:
'Window.fetch: https://user:password@sentry-test-external.io/credentials-in-url is an url with embedded credentials.',
};

const error = errorMap[browserName];

expect(eventData.exception?.values).toHaveLength(1);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'TypeError',
value: error,
mechanism: {
handled: false,
type: 'onunhandledrejection',
},
stacktrace: {
frames: expect.any(Array),
},
});
});

sentryTest('handles fetch invalid mode errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
const url = await getLocalTestUrl({ testDir: __dirname });
const reqPromise = waitForErrorRequest(page);
await page.goto(url);
await page.evaluate('invalidMode()');

const eventData = envelopeRequestParser(await reqPromise);

const errorMap: Record<string, string> = {
chromium:
"Failed to execute 'fetch' on 'Window': Cannot construct a Request with a RequestInit whose mode member is set as 'navigate'.",
webkit: 'Request constructor does not accept navigate fetch mode.',
firefox: 'Window.fetch: Invalid request mode navigate.',
};

const error = errorMap[browserName];

expect(eventData.exception?.values).toHaveLength(1);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'TypeError',
value: error,
mechanism: {
handled: false,
type: 'onunhandledrejection',
},
stacktrace: {
frames: expect.any(Array),
},
});
});

sentryTest('handles fetch invalid request method errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
const url = await getLocalTestUrl({ testDir: __dirname });
const reqPromise = waitForErrorRequest(page);
await page.goto(url);
await page.evaluate('invalidMethod()');

const eventData = envelopeRequestParser(await reqPromise);

const errorMap: Record<string, string> = {
chromium: "Failed to execute 'fetch' on 'Window': 'CONNECT' HTTP method is unsupported.",
webkit: 'Method is forbidden.',
firefox: 'Window.fetch: Invalid request method CONNECT.',
};

const error = errorMap[browserName];

expect(eventData.exception?.values).toHaveLength(1);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'TypeError',
value: error,
mechanism: {
handled: false,
type: 'onunhandledrejection',
},
stacktrace: {
frames: expect.any(Array),
},
});
});

sentryTest(
'handles fetch no-cors mode with cors-required method errors @firefox',
async ({ getLocalTestUrl, page, browserName }) => {
const url = await getLocalTestUrl({ testDir: __dirname });
const reqPromise = waitForErrorRequest(page);
await page.goto(url);
await page.evaluate('noCorsMethod()');

const eventData = envelopeRequestParser(await reqPromise);

const errorMap: Record<string, string> = {
chromium: "Failed to execute 'fetch' on 'Window': 'PUT' is unsupported in no-cors mode.",
webkit: 'Method must be GET, POST or HEAD in no-cors mode.',
firefox: 'Window.fetch: Invalid request method PUT.',
};

const error = errorMap[browserName];

expect(eventData.exception?.values).toHaveLength(1);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'TypeError',
value: error,
mechanism: {
handled: false,
type: 'onunhandledrejection',
},
stacktrace: {
frames: expect.any(Array),
},
});
},
);
2 changes: 1 addition & 1 deletion dev-packages/bundle-analyzer-scenarios/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
"name": "@sentry-internal/bundle-analyzer-scenarios",
"version": "9.6.1",
"version": "9.7.0-alpha.0",
"description": "Scenarios to test bundle analysis with",
"repository": "git://github.com/getsentry/sentry-javascript.git",
"homepage": "https://github.com/getsentry/sentry-javascript/tree/master/dev-packages/bundle-analyzer-scenarios",
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Branch for 9.7.0-alpha by chargome · Pull Request #15738 · getsentry/sentry-javascript · GitHub
Skip to content
Branch for 9.7.0-alpha#15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

chargome
wants to merge
10
commits into

from

 Closed


Branch for 9.7.0-alpha
#15738
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ce13e76

fix(node): Ensure httpIntegration propagates traces


mydea Mar 19, 2025
2271282

small ref


mydea Mar 19, 2025
9024c1a

fix the test


mydea Mar 19, 2025
e3b6bc3

feat(browser): Attach top-level domain to "Failed to fetch" errors


mydea Mar 19, 2025
52829ca

adjust size limit


mydea Mar 19, 2025
76e3c0d

take top level domain only


mydea Mar 19, 2025
334bf41

meta(changelog): Update changelog for 9.7.0-alpha (#15740)


chargome Mar 19, 2025
e1c17b4

meta(changelog): Update changelog for 9.7.0-alpha.0 (#15742)


chargome Mar 19, 2025
c047605

release: 9.7.0-alpha.0


getsentry-bot Mar 19, 2025
7a60a58

Merge branch 'release/9.7.0-alpha.0' into 9.7.0-alpha

Mar 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
 path: 'packages/browser/build/npm/esm/index.js',
 import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
 gzip: true,
 limit: '75.2 KB',
 limit: '76 KB',
 },
 {
 name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand Down

7 changes: 7 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,13 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0-alpha.0

This is an alpha release that includes experimental features which are subject to breaking changes.

- fix(node): Ensure httpIntegration propagates traces #15735
- feat(browser): Attach top-level domain to "Failed to fetch" errors #15729

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/browser-integration-tests",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "main": "index.js",
 "license": "MIT",
 "engines": {
Expand DownExpand Up@@ -42,7 +42,7 @@
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.34.0",
 "@sentry/browser": "9.6.1",
 "@sentry/browser": "9.7.0-alpha.0",
 "axios": "1.8.2",
 "babel-loader": "^8.2.2",
 "fflate": "0.8.2",
Expand Down

13 changes: 13 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 transportOptions: {
 fetchOptions: {
 // See: https://github.com/microsoft/playwright/issues/34497
 keepalive: false,
 },
 },
});

45 changes: 45 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/subject.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
// Based on possible TypeError exceptions from https://developer.mozilla.org/en-US/docs/Web/API/Window/fetch

// Network error (e.g. ad-blocked, offline, page does not exist, ...)
window.networkError = () => {
 fetch('http://sentry-test-external.io/does-not-exist');
};

window.networkErrorSubdomain = () => {
 fetch('http://subdomain.sentry-test-external.io/does-not-exist');
};

// Invalid header also produces TypeError
window.invalidHeaderName = () => {
 fetch('http://sentry-test-external.io/invalid-header-name', { headers: { 'C ontent-Type': 'text/xml' } });
};

// Invalid header value also produces TypeError
window.invalidHeaderValue = () => {
 fetch('http://sentry-test-external.io/invalid-header-value', { headers: ['Content-Type', 'text/html', 'extra'] });
};

// Invalid URL scheme
window.invalidUrlScheme = () => {
 fetch('blub://sentry-test-external.io/invalid-scheme');
};

// URL includes credentials
window.credentialsInUrl = () => {
 fetch('https://user:password@sentry-test-external.io/credentials-in-url');
};

// Invalid mode
window.invalidMode = () => {
 fetch('https://sentry-test-external.io/invalid-mode', { mode: 'navigate' });
};

// Invalid request method
window.invalidMethod = () => {
 fetch('http://sentry-test-external.io/invalid-method', { method: 'CONNECT' });
};

// No-cors mode with cors-required method
window.noCorsMethod = () => {
 fetch('http://sentry-test-external.io/no-cors-method', { mode: 'no-cors', method: 'PUT' });
};

288 changes: 288 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,288 @@
import { expect } from '@playwright/test';
import { sentryTest } from '../../../utils/fixtures';
import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';

sentryTest('handles fetch network errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkError()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});


sentryTest('handles fetch network errors on subdomains @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkErrorSubdomain()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});

sentryTest('handles fetch invalid header name errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderName()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': Invalid name",
 webkit: "Invalid header name: 'C ontent-Type'",
 firefox: 'Window.fetch: c ontent-type is an invalid header name.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid header value errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderValue()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Failed to read the 'headers' property from 'RequestInit': The provided value cannot be converted to a sequence.",
 webkit: 'Value is not a sequence',
 firefox:
 "Window.fetch: Element of sequence<sequence<ByteString>> branch of (sequence<sequence<ByteString>> or record<ByteString, ByteString>) can't be converted to a sequence.",
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid URL scheme errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 await page.route('http://sentry-test-external.io/**', route => {
 return route.fulfill({
 status: 200,
 });
 });

 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidUrlScheme()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 /**
 * This kind of error does show a helpful warning in the console, e.g.:
 * Fetch API cannot load blub://sentry-test-external.io/invalid-scheme. URL scheme "blub" is not supported.
 * But it seems we cannot really access this in the SDK :(
 */

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch credentials in url errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('credentialsInUrl()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Request cannot be constructed from a URL that includes credentials: https://user:password@sentry-test-external.io/credentials-in-url",
 webkit: 'URL is not valid or contains user credentials.',
 firefox:
 'Window.fetch: https://user:password@sentry-test-external.io/credentials-in-url is an url with embedded credentials.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid mode errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMode()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Cannot construct a Request with a RequestInit whose mode member is set as 'navigate'.",
 webkit: 'Request constructor does not accept navigate fetch mode.',
 firefox: 'Window.fetch: Invalid request mode navigate.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid request method errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'CONNECT' HTTP method is unsupported.",
 webkit: 'Method is forbidden.',
 firefox: 'Window.fetch: Invalid request method CONNECT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest(
 'handles fetch no-cors mode with cors-required method errors @firefox',
 async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('noCorsMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'PUT' is unsupported in no-cors mode.",
 webkit: 'Method must be GET, POST or HEAD in no-cors mode.',
 firefox: 'Window.fetch: Invalid request method PUT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
 },
);

2 changes: 1 addition & 1 deletion
dev-packages/bundle-analyzer-scenarios/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/bundle-analyzer-scenarios",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "description": "Scenarios to test bundle analysis with",
 "repository": "git://github.com/getsentry/sentry-javascript.git",
 "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/dev-packages/bundle-analyzer-scenarios",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Branch for 9.7.0-alpha by chargome · Pull Request #15738 · getsentry/sentry-javascript · GitHub
Skip to content
Branch for 9.7.0-alpha#15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

chargome
wants to merge
10
commits into

from

 Closed


Branch for 9.7.0-alpha
#15738
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ce13e76

fix(node): Ensure httpIntegration propagates traces


mydea Mar 19, 2025
2271282

small ref


mydea Mar 19, 2025
9024c1a

fix the test


mydea Mar 19, 2025
e3b6bc3

feat(browser): Attach top-level domain to "Failed to fetch" errors


mydea Mar 19, 2025
52829ca

adjust size limit


mydea Mar 19, 2025
76e3c0d

take top level domain only


mydea Mar 19, 2025
334bf41

meta(changelog): Update changelog for 9.7.0-alpha (#15740)


chargome Mar 19, 2025
e1c17b4

meta(changelog): Update changelog for 9.7.0-alpha.0 (#15742)


chargome Mar 19, 2025
c047605

release: 9.7.0-alpha.0


getsentry-bot Mar 19, 2025
7a60a58

Merge branch 'release/9.7.0-alpha.0' into 9.7.0-alpha

Mar 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
 path: 'packages/browser/build/npm/esm/index.js',
 import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
 gzip: true,
 limit: '75.2 KB',
 limit: '76 KB',
 },
 {
 name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand Down

7 changes: 7 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,13 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0-alpha.0

This is an alpha release that includes experimental features which are subject to breaking changes.

- fix(node): Ensure httpIntegration propagates traces #15735
- feat(browser): Attach top-level domain to "Failed to fetch" errors #15729

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/browser-integration-tests",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "main": "index.js",
 "license": "MIT",
 "engines": {
Expand DownExpand Up@@ -42,7 +42,7 @@
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.34.0",
 "@sentry/browser": "9.6.1",
 "@sentry/browser": "9.7.0-alpha.0",
 "axios": "1.8.2",
 "babel-loader": "^8.2.2",
 "fflate": "0.8.2",
Expand Down

13 changes: 13 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 transportOptions: {
 fetchOptions: {
 // See: https://github.com/microsoft/playwright/issues/34497
 keepalive: false,
 },
 },
});

45 changes: 45 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/subject.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
// Based on possible TypeError exceptions from https://developer.mozilla.org/en-US/docs/Web/API/Window/fetch

// Network error (e.g. ad-blocked, offline, page does not exist, ...)
window.networkError = () => {
 fetch('http://sentry-test-external.io/does-not-exist');
};

window.networkErrorSubdomain = () => {
 fetch('http://subdomain.sentry-test-external.io/does-not-exist');
};

// Invalid header also produces TypeError
window.invalidHeaderName = () => {
 fetch('http://sentry-test-external.io/invalid-header-name', { headers: { 'C ontent-Type': 'text/xml' } });
};

// Invalid header value also produces TypeError
window.invalidHeaderValue = () => {
 fetch('http://sentry-test-external.io/invalid-header-value', { headers: ['Content-Type', 'text/html', 'extra'] });
};

// Invalid URL scheme
window.invalidUrlScheme = () => {
 fetch('blub://sentry-test-external.io/invalid-scheme');
};

// URL includes credentials
window.credentialsInUrl = () => {
 fetch('https://user:password@sentry-test-external.io/credentials-in-url');
};

// Invalid mode
window.invalidMode = () => {
 fetch('https://sentry-test-external.io/invalid-mode', { mode: 'navigate' });
};

// Invalid request method
window.invalidMethod = () => {
 fetch('http://sentry-test-external.io/invalid-method', { method: 'CONNECT' });
};

// No-cors mode with cors-required method
window.noCorsMethod = () => {
 fetch('http://sentry-test-external.io/no-cors-method', { mode: 'no-cors', method: 'PUT' });
};

288 changes: 288 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,288 @@
import { expect } from '@playwright/test';
import { sentryTest } from '../../../utils/fixtures';
import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';

sentryTest('handles fetch network errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkError()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});


sentryTest('handles fetch network errors on subdomains @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkErrorSubdomain()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});

sentryTest('handles fetch invalid header name errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderName()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': Invalid name",
 webkit: "Invalid header name: 'C ontent-Type'",
 firefox: 'Window.fetch: c ontent-type is an invalid header name.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid header value errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderValue()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Failed to read the 'headers' property from 'RequestInit': The provided value cannot be converted to a sequence.",
 webkit: 'Value is not a sequence',
 firefox:
 "Window.fetch: Element of sequence<sequence<ByteString>> branch of (sequence<sequence<ByteString>> or record<ByteString, ByteString>) can't be converted to a sequence.",
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid URL scheme errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 await page.route('http://sentry-test-external.io/**', route => {
 return route.fulfill({
 status: 200,
 });
 });

 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidUrlScheme()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 /**
 * This kind of error does show a helpful warning in the console, e.g.:
 * Fetch API cannot load blub://sentry-test-external.io/invalid-scheme. URL scheme "blub" is not supported.
 * But it seems we cannot really access this in the SDK :(
 */

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch credentials in url errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('credentialsInUrl()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Request cannot be constructed from a URL that includes credentials: https://user:password@sentry-test-external.io/credentials-in-url",
 webkit: 'URL is not valid or contains user credentials.',
 firefox:
 'Window.fetch: https://user:password@sentry-test-external.io/credentials-in-url is an url with embedded credentials.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid mode errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMode()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Cannot construct a Request with a RequestInit whose mode member is set as 'navigate'.",
 webkit: 'Request constructor does not accept navigate fetch mode.',
 firefox: 'Window.fetch: Invalid request mode navigate.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid request method errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'CONNECT' HTTP method is unsupported.",
 webkit: 'Method is forbidden.',
 firefox: 'Window.fetch: Invalid request method CONNECT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest(
 'handles fetch no-cors mode with cors-required method errors @firefox',
 async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('noCorsMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'PUT' is unsupported in no-cors mode.",
 webkit: 'Method must be GET, POST or HEAD in no-cors mode.',
 firefox: 'Window.fetch: Invalid request method PUT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
 },
);

2 changes: 1 addition & 1 deletion
dev-packages/bundle-analyzer-scenarios/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/bundle-analyzer-scenarios",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "description": "Scenarios to test bundle analysis with",
 "repository": "git://github.com/getsentry/sentry-javascript.git",
 "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/dev-packages/bundle-analyzer-scenarios",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Branch for 9.7.0-alpha by chargome · Pull Request #15738 · getsentry/sentry-javascript · GitHub
Skip to content
Branch for 9.7.0-alpha#15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

chargome
wants to merge
10
commits into

from

 Closed


Branch for 9.7.0-alpha
#15738
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ce13e76

fix(node): Ensure httpIntegration propagates traces


mydea Mar 19, 2025
2271282

small ref


mydea Mar 19, 2025
9024c1a

fix the test


mydea Mar 19, 2025
e3b6bc3

feat(browser): Attach top-level domain to "Failed to fetch" errors


mydea Mar 19, 2025
52829ca

adjust size limit


mydea Mar 19, 2025
76e3c0d

take top level domain only


mydea Mar 19, 2025
334bf41

meta(changelog): Update changelog for 9.7.0-alpha (#15740)


chargome Mar 19, 2025
e1c17b4

meta(changelog): Update changelog for 9.7.0-alpha.0 (#15742)


chargome Mar 19, 2025
c047605

release: 9.7.0-alpha.0


getsentry-bot Mar 19, 2025
7a60a58

Merge branch 'release/9.7.0-alpha.0' into 9.7.0-alpha

Mar 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
 path: 'packages/browser/build/npm/esm/index.js',
 import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
 gzip: true,
 limit: '75.2 KB',
 limit: '76 KB',
 },
 {
 name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand Down

7 changes: 7 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,13 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0-alpha.0

This is an alpha release that includes experimental features which are subject to breaking changes.

- fix(node): Ensure httpIntegration propagates traces #15735
- feat(browser): Attach top-level domain to "Failed to fetch" errors #15729

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/browser-integration-tests",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "main": "index.js",
 "license": "MIT",
 "engines": {
Expand DownExpand Up@@ -42,7 +42,7 @@
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.34.0",
 "@sentry/browser": "9.6.1",
 "@sentry/browser": "9.7.0-alpha.0",
 "axios": "1.8.2",
 "babel-loader": "^8.2.2",
 "fflate": "0.8.2",
Expand Down

13 changes: 13 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 transportOptions: {
 fetchOptions: {
 // See: https://github.com/microsoft/playwright/issues/34497
 keepalive: false,
 },
 },
});

45 changes: 45 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/subject.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
// Based on possible TypeError exceptions from https://developer.mozilla.org/en-US/docs/Web/API/Window/fetch

// Network error (e.g. ad-blocked, offline, page does not exist, ...)
window.networkError = () => {
 fetch('http://sentry-test-external.io/does-not-exist');
};

window.networkErrorSubdomain = () => {
 fetch('http://subdomain.sentry-test-external.io/does-not-exist');
};

// Invalid header also produces TypeError
window.invalidHeaderName = () => {
 fetch('http://sentry-test-external.io/invalid-header-name', { headers: { 'C ontent-Type': 'text/xml' } });
};

// Invalid header value also produces TypeError
window.invalidHeaderValue = () => {
 fetch('http://sentry-test-external.io/invalid-header-value', { headers: ['Content-Type', 'text/html', 'extra'] });
};

// Invalid URL scheme
window.invalidUrlScheme = () => {
 fetch('blub://sentry-test-external.io/invalid-scheme');
};

// URL includes credentials
window.credentialsInUrl = () => {
 fetch('https://user:password@sentry-test-external.io/credentials-in-url');
};

// Invalid mode
window.invalidMode = () => {
 fetch('https://sentry-test-external.io/invalid-mode', { mode: 'navigate' });
};

// Invalid request method
window.invalidMethod = () => {
 fetch('http://sentry-test-external.io/invalid-method', { method: 'CONNECT' });
};

// No-cors mode with cors-required method
window.noCorsMethod = () => {
 fetch('http://sentry-test-external.io/no-cors-method', { mode: 'no-cors', method: 'PUT' });
};

288 changes: 288 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,288 @@
import { expect } from '@playwright/test';
import { sentryTest } from '../../../utils/fixtures';
import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';

sentryTest('handles fetch network errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkError()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});


sentryTest('handles fetch network errors on subdomains @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkErrorSubdomain()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});

sentryTest('handles fetch invalid header name errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderName()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': Invalid name",
 webkit: "Invalid header name: 'C ontent-Type'",
 firefox: 'Window.fetch: c ontent-type is an invalid header name.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid header value errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderValue()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Failed to read the 'headers' property from 'RequestInit': The provided value cannot be converted to a sequence.",
 webkit: 'Value is not a sequence',
 firefox:
 "Window.fetch: Element of sequence<sequence<ByteString>> branch of (sequence<sequence<ByteString>> or record<ByteString, ByteString>) can't be converted to a sequence.",
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid URL scheme errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 await page.route('http://sentry-test-external.io/**', route => {
 return route.fulfill({
 status: 200,
 });
 });

 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidUrlScheme()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 /**
 * This kind of error does show a helpful warning in the console, e.g.:
 * Fetch API cannot load blub://sentry-test-external.io/invalid-scheme. URL scheme "blub" is not supported.
 * But it seems we cannot really access this in the SDK :(
 */

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch credentials in url errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('credentialsInUrl()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Request cannot be constructed from a URL that includes credentials: https://user:password@sentry-test-external.io/credentials-in-url",
 webkit: 'URL is not valid or contains user credentials.',
 firefox:
 'Window.fetch: https://user:password@sentry-test-external.io/credentials-in-url is an url with embedded credentials.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid mode errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMode()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Cannot construct a Request with a RequestInit whose mode member is set as 'navigate'.",
 webkit: 'Request constructor does not accept navigate fetch mode.',
 firefox: 'Window.fetch: Invalid request mode navigate.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid request method errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'CONNECT' HTTP method is unsupported.",
 webkit: 'Method is forbidden.',
 firefox: 'Window.fetch: Invalid request method CONNECT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest(
 'handles fetch no-cors mode with cors-required method errors @firefox',
 async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('noCorsMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'PUT' is unsupported in no-cors mode.",
 webkit: 'Method must be GET, POST or HEAD in no-cors mode.',
 firefox: 'Window.fetch: Invalid request method PUT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
 },
);

2 changes: 1 addition & 1 deletion
dev-packages/bundle-analyzer-scenarios/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/bundle-analyzer-scenarios",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "description": "Scenarios to test bundle analysis with",
 "repository": "git://github.com/getsentry/sentry-javascript.git",
 "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/dev-packages/bundle-analyzer-scenarios",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Branch for 9.7.0-alpha by chargome · Pull Request #15738 · getsentry/sentry-javascript · GitHub
Skip to content
Branch for 9.7.0-alpha#15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

chargome
wants to merge
10
commits into

from

 Closed


Branch for 9.7.0-alpha
#15738
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ce13e76

fix(node): Ensure httpIntegration propagates traces


mydea Mar 19, 2025
2271282

small ref


mydea Mar 19, 2025
9024c1a

fix the test


mydea Mar 19, 2025
e3b6bc3

feat(browser): Attach top-level domain to "Failed to fetch" errors


mydea Mar 19, 2025
52829ca

adjust size limit


mydea Mar 19, 2025
76e3c0d

take top level domain only


mydea Mar 19, 2025
334bf41

meta(changelog): Update changelog for 9.7.0-alpha (#15740)


chargome Mar 19, 2025
e1c17b4

meta(changelog): Update changelog for 9.7.0-alpha.0 (#15742)


chargome Mar 19, 2025
c047605

release: 9.7.0-alpha.0


getsentry-bot Mar 19, 2025
7a60a58

Merge branch 'release/9.7.0-alpha.0' into 9.7.0-alpha

Mar 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
 path: 'packages/browser/build/npm/esm/index.js',
 import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
 gzip: true,
 limit: '75.2 KB',
 limit: '76 KB',
 },
 {
 name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand Down

7 changes: 7 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,13 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0-alpha.0

This is an alpha release that includes experimental features which are subject to breaking changes.

- fix(node): Ensure httpIntegration propagates traces #15735
- feat(browser): Attach top-level domain to "Failed to fetch" errors #15729

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/browser-integration-tests",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "main": "index.js",
 "license": "MIT",
 "engines": {
Expand DownExpand Up@@ -42,7 +42,7 @@
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.34.0",
 "@sentry/browser": "9.6.1",
 "@sentry/browser": "9.7.0-alpha.0",
 "axios": "1.8.2",
 "babel-loader": "^8.2.2",
 "fflate": "0.8.2",
Expand Down

13 changes: 13 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 transportOptions: {
 fetchOptions: {
 // See: https://github.com/microsoft/playwright/issues/34497
 keepalive: false,
 },
 },
});

45 changes: 45 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/subject.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
// Based on possible TypeError exceptions from https://developer.mozilla.org/en-US/docs/Web/API/Window/fetch

// Network error (e.g. ad-blocked, offline, page does not exist, ...)
window.networkError = () => {
 fetch('http://sentry-test-external.io/does-not-exist');
};

window.networkErrorSubdomain = () => {
 fetch('http://subdomain.sentry-test-external.io/does-not-exist');
};

// Invalid header also produces TypeError
window.invalidHeaderName = () => {
 fetch('http://sentry-test-external.io/invalid-header-name', { headers: { 'C ontent-Type': 'text/xml' } });
};

// Invalid header value also produces TypeError
window.invalidHeaderValue = () => {
 fetch('http://sentry-test-external.io/invalid-header-value', { headers: ['Content-Type', 'text/html', 'extra'] });
};

// Invalid URL scheme
window.invalidUrlScheme = () => {
 fetch('blub://sentry-test-external.io/invalid-scheme');
};

// URL includes credentials
window.credentialsInUrl = () => {
 fetch('https://user:password@sentry-test-external.io/credentials-in-url');
};

// Invalid mode
window.invalidMode = () => {
 fetch('https://sentry-test-external.io/invalid-mode', { mode: 'navigate' });
};

// Invalid request method
window.invalidMethod = () => {
 fetch('http://sentry-test-external.io/invalid-method', { method: 'CONNECT' });
};

// No-cors mode with cors-required method
window.noCorsMethod = () => {
 fetch('http://sentry-test-external.io/no-cors-method', { mode: 'no-cors', method: 'PUT' });
};

288 changes: 288 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,288 @@
import { expect } from '@playwright/test';
import { sentryTest } from '../../../utils/fixtures';
import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';

sentryTest('handles fetch network errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkError()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});


sentryTest('handles fetch network errors on subdomains @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkErrorSubdomain()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});

sentryTest('handles fetch invalid header name errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderName()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': Invalid name",
 webkit: "Invalid header name: 'C ontent-Type'",
 firefox: 'Window.fetch: c ontent-type is an invalid header name.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid header value errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderValue()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Failed to read the 'headers' property from 'RequestInit': The provided value cannot be converted to a sequence.",
 webkit: 'Value is not a sequence',
 firefox:
 "Window.fetch: Element of sequence<sequence<ByteString>> branch of (sequence<sequence<ByteString>> or record<ByteString, ByteString>) can't be converted to a sequence.",
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid URL scheme errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 await page.route('http://sentry-test-external.io/**', route => {
 return route.fulfill({
 status: 200,
 });
 });

 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidUrlScheme()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 /**
 * This kind of error does show a helpful warning in the console, e.g.:
 * Fetch API cannot load blub://sentry-test-external.io/invalid-scheme. URL scheme "blub" is not supported.
 * But it seems we cannot really access this in the SDK :(
 */

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch credentials in url errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('credentialsInUrl()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Request cannot be constructed from a URL that includes credentials: https://user:password@sentry-test-external.io/credentials-in-url",
 webkit: 'URL is not valid or contains user credentials.',
 firefox:
 'Window.fetch: https://user:password@sentry-test-external.io/credentials-in-url is an url with embedded credentials.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid mode errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMode()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Cannot construct a Request with a RequestInit whose mode member is set as 'navigate'.",
 webkit: 'Request constructor does not accept navigate fetch mode.',
 firefox: 'Window.fetch: Invalid request mode navigate.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid request method errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'CONNECT' HTTP method is unsupported.",
 webkit: 'Method is forbidden.',
 firefox: 'Window.fetch: Invalid request method CONNECT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest(
 'handles fetch no-cors mode with cors-required method errors @firefox',
 async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('noCorsMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'PUT' is unsupported in no-cors mode.",
 webkit: 'Method must be GET, POST or HEAD in no-cors mode.',
 firefox: 'Window.fetch: Invalid request method PUT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
 },
);

2 changes: 1 addition & 1 deletion
dev-packages/bundle-analyzer-scenarios/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/bundle-analyzer-scenarios",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "description": "Scenarios to test bundle analysis with",
 "repository": "git://github.com/getsentry/sentry-javascript.git",
 "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/dev-packages/bundle-analyzer-scenarios",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Branch for 9.7.0-alpha by chargome · Pull Request #15738 · getsentry/sentry-javascript · GitHub
Skip to content
Branch for 9.7.0-alpha#15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

chargome
wants to merge
10
commits into

from

 Closed


Branch for 9.7.0-alpha
#15738
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ce13e76

fix(node): Ensure httpIntegration propagates traces


mydea Mar 19, 2025
2271282

small ref


mydea Mar 19, 2025
9024c1a

fix the test


mydea Mar 19, 2025
e3b6bc3

feat(browser): Attach top-level domain to "Failed to fetch" errors


mydea Mar 19, 2025
52829ca

adjust size limit


mydea Mar 19, 2025
76e3c0d

take top level domain only


mydea Mar 19, 2025
334bf41

meta(changelog): Update changelog for 9.7.0-alpha (#15740)


chargome Mar 19, 2025
e1c17b4

meta(changelog): Update changelog for 9.7.0-alpha.0 (#15742)


chargome Mar 19, 2025
c047605

release: 9.7.0-alpha.0


getsentry-bot Mar 19, 2025
7a60a58

Merge branch 'release/9.7.0-alpha.0' into 9.7.0-alpha

Mar 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
 path: 'packages/browser/build/npm/esm/index.js',
 import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
 gzip: true,
 limit: '75.2 KB',
 limit: '76 KB',
 },
 {
 name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand Down

7 changes: 7 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,13 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0-alpha.0

This is an alpha release that includes experimental features which are subject to breaking changes.

- fix(node): Ensure httpIntegration propagates traces #15735
- feat(browser): Attach top-level domain to "Failed to fetch" errors #15729

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/browser-integration-tests",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "main": "index.js",
 "license": "MIT",
 "engines": {
Expand DownExpand Up@@ -42,7 +42,7 @@
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.34.0",
 "@sentry/browser": "9.6.1",
 "@sentry/browser": "9.7.0-alpha.0",
 "axios": "1.8.2",
 "babel-loader": "^8.2.2",
 "fflate": "0.8.2",
Expand Down

13 changes: 13 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 transportOptions: {
 fetchOptions: {
 // See: https://github.com/microsoft/playwright/issues/34497
 keepalive: false,
 },
 },
});

45 changes: 45 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/subject.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
// Based on possible TypeError exceptions from https://developer.mozilla.org/en-US/docs/Web/API/Window/fetch

// Network error (e.g. ad-blocked, offline, page does not exist, ...)
window.networkError = () => {
 fetch('http://sentry-test-external.io/does-not-exist');
};

window.networkErrorSubdomain = () => {
 fetch('http://subdomain.sentry-test-external.io/does-not-exist');
};

// Invalid header also produces TypeError
window.invalidHeaderName = () => {
 fetch('http://sentry-test-external.io/invalid-header-name', { headers: { 'C ontent-Type': 'text/xml' } });
};

// Invalid header value also produces TypeError
window.invalidHeaderValue = () => {
 fetch('http://sentry-test-external.io/invalid-header-value', { headers: ['Content-Type', 'text/html', 'extra'] });
};

// Invalid URL scheme
window.invalidUrlScheme = () => {
 fetch('blub://sentry-test-external.io/invalid-scheme');
};

// URL includes credentials
window.credentialsInUrl = () => {
 fetch('https://user:password@sentry-test-external.io/credentials-in-url');
};

// Invalid mode
window.invalidMode = () => {
 fetch('https://sentry-test-external.io/invalid-mode', { mode: 'navigate' });
};

// Invalid request method
window.invalidMethod = () => {
 fetch('http://sentry-test-external.io/invalid-method', { method: 'CONNECT' });
};

// No-cors mode with cors-required method
window.noCorsMethod = () => {
 fetch('http://sentry-test-external.io/no-cors-method', { mode: 'no-cors', method: 'PUT' });
};

288 changes: 288 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,288 @@
import { expect } from '@playwright/test';
import { sentryTest } from '../../../utils/fixtures';
import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';

sentryTest('handles fetch network errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkError()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});


sentryTest('handles fetch network errors on subdomains @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkErrorSubdomain()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});

sentryTest('handles fetch invalid header name errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderName()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': Invalid name",
 webkit: "Invalid header name: 'C ontent-Type'",
 firefox: 'Window.fetch: c ontent-type is an invalid header name.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid header value errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderValue()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Failed to read the 'headers' property from 'RequestInit': The provided value cannot be converted to a sequence.",
 webkit: 'Value is not a sequence',
 firefox:
 "Window.fetch: Element of sequence<sequence<ByteString>> branch of (sequence<sequence<ByteString>> or record<ByteString, ByteString>) can't be converted to a sequence.",
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid URL scheme errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 await page.route('http://sentry-test-external.io/**', route => {
 return route.fulfill({
 status: 200,
 });
 });

 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidUrlScheme()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 /**
 * This kind of error does show a helpful warning in the console, e.g.:
 * Fetch API cannot load blub://sentry-test-external.io/invalid-scheme. URL scheme "blub" is not supported.
 * But it seems we cannot really access this in the SDK :(
 */

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch credentials in url errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('credentialsInUrl()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Request cannot be constructed from a URL that includes credentials: https://user:password@sentry-test-external.io/credentials-in-url",
 webkit: 'URL is not valid or contains user credentials.',
 firefox:
 'Window.fetch: https://user:password@sentry-test-external.io/credentials-in-url is an url with embedded credentials.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid mode errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMode()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Cannot construct a Request with a RequestInit whose mode member is set as 'navigate'.",
 webkit: 'Request constructor does not accept navigate fetch mode.',
 firefox: 'Window.fetch: Invalid request mode navigate.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid request method errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'CONNECT' HTTP method is unsupported.",
 webkit: 'Method is forbidden.',
 firefox: 'Window.fetch: Invalid request method CONNECT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest(
 'handles fetch no-cors mode with cors-required method errors @firefox',
 async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('noCorsMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'PUT' is unsupported in no-cors mode.",
 webkit: 'Method must be GET, POST or HEAD in no-cors mode.',
 firefox: 'Window.fetch: Invalid request method PUT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
 },
);

2 changes: 1 addition & 1 deletion
dev-packages/bundle-analyzer-scenarios/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/bundle-analyzer-scenarios",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "description": "Scenarios to test bundle analysis with",
 "repository": "git://github.com/getsentry/sentry-javascript.git",
 "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/dev-packages/bundle-analyzer-scenarios",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Branch for 9.7.0-alpha by chargome · Pull Request #15738 · getsentry/sentry-javascript · GitHub
Skip to content
Branch for 9.7.0-alpha#15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

chargome
wants to merge
10
commits into

from

 Closed


Branch for 9.7.0-alpha
#15738
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ce13e76

fix(node): Ensure httpIntegration propagates traces


mydea Mar 19, 2025
2271282

small ref


mydea Mar 19, 2025
9024c1a

fix the test


mydea Mar 19, 2025
e3b6bc3

feat(browser): Attach top-level domain to "Failed to fetch" errors


mydea Mar 19, 2025
52829ca

adjust size limit


mydea Mar 19, 2025
76e3c0d

take top level domain only


mydea Mar 19, 2025
334bf41

meta(changelog): Update changelog for 9.7.0-alpha (#15740)


chargome Mar 19, 2025
e1c17b4

meta(changelog): Update changelog for 9.7.0-alpha.0 (#15742)


chargome Mar 19, 2025
c047605

release: 9.7.0-alpha.0


getsentry-bot Mar 19, 2025
7a60a58

Merge branch 'release/9.7.0-alpha.0' into 9.7.0-alpha

Mar 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
 path: 'packages/browser/build/npm/esm/index.js',
 import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
 gzip: true,
 limit: '75.2 KB',
 limit: '76 KB',
 },
 {
 name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand Down

7 changes: 7 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,13 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0-alpha.0

This is an alpha release that includes experimental features which are subject to breaking changes.

- fix(node): Ensure httpIntegration propagates traces #15735
- feat(browser): Attach top-level domain to "Failed to fetch" errors #15729

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/browser-integration-tests",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "main": "index.js",
 "license": "MIT",
 "engines": {
Expand DownExpand Up@@ -42,7 +42,7 @@
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.34.0",
 "@sentry/browser": "9.6.1",
 "@sentry/browser": "9.7.0-alpha.0",
 "axios": "1.8.2",
 "babel-loader": "^8.2.2",
 "fflate": "0.8.2",
Expand Down

13 changes: 13 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 transportOptions: {
 fetchOptions: {
 // See: https://github.com/microsoft/playwright/issues/34497
 keepalive: false,
 },
 },
});

45 changes: 45 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/subject.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
// Based on possible TypeError exceptions from https://developer.mozilla.org/en-US/docs/Web/API/Window/fetch

// Network error (e.g. ad-blocked, offline, page does not exist, ...)
window.networkError = () => {
 fetch('http://sentry-test-external.io/does-not-exist');
};

window.networkErrorSubdomain = () => {
 fetch('http://subdomain.sentry-test-external.io/does-not-exist');
};

// Invalid header also produces TypeError
window.invalidHeaderName = () => {
 fetch('http://sentry-test-external.io/invalid-header-name', { headers: { 'C ontent-Type': 'text/xml' } });
};

// Invalid header value also produces TypeError
window.invalidHeaderValue = () => {
 fetch('http://sentry-test-external.io/invalid-header-value', { headers: ['Content-Type', 'text/html', 'extra'] });
};

// Invalid URL scheme
window.invalidUrlScheme = () => {
 fetch('blub://sentry-test-external.io/invalid-scheme');
};

// URL includes credentials
window.credentialsInUrl = () => {
 fetch('https://user:password@sentry-test-external.io/credentials-in-url');
};

// Invalid mode
window.invalidMode = () => {
 fetch('https://sentry-test-external.io/invalid-mode', { mode: 'navigate' });
};

// Invalid request method
window.invalidMethod = () => {
 fetch('http://sentry-test-external.io/invalid-method', { method: 'CONNECT' });
};

// No-cors mode with cors-required method
window.noCorsMethod = () => {
 fetch('http://sentry-test-external.io/no-cors-method', { mode: 'no-cors', method: 'PUT' });
};

288 changes: 288 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,288 @@
import { expect } from '@playwright/test';
import { sentryTest } from '../../../utils/fixtures';
import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';

sentryTest('handles fetch network errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkError()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});


sentryTest('handles fetch network errors on subdomains @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkErrorSubdomain()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});

sentryTest('handles fetch invalid header name errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderName()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': Invalid name",
 webkit: "Invalid header name: 'C ontent-Type'",
 firefox: 'Window.fetch: c ontent-type is an invalid header name.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid header value errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderValue()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Failed to read the 'headers' property from 'RequestInit': The provided value cannot be converted to a sequence.",
 webkit: 'Value is not a sequence',
 firefox:
 "Window.fetch: Element of sequence<sequence<ByteString>> branch of (sequence<sequence<ByteString>> or record<ByteString, ByteString>) can't be converted to a sequence.",
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid URL scheme errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 await page.route('http://sentry-test-external.io/**', route => {
 return route.fulfill({
 status: 200,
 });
 });

 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidUrlScheme()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 /**
 * This kind of error does show a helpful warning in the console, e.g.:
 * Fetch API cannot load blub://sentry-test-external.io/invalid-scheme. URL scheme "blub" is not supported.
 * But it seems we cannot really access this in the SDK :(
 */

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch credentials in url errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('credentialsInUrl()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Request cannot be constructed from a URL that includes credentials: https://user:password@sentry-test-external.io/credentials-in-url",
 webkit: 'URL is not valid or contains user credentials.',
 firefox:
 'Window.fetch: https://user:password@sentry-test-external.io/credentials-in-url is an url with embedded credentials.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid mode errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMode()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Cannot construct a Request with a RequestInit whose mode member is set as 'navigate'.",
 webkit: 'Request constructor does not accept navigate fetch mode.',
 firefox: 'Window.fetch: Invalid request mode navigate.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid request method errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'CONNECT' HTTP method is unsupported.",
 webkit: 'Method is forbidden.',
 firefox: 'Window.fetch: Invalid request method CONNECT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest(
 'handles fetch no-cors mode with cors-required method errors @firefox',
 async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('noCorsMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'PUT' is unsupported in no-cors mode.",
 webkit: 'Method must be GET, POST or HEAD in no-cors mode.',
 firefox: 'Window.fetch: Invalid request method PUT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
 },
);

2 changes: 1 addition & 1 deletion
dev-packages/bundle-analyzer-scenarios/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/bundle-analyzer-scenarios",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "description": "Scenarios to test bundle analysis with",
 "repository": "git://github.com/getsentry/sentry-javascript.git",
 "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/dev-packages/bundle-analyzer-scenarios",
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Branch for 9.7.0-alpha by chargome · Pull Request #15738 · getsentry/sentry-javascript · GitHub
Skip to content
Branch for 9.7.0-alpha#15738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

chargome
wants to merge
10
commits into

from

 Closed


Branch for 9.7.0-alpha
#15738
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
ce13e76

fix(node): Ensure httpIntegration propagates traces


mydea Mar 19, 2025
2271282

small ref


mydea Mar 19, 2025
9024c1a

fix the test


mydea Mar 19, 2025
e3b6bc3

feat(browser): Attach top-level domain to "Failed to fetch" errors


mydea Mar 19, 2025
52829ca

adjust size limit


mydea Mar 19, 2025
76e3c0d

take top level domain only


mydea Mar 19, 2025
334bf41

meta(changelog): Update changelog for 9.7.0-alpha (#15740)


chargome Mar 19, 2025
e1c17b4

meta(changelog): Update changelog for 9.7.0-alpha.0 (#15742)


chargome Mar 19, 2025
c047605

release: 9.7.0-alpha.0


getsentry-bot Mar 19, 2025
7a60a58

Merge branch 'release/9.7.0-alpha.0' into 9.7.0-alpha

Mar 19, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.size-limit.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
 path: 'packages/browser/build/npm/esm/index.js',
 import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
 gzip: true,
 limit: '75.2 KB',
 limit: '76 KB',
 },
 {
 name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand Down

7 changes: 7 additions & 0 deletions
CHANGELOG.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,13 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0-alpha.0

This is an alpha release that includes experimental features which are subject to breaking changes.

- fix(node): Ensure httpIntegration propagates traces #15735
- feat(browser): Attach top-level domain to "Failed to fetch" errors #15729

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/browser-integration-tests",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "main": "index.js",
 "license": "MIT",
 "engines": {
Expand DownExpand Up@@ -42,7 +42,7 @@
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.34.0",
 "@sentry/browser": "9.6.1",
 "@sentry/browser": "9.7.0-alpha.0",
 "axios": "1.8.2",
 "babel-loader": "^8.2.2",
 "fflate": "0.8.2",
Expand Down

13 changes: 13 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 transportOptions: {
 fetchOptions: {
 // See: https://github.com/microsoft/playwright/issues/34497
 keepalive: false,
 },
 },
});

45 changes: 45 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/subject.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
// Based on possible TypeError exceptions from https://developer.mozilla.org/en-US/docs/Web/API/Window/fetch

// Network error (e.g. ad-blocked, offline, page does not exist, ...)
window.networkError = () => {
 fetch('http://sentry-test-external.io/does-not-exist');
};

window.networkErrorSubdomain = () => {
 fetch('http://subdomain.sentry-test-external.io/does-not-exist');
};

// Invalid header also produces TypeError
window.invalidHeaderName = () => {
 fetch('http://sentry-test-external.io/invalid-header-name', { headers: { 'C ontent-Type': 'text/xml' } });
};

// Invalid header value also produces TypeError
window.invalidHeaderValue = () => {
 fetch('http://sentry-test-external.io/invalid-header-value', { headers: ['Content-Type', 'text/html', 'extra'] });
};

// Invalid URL scheme
window.invalidUrlScheme = () => {
 fetch('blub://sentry-test-external.io/invalid-scheme');
};

// URL includes credentials
window.credentialsInUrl = () => {
 fetch('https://user:password@sentry-test-external.io/credentials-in-url');
};

// Invalid mode
window.invalidMode = () => {
 fetch('https://sentry-test-external.io/invalid-mode', { mode: 'navigate' });
};

// Invalid request method
window.invalidMethod = () => {
 fetch('http://sentry-test-external.io/invalid-method', { method: 'CONNECT' });
};

// No-cors mode with cors-required method
window.noCorsMethod = () => {
 fetch('http://sentry-test-external.io/no-cors-method', { mode: 'no-cors', method: 'PUT' });
};

288 changes: 288 additions & 0 deletions
dev-packages/browser-integration-tests/suites/errors/fetch/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,288 @@
import { expect } from '@playwright/test';
import { sentryTest } from '../../../utils/fixtures';
import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';

sentryTest('handles fetch network errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkError()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});


sentryTest('handles fetch network errors on subdomains @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('networkErrorSubdomain()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 });
});

sentryTest('handles fetch invalid header name errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderName()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': Invalid name",
 webkit: "Invalid header name: 'C ontent-Type'",
 firefox: 'Window.fetch: c ontent-type is an invalid header name.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid header value errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidHeaderValue()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Failed to read the 'headers' property from 'RequestInit': The provided value cannot be converted to a sequence.",
 webkit: 'Value is not a sequence',
 firefox:
 "Window.fetch: Element of sequence<sequence<ByteString>> branch of (sequence<sequence<ByteString>> or record<ByteString, ByteString>) can't be converted to a sequence.",
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid URL scheme errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 await page.route('http://sentry-test-external.io/**', route => {
 return route.fulfill({
 status: 200,
 });
 });

 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidUrlScheme()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: 'Failed to fetch (sentry-test-external.io)',
 webkit: 'Load failed (sentry-test-external.io)',
 firefox: 'NetworkError when attempting to fetch resource. (sentry-test-external.io)',
 };

 const error = errorMap[browserName];

 /**
 * This kind of error does show a helpful warning in the console, e.g.:
 * Fetch API cannot load blub://sentry-test-external.io/invalid-scheme. URL scheme "blub" is not supported.
 * But it seems we cannot really access this in the SDK :(
 */

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch credentials in url errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('credentialsInUrl()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Request cannot be constructed from a URL that includes credentials: https://user:password@sentry-test-external.io/credentials-in-url",
 webkit: 'URL is not valid or contains user credentials.',
 firefox:
 'Window.fetch: https://user:password@sentry-test-external.io/credentials-in-url is an url with embedded credentials.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid mode errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMode()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium:
 "Failed to execute 'fetch' on 'Window': Cannot construct a Request with a RequestInit whose mode member is set as 'navigate'.",
 webkit: 'Request constructor does not accept navigate fetch mode.',
 firefox: 'Window.fetch: Invalid request mode navigate.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest('handles fetch invalid request method errors @firefox', async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('invalidMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'CONNECT' HTTP method is unsupported.",
 webkit: 'Method is forbidden.',
 firefox: 'Window.fetch: Invalid request method CONNECT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
});

sentryTest(
 'handles fetch no-cors mode with cors-required method errors @firefox',
 async ({ getLocalTestUrl, page, browserName }) => {
 const url = await getLocalTestUrl({ testDir: __dirname });
 const reqPromise = waitForErrorRequest(page);
 await page.goto(url);
 await page.evaluate('noCorsMethod()');

 const eventData = envelopeRequestParser(await reqPromise);

 const errorMap: Record<string, string> = {
 chromium: "Failed to execute 'fetch' on 'Window': 'PUT' is unsupported in no-cors mode.",
 webkit: 'Method must be GET, POST or HEAD in no-cors mode.',
 firefox: 'Window.fetch: Invalid request method PUT.',
 };

 const error = errorMap[browserName];

 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'TypeError',
 value: error,
 mechanism: {
 handled: false,
 type: 'onunhandledrejection',
 },
 stacktrace: {
 frames: expect.any(Array),
 },
 });
 },
);

2 changes: 1 addition & 1 deletion
dev-packages/bundle-analyzer-scenarios/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
{
 "name": "@sentry-internal/bundle-analyzer-scenarios",
 "version": "9.6.1",
 "version": "9.7.0-alpha.0",
 "description": "Scenarios to test bundle analysis with",
 "repository": "git://github.com/getsentry/sentry-javascript.git",
 "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/dev-packages/bundle-analyzer-scenarios",
Expand Down
Loading