Uh oh!
There was an error while loading. Please reload this page.
meta(changelog): Update changelog for 9.12.0 - #16008
Merged
Merged
Conversation
[Gitflow] Merge master into develop
- set the `debug` option by reading `options.debug ?? process.env.SENTRY_DEBUG` - add unit test for a bunch of supported env variables
…shots (#15951) | Editing | In Sentry | | --- | --- | | <img width="1408" alt="SCR-20250402-pfuj" src="https://github.com/user-attachments/assets/896a1efe-74ac-42ca-8f51-b7024dee768c" /> | <img width="1421" alt="SCR-20250402-pgft" src="https://github.com/user-attachments/assets/37337f95-9e4d-477f-935b-2545466bc455" /> I should write that there are like 3 separate systems inside the `ScreenshotEditor` component, all working with the same data and helpers really, but each easy to spot and understand on their own. The end-goal is to have the correct thing rendered into `outputBuffer` (which is an argument to the component, but it's used for outputting data) and also render into the `foreground` and `background`. 1. The first is the `useLayoutEffect` and `useEffect` calls. These basically depend on the `screenshot` prop & `drawCommands` state. When those change we're basically re-sizing and re-rendering into our canvases. 2. The second system is all the stuff inside of `handleMouseDown`. We call `getBoundingClientRect` and use offsetX/offsetY for a consistent frame if reference when doing mouse coordinates. From in here we don't update any react state until onMouseUp happens, so the re-rendering onMouseMove is really fast to execute, and really easy to understand. 3. The last system to look at is is the `drawCommands` stuff and `scaleFactor`. All the drawCommands in state/memory are using an x/y coordinate system based on the size of the original screenshot. So when we call paintForeground it's really easy. But when we want to add `<div>` elements to the page we have to scale the sizes. This helps with window resize, and helps to consolidate when/where we convert from one x/y coordinate system to another. The resulting feedbacks are in the correct dpi, and have boxes draw using the same DPI. | Case | Img | | --- | --- | | No boxes drawn ever | <img width="485" alt="SCR-20250402-jidz" src="https://github.com/user-attachments/assets/3f5d177a-4652-40c1-be89-bfa2ff4f7399" /> | | Drew some, then removed them | <img width="452" alt="SCR-20250402-jifp" src="https://github.com/user-attachments/assets/c24fc144-d0f1-4b64-af6c-199eff0a3fee" /> | | Some boxes | <img width="452" alt="SCR-20250402-jigm" src="https://github.com/user-attachments/assets/a3af82b1-16a8-4a78-bac4-5d83f687a59f" /> | Related to #15424 Iteration on top of develop...ryan953/feedback-highlight-mask-refFixesgetsentry/sentry#69786 --------- Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Improving tests for #15859 - added `it.each` instead of looping with `foreach` - added tests for console output
With the addition on `instrumentation-client.ts` the likelihood of `Sentry.init()` rose starkly so I figured it might be worth printing a warning. Resolvesgetsentry/sentry-wizard#930
…ion` (#15959) Allow ignoring the request body for certain requests, which is very useful in situations of long-running requests with large/streaming request bodies which can result in a lot of memory usage --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #15959 Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
…ration (#15979) This PR adds a hook to the browser tracing integration that allows to hook into the creation of request spans (fetch & xhr) and set attributes based on headers (can be extended with additional info in the future). Primarily I was gonna use this to set an attribute/op on prefetch client requests in Next.js to show them as `http.client.prefetch`. --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Generally for attribute keys we prefer to avoid abbreviation. For example in OTEL, [`net.X`](https://github.com/getsentry/sentry-conventions/blob/main/generated/attributes/net.md) was renamed to [`network.X`](https://github.com/getsentry/sentry-conventions/blob/main/generated/attributes/network.md)
…st.prefetch: true` attribute (#15980) Adds a `http.request.prefetch: true` attribute to Next.js clientside requests if they're prefetching other pages. --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
They actually unexperimentified it vercel/next.js@2737373
…avigations (#15981) We relied on Next.js internals for navigation spans and that inevitably broke so Next.js added a `onRouterTransitionStart` hook in `instrumentation-client.ts` (vercel/next.js#77791) for us to use. This PR exposes a handler called `captureRouterTransitionStart` for that hook so that we can actually instrument navigations again.
Astro components are rendered in a stream, so if a component that is not the page fails during a request, this error is not thrown by the `await next()` call, only when the component is reached in the response stream. The code was iterating over the response stream assuming it was infallible, so component errors were being ignored by sentry and hidden from the user. This PR wraps the iteration on a `try/catch` pair to report the error and forward it along to the error handling pipeline.
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #15995 Co-authored-by: AbhiPrasad <18689448+AbhiPrasad@users.noreply.github.com>
resolves https://linear.app/getsentry/issue/LOGS-18 We got some user feedback that nodejs logging was too inconsistent. This PR improves that. 1. Add a new `flushLogs` client hook that allows us to reset server weight tracking logic more consistently. This also fixes a bug where we didn't reset weight tracking when calling `Sentry.flush`. 2. Add a `process.on('beforeExit'` listener to flush logs. Hooking onto `beforeExit` does not guarantee we flush all logs before exit, but it does increase the chances we do. 4. Add an idle timeout that will flush logs after 5 seconds if no new logs are recorded. This should not leak memory because it is not an interval, but instead a timeout.
fixes https://linear.app/getsentry/issue/LOGS-5 previously I wasn't matching the spec, this fixes that.
`server.address` is the equivalent to `server_name` we attach to errors and transactions. See the spec for the attribute here: https://getsentry.github.io/sentry-conventions/generated/attributes/server.html#serveraddress resolves https://linear.app/getsentry/issue/LOGS-32
AbhiPrasad
requested review from
andreiborza and mydea
and removed request for
a teamApril 8, 2025 10:29
Lms24
approved these changes
Apr 8, 2025
AbhiPrasad
commented
Apr 8, 2025
ContributorAuthor
will rebase when #16009 gets merged in and then we can cut the release |
#15993 is incredibly annoying to debug because we don't log the actual error
AbhiPrasadforce-pushed
the
prepare-release/9.12.0
branch
from
April 8, 2025 11:13
8c8b6ad to
9d4d6dfCompareAbhiPrasad
enabled auto-merge
April 8, 2025 11:15
auto-merge was automatically disabled
April 8, 2025 11:15
Pull request was closed
AbhiPrasad
enabled auto-merge
April 8, 2025 11:15
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a billion log bugs, let's get it out!