Uh oh!
There was an error while loading. Please reload this page.
meta(changelog): Update changelog for 9.15.0 - #16162
Merged
Merged
Conversation
[Gitflow] Merge master into develop
chore: Improve docstrings for options and add defaults
) Before submitting a pull request, please take a look at our [Contributing](https://github.com/getsentry/sentry-javascript/blob/master/CONTRIBUTING.md) guidelines and verify: - [ X ] If you've added code that should be tested, please add tests. - [ X ] Ensure your code lints and the test suite passes (`yarn lint`) & (`yarn test`).
We can get rid of this barrel file.
Exports the `wrapMcpServerWithSentry` which is our MCP server instrumentation from all the server packages. Fixes#16111
Adding Node 21 to the accepted version range for `module.register` as it is already supported (https://nodejs.org/docs/v21.0.0/api/module.html). This also causes the customization hook not to call register (maybe a reason why some packages in issue #14202 are not instrumented): https://github.com/getsentry/sentry-javascript/blob/59094afb6ab53ac33b87b83f70eea9d13e4c2291/packages/node/src/sdk/initOtel.ts#L45-L65 --- Additionally, the above mentioned issue #14202 shows the following warning although it's using v21: ``` [Sentry] You are using Node.js in ESM mode ("import syntax"). The Sentry Node.js SDK is not compatible with ESM in Node.js versions before 18.19.0 or before 20.6.0. Please either build your application with CommonJS ("require() syntax"), or upgrade your Node.js version. ```
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #16106 Co-authored-by: s1gr1d <32902192+s1gr1d@users.noreply.github.com>
…16135) Extracted out of #16134 During that refactor, a bunch of stuff failed. The reason for this is that we relied on a side-effect mock in `use-fake-timers` utility, which is really not ideal at all. So this refactors this to instead make this explicit, as a side-effect import on the top of the test files. Then we can just use `vi.useFakeTimers()` normally.
Vite 6 is more strict with exports. I changed the `exports` section a bit to make it compatible. closes#16120 --------- Co-authored-by: Onur Temizkan <onur@narval.co.uk>
Docs follow-up for this PR: #14831 --------- Co-authored-by: Francesco Gringl-Novy <francesco.novy@sentry.io>
Resolves: #16075 We used to allow rewrapping of the root loader when we had a separate Express adapter, where we could not determine the instrumentation order. Now that we don't have it anymore, we can remove this. Still, can't reproduce the original issue running e2e test apps under load. But it's clear that's what caused it.
We had a bunch of import/export related eslint rules, but did not actually apply them to anything 🤦 this PR changes this, and also applies all the rules to all the files. The vast majority of the changes is just auto-fixes, but there are a few small manual things that were needed - these are in separate commits, it's probably easier to look at them separately! It also updates prettier to apply to dev-packages.
I was always annoyed that this was not properly highlighted by VSCode, so I looked into this a bit, and actually refactored it a bit to be more type-safe in the vitest world we now live in :) I got rid of `toHaveSentReplay` in favor of simply always using `toHaveLastSentReplay` (which we already used almost everywhere). I also moved the type definition into a separate file and ensured it actually works, at leas tin my vscode/cursor instance. This also kind of surfaced some type errors that existed in tests, but have not been shown (??) for whatever reason... no idea what is going on there.
…pan instead of response span (#16126)
…6158) Seems like `@shopify/mini-oxygen@3.2.1` breaks something. I somewhat suspect that they bumped a vite version but I didn't find a changelog yet This should unblock the PRs we want to include in Today's release Update: Shopify/hydrogen#2863 likely caused this
- Closes#16137 With ESM patching you need to retain the original module and just overwrite the exports you want to wrap. This usually works for CJS too but unfortunately, the CJS exports of `ai` only have getters and no setters so this route is not possible. This PR changes the patching so that it works slightly differently for ESM and CJS. The original code that outputs a newly created object is retained for CJS but for ESM we use the preferred route of replacing the required exports. To detect whether the module we're patching is an ES module we check `Object.prototype.toString.call(moduleExports) === '[object Module]'` which is documented [here](https://tc39.es/ecma262/#sec-module-namespace-objects). This PR also adds an ESM test for `ai`.
Contributor
size-limit report 📦
|
Lms24
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.