Uh oh!
There was an error while loading. Please reload this page.
meta(changelog): Update changelog for 9.16.0 - #16207
Merged
Merged
Conversation
To test logs for the alpha we used a standardized `otel_log` envelope item. Now that the logs protocol is more stable, we are switching to the sentry specific envelope item. This is fully documented here: https://develop.sentry.dev/sdk/telemetry/logs/
[Gitflow] Merge master into develop
Today, we do not have a lot of esm-specific node integration tests. Our
tests make it possible to test ESM, but we only use it very rarely,
sticking to cjs tests across the suite mostly. This means that we have a
bunch of gaps around our ESM support.
This PR introduces a new test utility to make it easier to test stuff in
ESM and CJS:
```js
createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createRunner, test) => {
test('it works when importing the http module', async () => {
const runner = createRunner(); // normal test as before
});
});
```
This has a few limitations based on how this works - we can make this
more robust in the future, but for now it should be "OK":
1. It requires a .mjs based instrument file as well as an .mjs based
scenario
2. No relative imports are supported (all content must be in these two
files)
3. It simply regex replaces the esm imports with require for the CJS
tests. not perfect, but it kind of works
For tests that are known to fail on e.g. esm or cjs, you can configure
`failsOnEsm: true`. In this case, it will fail if the test _does not
fail_ (by using `test.fails()` to ensure test failure). This way we can
ensure we find out if stuff starts to fail etc.
To make this work, I had to re-write the test runner code a bit, because
it had issues with vitest unhandled rejection handling. Due to the way
we handled test completion with a promise, `test.fails` was not working
as expected, because the test indeed succeeded when it failed, but the
overall test run still failed because an unhandled rejection bubbled up.
Now, this should work as expected...
I re-wrote a few tests already to show how it works, plus added a new
test that shows an ESM test failure when importing http module (😭 )chore: Update GH issue templates for Linear compatibility
This removes usage of `axios` in our node-integration-test runner, in favor of just using `fetch`.
An internal user reported seeing "NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node." and the replay of their session confirms it: https://sentry.sentry.io/explore/replays/127444034ae84099a84b524458b6dd90/ However, there is no matching JS error to give more clues. What I think happened is that after interacting with the Feedback SDK the widget got into a state where it was no longer mounted into the page, but we called `removeFromDom()` anyway. Looking at the replay i saw the moment when the feedback dom was aded to the page, but it wasn't visible, only this got added at 18:51: <img width="265" alt="SCR-20250411-lsav" src="https://github.com/user-attachments/assets/1f65a174-1a8a-405c-8ce4-be0a10d09a64" /> So something prevented it from opening all the way up. Fixesgetsentry/sentry#89424
This PR introduces a new `instrumentDurableObjectWithSentry` method to
the SDK, which instruments durable objects. We capture both traces and
errors automatically.
Usage:
```ts
class MyDurableObjectBase extends DurableObject<Env> {
// impl
}
// Export your named class as defined in your wrangler config
export const MyDurableObject = Sentry.instrumentDurableObjectWithSentry(
// need to define options again because durable objects can be in a separate instance
// to the cloudflare worker (env) => ({
dsn: env.SENTRY_DSN,
tracesSampleRate: 1.0,
}),
MyDurableObjectBase,
);
```
This should work with websockets, and thus
https://github.com/getsentry/sentry-mcp as well.
This PR also refactors some types in
`packages/cloudflare/src/handler.ts` with the `withSentry` method, which
should prevent type errors in some situations.
resolves#15975
resolves https://linear.app/getsentry/issue/JS-285resolves#16182
resolves https://linear.app/getsentry/issue/JS-398…16143) Based on the docs work for the issue getsentry/sentry-docs#13407, I went through the repository and looked for places where a conditional check for `sendDefaultPii` might be missing.
- Adds client-side instrumentation for react router's `HydratedRouter` (which is basically a `DataRouter` enhanced with ssr data) - Updates pageloads to have parameterized transaction names - Adds parameterized navigation payloads - Adds `reactRouterTracingIntegration` which needs to be used instead of `browserTracingIntegration` (this in turn inits the router instrumentation) - Logs a warning whenever `browserTracingIntegration` is used within this package closes#16160
…#16183) If users manually pass in `sentry-trace` and `baggage` headers, we previously overwrote the values with the ones we computed. With this patch, we: - still check for pre-existing sentry headers, but do nothing if we find them instead of replacing them - still ensure that we merge pre-existing non-sentry baggage values with our baggage values - add a bunch of unit tests for the various header and request types (I feel like I wrote these before but couldn't find em) - add an integration test to demonstrate that manually passed in headers are still taken
…ests (#16184) Analogously to #16183 for `fetch`, this patch ensures that manually set `sentry-trace` and `baggage` headers in XHR requests are respected by our XHR instrumentation and not overwritten. This patch also fixes a bug where we'd append multiple `sentry-trace` or `baggage` values in case the header was somehow set more than once (analogously to #13907 for `fetch`)
@s1gr1d and @Lms24 figured out that the duplicate spans we sometimes see are related to esm and the http module. Especially, it seems to be related to us using the `stealthWrap` function to wrap `server.emit` for request isolation purposes. While we still don't really know _why_ this is making such problems, this PR seems to fix it (at least in integration tests) by avoiding using import-in-the-middle here, and instead using diagnostics channel with good old-fashioned monkey patching on the passed-in `server` instance. Some note: We need to make sure to still call this in the otel-wrapping code of `init()`, otherwise there are weird timing issues in top-level-import scenarios 😬 Hopefully fixes#15830, and fixes#15803 --------- Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
Implement consistent sampling across traces in browser SDKs. Concrete changes: - Add `consistentTraceSampling` option - Emit `beforeSampling` hook before sampling and creating `SentrySpan`'s in the coreSDK (this hook is already called in Otel-based spans). - Allow `beforeSampling` hook subscribers to alter span `attributes` and `parentSampled` flag - Subscribe to `beforeSampling` hook when `consistentTraceSampling` is enabled and `linkPreviousTrace` is not disabled - modify attributes and `parentSampled` flag based on the sampling decision, sample rate and sample rand of the previous trace - this will ensure that the newly started trace is sampled postitively/negatively depending on the decision of the previous trace - we also directly modify the propagation context to ensure that the previous trace's sampling decision, rate and rand are propagated correctly to downstream services and in the `trace` envelope header. This is necessary to ensure correct span metrics extrapolation. - sampling decisions from `<meta>` tags still have precedence for the first pageload over the previous trace's sampling decision. This is necessary because we need to prioritize inter-trace completeness over intra-trace completeness - explicit sampling decisions from `tracesSampler` still have precedence over the previous trace's sampling decision - added a bunch of browser integration tests describing the behaviour in various edge cases and sampling configurations
resolves#15989 resolves https://linear.app/getsentry/issue/JS-270 Adds logs exports to the cloudflare SDK. The cloudflare SDK is implemented on top of the `ServerRuntimeClient`, so it has all the flushing improvements we added to the Node.js SDK.
feat(react-router): Create a Vite plugin that injects sentryConfig into the global vite config
This updates naming etc. for express (v5) tests, and makes sure that we test this in esm & cjs in a basic way. It also adds test for handling of the root route (`/`) as well as 404, where current failures are shown (see #16203).
Contributor
size-limit report 📦
|
chargome
reviewed
May 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
As pre-work for #16178, actually add a test for this (kind of). This showed that there was actually a fundamental flaw here, as we looked as the `req` not the `res`, oops.
This can be configured like this:
```js
httpIntegration({
dropSpansForIncomingRequestStatusCodes: [404, [300,399]]
})
```
It defaults to `[404]`. Closes#16193resolves#16110 Stores the Client to LogBuffer WeakMap onto the global object so logs can be retrieved correctly during flushing. Previously, the WeakMap reference would be different at flush time, causing no logs to be found for any given client. Adds an express e2e tests to ensure logs are flushed correctly.
AbhiPrasad
approved these changes
May 7, 2025
This PR enables reading the `SENTRY_RELEASE` variable from the CF `env` that users should pass to their `withSentry` worker wrapper. This is quite similar to how we'd usually access env variables in Node-based SDKs. We need this for uploading release-based source maps for CF worker functions being bundled and deployed by wrangler. see getsentry/sentry-wizard#824 (comment) ref https://linear.app/getsentry/issue/WIZARD-36/improve-sentrywizard-i-sourcemaps-for-cloudflarewrangler --------- Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
RulaKhaledforce-pushed
the
prepare-release/9.16.0
branch
from
May 7, 2025 13:57
73a9c95 to
2687d26Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update changelog for 9.16.0