Skip to content

deps(solidstart): Add explicit peer deps as devDependencies - #16860

Merged
mydea merged 1 commit into
developfrom
fn/add-solidstart-peer-deps
Jul 10, 2025
Merged

deps(solidstart): Add explicit peer deps as devDependencies#16860
mydea merged 1 commit into
developfrom
fn/add-solidstart-peer-deps

Conversation

@mydea

@mydeamydea commented Jul 9, 2025

Copy link
Copy Markdown
Member

This adds explicit peer dependecies in the solidstart package. Those are dev dependencies only. Importantly, that seems to bump some things that result in slightly different types we need to adjust to.

Extracted out of #16751

@mydeamydea self-assigned this Jul 9, 2025
@mydea
mydeaforce-pushed the fn/add-solidstart-peer-deps branch from c93f037 to 2878ce0CompareJuly 9, 2025 13:25
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser23.99 kB--
@sentry/browser - with treeshaking flags23.76 kB--
@sentry/browser (incl. Tracing)39.62 kB--
@sentry/browser (incl. Tracing, Replay)77.82 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.9 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)82.54 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)94.7 kB--
@sentry/browser (incl. Feedback)40.75 kB--
@sentry/browser (incl. sendFeedback)28.7 kB--
@sentry/browser (incl. FeedbackAsync)33.59 kB--
@sentry/react25.76 kB--
@sentry/react (incl. Tracing)41.61 kB--
@sentry/vue28.37 kB--
@sentry/vue (incl. Tracing)41.41 kB--
@sentry/svelte24.01 kB--
CDN Bundle25.5 kB--
CDN Bundle (incl. Tracing)39.63 kB--
CDN Bundle (incl. Tracing, Replay)75.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)81.07 kB--
CDN Bundle - uncompressed74.5 kB--
CDN Bundle (incl. Tracing) - uncompressed117.77 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed232.07 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed244.89 kB--
@sentry/nextjs (client)43.26 kB--
@sentry/sveltekit (client)40.08 kB--
@sentry/node161.84 kB-0.01%-9 B 🔽
@sentry/node - without tracing98.79 kB-0.01%-6 B 🔽
@sentry/aws-serverless124.61 kB-0.02%-17 B 🔽

View base workflow run

@mydeamydea changed the title deps(solidstart): Add explicit peer depsdeps(solidstart): Add explicit peer deps as devDependenciesJul 9, 2025
@mydea
mydea merged commit 501e442 into developJul 10, 2025
@mydea
mydea deleted the fn/add-solidstart-peer-deps branch July 10, 2025 07:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@andreiborza