Uh oh!
There was an error while loading. Please reload this page.
deps(dev): Add missing peer dependencies of dev dependencies - #16751
Conversation
485df2e to
d477e77Comparesize-limit report 📦
|
c752ad0 to
25687c2Compare❌ Unsupported file formatUpload processing failed due to unsupported file format. Please review the parser error message:
For more help, visit our troubleshooting guide. |
f66c60e to
8e4e86bCompare| const expectedScripts = [ | ||
| '/init.bundle.js', | ||
| '/subject.bundle.js', |
There was a problem hiding this comment.
this (subject) is not defined for this test, apparently some changed webpack version emits or does not emit the empty file anymore, but this should be OK.
| "@nestjs/common": "11.0.16", | ||
| "@nestjs/core": "10.4.6", | ||
| "@nestjs/platform-express": "10.4.6", | ||
| "@nestjs/common": "11.1.3", |
There was a problem hiding this comment.
bumping & aligning to latest as that fixes some transitive dependency security issue.
| "ember-template-lint": "~4.16.1", | ||
| "eslint-plugin-ember": "11.9.0", | ||
| "eslint-plugin-n": "16.0.1", | ||
| "eslint-plugin-n": "15.0.0", |
There was a problem hiding this comment.
downgrading because this actually requires eslint 8
| import { captureException, getClient, getTraceMetaTags, logger } from '@sentry/core'; | ||
| import type { VueOptions } from '@sentry/vue/src/types'; | ||
| import type { CapturedErrorContext } from 'nitropack'; | ||
| import type { CapturedErrorContext } from 'nitropack/types'; |
There was a problem hiding this comment.
this apparently changed in a newer nitropack version 😭
There was a problem hiding this comment.
should we extract this change out? Might be easier debug/rollback if we need to.
| }; | ||
| export type SolidStartInlineConfig = Parameters<typeof defineConfig>[0]; | ||
| export type SolidStartInlineConfig = NonNullable<Parameters<typeof defineConfig>[0]>; |
There was a problem hiding this comment.
type is now possible undefined, which leads to problems.
8e4e86b to
4ee837dCompare2785d43 to
1e7a6d4Compare
AbhiPrasad
left a comment
There was a problem hiding this comment.
It might be nice to split out the nuxt and solidstart changes given they change application code, git blame/rollback will be easier.
| import { captureException, getClient, getTraceMetaTags, logger } from '@sentry/core'; | ||
| import type { VueOptions } from '@sentry/vue/src/types'; | ||
| import type { CapturedErrorContext } from 'nitropack'; | ||
| import type { CapturedErrorContext } from 'nitropack/types'; |
There was a problem hiding this comment.
should we extract this change out? Might be easier debug/rollback if we need to.
14cd14c to
519054dCompareThis just bumps the underlying transitive dependency on nitropack, which apparently changes some type imports. Extracted out of #16751
This just bumps the underlying transitive dependency on nitropack, which apparently changes some type imports. Extracted out of #16751
Lms24
left a comment
There was a problem hiding this comment.
Ah these are peer dependencies specified by other dependencies. Took me a minute to grasp. But makes sense 👍
This adds explicit peer dependecies in the solidstart package. Those are dev dependencies only. Importantly, that seems to bump some things that result in slightly different types we need to adjust to. Extracted out of #16751
This adds missing peer dependencies that yarn complains about. Nothing should change, fundamentally. some more refs
519054d to
74c5fccComparemydea
commented
Jul 10, 2025
Extracted more user-facing changes out, now this should be more straightforward than before! |
There was a problem hiding this comment.
Bug: Sucrase Resolution Change Affects Transitive Dependencies
The sucrase resolution pattern in package.json was changed from **/sucrase to sucrase. This narrows the scope from all sucrase dependencies (including transitive) to only direct ones. Consequently, transitive dependencies requiring the getsentry/sucrase#es2020-polyfills custom fork will no longer receive it, potentially causing breakage if they rely on its ES2020 polyfills.
package.json#L151-L152
sentry-javascript/package.json
Lines 151 to 152 in a84aae3
Was this report helpful? Give feedback by reacting with 👍 or 👎
…ncy (#19824) It seems like we added `file-type` as a dependency in #16751 with the reason that yarn was complaining about a missing peer dependency. However, `file-type` is not a peer dependency but a dependency of `@nestjs/common`. So it should be installed anyway. Given CI passes, I'd rather remove it for now.
This adds missing peer dependencies that yarn complains about. Nothing should change, fundamentally.
Extracted this out of #16744