Uh oh!
There was an error while loading. Please reload this page.
fix(browser): Handle data urls in errors caught by globalHandlersIntegration - #17216
Merged
Conversation
Contributor
size-limit report 📦
|
AbhiPrasad pushed a commit
that referenced
this pull request
Jul 31, 2025
- Ref #17216 Because JavaScript can dynamically load code from text like this: ```ts const {dynamicFn} = await import(`data:application/javascript, export function dynamicFn() { throw new Error('Error from data-uri module'); };`); dynamicFn(); ``` You can get slack lines like this: ``` at dynamicFn (data:application/javascript,export function dynamicFn() { throw new Error('Error from data-uri module');};:1:38) ``` These can be huge, often base64 encoded strings. Currently we skip regex parsing on anything over 1k in length but that means we ignore the frame entirely. This PR: - Changes the stack parser so that if the line is over 1k, we still pass the first 1k for parsing - Adds initial check to the Node line parser that special cases truncated lines with data URIs in them
Lms24force-pushed
the
lms/fix-browser-long-data-urls
branch
from
August 1, 2025 13:43
9084de1 to
e26cd1dCompareLms24
marked this pull request as ready for review
August 1, 2025 13:43
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
timfish
reviewed
Aug 1, 2025
timfish
left a comment
Collaborator
There was a problem hiding this comment.
Needs a test!
I've got another PR incoming that adds the data Uri handling to chrome too.
Lms24
commented
Aug 7, 2025
MemberAuthor
good call with the Test, thanks! Added an integration test |
Lms24force-pushed
the
lms/fix-browser-long-data-urls
branch
from
August 7, 2025 11:31
e26cd1d to
22ce8dcComparetimfish
approved these changes
Aug 7, 2025
Lms24
enabled auto-merge (squash)
August 7, 2025 11:33
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17218 adjusted data URI stack line parsing for most errors that go through the stack parsers (fully for node, line truncation in general). This PR now applies a similar logic to
globalHandlersIntegrationwhich in some conditions applies a stack frame that doesn't go through the same stack parser.