Uh oh!
There was an error while loading. Please reload this page.
fix(node): Handle stack traces with data URI filenames - #17218
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
timfishforce-pushed
the
timfish/fix/node-stack-trace-data-uri
branch
from
July 29, 2025 19:23
fcdb0ef to
7072a48Comparetimfishforce-pushed
the
timfish/fix/node-stack-trace-data-uri
branch
from
July 29, 2025 19:28
c6b2471 to
59550e3CompareAbhiPrasad
approved these changes
Jul 30, 2025
AbhiPrasad
commented
Jul 31, 2025
Contributor
Let's get this backported too! |
Uh oh!
There was an error while loading. Please reload this page.
AbhiPrasad pushed a commit
that referenced
this pull request
Aug 5, 2025
This PR copies what we did for Node (#17218) but for the Chromium stack parser.
RulaKhaled pushed a commit
that referenced
this pull request
Aug 7, 2025
This PR copies what we did for Node (#17218) but for the Chromium stack parser.
Lms24 added a commit
that referenced
this pull request
Aug 7, 2025
…egration` (#17216) [#17218](#17218) adjusted data URI stack line parsing for most errors that go through the stack parsers (fully for node, line truncation in general). This patch now applies a similar logic to `globalHandlersIntegration` which in some conditions applies a stack frame that doesn't go through the same stack parser.
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
globalHandlersIntegration#17216Because JavaScript can dynamically load code from text like this:
You can get slack lines like this:
These can be huge, often base64 encoded strings.
Currently we skip regex parsing on anything over 1k in length but that means we ignore the frame entirely.
This PR: