') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update raven.js to work around IE8 shortcomings by johnbacon · Pull Request #179 · getsentry/sentry-javascript · GitHub
Skip to content

Update raven.js to work around IE8 shortcomings - #179

Merged
mattrobenolt merged 3 commits into
getsentry:masterfrom
johnbacon:patch-1
Jan 11, 2014
Merged

Update raven.js to work around IE8 shortcomings#179
mattrobenolt merged 3 commits into
getsentry:masterfrom
johnbacon:patch-1

Conversation

@johnbacon

@johnbaconjohnbacon commented Jan 10, 2014

Copy link
Copy Markdown
Contributor

Internet Explorer 8 chokes on an undefined or null reference passed into the joinRegExp function:

SCRIPT5007: Unable to get property 'source' of undefined or null reference raven.js, line 1762 character 9

Line 1762, character 9 is as follows:

sources[i]=isString(patterns[i]) ?

Checking for the presence of an undefined or null value correctly handles this quirk while still seemingly performing correctly when present.

@johnbacon
Update raven.js to work around IE8 shortcomings
1e5c561
Internet Explorer 8 chokes on an undefined or null reference passed into this function. Wrapping an if statement around the processing correctly handles this while still performing correctly.
mattrobenolt
mattrobenolt reviewed Jan 10, 2014
View reviewed changes
Comment threadsrc/raven.js Outdated

@mattrobenoltmattrobenoltJan 10, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a helper for isUndefined.

@mattrobenolt

mattrobenolt commented Jan 10, 2014

Copy link
Copy Markdown
Contributor

Looks good to me.

Are you able to add a test to assert this behavior is correct and we don't regress in the future?

@johnbacon
Test whether joinRegExp processes empty or undefined variables
e75467d
Raven throws an error if empty or undefined variables are processed by joinRegExp. Some browsers (such as Internet Explorer 8 and possibly earlier) apparently pass these variables, causing errors.
@johnbacon
Use the isUndefined helper rather than typeof in joinRegExp
fdac9de
@johnbacon

johnbacon commented Jan 11, 2014

Copy link
Copy Markdown
ContributorAuthor

Take a look at that and see if it's acceptable.

@mattrobenolt

mattrobenolt commented Jan 11, 2014

Copy link
Copy Markdown
Contributor

So if we're being specific to the problem here, the issue is that it has a variable which doesn't have a source property.

What if we did a check for: isString(sources[i]) || (!isUndefined(sources[i]) && sources[i].source)

Thinking to prevent other edge cases that may pop up. I think this function can just be reworked to handle specifically if it's a string, or if it has a .source. Ignore everything else.

Thoughts?

mattrobenolt added a commit that referenced this pull request Jan 11, 2014
@mattrobenolt
Merge pull request#179from johnbacon/patch-1
61d5b88
Update raven.js to work around IE8 shortcomings
@mattrobenolt
mattrobenolt merged commit 61d5b88 into getsentry:masterJan 11, 2014
@johnbacon

johnbacon commented Jan 11, 2014

Copy link
Copy Markdown
ContributorAuthor

A buddy and I were working on a slightly more robust solution. Expect to see it soon!

johnbacon added a commit to johnbacon/raven-js that referenced this pull request Jan 11, 2014
@johnbacon
Improved solution to issuegetsentry#179(invalid options throwing er…
0bd6221
…rors in joinRegExp)
This slightly more robust solution ignores options that are not strings
or regular expressions in the passed patterns array.
The prior solution still accepted non-string, non-regexp options (e.g.
[], {}, true, etc.).
Credit goes to @soundslocke for the fix.
mattrobenolt added a commit that referenced this pull request Jan 12, 2014
@mattrobenolt
Merge pull request#180from johnbacon/patch-1
f3baeee
Improved solution to issue #179 (invalid options throwing errors in joinRegExp)
@mattrobenolt

mattrobenolt commented Jan 16, 2014

Copy link
Copy Markdown
Contributor

@johnbacon I've published a 1.1.8, fwiw with this patch. Thanks again. :)

kamilogorek pushed a commit that referenced this pull request Jun 12, 2018
James Baxley@benvinegar
add in environment option (#179)
14401a2
mydea added a commit that referenced this pull request May 12, 2025
@mydea
deps(node): Bump import-in-the-middle to 1.13.1
5eea5d5
See https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.13.1
### Bug Fixes
* handling of circular dependencies ([#181](nodejs/import-in-the-middle#181)) ([b58092e](nodejs/import-in-the-middle@b58092e))
* importing JSON files ([#182](nodejs/import-in-the-middle#182)) ([8c52014](nodejs/import-in-the-middle@8c52014))
* warning from use of context.importAssertions ([#179](nodejs/import-in-the-middle#179)) ([8e56cf1](nodejs/import-in-the-middle@8e56cf1))
mydea added a commit that referenced this pull request May 12, 2025
@mydea
deps(node): Bumpimport-in-the-middleto1.13.1(#16260)
02f280c
See
https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.13.1
### Bug Fixes
* handling of circular dependencies
([#181](nodejs/import-in-the-middle#181))
([b58092e](nodejs/import-in-the-middle@b58092e))
* importing JSON files
([#182](nodejs/import-in-the-middle#182))
([8c52014](nodejs/import-in-the-middle@8c52014))
* warning from use of context.importAssertions
([#179](nodejs/import-in-the-middle#179))
([8e56cf1](nodejs/import-in-the-middle@8e56cf1))
This version is already allowed by our range, but in order to ensure
everybody gets this, bumping it here.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnbacon@mattrobenolt