') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); add option to prevent wrapping also the functions arguments by Stereobit · Pull Request #182 · getsentry/sentry-javascript · GitHub
Skip to content

add option to prevent wrapping also the functions arguments - #182

Merged
mattrobenolt merged 4 commits into
getsentry:masterfrom
Stereobit:master
Jan 19, 2014
Merged

add option to prevent wrapping also the functions arguments#182
mattrobenolt merged 4 commits into
getsentry:masterfrom
Stereobit:master

Conversation

@Stereobit

@StereobitStereobit commented Jan 18, 2014

Copy link
Copy Markdown
Contributor

Hey,

I've been running into some problems when wrapping require JS define and require functions. I often return functions that have to be called as constructor functions. My first approach was checking if the function is called as a constructor function and if so calling the wrapped function with the new keyword as well. Which is impossible as long as you want variable arguments.

The next approach was using a ES6 Object.setPrototypeOf() polyfill. It's working but it is strongly discouraged, because it is very slow and unavoidably slows down subsequent execution in modern JavaScript implementations.

So I ended up adding a option to prevent wrapping the functions arguments.

~ Tobi

@mattrobenolt

mattrobenolt commented Jan 19, 2014

Copy link
Copy Markdown
Contributor

Can you give me an example where this fails so I can figure out a better way to potentially do it automatically?

mattrobenolt added a commit that referenced this pull request Jan 19, 2014
@mattrobenolt
Merge pull request#182from Stereobit/master
9419e48
add option to prevent wrapping also the functions arguments
@mattrobenolt
mattrobenolt merged commit 9419e48 into getsentry:masterJan 19, 2014
@Stereobit

Stereobit commented Jan 19, 2014

Copy link
Copy Markdown
ContributorAuthor

Sure. Checkout http://jsfiddle.net/k7uaT/

You can add/remove raven to see the problem.

@mattrobenolt

mattrobenolt commented Jan 19, 2014

Copy link
Copy Markdown
Contributor

Ohh, I see. JavaScript sucks. :(

Thanks for the PR.

kamilogorek pushed a commit that referenced this pull request Jun 12, 2018
@benvinegar
Use json-stringify-safe to prevent circular references (refs#102) (#182
800d67c
)
kamilogorek pushed a commit that referenced this pull request Jun 12, 2018
@adamchainz@mattrobenolt
History - fix issue number for process.env (#230)
63eef4d
#181 not #182
mydea added a commit that referenced this pull request May 12, 2025
@mydea
deps(node): Bump import-in-the-middle to 1.13.1
5eea5d5
See https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.13.1
### Bug Fixes
* handling of circular dependencies ([#181](nodejs/import-in-the-middle#181)) ([b58092e](nodejs/import-in-the-middle@b58092e))
* importing JSON files ([#182](nodejs/import-in-the-middle#182)) ([8c52014](nodejs/import-in-the-middle@8c52014))
* warning from use of context.importAssertions ([#179](nodejs/import-in-the-middle#179)) ([8e56cf1](nodejs/import-in-the-middle@8e56cf1))
mydea added a commit that referenced this pull request May 12, 2025
@mydea
deps(node): Bumpimport-in-the-middleto1.13.1(#16260)
02f280c
See
https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.13.1
### Bug Fixes
* handling of circular dependencies
([#181](nodejs/import-in-the-middle#181))
([b58092e](nodejs/import-in-the-middle@b58092e))
* importing JSON files
([#182](nodejs/import-in-the-middle#182))
([8c52014](nodejs/import-in-the-middle@8c52014))
* warning from use of context.importAssertions
([#179](nodejs/import-in-the-middle#179))
([8e56cf1](nodejs/import-in-the-middle@8e56cf1))
This version is already allowed by our range, but in order to ensure
everybody gets this, bumping it here.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Stereobit@mattrobenolt