Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10#18631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -99,13 +99,11 @@ | ||
| } | ||
| }, | ||
| "dependencies": { | ||
| "@apm-js-collab/tracing-hooks": "^0.3.1", | ||
cursor[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| "@sentry/core": "10.39.0", | ||
| "@sentry/opentelemetry": "10.39.0", | ||
| "import-in-the-middle": "^2.0.6" | ||
| }, | ||
| "devDependencies": { | ||
| "@apm-js-collab/code-transformer": "^0.8.2", | ||
| "@opentelemetry/api": "^1.9.0", | ||
| "@opentelemetry/context-async-hooks": "^2.5.0", | ||
| "@opentelemetry/core": "^2.5.0", | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -9,7 +9,6 @@ import { | ||
| severityLevelFromString, | ||
| withScope, | ||
| } from '@sentry/core'; | ||
| import { addInstrumentationConfig } from '../sdk/injectLoader'; | ||
| const SENTRY_TRACK_SYMBOL = Symbol('sentry-track-pino-logger'); | ||
| @@ -128,18 +127,6 @@ const _pinoIntegration = defineIntegration((userOptions: DeepPartial<PinoOptions | ||
| setup: client => { | ||
| const enableLogs = !!client.getOptions().enableLogs; | ||
| addInstrumentationConfig({ | ||
| channelName: 'pino-log', | ||
| // From Pino v9.10.0 a tracing channel is available directly from Pino: | ||
| // https://github.com/pinojs/pino/pull/2281 | ||
| module: { name: 'pino', versionRange: '>=8.0.0 < 9.10.0', filePath: 'lib/tools.js' }, | ||
| functionQuery: { | ||
| functionName: 'asJson', | ||
| kind: 'Sync', | ||
| }, | ||
| }); | ||
| const injectedChannel = diagnosticsChannel.tracingChannel('orchestrion:pino:pino-log'); | ||
| const integratedChannel = diagnosticsChannel.tracingChannel('pino_asJson'); | ||
| function onPinoStart(self: Pino, args: PinoHookArgs, result: PinoResult): void { | ||
sentry[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. sentry[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| @@ -192,11 +179,6 @@ const _pinoIntegration = defineIntegration((userOptions: DeepPartial<PinoOptions | ||
| } | ||
| } | ||
| injectedChannel.end.subscribe(data => { | ||
| const { self, arguments: args, result } = data as { self: Pino; arguments: PinoHookArgs; result: string }; | ||
| onPinoStart(self, args, JSON.parse(result)); | ||
| }); | ||
| integratedChannel.end.subscribe(data => { | ||
| const { | ||
| instance, | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix PR lacks regression test per review rules
Low Severity
Per the review rules, a
fixPR needs at least one unit, integration, or E2E test that validates the regression being fixed. This PR only bumps the pino version in tests from 9.9.4 to 9.10.0 but doesn't add a new test verifying that the bundle size reduction works or that pino integration still functions correctly with only theintegratedChannel. Existing tests may pass coincidentally without actually verifying the specific change.Triggered by project rule: PR Review Guidelines for Cursor Bot