fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 - #18631

Merged
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
Feb 17, 2026
Merged

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10#18631
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when

Conversation

@logaretm

Copy link
Copy Markdown
Member

We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in frameworks still using CJS like Next.js, even if the user was not using Pino integration at all. Attempts to tree-shake it failed as Next.js is still using CJS.

We can drop support for older versions of Pino, given that pino@9.10 already exposes a tracing channel that we use, and that the injected channel was a backup for pino<9.10

This will reduce bundle sizes and ensure frameworks incapable of esm tree-shaking don't pick it up as a dependency.

I will remove @apm-js-collab/tracing-hooks as a dep from node-core since nothing else uses it.

closes#18199

@linear

linearBot commented Dec 29, 2025

Copy link
Copy Markdown

@logaretmlogaretm changed the title ref(pino): Drop pino<9.10 supportref(node-core): Drop pino<9.10 supportDec 29, 2025
@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,239-11,206-18%
GET With Sentry1,71419%1,856-8%
GET With Sentry (error only)6,11266%7,570-19%
POST Baseline1,185-1,166+2%
POST With Sentry59951%572+5%
POST With Sentry (error only)1,05089%1,025+2%
MYSQL Baseline3,257-3,984-18%
MYSQL With Sentry50015%515-3%
MYSQL With Sentry (error only)2,65882%3,288-19%

View base workflow run

@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.22 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.07 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB-0.01%-5 B 🔽
@sentry/node166.53 kB-0.01%-2 B 🔽
@sentry/node - without tracing93.95 kB+0.01%+1 B 🔺
@sentry/aws-serverless109.45 kB-0.01%-2 B 🔽

View base workflow run

@Lms24Lms24 added this to the 11.0.0 milestone Dec 29, 2025
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 3d7aa48 to e0577edCompareFebruary 15, 2026 17:51
@logaretm
logaretm marked this pull request as ready for review February 16, 2026 06:41
Comment threadpackages/node-core/package.json
Comment threadpackages/node-core/src/integrations/pino.ts

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR drops support for Pino versions before 9.10.0 to reduce bundle size, particularly for frameworks using CommonJS (like Next.js) that cannot effectively tree-shake unused dependencies. The change removes the @apm-js-collab/tracing-hooks dependency and associated injection loader infrastructure, relying solely on the native pino_asJson tracing channel introduced in Pino 9.10.0.

Changes:

  • Removed @apm-js-collab/tracing-hooks and @apm-js-collab/code-transformer dependencies
  • Deleted the injection loader infrastructure (injectLoader.ts and related hooks)
  • Updated Pino integration to use only the native pino_asJson tracing channel
  • Updated test dependencies to use Pino 9.10.0

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
yarn.lockRemoved @apm-js-collab package entries and updated pino from 9.9.4 to 9.10.0
packages/node-core/src/sdk/injectLoader.tsDeleted entire file containing injection loader infrastructure
packages/node-core/src/sdk/index.tsRemoved GLOBAL_OBJ import and call to inject loader hook registration
packages/node-core/src/integrations/pino.tsRemoved addInstrumentationConfig import and usage, removed injectedChannel subscription for pino<9.10
packages/node-core/package.jsonRemoved @apm-js-collab/tracing-hooks dependency and @apm-js-collab/code-transformer devDependency
packages/core/src/utils/worldwide.tsRemoved _sentryInjectLoaderHookRegister and _sentryInjectLoaderHookRegistered global type definitions
dev-packages/node-integration-tests/package.jsonUpdated pino version from 9.9.4 to 9.10.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since it seems like a lot of users are affected by largely increased bundle/module sizes. Some suggestions:

  • I'd re-classify this as a fix and highlight it as an important change in the changelog
  • Let's ensure projects with older Pino versions only break sliently (as in, we don't actually break builds after updating the SDK).


addExceptionMechanism(event, {
handled: options.error.handled,
type: 'pino',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: unrelated to this PR but can we align the exception mechanism to be adhere to our mechanism type specification?

I'd suggest

Suggested change
type: 'auto.log.pino',

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create another PR 👍

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from e0577ed to 9ec85d9CompareFebruary 16, 2026 13:49
@logaretmlogaretm changed the title ref(node-core): Drop pino<9.10 supportfix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10Feb 16, 2026
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch 2 times, most recently from bd1c6cd to 17cec6aCompareFebruary 16, 2026 14:09
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 17cec6a to 290e69aCompareFebruary 17, 2026 01:23
@logaretmlogaretm removed this from the 11.0.0 milestone Feb 17, 2026
Comment threadpackages/node-core/src/integrations/pino.ts
@github-actions

github-actionsBot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊


Generated by Codecov Action

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

25 passed | ⏭️ 5 skipped | Total: 30 | Pass Rate: 83.33% | Execution Time: 13.14s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests📈 +2
Failed Tests
Skipped Tests📉 -2

✨ No test changes detected

All tests are passing successfully.


Generated by Codecov Action

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from ff4f5db to 6b45fbaCompareFebruary 17, 2026 15:04

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"openai": "5.18.1",
"pg": "8.16.0",
"pino": "9.9.4",
"pino": "9.10.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks regression test per review rules

Low Severity

Per the review rules, a fix PR needs at least one unit, integration, or E2E test that validates the regression being fixed. This PR only bumps the pino version in tests from 9.9.4 to 9.10.0 but doesn't add a new test verifying that the bundle size reduction works or that pino integration still functions correctly with only the integratedChannel. Existing tests may pass coincidentally without actually verifying the specific change.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

@logaretm
logaretm merged commit cc0dc3b into developFeb 17, 2026
222 checks passed
@logaretm
logaretm deleted the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch February 17, 2026 15:26
logaretm added a commit that referenced this pull request Feb 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@apm-js-collab is included in the @sentry/nextjs bundle when Pino integration is not enabled

5 participants

@logaretm@timfish@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 - #18631

Merged
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
Feb 17, 2026
Merged

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10#18631
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when

Conversation

@logaretm

Copy link
Copy Markdown
Member

We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in frameworks still using CJS like Next.js, even if the user was not using Pino integration at all. Attempts to tree-shake it failed as Next.js is still using CJS.

We can drop support for older versions of Pino, given that pino@9.10 already exposes a tracing channel that we use, and that the injected channel was a backup for pino<9.10

This will reduce bundle sizes and ensure frameworks incapable of esm tree-shaking don't pick it up as a dependency.

I will remove @apm-js-collab/tracing-hooks as a dep from node-core since nothing else uses it.

closes#18199

@linear

linearBot commented Dec 29, 2025

Copy link
Copy Markdown

@logaretmlogaretm changed the title ref(pino): Drop pino<9.10 supportref(node-core): Drop pino<9.10 supportDec 29, 2025
@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,239-11,206-18%
GET With Sentry1,71419%1,856-8%
GET With Sentry (error only)6,11266%7,570-19%
POST Baseline1,185-1,166+2%
POST With Sentry59951%572+5%
POST With Sentry (error only)1,05089%1,025+2%
MYSQL Baseline3,257-3,984-18%
MYSQL With Sentry50015%515-3%
MYSQL With Sentry (error only)2,65882%3,288-19%

View base workflow run

@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.22 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.07 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB-0.01%-5 B 🔽
@sentry/node166.53 kB-0.01%-2 B 🔽
@sentry/node - without tracing93.95 kB+0.01%+1 B 🔺
@sentry/aws-serverless109.45 kB-0.01%-2 B 🔽

View base workflow run

@Lms24Lms24 added this to the 11.0.0 milestone Dec 29, 2025
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 3d7aa48 to e0577edCompareFebruary 15, 2026 17:51
@logaretm
logaretm marked this pull request as ready for review February 16, 2026 06:41
Comment threadpackages/node-core/package.json
Comment threadpackages/node-core/src/integrations/pino.ts

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR drops support for Pino versions before 9.10.0 to reduce bundle size, particularly for frameworks using CommonJS (like Next.js) that cannot effectively tree-shake unused dependencies. The change removes the @apm-js-collab/tracing-hooks dependency and associated injection loader infrastructure, relying solely on the native pino_asJson tracing channel introduced in Pino 9.10.0.

Changes:

  • Removed @apm-js-collab/tracing-hooks and @apm-js-collab/code-transformer dependencies
  • Deleted the injection loader infrastructure (injectLoader.ts and related hooks)
  • Updated Pino integration to use only the native pino_asJson tracing channel
  • Updated test dependencies to use Pino 9.10.0

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
yarn.lockRemoved @apm-js-collab package entries and updated pino from 9.9.4 to 9.10.0
packages/node-core/src/sdk/injectLoader.tsDeleted entire file containing injection loader infrastructure
packages/node-core/src/sdk/index.tsRemoved GLOBAL_OBJ import and call to inject loader hook registration
packages/node-core/src/integrations/pino.tsRemoved addInstrumentationConfig import and usage, removed injectedChannel subscription for pino<9.10
packages/node-core/package.jsonRemoved @apm-js-collab/tracing-hooks dependency and @apm-js-collab/code-transformer devDependency
packages/core/src/utils/worldwide.tsRemoved _sentryInjectLoaderHookRegister and _sentryInjectLoaderHookRegistered global type definitions
dev-packages/node-integration-tests/package.jsonUpdated pino version from 9.9.4 to 9.10.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since it seems like a lot of users are affected by largely increased bundle/module sizes. Some suggestions:

  • I'd re-classify this as a fix and highlight it as an important change in the changelog
  • Let's ensure projects with older Pino versions only break sliently (as in, we don't actually break builds after updating the SDK).


addExceptionMechanism(event, {
handled: options.error.handled,
type: 'pino',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: unrelated to this PR but can we align the exception mechanism to be adhere to our mechanism type specification?

I'd suggest

Suggested change
type: 'auto.log.pino',

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create another PR 👍

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from e0577ed to 9ec85d9CompareFebruary 16, 2026 13:49
@logaretmlogaretm changed the title ref(node-core): Drop pino<9.10 supportfix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10Feb 16, 2026
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch 2 times, most recently from bd1c6cd to 17cec6aCompareFebruary 16, 2026 14:09
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 17cec6a to 290e69aCompareFebruary 17, 2026 01:23
@logaretmlogaretm removed this from the 11.0.0 milestone Feb 17, 2026
Comment threadpackages/node-core/src/integrations/pino.ts
@github-actions

github-actionsBot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊


Generated by Codecov Action

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

25 passed | ⏭️ 5 skipped | Total: 30 | Pass Rate: 83.33% | Execution Time: 13.14s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests📈 +2
Failed Tests
Skipped Tests📉 -2

✨ No test changes detected

All tests are passing successfully.


Generated by Codecov Action

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from ff4f5db to 6b45fbaCompareFebruary 17, 2026 15:04

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"openai": "5.18.1",
"pg": "8.16.0",
"pino": "9.9.4",
"pino": "9.10.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks regression test per review rules

Low Severity

Per the review rules, a fix PR needs at least one unit, integration, or E2E test that validates the regression being fixed. This PR only bumps the pino version in tests from 9.9.4 to 9.10.0 but doesn't add a new test verifying that the bundle size reduction works or that pino integration still functions correctly with only the integratedChannel. Existing tests may pass coincidentally without actually verifying the specific change.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

@logaretm
logaretm merged commit cc0dc3b into developFeb 17, 2026
222 checks passed
@logaretm
logaretm deleted the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch February 17, 2026 15:26
logaretm added a commit that referenced this pull request Feb 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@apm-js-collab is included in the @sentry/nextjs bundle when Pino integration is not enabled

5 participants

@logaretm@timfish@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 - #18631

Merged
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
Feb 17, 2026
Merged

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10#18631
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when

Conversation

@logaretm

Copy link
Copy Markdown
Member

We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in frameworks still using CJS like Next.js, even if the user was not using Pino integration at all. Attempts to tree-shake it failed as Next.js is still using CJS.

We can drop support for older versions of Pino, given that pino@9.10 already exposes a tracing channel that we use, and that the injected channel was a backup for pino<9.10

This will reduce bundle sizes and ensure frameworks incapable of esm tree-shaking don't pick it up as a dependency.

I will remove @apm-js-collab/tracing-hooks as a dep from node-core since nothing else uses it.

closes#18199

@linear

linearBot commented Dec 29, 2025

Copy link
Copy Markdown

@logaretmlogaretm changed the title ref(pino): Drop pino<9.10 supportref(node-core): Drop pino<9.10 supportDec 29, 2025
@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,239-11,206-18%
GET With Sentry1,71419%1,856-8%
GET With Sentry (error only)6,11266%7,570-19%
POST Baseline1,185-1,166+2%
POST With Sentry59951%572+5%
POST With Sentry (error only)1,05089%1,025+2%
MYSQL Baseline3,257-3,984-18%
MYSQL With Sentry50015%515-3%
MYSQL With Sentry (error only)2,65882%3,288-19%

View base workflow run

@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.22 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.07 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB-0.01%-5 B 🔽
@sentry/node166.53 kB-0.01%-2 B 🔽
@sentry/node - without tracing93.95 kB+0.01%+1 B 🔺
@sentry/aws-serverless109.45 kB-0.01%-2 B 🔽

View base workflow run

@Lms24Lms24 added this to the 11.0.0 milestone Dec 29, 2025
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 3d7aa48 to e0577edCompareFebruary 15, 2026 17:51
@logaretm
logaretm marked this pull request as ready for review February 16, 2026 06:41
Comment threadpackages/node-core/package.json
Comment threadpackages/node-core/src/integrations/pino.ts

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR drops support for Pino versions before 9.10.0 to reduce bundle size, particularly for frameworks using CommonJS (like Next.js) that cannot effectively tree-shake unused dependencies. The change removes the @apm-js-collab/tracing-hooks dependency and associated injection loader infrastructure, relying solely on the native pino_asJson tracing channel introduced in Pino 9.10.0.

Changes:

  • Removed @apm-js-collab/tracing-hooks and @apm-js-collab/code-transformer dependencies
  • Deleted the injection loader infrastructure (injectLoader.ts and related hooks)
  • Updated Pino integration to use only the native pino_asJson tracing channel
  • Updated test dependencies to use Pino 9.10.0

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
yarn.lockRemoved @apm-js-collab package entries and updated pino from 9.9.4 to 9.10.0
packages/node-core/src/sdk/injectLoader.tsDeleted entire file containing injection loader infrastructure
packages/node-core/src/sdk/index.tsRemoved GLOBAL_OBJ import and call to inject loader hook registration
packages/node-core/src/integrations/pino.tsRemoved addInstrumentationConfig import and usage, removed injectedChannel subscription for pino<9.10
packages/node-core/package.jsonRemoved @apm-js-collab/tracing-hooks dependency and @apm-js-collab/code-transformer devDependency
packages/core/src/utils/worldwide.tsRemoved _sentryInjectLoaderHookRegister and _sentryInjectLoaderHookRegistered global type definitions
dev-packages/node-integration-tests/package.jsonUpdated pino version from 9.9.4 to 9.10.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since it seems like a lot of users are affected by largely increased bundle/module sizes. Some suggestions:

  • I'd re-classify this as a fix and highlight it as an important change in the changelog
  • Let's ensure projects with older Pino versions only break sliently (as in, we don't actually break builds after updating the SDK).


addExceptionMechanism(event, {
handled: options.error.handled,
type: 'pino',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: unrelated to this PR but can we align the exception mechanism to be adhere to our mechanism type specification?

I'd suggest

Suggested change
type: 'auto.log.pino',

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create another PR 👍

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from e0577ed to 9ec85d9CompareFebruary 16, 2026 13:49
@logaretmlogaretm changed the title ref(node-core): Drop pino<9.10 supportfix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10Feb 16, 2026
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch 2 times, most recently from bd1c6cd to 17cec6aCompareFebruary 16, 2026 14:09
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 17cec6a to 290e69aCompareFebruary 17, 2026 01:23
@logaretmlogaretm removed this from the 11.0.0 milestone Feb 17, 2026
Comment threadpackages/node-core/src/integrations/pino.ts
@github-actions

github-actionsBot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊


Generated by Codecov Action

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

25 passed | ⏭️ 5 skipped | Total: 30 | Pass Rate: 83.33% | Execution Time: 13.14s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests📈 +2
Failed Tests
Skipped Tests📉 -2

✨ No test changes detected

All tests are passing successfully.


Generated by Codecov Action

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from ff4f5db to 6b45fbaCompareFebruary 17, 2026 15:04

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"openai": "5.18.1",
"pg": "8.16.0",
"pino": "9.9.4",
"pino": "9.10.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks regression test per review rules

Low Severity

Per the review rules, a fix PR needs at least one unit, integration, or E2E test that validates the regression being fixed. This PR only bumps the pino version in tests from 9.9.4 to 9.10.0 but doesn't add a new test verifying that the bundle size reduction works or that pino integration still functions correctly with only the integratedChannel. Existing tests may pass coincidentally without actually verifying the specific change.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

@logaretm
logaretm merged commit cc0dc3b into developFeb 17, 2026
222 checks passed
@logaretm
logaretm deleted the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch February 17, 2026 15:26
logaretm added a commit that referenced this pull request Feb 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@apm-js-collab is included in the @sentry/nextjs bundle when Pino integration is not enabled

5 participants

@logaretm@timfish@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 - #18631

Merged
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
Feb 17, 2026
Merged

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10#18631
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when

Conversation

@logaretm

Copy link
Copy Markdown
Member

We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in frameworks still using CJS like Next.js, even if the user was not using Pino integration at all. Attempts to tree-shake it failed as Next.js is still using CJS.

We can drop support for older versions of Pino, given that pino@9.10 already exposes a tracing channel that we use, and that the injected channel was a backup for pino<9.10

This will reduce bundle sizes and ensure frameworks incapable of esm tree-shaking don't pick it up as a dependency.

I will remove @apm-js-collab/tracing-hooks as a dep from node-core since nothing else uses it.

closes#18199

@linear

linearBot commented Dec 29, 2025

Copy link
Copy Markdown

@logaretmlogaretm changed the title ref(pino): Drop pino<9.10 supportref(node-core): Drop pino<9.10 supportDec 29, 2025
@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,239-11,206-18%
GET With Sentry1,71419%1,856-8%
GET With Sentry (error only)6,11266%7,570-19%
POST Baseline1,185-1,166+2%
POST With Sentry59951%572+5%
POST With Sentry (error only)1,05089%1,025+2%
MYSQL Baseline3,257-3,984-18%
MYSQL With Sentry50015%515-3%
MYSQL With Sentry (error only)2,65882%3,288-19%

View base workflow run

@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.22 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.07 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB-0.01%-5 B 🔽
@sentry/node166.53 kB-0.01%-2 B 🔽
@sentry/node - without tracing93.95 kB+0.01%+1 B 🔺
@sentry/aws-serverless109.45 kB-0.01%-2 B 🔽

View base workflow run

@Lms24Lms24 added this to the 11.0.0 milestone Dec 29, 2025
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 3d7aa48 to e0577edCompareFebruary 15, 2026 17:51
@logaretm
logaretm marked this pull request as ready for review February 16, 2026 06:41
Comment threadpackages/node-core/package.json
Comment threadpackages/node-core/src/integrations/pino.ts

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR drops support for Pino versions before 9.10.0 to reduce bundle size, particularly for frameworks using CommonJS (like Next.js) that cannot effectively tree-shake unused dependencies. The change removes the @apm-js-collab/tracing-hooks dependency and associated injection loader infrastructure, relying solely on the native pino_asJson tracing channel introduced in Pino 9.10.0.

Changes:

  • Removed @apm-js-collab/tracing-hooks and @apm-js-collab/code-transformer dependencies
  • Deleted the injection loader infrastructure (injectLoader.ts and related hooks)
  • Updated Pino integration to use only the native pino_asJson tracing channel
  • Updated test dependencies to use Pino 9.10.0

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
yarn.lockRemoved @apm-js-collab package entries and updated pino from 9.9.4 to 9.10.0
packages/node-core/src/sdk/injectLoader.tsDeleted entire file containing injection loader infrastructure
packages/node-core/src/sdk/index.tsRemoved GLOBAL_OBJ import and call to inject loader hook registration
packages/node-core/src/integrations/pino.tsRemoved addInstrumentationConfig import and usage, removed injectedChannel subscription for pino<9.10
packages/node-core/package.jsonRemoved @apm-js-collab/tracing-hooks dependency and @apm-js-collab/code-transformer devDependency
packages/core/src/utils/worldwide.tsRemoved _sentryInjectLoaderHookRegister and _sentryInjectLoaderHookRegistered global type definitions
dev-packages/node-integration-tests/package.jsonUpdated pino version from 9.9.4 to 9.10.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since it seems like a lot of users are affected by largely increased bundle/module sizes. Some suggestions:

  • I'd re-classify this as a fix and highlight it as an important change in the changelog
  • Let's ensure projects with older Pino versions only break sliently (as in, we don't actually break builds after updating the SDK).


addExceptionMechanism(event, {
handled: options.error.handled,
type: 'pino',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: unrelated to this PR but can we align the exception mechanism to be adhere to our mechanism type specification?

I'd suggest

Suggested change
type: 'auto.log.pino',

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create another PR 👍

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from e0577ed to 9ec85d9CompareFebruary 16, 2026 13:49
@logaretmlogaretm changed the title ref(node-core): Drop pino<9.10 supportfix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10Feb 16, 2026
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch 2 times, most recently from bd1c6cd to 17cec6aCompareFebruary 16, 2026 14:09
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 17cec6a to 290e69aCompareFebruary 17, 2026 01:23
@logaretmlogaretm removed this from the 11.0.0 milestone Feb 17, 2026
Comment threadpackages/node-core/src/integrations/pino.ts
@github-actions

github-actionsBot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊


Generated by Codecov Action

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

25 passed | ⏭️ 5 skipped | Total: 30 | Pass Rate: 83.33% | Execution Time: 13.14s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests📈 +2
Failed Tests
Skipped Tests📉 -2

✨ No test changes detected

All tests are passing successfully.


Generated by Codecov Action

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from ff4f5db to 6b45fbaCompareFebruary 17, 2026 15:04

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"openai": "5.18.1",
"pg": "8.16.0",
"pino": "9.9.4",
"pino": "9.10.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks regression test per review rules

Low Severity

Per the review rules, a fix PR needs at least one unit, integration, or E2E test that validates the regression being fixed. This PR only bumps the pino version in tests from 9.9.4 to 9.10.0 but doesn't add a new test verifying that the bundle size reduction works or that pino integration still functions correctly with only the integratedChannel. Existing tests may pass coincidentally without actually verifying the specific change.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

@logaretm
logaretm merged commit cc0dc3b into developFeb 17, 2026
222 checks passed
@logaretm
logaretm deleted the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch February 17, 2026 15:26
logaretm added a commit that referenced this pull request Feb 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@apm-js-collab is included in the @sentry/nextjs bundle when Pino integration is not enabled

5 participants

@logaretm@timfish@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 - #18631

Merged
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
Feb 17, 2026
Merged

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10#18631
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when

Conversation

@logaretm

Copy link
Copy Markdown
Member

We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in frameworks still using CJS like Next.js, even if the user was not using Pino integration at all. Attempts to tree-shake it failed as Next.js is still using CJS.

We can drop support for older versions of Pino, given that pino@9.10 already exposes a tracing channel that we use, and that the injected channel was a backup for pino<9.10

This will reduce bundle sizes and ensure frameworks incapable of esm tree-shaking don't pick it up as a dependency.

I will remove @apm-js-collab/tracing-hooks as a dep from node-core since nothing else uses it.

closes#18199

@linear

linearBot commented Dec 29, 2025

Copy link
Copy Markdown

@logaretmlogaretm changed the title ref(pino): Drop pino<9.10 supportref(node-core): Drop pino<9.10 supportDec 29, 2025
@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,239-11,206-18%
GET With Sentry1,71419%1,856-8%
GET With Sentry (error only)6,11266%7,570-19%
POST Baseline1,185-1,166+2%
POST With Sentry59951%572+5%
POST With Sentry (error only)1,05089%1,025+2%
MYSQL Baseline3,257-3,984-18%
MYSQL With Sentry50015%515-3%
MYSQL With Sentry (error only)2,65882%3,288-19%

View base workflow run

@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.22 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.07 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB-0.01%-5 B 🔽
@sentry/node166.53 kB-0.01%-2 B 🔽
@sentry/node - without tracing93.95 kB+0.01%+1 B 🔺
@sentry/aws-serverless109.45 kB-0.01%-2 B 🔽

View base workflow run

@Lms24Lms24 added this to the 11.0.0 milestone Dec 29, 2025
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 3d7aa48 to e0577edCompareFebruary 15, 2026 17:51
@logaretm
logaretm marked this pull request as ready for review February 16, 2026 06:41
Comment threadpackages/node-core/package.json
Comment threadpackages/node-core/src/integrations/pino.ts

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR drops support for Pino versions before 9.10.0 to reduce bundle size, particularly for frameworks using CommonJS (like Next.js) that cannot effectively tree-shake unused dependencies. The change removes the @apm-js-collab/tracing-hooks dependency and associated injection loader infrastructure, relying solely on the native pino_asJson tracing channel introduced in Pino 9.10.0.

Changes:

  • Removed @apm-js-collab/tracing-hooks and @apm-js-collab/code-transformer dependencies
  • Deleted the injection loader infrastructure (injectLoader.ts and related hooks)
  • Updated Pino integration to use only the native pino_asJson tracing channel
  • Updated test dependencies to use Pino 9.10.0

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
yarn.lockRemoved @apm-js-collab package entries and updated pino from 9.9.4 to 9.10.0
packages/node-core/src/sdk/injectLoader.tsDeleted entire file containing injection loader infrastructure
packages/node-core/src/sdk/index.tsRemoved GLOBAL_OBJ import and call to inject loader hook registration
packages/node-core/src/integrations/pino.tsRemoved addInstrumentationConfig import and usage, removed injectedChannel subscription for pino<9.10
packages/node-core/package.jsonRemoved @apm-js-collab/tracing-hooks dependency and @apm-js-collab/code-transformer devDependency
packages/core/src/utils/worldwide.tsRemoved _sentryInjectLoaderHookRegister and _sentryInjectLoaderHookRegistered global type definitions
dev-packages/node-integration-tests/package.jsonUpdated pino version from 9.9.4 to 9.10.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since it seems like a lot of users are affected by largely increased bundle/module sizes. Some suggestions:

  • I'd re-classify this as a fix and highlight it as an important change in the changelog
  • Let's ensure projects with older Pino versions only break sliently (as in, we don't actually break builds after updating the SDK).


addExceptionMechanism(event, {
handled: options.error.handled,
type: 'pino',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: unrelated to this PR but can we align the exception mechanism to be adhere to our mechanism type specification?

I'd suggest

Suggested change
type: 'auto.log.pino',

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create another PR 👍

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from e0577ed to 9ec85d9CompareFebruary 16, 2026 13:49
@logaretmlogaretm changed the title ref(node-core): Drop pino<9.10 supportfix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10Feb 16, 2026
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch 2 times, most recently from bd1c6cd to 17cec6aCompareFebruary 16, 2026 14:09
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 17cec6a to 290e69aCompareFebruary 17, 2026 01:23
@logaretmlogaretm removed this from the 11.0.0 milestone Feb 17, 2026
Comment threadpackages/node-core/src/integrations/pino.ts
@github-actions

github-actionsBot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊


Generated by Codecov Action

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

25 passed | ⏭️ 5 skipped | Total: 30 | Pass Rate: 83.33% | Execution Time: 13.14s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests📈 +2
Failed Tests
Skipped Tests📉 -2

✨ No test changes detected

All tests are passing successfully.


Generated by Codecov Action

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from ff4f5db to 6b45fbaCompareFebruary 17, 2026 15:04

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"openai": "5.18.1",
"pg": "8.16.0",
"pino": "9.9.4",
"pino": "9.10.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks regression test per review rules

Low Severity

Per the review rules, a fix PR needs at least one unit, integration, or E2E test that validates the regression being fixed. This PR only bumps the pino version in tests from 9.9.4 to 9.10.0 but doesn't add a new test verifying that the bundle size reduction works or that pino integration still functions correctly with only the integratedChannel. Existing tests may pass coincidentally without actually verifying the specific change.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

@logaretm
logaretm merged commit cc0dc3b into developFeb 17, 2026
222 checks passed
@logaretm
logaretm deleted the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch February 17, 2026 15:26
logaretm added a commit that referenced this pull request Feb 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@apm-js-collab is included in the @sentry/nextjs bundle when Pino integration is not enabled

5 participants

@logaretm@timfish@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 - #18631

Merged
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
Feb 17, 2026
Merged

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10#18631
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when

Conversation

@logaretm

Copy link
Copy Markdown
Member

We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in frameworks still using CJS like Next.js, even if the user was not using Pino integration at all. Attempts to tree-shake it failed as Next.js is still using CJS.

We can drop support for older versions of Pino, given that pino@9.10 already exposes a tracing channel that we use, and that the injected channel was a backup for pino<9.10

This will reduce bundle sizes and ensure frameworks incapable of esm tree-shaking don't pick it up as a dependency.

I will remove @apm-js-collab/tracing-hooks as a dep from node-core since nothing else uses it.

closes#18199

@linear

linearBot commented Dec 29, 2025

Copy link
Copy Markdown

@logaretmlogaretm changed the title ref(pino): Drop pino<9.10 supportref(node-core): Drop pino<9.10 supportDec 29, 2025
@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,239-11,206-18%
GET With Sentry1,71419%1,856-8%
GET With Sentry (error only)6,11266%7,570-19%
POST Baseline1,185-1,166+2%
POST With Sentry59951%572+5%
POST With Sentry (error only)1,05089%1,025+2%
MYSQL Baseline3,257-3,984-18%
MYSQL With Sentry50015%515-3%
MYSQL With Sentry (error only)2,65882%3,288-19%

View base workflow run

@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.22 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.07 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB-0.01%-5 B 🔽
@sentry/node166.53 kB-0.01%-2 B 🔽
@sentry/node - without tracing93.95 kB+0.01%+1 B 🔺
@sentry/aws-serverless109.45 kB-0.01%-2 B 🔽

View base workflow run

@Lms24Lms24 added this to the 11.0.0 milestone Dec 29, 2025
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 3d7aa48 to e0577edCompareFebruary 15, 2026 17:51
@logaretm
logaretm marked this pull request as ready for review February 16, 2026 06:41
Comment threadpackages/node-core/package.json
Comment threadpackages/node-core/src/integrations/pino.ts

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR drops support for Pino versions before 9.10.0 to reduce bundle size, particularly for frameworks using CommonJS (like Next.js) that cannot effectively tree-shake unused dependencies. The change removes the @apm-js-collab/tracing-hooks dependency and associated injection loader infrastructure, relying solely on the native pino_asJson tracing channel introduced in Pino 9.10.0.

Changes:

  • Removed @apm-js-collab/tracing-hooks and @apm-js-collab/code-transformer dependencies
  • Deleted the injection loader infrastructure (injectLoader.ts and related hooks)
  • Updated Pino integration to use only the native pino_asJson tracing channel
  • Updated test dependencies to use Pino 9.10.0

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
yarn.lockRemoved @apm-js-collab package entries and updated pino from 9.9.4 to 9.10.0
packages/node-core/src/sdk/injectLoader.tsDeleted entire file containing injection loader infrastructure
packages/node-core/src/sdk/index.tsRemoved GLOBAL_OBJ import and call to inject loader hook registration
packages/node-core/src/integrations/pino.tsRemoved addInstrumentationConfig import and usage, removed injectedChannel subscription for pino<9.10
packages/node-core/package.jsonRemoved @apm-js-collab/tracing-hooks dependency and @apm-js-collab/code-transformer devDependency
packages/core/src/utils/worldwide.tsRemoved _sentryInjectLoaderHookRegister and _sentryInjectLoaderHookRegistered global type definitions
dev-packages/node-integration-tests/package.jsonUpdated pino version from 9.9.4 to 9.10.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since it seems like a lot of users are affected by largely increased bundle/module sizes. Some suggestions:

  • I'd re-classify this as a fix and highlight it as an important change in the changelog
  • Let's ensure projects with older Pino versions only break sliently (as in, we don't actually break builds after updating the SDK).


addExceptionMechanism(event, {
handled: options.error.handled,
type: 'pino',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: unrelated to this PR but can we align the exception mechanism to be adhere to our mechanism type specification?

I'd suggest

Suggested change
type: 'auto.log.pino',

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create another PR 👍

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from e0577ed to 9ec85d9CompareFebruary 16, 2026 13:49
@logaretmlogaretm changed the title ref(node-core): Drop pino<9.10 supportfix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10Feb 16, 2026
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch 2 times, most recently from bd1c6cd to 17cec6aCompareFebruary 16, 2026 14:09
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 17cec6a to 290e69aCompareFebruary 17, 2026 01:23
@logaretmlogaretm removed this from the 11.0.0 milestone Feb 17, 2026
Comment threadpackages/node-core/src/integrations/pino.ts
@github-actions

github-actionsBot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊


Generated by Codecov Action

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

25 passed | ⏭️ 5 skipped | Total: 30 | Pass Rate: 83.33% | Execution Time: 13.14s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests📈 +2
Failed Tests
Skipped Tests📉 -2

✨ No test changes detected

All tests are passing successfully.


Generated by Codecov Action

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from ff4f5db to 6b45fbaCompareFebruary 17, 2026 15:04

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"openai": "5.18.1",
"pg": "8.16.0",
"pino": "9.9.4",
"pino": "9.10.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks regression test per review rules

Low Severity

Per the review rules, a fix PR needs at least one unit, integration, or E2E test that validates the regression being fixed. This PR only bumps the pino version in tests from 9.9.4 to 9.10.0 but doesn't add a new test verifying that the bundle size reduction works or that pino integration still functions correctly with only the integratedChannel. Existing tests may pass coincidentally without actually verifying the specific change.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

@logaretm
logaretm merged commit cc0dc3b into developFeb 17, 2026
222 checks passed
@logaretm
logaretm deleted the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch February 17, 2026 15:26
logaretm added a commit that referenced this pull request Feb 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@apm-js-collab is included in the @sentry/nextjs bundle when Pino integration is not enabled

5 participants

@logaretm@timfish@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 - #18631

Merged
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
Feb 17, 2026
Merged

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10#18631
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when

Conversation

@logaretm

Copy link
Copy Markdown
Member

We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in frameworks still using CJS like Next.js, even if the user was not using Pino integration at all. Attempts to tree-shake it failed as Next.js is still using CJS.

We can drop support for older versions of Pino, given that pino@9.10 already exposes a tracing channel that we use, and that the injected channel was a backup for pino<9.10

This will reduce bundle sizes and ensure frameworks incapable of esm tree-shaking don't pick it up as a dependency.

I will remove @apm-js-collab/tracing-hooks as a dep from node-core since nothing else uses it.

closes#18199

@linear

linearBot commented Dec 29, 2025

Copy link
Copy Markdown

@logaretmlogaretm changed the title ref(pino): Drop pino<9.10 supportref(node-core): Drop pino<9.10 supportDec 29, 2025
@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,239-11,206-18%
GET With Sentry1,71419%1,856-8%
GET With Sentry (error only)6,11266%7,570-19%
POST Baseline1,185-1,166+2%
POST With Sentry59951%572+5%
POST With Sentry (error only)1,05089%1,025+2%
MYSQL Baseline3,257-3,984-18%
MYSQL With Sentry50015%515-3%
MYSQL With Sentry (error only)2,65882%3,288-19%

View base workflow run

@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.22 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.07 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB-0.01%-5 B 🔽
@sentry/node166.53 kB-0.01%-2 B 🔽
@sentry/node - without tracing93.95 kB+0.01%+1 B 🔺
@sentry/aws-serverless109.45 kB-0.01%-2 B 🔽

View base workflow run

@Lms24Lms24 added this to the 11.0.0 milestone Dec 29, 2025
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 3d7aa48 to e0577edCompareFebruary 15, 2026 17:51
@logaretm
logaretm marked this pull request as ready for review February 16, 2026 06:41
Comment threadpackages/node-core/package.json
Comment threadpackages/node-core/src/integrations/pino.ts

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR drops support for Pino versions before 9.10.0 to reduce bundle size, particularly for frameworks using CommonJS (like Next.js) that cannot effectively tree-shake unused dependencies. The change removes the @apm-js-collab/tracing-hooks dependency and associated injection loader infrastructure, relying solely on the native pino_asJson tracing channel introduced in Pino 9.10.0.

Changes:

  • Removed @apm-js-collab/tracing-hooks and @apm-js-collab/code-transformer dependencies
  • Deleted the injection loader infrastructure (injectLoader.ts and related hooks)
  • Updated Pino integration to use only the native pino_asJson tracing channel
  • Updated test dependencies to use Pino 9.10.0

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
yarn.lockRemoved @apm-js-collab package entries and updated pino from 9.9.4 to 9.10.0
packages/node-core/src/sdk/injectLoader.tsDeleted entire file containing injection loader infrastructure
packages/node-core/src/sdk/index.tsRemoved GLOBAL_OBJ import and call to inject loader hook registration
packages/node-core/src/integrations/pino.tsRemoved addInstrumentationConfig import and usage, removed injectedChannel subscription for pino<9.10
packages/node-core/package.jsonRemoved @apm-js-collab/tracing-hooks dependency and @apm-js-collab/code-transformer devDependency
packages/core/src/utils/worldwide.tsRemoved _sentryInjectLoaderHookRegister and _sentryInjectLoaderHookRegistered global type definitions
dev-packages/node-integration-tests/package.jsonUpdated pino version from 9.9.4 to 9.10.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since it seems like a lot of users are affected by largely increased bundle/module sizes. Some suggestions:

  • I'd re-classify this as a fix and highlight it as an important change in the changelog
  • Let's ensure projects with older Pino versions only break sliently (as in, we don't actually break builds after updating the SDK).


addExceptionMechanism(event, {
handled: options.error.handled,
type: 'pino',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: unrelated to this PR but can we align the exception mechanism to be adhere to our mechanism type specification?

I'd suggest

Suggested change
type: 'auto.log.pino',

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create another PR 👍

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from e0577ed to 9ec85d9CompareFebruary 16, 2026 13:49
@logaretmlogaretm changed the title ref(node-core): Drop pino<9.10 supportfix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10Feb 16, 2026
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch 2 times, most recently from bd1c6cd to 17cec6aCompareFebruary 16, 2026 14:09
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 17cec6a to 290e69aCompareFebruary 17, 2026 01:23
@logaretmlogaretm removed this from the 11.0.0 milestone Feb 17, 2026
Comment threadpackages/node-core/src/integrations/pino.ts
@github-actions

github-actionsBot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊


Generated by Codecov Action

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

25 passed | ⏭️ 5 skipped | Total: 30 | Pass Rate: 83.33% | Execution Time: 13.14s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests📈 +2
Failed Tests
Skipped Tests📉 -2

✨ No test changes detected

All tests are passing successfully.


Generated by Codecov Action

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from ff4f5db to 6b45fbaCompareFebruary 17, 2026 15:04

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"openai": "5.18.1",
"pg": "8.16.0",
"pino": "9.9.4",
"pino": "9.10.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks regression test per review rules

Low Severity

Per the review rules, a fix PR needs at least one unit, integration, or E2E test that validates the regression being fixed. This PR only bumps the pino version in tests from 9.9.4 to 9.10.0 but doesn't add a new test verifying that the bundle size reduction works or that pino integration still functions correctly with only the integratedChannel. Existing tests may pass coincidentally without actually verifying the specific change.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

@logaretm
logaretm merged commit cc0dc3b into developFeb 17, 2026
222 checks passed
@logaretm
logaretm deleted the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch February 17, 2026 15:26
logaretm added a commit that referenced this pull request Feb 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@apm-js-collab is included in the @sentry/nextjs bundle when Pino integration is not enabled

5 participants

@logaretm@timfish@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 - #18631

Merged
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when
Feb 17, 2026
Merged

fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10#18631
logaretm merged 4 commits into
developfrom
awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when

Conversation

@logaretm

Copy link
Copy Markdown
Member

We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in frameworks still using CJS like Next.js, even if the user was not using Pino integration at all. Attempts to tree-shake it failed as Next.js is still using CJS.

We can drop support for older versions of Pino, given that pino@9.10 already exposes a tracing channel that we use, and that the injected channel was a backup for pino<9.10

This will reduce bundle sizes and ensure frameworks incapable of esm tree-shaking don't pick it up as a dependency.

I will remove @apm-js-collab/tracing-hooks as a dep from node-core since nothing else uses it.

closes#18199

@linear

linearBot commented Dec 29, 2025

Copy link
Copy Markdown

@logaretmlogaretm changed the title ref(pino): Drop pino<9.10 supportref(node-core): Drop pino<9.10 supportDec 29, 2025
@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,239-11,206-18%
GET With Sentry1,71419%1,856-8%
GET With Sentry (error only)6,11266%7,570-19%
POST Baseline1,185-1,166+2%
POST With Sentry59951%572+5%
POST With Sentry (error only)1,05089%1,025+2%
MYSQL Baseline3,257-3,984-18%
MYSQL With Sentry50015%515-3%
MYSQL With Sentry (error only)2,65882%3,288-19%

View base workflow run

@github-actions

github-actionsBot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.56 kB--
@sentry/browser - with treeshaking flags24.08 kB--
@sentry/browser (incl. Tracing)42.36 kB--
@sentry/browser (incl. Tracing, Profiling)47.03 kB--
@sentry/browser (incl. Tracing, Replay)81.18 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags70.8 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)85.87 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.03 kB--
@sentry/browser (incl. Feedback)42.29 kB--
@sentry/browser (incl. sendFeedback)30.23 kB--
@sentry/browser (incl. FeedbackAsync)35.22 kB--
@sentry/browser (incl. Metrics)26.74 kB--
@sentry/browser (incl. Logs)26.88 kB--
@sentry/browser (incl. Metrics & Logs)27.56 kB--
@sentry/react27.33 kB--
@sentry/react (incl. Tracing)44.72 kB--
@sentry/vue30.01 kB--
@sentry/vue (incl. Tracing)44.22 kB--
@sentry/svelte25.58 kB--
CDN Bundle28.11 kB--
CDN Bundle (incl. Tracing)43.2 kB--
CDN Bundle (incl. Logs, Metrics)28.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.02 kB--
CDN Bundle (incl. Tracing, Replay)80.07 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)80.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.4 kB--
CDN Bundle - uncompressed82.22 kB--
CDN Bundle (incl. Tracing) - uncompressed127.93 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed130.76 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed208.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed244.81 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed247.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed257.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed260.42 kB--
@sentry/nextjs (client)47.07 kB--
@sentry/sveltekit (client)42.81 kB--
@sentry/node-core52.15 kB-0.01%-5 B 🔽
@sentry/node166.53 kB-0.01%-2 B 🔽
@sentry/node - without tracing93.95 kB+0.01%+1 B 🔺
@sentry/aws-serverless109.45 kB-0.01%-2 B 🔽

View base workflow run

@Lms24Lms24 added this to the 11.0.0 milestone Dec 29, 2025
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 3d7aa48 to e0577edCompareFebruary 15, 2026 17:51
@logaretm
logaretm marked this pull request as ready for review February 16, 2026 06:41
Comment threadpackages/node-core/package.json
Comment threadpackages/node-core/src/integrations/pino.ts

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR drops support for Pino versions before 9.10.0 to reduce bundle size, particularly for frameworks using CommonJS (like Next.js) that cannot effectively tree-shake unused dependencies. The change removes the @apm-js-collab/tracing-hooks dependency and associated injection loader infrastructure, relying solely on the native pino_asJson tracing channel introduced in Pino 9.10.0.

Changes:

  • Removed @apm-js-collab/tracing-hooks and @apm-js-collab/code-transformer dependencies
  • Deleted the injection loader infrastructure (injectLoader.ts and related hooks)
  • Updated Pino integration to use only the native pino_asJson tracing channel
  • Updated test dependencies to use Pino 9.10.0

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
yarn.lockRemoved @apm-js-collab package entries and updated pino from 9.9.4 to 9.10.0
packages/node-core/src/sdk/injectLoader.tsDeleted entire file containing injection loader infrastructure
packages/node-core/src/sdk/index.tsRemoved GLOBAL_OBJ import and call to inject loader hook registration
packages/node-core/src/integrations/pino.tsRemoved addInstrumentationConfig import and usage, removed injectedChannel subscription for pino<9.10
packages/node-core/package.jsonRemoved @apm-js-collab/tracing-hooks dependency and @apm-js-collab/code-transformer devDependency
packages/core/src/utils/worldwide.tsRemoved _sentryInjectLoaderHookRegister and _sentryInjectLoaderHookRegistered global type definitions
dev-packages/node-integration-tests/package.jsonUpdated pino version from 9.9.4 to 9.10.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since it seems like a lot of users are affected by largely increased bundle/module sizes. Some suggestions:

  • I'd re-classify this as a fix and highlight it as an important change in the changelog
  • Let's ensure projects with older Pino versions only break sliently (as in, we don't actually break builds after updating the SDK).


addExceptionMechanism(event, {
handled: options.error.handled,
type: 'pino',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: unrelated to this PR but can we align the exception mechanism to be adhere to our mechanism type specification?

I'd suggest

Suggested change
type: 'auto.log.pino',

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create another PR 👍

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from e0577ed to 9ec85d9CompareFebruary 16, 2026 13:49
@logaretmlogaretm changed the title ref(node-core): Drop pino<9.10 supportfix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10Feb 16, 2026
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch 2 times, most recently from bd1c6cd to 17cec6aCompareFebruary 16, 2026 14:09
@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from 17cec6a to 290e69aCompareFebruary 17, 2026 01:23
@logaretmlogaretm removed this from the 11.0.0 milestone Feb 17, 2026
Comment threadpackages/node-core/src/integrations/pino.ts
@github-actions

github-actionsBot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊


Generated by Codecov Action

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

25 passed | ⏭️ 5 skipped | Total: 30 | Pass Rate: 83.33% | Execution Time: 13.14s

📊 Comparison with Base Branch

MetricChange
Total Tests
Passed Tests📈 +2
Failed Tests
Skipped Tests📉 -2

✨ No test changes detected

All tests are passing successfully.


Generated by Codecov Action

@logaretm
logaretmforce-pushed the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch from ff4f5db to 6b45fbaCompareFebruary 17, 2026 15:04

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"openai": "5.18.1",
"pg": "8.16.0",
"pino": "9.9.4",
"pino": "9.10.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks regression test per review rules

Low Severity

Per the review rules, a fix PR needs at least one unit, integration, or E2E test that validates the regression being fixed. This PR only bumps the pino version in tests from 9.9.4 to 9.10.0 but doesn't add a new test verifying that the bundle size reduction works or that pino integration still functions correctly with only the integratedChannel. Existing tests may pass coincidentally without actually verifying the specific change.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

@logaretm
logaretm merged commit cc0dc3b into developFeb 17, 2026
222 checks passed
@logaretm
logaretm deleted the awad/js-1160-apm-js-collab-is-included-in-the-sentrynextjs-bundle-when branch February 17, 2026 15:26
logaretm added a commit that referenced this pull request Feb 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@apm-js-collab is included in the @sentry/nextjs bundle when Pino integration is not enabled

5 participants

@logaretm@timfish@Lms24@s1gr1d