Skip to content

chore(node-integration-tests): Remove unnecessary file-type dependency - #19824

Merged
Lms24 merged 1 commit into
developfrom
lms/chore-remove-file-type
Mar 19, 2026
Merged

chore(node-integration-tests): Remove unnecessary file-type dependency#19824
Lms24 merged 1 commit into
developfrom
lms/chore-remove-file-type

Conversation

@Lms24

@Lms24Lms24 commented Mar 16, 2026

Copy link
Copy Markdown
Member

It seems like we added file-type as a dependency in #16751 with the reason that yarn was complaining about a missing peer dependency. However, file-type is not a peer dependency but a dependency of @nestjs/common. So it should be installed anyway. Given CI passes, I'd rather remove it for now.

@Lms24Lms24 self-assigned this Mar 16, 2026
@github-actions

github-actionsBot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser25.64 kB--
@sentry/browser - with treeshaking flags24.14 kB--
@sentry/browser (incl. Tracing)42.62 kB--
@sentry/browser (incl. Tracing, Profiling)47.28 kB--
@sentry/browser (incl. Tracing, Replay)81.42 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags71 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)86.12 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)98.37 kB--
@sentry/browser (incl. Feedback)42.45 kB--
@sentry/browser (incl. sendFeedback)30.31 kB--
@sentry/browser (incl. FeedbackAsync)35.36 kB--
@sentry/browser (incl. Metrics)26.92 kB--
@sentry/browser (incl. Logs)27.07 kB--
@sentry/browser (incl. Metrics & Logs)27.74 kB--
@sentry/react27.39 kB--
@sentry/react (incl. Tracing)44.95 kB--
@sentry/vue30.08 kB--
@sentry/vue (incl. Tracing)44.48 kB--
@sentry/svelte25.66 kB--
CDN Bundle28.28 kB--
CDN Bundle (incl. Tracing)43.51 kB--
CDN Bundle (incl. Logs, Metrics)29.14 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)44.36 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.21 kB--
CDN Bundle (incl. Tracing, Replay)80.33 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)81.23 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)85.87 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)86.77 kB--
CDN Bundle - uncompressed82.62 kB--
CDN Bundle (incl. Tracing) - uncompressed128.56 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed85.49 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed131.43 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed209.12 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed245.41 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed248.26 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed258.32 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed261.17 kB--
@sentry/nextjs (client)47.37 kB--
@sentry/sveltekit (client)43.07 kB--
@sentry/node-core56.35 kB+0.02%+9 B 🔺
@sentry/node173.17 kB+0.01%+10 B 🔺
@sentry/node - without tracing96.35 kB+0.01%+6 B 🔺
@sentry/aws-serverless113.35 kB+0.01%+9 B 🔺

View base workflow run

@github-actions

github-actionsBot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

ScenarioRequests/s% of BaselinePrev. Requests/sChange %
GET Baseline9,175-9,396-2%
GET With Sentry1,73619%1,626+7%
GET With Sentry (error only)6,25268%5,968+5%
POST Baseline1,199-1,178+2%
POST With Sentry59149%567+4%
POST With Sentry (error only)1,06489%1,044+2%
MYSQL Baseline3,285-3,212+2%
MYSQL With Sentry45914%435+6%
MYSQL With Sentry (error only)2,66381%2,614+2%

View base workflow run

@github-actions

github-actionsBot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

Deps

  • Bump devalue 5.6.3 to 5.6.4 to fix CVE-2026-30226 by chargome in #19849
  • Bump file-type to 21.3.2 and @nestjs/common to 11.1.17 by chargome in #19847
  • Bump unhead 2.1.4 to 2.1.12 to fix CVE-2026-31860 and CVE-2026-31873 by chargome in #19848
  • Bump flatted 3.3.1 to 3.4.2 to fix CVE-2026-32141 by chargome in #19842
  • Bump tar 7.5.10 to 7.5.11 to fix CVE-2026-31802 by chargome in #19846
  • Bump hono 4.12.5 to 4.12.7 in cloudflare-hono E2E test app by chargome in #19850
  • Bump undici 6.23.0 to 6.24.1 to fix multiple CVEs by chargome in #19841

Other

  • (deno) Clear pre-existing OTel global before registering TracerProvider by sergical in #19723

Internal Changes 🔧

  • (deps) Bump next from 16.1.5 to 16.1.7 in /dev-packages/e2e-tests/test-applications/nextjs-16 by dependabot in #19851
  • (node-integration-tests) Remove unnecessary file-type dependency by Lms24 in #19824
  • (react) Add gql tests for react router by chargome in #19844
  • (release) Switch from action-prepare-release to Craft by BYK in #18763

🤖 This preview updates automatically when you update the PR.

@Lms24
Lms24force-pushed the lms/chore-remove-file-type branch from 1f2d603 to 95c7aa5CompareMarch 18, 2026 14:19
@Lms24
Lms24 marked this pull request as ready for review March 18, 2026 14:20
@Lms24
Lms24 requested review from a team, JPeer264, chargome and mydea and removed request for a team and mydeaMarch 18, 2026 16:35
@Lms24
Lms24 merged commit ffe00a7 into developMar 19, 2026
458 of 460 checks passed
@Lms24
Lms24 deleted the lms/chore-remove-file-type branch March 19, 2026 17:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@JPeer264