Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/aws-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing v8 tag fix for @sentry/utils package

High Severity

This PR aims to ensure all packages are tagged with v8 when publishing to NPM, but packages/utils/package.json still has "tag": "latest" in its publishConfig instead of "tag": "v8". Since @sentry/utils is a public, non-private package at version 8.55.1, publishing it from the v8 branch would overwrite the latest NPM dist-tag — exactly the problem this PR is trying to prevent.

Fix in CursorFix in Web

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stopped publishing utils with v9 so I think having latest there is fine

},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/browser-utils/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
Comment on lines +39 to 42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @sentry/utils package is missing the "tag": "v8" update in its publishConfig, which will cause it to be incorrectly published as latest on npm.
Severity: HIGH

Suggested Fix

In packages/utils/package.json, update the publishConfig to use the "v8" tag instead of "latest". This will align it with the other public packages in the v8 branch and ensure the correct version is tagged as latest on npm.

"publishConfig": {
"access": "public",
"tag": "v8"
},
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/browser-utils/package.json#L39-L42
Potential issue: The pull request updates the `publishConfig` for several packages to
use `"tag": "v8"` instead of `"latest"`, preventing v8 releases from overriding the
`latest` npm dist-tag. However, the public package `@sentry/utils` was missed in this
change. Its `package.json` still contains `"tag": "latest"`. When the v8 branch is
published, this will cause the deprecated v8 version of `@sentry/utils` to be tagged as
`latest` on npm, overriding the expected v9 version. Users running `npm install
@sentry/utils` will then receive the incorrect, older major version.

Did we get this right? 👍 / 👎 to inform future reviews.

"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/cloudflare/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/google-cloud-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nestjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nuxt/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"nuxt": ">=3.7.0 || 4.x"
Expand Down
3 changes: 2 additions & 1 deletion packages/replay-internal/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,8 @@
],
"sideEffects": false,
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"scripts": {
"build": "run-p build:transpile build:types build:bundle",
Expand Down
3 changes: 2 additions & 1 deletion packages/solid/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/browser": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/solidstart/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"@solidjs/router": "^0.13.4",
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(v8/publish): Ensure all packages are tagged with `v8` on when publishing to NPM by Lms24 · Pull Request #19974 · getsentry/sentry-javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/aws-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing v8 tag fix for @sentry/utils package

High Severity

This PR aims to ensure all packages are tagged with v8 when publishing to NPM, but packages/utils/package.json still has "tag": "latest" in its publishConfig instead of "tag": "v8". Since @sentry/utils is a public, non-private package at version 8.55.1, publishing it from the v8 branch would overwrite the latest NPM dist-tag — exactly the problem this PR is trying to prevent.

Fix in CursorFix in Web

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stopped publishing utils with v9 so I think having latest there is fine

},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/browser-utils/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
Comment on lines +39 to 42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @sentry/utils package is missing the "tag": "v8" update in its publishConfig, which will cause it to be incorrectly published as latest on npm.
Severity: HIGH

Suggested Fix

In packages/utils/package.json, update the publishConfig to use the "v8" tag instead of "latest". This will align it with the other public packages in the v8 branch and ensure the correct version is tagged as latest on npm.

"publishConfig": {
"access": "public",
"tag": "v8"
},
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/browser-utils/package.json#L39-L42
Potential issue: The pull request updates the `publishConfig` for several packages to
use `"tag": "v8"` instead of `"latest"`, preventing v8 releases from overriding the
`latest` npm dist-tag. However, the public package `@sentry/utils` was missed in this
change. Its `package.json` still contains `"tag": "latest"`. When the v8 branch is
published, this will cause the deprecated v8 version of `@sentry/utils` to be tagged as
`latest` on npm, overriding the expected v9 version. Users running `npm install
@sentry/utils` will then receive the incorrect, older major version.

Did we get this right? 👍 / 👎 to inform future reviews.

"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/cloudflare/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/google-cloud-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nestjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nuxt/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"nuxt": ">=3.7.0 || 4.x"
Expand Down
3 changes: 2 additions & 1 deletion packages/replay-internal/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,8 @@
],
"sideEffects": false,
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"scripts": {
"build": "run-p build:transpile build:types build:bundle",
Expand Down
3 changes: 2 additions & 1 deletion packages/solid/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/browser": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/solidstart/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"@solidjs/router": "^0.13.4",
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(v8/publish): Ensure all packages are tagged with `v8` on when publishing to NPM by Lms24 · Pull Request #19974 · getsentry/sentry-javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/aws-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing v8 tag fix for @sentry/utils package

High Severity

This PR aims to ensure all packages are tagged with v8 when publishing to NPM, but packages/utils/package.json still has "tag": "latest" in its publishConfig instead of "tag": "v8". Since @sentry/utils is a public, non-private package at version 8.55.1, publishing it from the v8 branch would overwrite the latest NPM dist-tag — exactly the problem this PR is trying to prevent.

Fix in CursorFix in Web

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stopped publishing utils with v9 so I think having latest there is fine

},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/browser-utils/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
Comment on lines +39 to 42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @sentry/utils package is missing the "tag": "v8" update in its publishConfig, which will cause it to be incorrectly published as latest on npm.
Severity: HIGH

Suggested Fix

In packages/utils/package.json, update the publishConfig to use the "v8" tag instead of "latest". This will align it with the other public packages in the v8 branch and ensure the correct version is tagged as latest on npm.

"publishConfig": {
"access": "public",
"tag": "v8"
},
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/browser-utils/package.json#L39-L42
Potential issue: The pull request updates the `publishConfig` for several packages to
use `"tag": "v8"` instead of `"latest"`, preventing v8 releases from overriding the
`latest` npm dist-tag. However, the public package `@sentry/utils` was missed in this
change. Its `package.json` still contains `"tag": "latest"`. When the v8 branch is
published, this will cause the deprecated v8 version of `@sentry/utils` to be tagged as
`latest` on npm, overriding the expected v9 version. Users running `npm install
@sentry/utils` will then receive the incorrect, older major version.

Did we get this right? 👍 / 👎 to inform future reviews.

"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/cloudflare/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/google-cloud-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nestjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nuxt/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"nuxt": ">=3.7.0 || 4.x"
Expand Down
3 changes: 2 additions & 1 deletion packages/replay-internal/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,8 @@
],
"sideEffects": false,
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"scripts": {
"build": "run-p build:transpile build:types build:bundle",
Expand Down
3 changes: 2 additions & 1 deletion packages/solid/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/browser": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/solidstart/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"@solidjs/router": "^0.13.4",
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(v8/publish): Ensure all packages are tagged with `v8` on when publishing to NPM by Lms24 · Pull Request #19974 · getsentry/sentry-javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/aws-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing v8 tag fix for @sentry/utils package

High Severity

This PR aims to ensure all packages are tagged with v8 when publishing to NPM, but packages/utils/package.json still has "tag": "latest" in its publishConfig instead of "tag": "v8". Since @sentry/utils is a public, non-private package at version 8.55.1, publishing it from the v8 branch would overwrite the latest NPM dist-tag — exactly the problem this PR is trying to prevent.

Fix in CursorFix in Web

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stopped publishing utils with v9 so I think having latest there is fine

},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/browser-utils/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
Comment on lines +39 to 42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @sentry/utils package is missing the "tag": "v8" update in its publishConfig, which will cause it to be incorrectly published as latest on npm.
Severity: HIGH

Suggested Fix

In packages/utils/package.json, update the publishConfig to use the "v8" tag instead of "latest". This will align it with the other public packages in the v8 branch and ensure the correct version is tagged as latest on npm.

"publishConfig": {
"access": "public",
"tag": "v8"
},
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/browser-utils/package.json#L39-L42
Potential issue: The pull request updates the `publishConfig` for several packages to
use `"tag": "v8"` instead of `"latest"`, preventing v8 releases from overriding the
`latest` npm dist-tag. However, the public package `@sentry/utils` was missed in this
change. Its `package.json` still contains `"tag": "latest"`. When the v8 branch is
published, this will cause the deprecated v8 version of `@sentry/utils` to be tagged as
`latest` on npm, overriding the expected v9 version. Users running `npm install
@sentry/utils` will then receive the incorrect, older major version.

Did we get this right? 👍 / 👎 to inform future reviews.

"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/cloudflare/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/google-cloud-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nestjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nuxt/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"nuxt": ">=3.7.0 || 4.x"
Expand Down
3 changes: 2 additions & 1 deletion packages/replay-internal/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,8 @@
],
"sideEffects": false,
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"scripts": {
"build": "run-p build:transpile build:types build:bundle",
Expand Down
3 changes: 2 additions & 1 deletion packages/solid/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/browser": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/solidstart/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"@solidjs/router": "^0.13.4",
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(v8/publish): Ensure all packages are tagged with `v8` on when publishing to NPM by Lms24 · Pull Request #19974 · getsentry/sentry-javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/aws-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing v8 tag fix for @sentry/utils package

High Severity

This PR aims to ensure all packages are tagged with v8 when publishing to NPM, but packages/utils/package.json still has "tag": "latest" in its publishConfig instead of "tag": "v8". Since @sentry/utils is a public, non-private package at version 8.55.1, publishing it from the v8 branch would overwrite the latest NPM dist-tag — exactly the problem this PR is trying to prevent.

Fix in CursorFix in Web

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stopped publishing utils with v9 so I think having latest there is fine

},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/browser-utils/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
Comment on lines +39 to 42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @sentry/utils package is missing the "tag": "v8" update in its publishConfig, which will cause it to be incorrectly published as latest on npm.
Severity: HIGH

Suggested Fix

In packages/utils/package.json, update the publishConfig to use the "v8" tag instead of "latest". This will align it with the other public packages in the v8 branch and ensure the correct version is tagged as latest on npm.

"publishConfig": {
"access": "public",
"tag": "v8"
},
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/browser-utils/package.json#L39-L42
Potential issue: The pull request updates the `publishConfig` for several packages to
use `"tag": "v8"` instead of `"latest"`, preventing v8 releases from overriding the
`latest` npm dist-tag. However, the public package `@sentry/utils` was missed in this
change. Its `package.json` still contains `"tag": "latest"`. When the v8 branch is
published, this will cause the deprecated v8 version of `@sentry/utils` to be tagged as
`latest` on npm, overriding the expected v9 version. Users running `npm install
@sentry/utils` will then receive the incorrect, older major version.

Did we get this right? 👍 / 👎 to inform future reviews.

"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/cloudflare/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/google-cloud-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nestjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nuxt/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"nuxt": ">=3.7.0 || 4.x"
Expand Down
3 changes: 2 additions & 1 deletion packages/replay-internal/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,8 @@
],
"sideEffects": false,
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"scripts": {
"build": "run-p build:transpile build:types build:bundle",
Expand Down
3 changes: 2 additions & 1 deletion packages/solid/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/browser": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/solidstart/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"@solidjs/router": "^0.13.4",
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(v8/publish): Ensure all packages are tagged with `v8` on when publishing to NPM by Lms24 · Pull Request #19974 · getsentry/sentry-javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/aws-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing v8 tag fix for @sentry/utils package

High Severity

This PR aims to ensure all packages are tagged with v8 when publishing to NPM, but packages/utils/package.json still has "tag": "latest" in its publishConfig instead of "tag": "v8". Since @sentry/utils is a public, non-private package at version 8.55.1, publishing it from the v8 branch would overwrite the latest NPM dist-tag — exactly the problem this PR is trying to prevent.

Fix in CursorFix in Web

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stopped publishing utils with v9 so I think having latest there is fine

},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/browser-utils/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
Comment on lines +39 to 42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @sentry/utils package is missing the "tag": "v8" update in its publishConfig, which will cause it to be incorrectly published as latest on npm.
Severity: HIGH

Suggested Fix

In packages/utils/package.json, update the publishConfig to use the "v8" tag instead of "latest". This will align it with the other public packages in the v8 branch and ensure the correct version is tagged as latest on npm.

"publishConfig": {
"access": "public",
"tag": "v8"
},
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/browser-utils/package.json#L39-L42
Potential issue: The pull request updates the `publishConfig` for several packages to
use `"tag": "v8"` instead of `"latest"`, preventing v8 releases from overriding the
`latest` npm dist-tag. However, the public package `@sentry/utils` was missed in this
change. Its `package.json` still contains `"tag": "latest"`. When the v8 branch is
published, this will cause the deprecated v8 version of `@sentry/utils` to be tagged as
`latest` on npm, overriding the expected v9 version. Users running `npm install
@sentry/utils` will then receive the incorrect, older major version.

Did we get this right? 👍 / 👎 to inform future reviews.

"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/cloudflare/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/google-cloud-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nestjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nuxt/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"nuxt": ">=3.7.0 || 4.x"
Expand Down
3 changes: 2 additions & 1 deletion packages/replay-internal/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,8 @@
],
"sideEffects": false,
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"scripts": {
"build": "run-p build:transpile build:types build:bundle",
Expand Down
3 changes: 2 additions & 1 deletion packages/solid/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/browser": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/solidstart/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"@solidjs/router": "^0.13.4",
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(v8/publish): Ensure all packages are tagged with `v8` on when publishing to NPM by Lms24 · Pull Request #19974 · getsentry/sentry-javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/aws-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing v8 tag fix for @sentry/utils package

High Severity

This PR aims to ensure all packages are tagged with v8 when publishing to NPM, but packages/utils/package.json still has "tag": "latest" in its publishConfig instead of "tag": "v8". Since @sentry/utils is a public, non-private package at version 8.55.1, publishing it from the v8 branch would overwrite the latest NPM dist-tag — exactly the problem this PR is trying to prevent.

Fix in CursorFix in Web

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stopped publishing utils with v9 so I think having latest there is fine

},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/browser-utils/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
Comment on lines +39 to 42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @sentry/utils package is missing the "tag": "v8" update in its publishConfig, which will cause it to be incorrectly published as latest on npm.
Severity: HIGH

Suggested Fix

In packages/utils/package.json, update the publishConfig to use the "v8" tag instead of "latest". This will align it with the other public packages in the v8 branch and ensure the correct version is tagged as latest on npm.

"publishConfig": {
"access": "public",
"tag": "v8"
},
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/browser-utils/package.json#L39-L42
Potential issue: The pull request updates the `publishConfig` for several packages to
use `"tag": "v8"` instead of `"latest"`, preventing v8 releases from overriding the
`latest` npm dist-tag. However, the public package `@sentry/utils` was missed in this
change. Its `package.json` still contains `"tag": "latest"`. When the v8 branch is
published, this will cause the deprecated v8 version of `@sentry/utils` to be tagged as
`latest` on npm, overriding the expected v9 version. Users running `npm install
@sentry/utils` will then receive the incorrect, older major version.

Did we get this right? 👍 / 👎 to inform future reviews.

"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/cloudflare/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/google-cloud-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nestjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nuxt/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"nuxt": ">=3.7.0 || 4.x"
Expand Down
3 changes: 2 additions & 1 deletion packages/replay-internal/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,8 @@
],
"sideEffects": false,
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"scripts": {
"build": "run-p build:transpile build:types build:bundle",
Expand Down
3 changes: 2 additions & 1 deletion packages/solid/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/browser": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/solidstart/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"@solidjs/router": "^0.13.4",
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(v8/publish): Ensure all packages are tagged with `v8` on when publishing to NPM by Lms24 · Pull Request #19974 · getsentry/sentry-javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/aws-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,7 +61,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing v8 tag fix for @sentry/utils package

High Severity

This PR aims to ensure all packages are tagged with v8 when publishing to NPM, but packages/utils/package.json still has "tag": "latest" in its publishConfig instead of "tag": "v8". Since @sentry/utils is a public, non-private package at version 8.55.1, publishing it from the v8 branch would overwrite the latest NPM dist-tag — exactly the problem this PR is trying to prevent.

Fix in CursorFix in Web

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stopped publishing utils with v9 so I think having latest there is fine

},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
Expand Down
3 changes: 2 additions & 1 deletion packages/browser-utils/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
Comment on lines +39 to 42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The @sentry/utils package is missing the "tag": "v8" update in its publishConfig, which will cause it to be incorrectly published as latest on npm.
Severity: HIGH

Suggested Fix

In packages/utils/package.json, update the publishConfig to use the "v8" tag instead of "latest". This will align it with the other public packages in the v8 branch and ensure the correct version is tagged as latest on npm.

"publishConfig": {
"access": "public",
"tag": "v8"
},
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/browser-utils/package.json#L39-L42
Potential issue: The pull request updates the `publishConfig` for several packages to
use `"tag": "v8"` instead of `"latest"`, preventing v8 releases from overriding the
`latest` npm dist-tag. However, the public package `@sentry/utils` was missed in this
change. Its `package.json` still contains `"tag": "latest"`. When the v8 branch is
published, this will cause the deprecated v8 version of `@sentry/utils` to be tagged as
`latest` on npm, overriding the expected v9 version. Users running `npm install
@sentry/utils` will then receive the incorrect, older major version.

Did we get this right? 👍 / 👎 to inform future reviews.

"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/cloudflare/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1"
Expand Down
3 changes: 2 additions & 1 deletion packages/google-cloud-serverless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nestjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/core": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/nuxt/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"nuxt": ">=3.7.0 || 4.x"
Expand Down
3 changes: 2 additions & 1 deletion packages/replay-internal/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,8 @@
],
"sideEffects": false,
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"scripts": {
"build": "run-p build:transpile build:types build:bundle",
Expand Down
3 changes: 2 additions & 1 deletion packages/solid/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -41,7 +41,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"dependencies": {
"@sentry/browser": "8.55.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/solidstart/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,8 @@
}
},
"publishConfig": {
"access": "public"
"access": "public",
"tag": "v8"
},
"peerDependencies": {
"@solidjs/router": "^0.13.4",
Expand Down
Loading