Uh oh!
There was an error while loading. Please reload this page.
feat(cloudflare): Enable RPC trace propagation with enableRpcTracePropagation - #20345
Merged
Conversation
JPeer264force-pushed
the
jp/hide-rpc-behind-option
branch
from
April 16, 2026 09:42
79e6052 to
a11d4aeCompareContributor
size-limit report 📦
|
Lms24
reviewed
Apr 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
Lms24
approved these changes
Apr 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
46 tasks
andreiborza pushed a commit
that referenced
this pull request
Apr 20, 2026
…pagation (#20345) follow up to #19991 It is better to release it first with an option to be enabled, that would then also be in line with #20343, otherwise `.fetch()` RPC calls would work without any option and the actual Cap'n'Proto RPC calls wouldn't work without. That would be an odd experience. ### New option: `enableRpcTracePropagation` > `instrumentPrototypeMethods` has been deprecated in favor of `enableRpcTracePropagation` Replaces the deprecated `instrumentPrototypeMethods` option with a clearer name that describes what it actually does. This option must be enabled on **both** the caller (Worker) and receiver (Durable Object) sides for trace propagation to work. It is also worth to mention that the implementation of "instrumenting prototype methods" has changed to a Proxy. ```ts // Worker side export default Sentry.withSentry( (env) => ({ dsn: env.SENTRY_DSN, enableRpcTracePropagation: true, }), handler, ); // Durable Object side export const MyDurableObject = Sentry.instrumentDurableObjectWithSentry( (env) => ({ dsn: env.SENTRY_DSN, enableRpcTracePropagation: true, }), MyDurableObjectBase, ); ```
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #19991
It is better to release it first with an option to be enabled, that would then also be in line with #20343, otherwise
.fetch()RPC calls would work without any option and the actual Cap'n'Proto RPC calls wouldn't work without. That would be an odd experience.New option:
enableRpcTracePropagationReplaces the deprecated
instrumentPrototypeMethodsoption with a clearer name that describes what it actually does. This option must be enabled on both the caller (Worker) and receiver (Durable Object) sides for trace propagation to work.It is also worth to mention that the implementation of "instrumenting prototype methods" has changed to a Proxy.