follow up to #20345
The instrumentPrototypeMethods are deprecated in favor of enableRpcTracePropagation. The main reason instrumentPrototypeMethods existed where the unknowns of the benchmarks. We didn't have anything do measure it. As of now enableRpcTracePropagation overwrites the prototypes into a Proxy and caches the instrumentations.
Best case scenario would be that we also drop the need for enableRpcTracePropagation and instrument it always by default, but for that we need to know how much of a cost this is, as it would be instrumented on each request.
If the benchmarks are low we need to remove instrumentPrototypeMethods and keep enableRpcTracePropagation
follow up to #20345
The
instrumentPrototypeMethodsare deprecated in favor ofenableRpcTracePropagation. The main reasoninstrumentPrototypeMethodsexisted where the unknowns of the benchmarks. We didn't have anything do measure it. As of nowenableRpcTracePropagationoverwrites the prototypes into aProxyand caches the instrumentations.Best case scenario would be that we also drop the need for
enableRpcTracePropagationand instrument it always by default, but for that we need to know how much of a cost this is, as it would be instrumented on each request.If the benchmarks are low we need to remove
instrumentPrototypeMethodsand keepenableRpcTracePropagation